Commit Graph

13986 Commits

Author SHA1 Message Date
Tony Wickham c4405218ca Merge "Log when MotionPauseDetector detects onMotionPauseChanged" into tm-qpr-dev 2022-06-27 17:28:17 +00:00
Alex Chau a3070ea61d In AllApps search mode, only consume touch over visible container
Bug: 236360930
Test: Tap on deadzone to dismiss AllApps in search mode
Test: touch outside recycler view inside container, doesn't swipe left/right
Change-Id: I18498ea50f217231c3bb4489d6d9e95fc0e7da53
2022-06-24 11:51:11 +01:00
Luca Zuccarini 4a0129fa5f Merge "Unify the source of truth for NORMAL <> ALL_APPS transitions." into tm-qpr-dev 2022-06-24 10:25:49 +00:00
Alex Chau f6674c27f7 Merge "Disable header protection on tablets" into tm-qpr-dev 2022-06-24 10:02:51 +00:00
Sebastián Franco 578fbee848 Merge "Make Talkback anounce which page is the icon being move on." into tm-qpr-dev 2022-06-24 04:54:31 +00:00
Sunny Goyal 1f5cc67c13 Merge "Moving widget padding to drawable instead of using itemDecorator" into tm-qpr-dev 2022-06-24 04:39:23 +00:00
Sebastián Franco 1e2454eb85 Merge "Added a content call to emulate the other devices displays" into tm-qpr-dev 2022-06-23 23:41:28 +00:00
Sunny Goyal c3a5c4b16e Merge "Fixing wrong flags used by AllAppsController in SystemUiController" into tm-qpr-dev 2022-06-23 22:52:11 +00:00
Tony Wickham c214335eba Log when MotionPauseDetector detects onMotionPauseChanged
Test: verified logging locally
Bug: 232548865
Change-Id: I587481a380148127f715c5b1b59436b2cbc1533e
2022-06-23 15:05:42 -07:00
Brandon Dayauon 0130315860 Merge "Fix work toggle button that gets blocked by threeButton nav bar on TABLETS" into tm-qpr-dev 2022-06-23 21:45:12 +00:00
Sunny Goyal ed681548fc Moving widget padding to drawable instead of using itemDecorator
ItemDecorator uses item position which is not stable during animations.
Moving it to the background allows the padding to be stable

Bug: 236961658
Test: Verified that the app doesn't crash.
Change-Id: Ied12077de4097e827c5c4157f5196346a301f185
2022-06-23 14:37:17 -07:00
Sebastian Franco 930531f669 Make Talkback anounce which page is the icon being move on.
Adding a third argument for the talkback string.

Fix: 230593493
Test: Move an item using Talkback and it should mention the row,
column and page where you can drop the item.

Change-Id: Id3d4435e9ef3348278643e6e2a1cd1e8bf5157b7
2022-06-22 17:17:38 -07:00
Brandon Dayauon 65590cb071 Fix work toggle button that gets blocked by threeButton nav bar on TABLETS
Ex) for tablets.. the nav bar height is really the height of the taskbar.
	Thats why we add the current padding of the work toggle button to the
	taskbar size.

As of patchset 3.. I reverted mDevice.getInsets().bottom because it caused
the button to be higher than it should be on landscape.
Bug: 235053326
Test: Manual (pictures in  bug thread)

Change-Id: I2f77d759ae060311d049182e8347dede590cd0b0
2022-06-22 13:21:25 -07:00
Sunny Goyal 24b441051e Fixing wrong flags used by AllAppsController in SystemUiController
Bug: 236857339
Test: Verified the UI manually
Change-Id: I2773837932ed50a59ebc9d2810f9e7ee501b6f6b
2022-06-22 12:09:22 -07:00
Alex Chau 05e6d084ec Disable header protection on tablets
- Also listen for config chagne in FloatingHeaderView

Fix: 218500759
Test: Change screen size between phone and tablet, header protection is only enabled for phone
Change-Id: I65120080641ea75ae58c010c4a27fe2b1539e0b5
2022-06-22 18:09:35 +01:00
Sebastian Franco 9097d7d09f Added a content call to emulate the other devices displays
Running the following commands should change your connected
device display:

  adb root
  adb shell setprop ro.test_harness 1
  adb shell pm enable --user 0 com.google.android.apps.nexuslauncher/com.android.launcher3.testing.TestInformationProvider
  adb shell content call --uri content://com.google.android.apps.nexuslauncher.TestInfo --method emulate-display --extra device:s:pixel5 --extra grid:s:crazy_big
  adb shell setprop ro.test_harness 0

Alternative method for this is using
  ./display_emulator.py emulate --device pixel5

I hooked up the existing DisplayEmulator into a content
provider. Doing this has a couple advantages to the previous method
of calling the emulator inside of a test. The biggest one is
that running the emulation doesn't restarts the Launcher3,
and because of that the previous method could leave the user in a
fake emulation where it looks like the device is being emulated but
is not 100% accurate.

Test: Run the command lines described above.
Fix: 229666646
Change-Id: Ia039fbaf4c7330d6bdf469633127f58d2466a1bf
2022-06-22 09:36:52 -07:00
TreeHugger Robot 5069964ea2 Merge "Unifying scroll calculation logic for both widgets and apps recycler view Also using itemType instead of item object for widget size cache" into tm-qpr-dev 2022-06-22 03:23:07 +00:00
Alex Chau bd8111a049 Merge "Only check dbFile to decide if grid migration is needed" into tm-qpr-dev 2022-06-21 20:08:53 +00:00
Alex Chau 49dcd16b26 Only check dbFile to decide if grid migration is needed
Fix: 234847755
Test: With a modified local build, when changing display config to swap between same grid:
- When dbFile is same but device type is different, no migration is performed
- When both dbFile and device type are different, migration is performed properly
Test: Grid migration through Wallpaper & Styles still works properly

Change-Id: Ie7429a7d59c135ba47061cae21c40b8d8af7188a
2022-06-21 12:36:50 +00:00
Alex Chau b065b4b05a Revert "Add logs for InvariantDeviceProfile.getDeviceProfile"
This reverts commit d3e8cc40b4.

Reason for revert: b/231312158 is fixed, log is no longer needed
Fix: 231851651

Change-Id: I3ea8b9d14e7eb6f8f9c794c5d15cdfc94153d392
2022-06-17 09:36:00 +00:00
Sunny Goyal bbad97e273 Unifying scroll calculation logic for both widgets and apps recycler view
Also using itemType instead of item object for widget size cache

Bug: 234008165
Test: Verified on device
Change-Id: Ia4b4a00a11627c0c454e4a699570e8ab1667a390
2022-06-16 16:03:37 -07:00
Sebastián Franco 2545f45a1f Merge "Adding a case when there is only 1 system shortcut on the Popup Container" into tm-qpr-dev 2022-06-16 17:01:10 +00:00
Luca Zuccarini c703f3a3e0 Unify the source of truth for NORMAL <> ALL_APPS transitions.
Bug: 231682175
Bug: 234812580
Test: manual
Change-Id: I5b66735474915d7a59bda337f67df37ff397908a
2022-06-16 16:40:26 +00:00
Thales Lima 85e52e2f9d Merge "Fix QSB alignment" into tm-qpr-dev 2022-06-16 12:19:45 +00:00
Alex Chau a5ae4c2e57 Merge "Animate inline QSB between home and apps" into tm-qpr-dev 2022-06-16 08:00:51 +00:00
Brandon Dayauon 111473315d Merge "Fix work toggle button to be placed where it should be." into tm-qpr-dev 2022-06-15 22:05:49 +00:00
TreeHugger Robot 34958f4bdf Merge "Fix folder preview animation when adding or removing icons." into tm-qpr-dev 2022-06-15 21:20:55 +00:00
Alex Chau c1d26448c5 Animate inline QSB between home and apps
- Added a QSB to taskbar to be animated between inline QSB and taskbar
- Passed endValue of taskbar animator to TaskbarController to have aniamtion variation between home -> app and app -> home
- Tuned duartion of taskbar animation and also stagger animation when taskbar is present
- Disabled scaling down of taskbar and inline QSB for home -> app
- Disabled stagger animation of taskbar and inline QSB for app -> home

Bug: 220733187
Test: manual
Change-Id: I4aac0bbc343b992a0472298595770e2bf2a55990
2022-06-15 22:12:29 +01:00
Thales Lima 616e0102a4 Fix QSB alignment
Fix: 232908328
Test: manual
Change-Id: If5516be6b8f7142577257f5ec5b5dfa8feca445d
2022-06-15 11:40:58 +01:00
Hyunyoung Song b751033f30 Merge "Remove hideKeyboard exception in the log" into tm-dev am: 5d57e3d651 am: 76e688b7c1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18869544

Change-Id: I2131e1676c613f0df96d9989876632d5fa282e4b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-15 06:39:06 +00:00
Hyunyoung Song 5d57e3d651 Merge "Remove hideKeyboard exception in the log" into tm-dev 2022-06-15 05:38:16 +00:00
Tony Wickham a763a7ccd4 Merge "Revert line that could wrongly initialize RecentsView scroll" into tm-dev am: 4ee29221df am: 356eaea195
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18820561

Change-Id: I83c63625c78cc4ce8791ac6190a2e758bd7713b9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-15 03:14:42 +00:00
Tony Wickham 4ee29221df Merge "Revert line that could wrongly initialize RecentsView scroll" into tm-dev 2022-06-15 02:23:13 +00:00
hyunyoungs 6677fa3cf3 Remove hideKeyboard exception in the log
Bug: 235616419
Test: no error stack trace
Change-Id: Ice5a52edaed2fb0485696a4586552792b0b5b932
2022-06-14 17:03:47 -07:00
Tony Wickham 3945f028de Revert line that could wrongly initialize RecentsView scroll
Test: open a random app that hasn't been opened in a while, touch down
on nav handle and see if RecentsView scrolls partially or fully
offscreen; repeat 20 times to be sure
Bug: 233112195
Fixes: 235369468

Change-Id: Ie8b3dbea7c4826af037edf22360946105ab22134
2022-06-14 19:17:55 +00:00
Brandon Dayauon c40daffac5 Merge "ENABLE_HIDEHEADER_PRIVATE_IME" into tm-qpr-dev 2022-06-14 05:59:49 +00:00
Brandon Dayauon 452ee1e45a ENABLE_HIDEHEADER_PRIVATE_IME
Add featureflag to have the hide header feature
Bug: 222862488
Test: Manual

Change-Id: I5e0cd0e5d40e0eb2d70e95b4981e6b2c7835cf0d
2022-06-13 14:29:17 -07:00
Hyunyoung Song 7ae633a89f Merge "Workspace should not receive touch events" into tm-dev am: 5c33ec3766 am: f30d5d1d5b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18791871

Change-Id: Ic9e5e4ed66277eded872ace970d3b20387a07bdc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-13 17:16:47 +00:00
Hyunyoung Song 5c33ec3766 Merge "Workspace should not receive touch events" into tm-dev 2022-06-13 16:30:19 +00:00
Becky Qiu 51f1b987a3 Merge "[Toast] Add a new type fields for user visible cold status." into tm-dev am: a500cde8f2 am: 748ef6c244
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18821283

Change-Id: I516efb76f7c79000b7018593c1883a356c376b04
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-11 08:38:23 +00:00
Becky Qiu a500cde8f2 Merge "[Toast] Add a new type fields for user visible cold status." into tm-dev 2022-06-11 06:00:46 +00:00
Becky Qiu b35ca57046 Merge "Hide keyboard when thumb scroller is visible." into tm-dev am: d6d0dc3ca8 am: a95e5116d8
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18819707

Change-Id: Ie6b938fcb5faebeea986950c39a20ff0ca513259
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-11 02:49:54 +00:00
Becky Qiu d6d0dc3ca8 Merge "Hide keyboard when thumb scroller is visible." into tm-dev 2022-06-11 01:45:36 +00:00
Brandon Dayauon 9d87b0c317 Fix work toggle button to be placed where it should be.
Previously, the implementation used the entire screen width
within it's calculations to determine where the button should be placed.
This is wrong because allApps have it's own container which we should
take the width from. The current implementation works fine because
the width of the screen for phones is the same width as the allApps container
BUT this implemention is WRONG for tablets. With now using the
allApps width for the calculation .. it works for both tablets/phones.

Bug: 235054324
Test: Photos in bug thread
Change-Id: I4c771d310a5d33646ad618e9c241cb5662493747
2022-06-10 15:57:01 -07:00
Becky Qiu 24c77a5ff5 Hide keyboard when thumb scroller is visible.
Bug: 235497706
Test: manual
Change-Id: Id3202300650949d079b9209e30b2bfc4f80979cd
2022-06-10 13:58:09 -07:00
TreeHugger Robot a1d5677e51 Merge "Fix NPE when user swipes back in All Apps and no matching view found" into tm-dev am: a49ba25353 am: 9336589d01
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18821198

Change-Id: I04e84d8319ea66427965782ddef9bda9fa5933cd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-10 20:32:16 +00:00
Andy Wickham aade3dc637 Merge "Fixes Search bar padding when work profile not present." into tm-dev am: 34e8c3364a am: ef4136ad4e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18789522

Change-Id: I2db55aaab2e0ad4ad8b2f3388f0cc7fe404a2aec
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-10 19:41:29 +00:00
TreeHugger Robot a49ba25353 Merge "Fix NPE when user swipes back in All Apps and no matching view found" into tm-dev 2022-06-10 19:05:32 +00:00
Becky Qiu fa317f4420 [Toast] Add a new type fields for user visible cold status.
Bug: 235249335
Test: manual
Change-Id: I58eee38e740e746e8a3d6065d4ef57cc5569a837
2022-06-10 12:03:56 -07:00
Andy Wickham 34e8c3364a Merge "Fixes Search bar padding when work profile not present." into tm-dev 2022-06-10 17:07:43 +00:00