Commit Graph

16646 Commits

Author SHA1 Message Date
Fengjiang Li 9ecc325870 Merge "Fix NPE where CellLayout is null when removing item out of folder" into udc-dev am: 5d81dd2d77 am: f0f298398b am: 886e8e8d75
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23521759

Change-Id: I0bcf8e2d4f7a00e49f3c0ee679249b4da7d3d01d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-08 20:36:48 +00:00
Fengjiang Li 5d81dd2d77 Merge "Fix NPE where CellLayout is null when removing item out of folder" into udc-dev 2023-06-08 19:33:52 +00:00
Pat Manning abe6de475f Merge "Refactor ArrowTipView so it can be customized and used in any drag layer." into udc-qpr-dev 2023-06-08 10:14:54 +00:00
Treehugger Robot fbc0328fec Merge "Log UserManager users and cached users each time users accessed" into udc-dev am: ffdcac46b6 am: 9b0164c832
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23604024

Change-Id: Ib562a0157e0e1914814d83fd56b767d4cd48f2da
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-07 23:27:30 +00:00
Fengjiang Li d29db8ea4d Fix NPE where CellLayout is null when removing item out of folder
Fix: 282249989
Test: create a folder of 2 app icons, remove one icon out of folder, no crash
Change-Id: I3c132ec8833c7cb14066cc403c0641d089bab8ab
2023-06-07 15:36:54 -07:00
Treehugger Robot ffdcac46b6 Merge "Log UserManager users and cached users each time users accessed" into udc-dev 2023-06-07 22:08:03 +00:00
Sunny Goyal cda1842e7a Merge "Removing all usage of LauncherProvider" into udc-qpr-dev 2023-06-07 22:03:48 +00:00
Vadim Tryshev 544dff52af Merge "Switch ScrimView to use view alpha" into udc-qpr-dev 2023-06-07 21:47:59 +00:00
Sunny Goyal 7b9e28f152 Removing all usage of LauncherProvider
Also fixing a race condition in model when an item update/delete task
gets queued and executed after the model has reloaded (making the old
data obsolete)

Bug: 277345535
Bug: 263079498
Test: Presubmit
Flag: N/A
Change-Id: Ibd4bdbb3eece05b38b73a22a4be5f368df3754f0
2023-06-07 12:57:13 -07:00
Vinit Nayak 9377e56f47 Log UserManager users and cached users each time users accessed
Bug: 243688989
Change-Id: Ifa6eec39f9fc90a4871ac2ff010588c3a5cac531
2023-06-07 11:32:01 -07:00
Schneider Victor-tulias 19d085107a Merge "Add null-check to findLastActiveTaskAndRunCallback" into udc-dev am: bfa0fae851 am: 396bb7c262
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23590296

Change-Id: Ifd444206ac34ba591bf2f6033bf6961fadb5425f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-07 18:21:17 +00:00
Schneider Victor-tulias bfa0fae851 Merge "Add null-check to findLastActiveTaskAndRunCallback" into udc-dev 2023-06-07 16:49:20 +00:00
Schneider Victor-tulias ab51f2110a Add null-check to findLastActiveTaskAndRunCallback
ItemInfo.getTargetComponent is nullable, so we can't always create a ComponentKey. Added a null-check and proper creation of ComponentKeys

Flag: not needed
Fixes: 286053950
Test: started and completed splitscreen selection from home, taskbar and overview
Change-Id: Ifa30f194ae064fab8aad79c5116f8c859dfd8cf1
2023-06-06 11:02:09 -07:00
TreeHugger Robot ddfb4a982e Merge "Enabled NOTIFY_CRASHES for teamfood" into udc-dev am: ed4695e37e am: 344146970d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23570671

Change-Id: Iaf053f020e0e7ee1dbeece136f80ff2395f0f38f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 18:02:08 +00:00
TreeHugger Robot ed4695e37e Merge "Enabled NOTIFY_CRASHES for teamfood" into udc-dev 2023-06-06 16:29:12 +00:00
Pat Manning 58b6145feb Refactor ArrowTipView so it can be customized and used in any drag layer.
Allows use in TaskbarDragLayer.

Allows customization of properties like text color, background color, and open/close animations.

Bug: 250092437
Test: manual. (Will test with TaplTestsTaskbar in follow up CL when implemented.)
Change-Id: I056395322e5fef7aa4d9fd7e4c2d73c050eff759
2023-06-06 13:46:31 +01:00
TreeHugger Robot 859d0d87e2 Merge "Simplifying some test utility methods" into udc-qpr-dev 2023-06-05 23:10:06 +00:00
Anushree Ganjam 1373c90087 Remove @WorkerThread annotation and Preconditions.assertWorkerThread check. am: f781ef81bf am: 82f0aaa1d5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23566433

Change-Id: Iddd70c0bfbe2dae1653d5a9e4348f4751841705f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-05 22:33:38 +00:00
Tony Wickham 670f17f560 Enabled NOTIFY_CRASHES for teamfood
Flag: NOTIFY_CRASHES
Test: none
Fixes: 285951384
Change-Id: I1f4905e0b797f4d0d7356cad0be4d98bfa09a3b7
2023-06-05 22:15:18 +00:00
Anushree Ganjam f781ef81bf Remove @WorkerThread annotation and Preconditions.assertWorkerThread check.
`BaseLauncherBinder.bindAllApps` and `BaseModelUpdateTask.bindApplicationsIfNeeded` can be called on both UI and Background thread.

Bug: 285711446
Test: Manual
Flags: NA
Change-Id: If6f6cce5f6e37fb21609aded8587afbdffda7545
2023-06-05 19:06:00 +00:00
Sunny Goyal db51eeff7c Merge "Updating the top scrim to also use dynamicaly generated bitmap" into udc-qpr-dev 2023-06-05 17:18:28 +00:00
Sunny Goyal 6773667e34 Revert "Revert "Adding main thread binder tracing in development..."
Revert submission 23522417-revert-23482347-launcher-binder-tracing-RBUMTFPXQG

Reason for revert: Fixed broken build
Reverted changes: /q/submissionid:23522417-revert-23482347-launcher-binder-tracing-RBUMTFPXQG

Change-Id: I3e130a780b8641c4a17a5cdf799513f2ba08b16e
2023-06-02 18:14:35 -07:00
Brian Isganitis 992065ba38 Merge changes from topics "all-apps-search-delegate-qpr", "search-container-view" into udc-qpr-dev
* changes:
  Add initial support for search session in Taskbar All Apps.
  Add All Apps search delegate for inflating search box.
2023-06-03 00:59:47 +00:00
Kevin Lim 89be8eec42 Merge "[Launcher] Added comment to keep logging latency type in sync" into udc-qpr-dev 2023-06-03 00:11:54 +00:00
vadimt 99c4becf24 Switch ScrimView to use view alpha
Using view alpha instead of background paint’s color alpha component
will make ScrimView alpha and visibility available to View Capture and
any analysis tool that’s based on it.

The change makes ScimView background completely opaque, and makes Scrim
View use variable alpha instead of always-1.0 alpha.

Changes some code that depends on the old way of representing ScrimView
opacity.

Also moves “updateSysUiColors()” call in ScrimView#setBackgroundColor
below updating alpha and background color so the new values are used in
the calculations.

Bug: 282991128
Test: local, presubmit
Change-Id: I6ca089bae55adfb9c3140d06da4fbb3b08f2bf8b
2023-06-02 15:47:51 -07:00
Andrew Cole a9a97f5123 Merge "Multi-line titles supporting RTL" into udc-dev am: f011d43325 am: aadd40dc21
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23521213

Change-Id: Ie0bf8ee8743b9960582221d1a091c92b76c87974
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 20:26:56 +00:00
TreeHugger Robot 3b7285f61c Merge "Revert "Adding tracing for workspace loading that never finishes"" into udc-dev am: 4ad5ffd0a1 am: ef529447b2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23537958

Change-Id: I774fa87ee58d684ab27114a68354ffd42538077c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 20:26:50 +00:00
Andrew Cole f011d43325 Merge "Multi-line titles supporting RTL" into udc-dev 2023-06-02 19:04:50 +00:00
TreeHugger Robot 4ad5ffd0a1 Merge "Revert "Adding tracing for workspace loading that never finishes"" into udc-dev 2023-06-02 18:59:47 +00:00
Kevin Lim 7d8058cf43 [Launcher] Added comment to keep logging latency type in sync
Bug: b/279978057
Flag: No flag needed. Documentation change.
Test: No test needed. Documentation change.
Change-Id: I5bd7f260fe7e4e2a0c4a5aa005a3d7c80351af09
2023-06-02 17:47:46 +00:00
Brian Isganitis 1fb10991d0 Add All Apps search delegate for inflating search box.
Test: Manual
Bug: 216683257
Flag: not needed
Change-Id: I2e1d9b0abf6d370d7ff6d6af2bab002b87330d86
2023-06-02 15:40:36 +00:00
Vadim Tryshev d8b470cf2f Revert "Adding tracing for workspace loading that never finishes"
This reverts commit 80bb8a12da.

Reason for revert: Cleanup after the bug is fixed. Tracing is not necessary anymore.

Change-Id: I1bb2bc59dd5debb51b094f14430cd18a203ed33c
2023-06-02 15:28:18 +00:00
Sunny Goyal ee9740462e Simplifying some test utility methods
Bug: 283821111
Test: Presubmit
Flag: N/A
Change-Id: I7b9690bc0cc53d097d26cd4f0ab2dd36ba88e1cb
2023-06-02 13:30:55 +00:00
Alex Chau 1a5ca93835 ENABLE_CURSOR_HOVER_STATES should be TEAMFOOD only
- Not all features are landed yet

Bug: 243191650
Test: manual
Change-Id: I7f70898fb16435134bfb58982b754a57c6f5c29f
2023-06-02 10:05:47 +00:00
Santiago Aboy Solanes 0edac04688 Merge "Revert "Adding main thread binder tracing in development build."" into udc-qpr-dev 2023-06-02 09:06:26 +00:00
Santiago Aboy Solanes ee846feb80 Revert "Adding main thread binder tracing in development build."
Revert submission 23482347-launcher-binder-tracing

Reason for revert: Broken Build 10242119 on git_master on errorprone b/285434612

Reverted changes: /q/submissionid:23482347-launcher-binder-tracing

Change-Id: Id9726474265e839a59d6eb34822e7a86d40f0fc9
2023-06-02 08:59:28 +00:00
Vinit Nayak c2545b82cc Merge "Add logs for launcher user cache" into udc-dev am: 43c79d23b3 am: d7037d07e4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23523872

Change-Id: I5a512981f5776174f079dca8b81fc3e3fe069a83
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 04:24:56 +00:00
Vinit Nayak 43c79d23b3 Merge "Add logs for launcher user cache" into udc-dev 2023-06-02 02:57:40 +00:00
Anushree Ganjam 87cb7ad06a Merge "Add UID in AppInfo." into udc-dev am: 9b4f62e681 am: eb9cd7e26e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23331302

Change-Id: I2bfbbf5fd5ec777baca79d89c13204857e600f8d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-02 01:46:38 +00:00
Anushree Ganjam 9b4f62e681 Merge "Add UID in AppInfo." into udc-dev 2023-06-02 01:17:29 +00:00
Vinit Nayak 134e429189 Add logs for launcher user cache
Bug: 243688989
Flag: None
Change-Id: I6f6ea3f3326c1814c2a50863e9bfbcb7e4323ae8
2023-06-01 17:11:42 -07:00
Anushree Ganjam 97434eea53 Add UID in AppInfo.
Create a reverse hashmap of PackageUserKey to Uid in AllAppsStore for
faster lookup of uid based on packageName and userHandle.

Log Uid in Impression Logging.

Bug: 282849559
Test: Manual. See various usecases documented in http://shortn/_UcvAYOmLIP
Flag: NA

Change-Id: I416426214f6b6efc45f7d4c0433bbbfca9056adf
2023-06-01 22:45:19 +00:00
Andrew Cole 0aae6049e2 Multi-line titles supporting RTL
In order to support multi-line titles in an RTL configuration we have to override
the androidx preferences library and manually set the text direction of the list view to be locale

Bug: 279880739
Test: Manual
Change-Id: I1f837a14a289e2ced8f8f3655f5ce061b37baa74
2023-06-01 15:08:35 -07:00
Brandon Dayauon fde9d30ff2 Merge "Fix "Pause work apps" button in strange location" into udc-dev am: 052045907c am: 225170c59b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23480191

Change-Id: I74502ce0b46bead253388281a18cf74ca0f03857
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-01 20:50:36 +00:00
Sunny Goyal 3e596d3aa4 Updating the top scrim to also use dynamicaly generated bitmap
Bug: 237818532
Test: Verified on device
Flag: N/A
Change-Id: I22ceb470677ab9df53e40fb78f0292b7fd5e2241
2023-06-01 19:20:04 +00:00
Brandon Dayauon 052045907c Merge "Fix "Pause work apps" button in strange location" into udc-dev 2023-06-01 19:00:27 +00:00
Sunny Goyal 50c9126cc3 Merge "Adding main thread binder tracing in development build." into udc-qpr-dev 2023-06-01 17:27:21 +00:00
Sunny Goyal 3db98b1152 Adding main thread binder tracing in development build.
> Unifying multiple binder tracing implementations
> Removing wallpaper customization check as it has been rolled out
  few years ago, this avoids additional RPC to check for wallpaper
> Removing RaceConditionReproducer as it is not used anywhere and
  is not integrated with this tracing anymore

Bug: 273718665
Test: Presubmit
Flag: N/A
Change-Id: I801af5d039a9d38d5d39e803723ec6da50a9d59f
2023-06-01 09:39:50 -07:00
Alex Chau 3e68f68528 Enable Grid only overview in teamfood
Bug: 270397206
Test: manual
Change-Id: I5f1fed8f04f63cb53af66a94ad415d3d6814245d
2023-06-01 14:29:55 +00:00
Nick Chameyev c1eafd92ab Merge "[Unfold animation] Do not preemptively start the animation if it has run already" into udc-qpr-dev 2023-06-01 12:55:27 +00:00