Commit Graph

1962 Commits

Author SHA1 Message Date
Vadim Tryshev 2b5c4d51a5 Merge "Demote from presubmit a set of flaking tests" into main 2024-02-27 17:11:09 +00:00
Himanshu Gupta dcf394535a Merge "Making Settings Cog open PS Settings page." into main 2024-02-27 15:46:34 +00:00
Jakob Schneider c93dc0e52a Merge "Remove archiving test because it tests platform specifics instead of launcher logic." into main 2024-02-26 18:26:18 +00:00
Vadim Tryshev 3d02d86872 Demote from presubmit a set of flaking tests
Bug: 319923578
Test: presubmit
Flag: N/A
Change-Id: Icd18cbe386b5cab9ac33b0b74ad0d2d8a40fa5c3
2024-02-26 10:18:54 -08:00
Andy Wickham 525163d0c7 Merge "Use setFlags to disable two line toggle flag in tests." into main 2024-02-25 08:09:39 +00:00
Priyanka Advani d0a1c2c023 Merge "Revert "Remove Unused parts of LauncherPrefs causing cyclical dependency."" into main 2024-02-23 18:11:50 +00:00
Priyanka Advani a80997d9eb Revert "Remove Unused parts of LauncherPrefs causing cyclical dependency."
This reverts commit 21ab3b979b.

Reason for revert: Culprit for b/326611479. Will be verifying through ABTD for confirmation and before submitting the revert.

Change-Id: Ib71791d159b3ac65ca332f58500341a1a0fe36e1
2024-02-23 18:05:39 +00:00
Jakob Schneider 07c1c98dab Remove archiving test because it tests platform specifics instead of
launcher logic.

Sunny suggested to remove this test b/325283522 because we shouldn't
have any platform logic in these launchers tests.

Test: N/A
Bug: 325283522
Flag: NA
Change-Id: I6a8eea815e0cf5951f98030063447fe5fd0142eb
2024-02-23 16:20:30 +00:00
Federico Baron cda8adfad3 Merge "Fix testDragToFolder()" into main 2024-02-23 00:41:55 +00:00
Sunny Goyal 1d6f76f811 Merge "Adding support for async view inflation" into main 2024-02-22 22:38:41 +00:00
Brandon Dayauon b177c9226e Use setFlags to disable two line toggle flag in tests.
disableFlags for Flags.FLAG_ENABLED_TWOLINE_TOGGLE

bug: 316027081
Test: presubmit/gantry/manual
BubbleTextViewTest: https://screenshot.googleplex.com/8zFHWbwCFyxTTHC
Flag: com.android.launcher3.enable_twoline_toggle DEVELOPMENT
Change-Id: I530126de6ac63395acd2d176935e6f6f9759d4c3
2024-02-22 14:19:31 -08:00
Anushree Ganjam cc971f67f5 Merge "Remove Unused parts of LauncherPrefs causing cyclical dependency." into main 2024-02-22 21:53:21 +00:00
fbaron d0f392db6e Fix testDragToFolder()
The issue here was that we were dragging to the folder icon when it was already a folder. We need to drag to the folder icon, wait for the folder to open, and then drag into the middle of the opened folder.

Fix: 320742556
Flag: NONE
Test: TaplDragTest#testDragToFolder
Change-Id: I82816f8e249cbe55fb4eef79c27e19b6fe00318e
2024-02-22 13:21:18 -08:00
Charlie Anderson a88605df5e Merge "Add additional debug logging for when Launcher cannot find a valid activity to launch an app with." into main 2024-02-22 19:20:47 +00:00
Sunny Goyal 72a74669e7 Adding support for async view inflation
Bug: 318539160
Test: atest AsyncBindingTest; atest ItemInflaterTest
Flag: aconfig enable_workspace_inflation DEVELOPMENT
Change-Id: I77a373db7a5805f68f4b8cbfa9b586b5674252de
2024-02-22 10:58:48 -08:00
Sebastián Franco 6a55a7b4b8 Merge "Remove the initialize method from setUp since is now on being called on the super method." into main 2024-02-22 18:38:50 +00:00
Sebastián Franco 747ee169ed Merge "Investigating test" into main 2024-02-22 17:25:15 +00:00
Jagrut Desai 8715639c69 Merge "Fix CellContentDimensionsTest" into main 2024-02-22 15:55:48 +00:00
Charlie Anderson d11c24e750 Add additional debug logging for when Launcher cannot find a valid activity to launch an app with.
Test: local
Flag: N/A
Bug: 298342929
Change-Id: I90582de2dd52a82648f31f894fffce71c146376a
2024-02-22 10:09:24 -05:00
Stefan Andonian 21ab3b979b Remove Unused parts of LauncherPrefs causing cyclical dependency.
This "migration" feature was planned as an effort to reduce latency upon
startup. That being said, now that there is a loading screen being added
to pixel startup time, it doesn't make sense to perform a risky data
migration just to save a 100ms or so of startup time. Therefore, I am
removing this code as a clean up effort to make LauncherPrefs simpler.
Also, there was a cyclical dependency introduced in b/324670265 that
makes this cleanup effort especially worthwhile, as it resolves a bug
for other developers.

Bug: 324670265
Test: Installed this on a device and tested that nothing was broken.
Flag: NA
Change-Id: I81df710057d80fbd071bc26a53cb191d453e7dee
2024-02-22 05:50:15 +00:00
Sebastian Franco 5ab4a49594 Investigating test
Flag: NA
Bug: 322823478
Test: waiting for falkes to see results
Change-Id: Ifc24d4681f71d3e89943b312044012443e787d29
2024-02-21 17:31:42 -08:00
Sebastian Franco 51231ee5c2 Remove the initialize method from setUp since is now on being called on the super method.
Bug: 324261526
Test: most Tapl test
Flag: NA
Change-Id: Icbf9883613069101a3c8428e8e3b02b1eb01dcd0
2024-02-21 17:24:12 -08:00
Vadim Tryshev b4af57a9a6 Merge "Demote unstable test testSessionUpdate_updates_pending_apps from presubmit" into main 2024-02-21 21:46:42 +00:00
Treehugger Robot b03d58ff12 Merge "Demote unstable test testUninstallFromAllApps from presubmit" into main 2024-02-21 21:35:07 +00:00
Jagrut Desai e5d9f5e436 Fix CellContentDimensionsTest
- due to comment font scale issue we were failing. applying fontscale to 1.0f

Test: Presubmit
Bug: 324910285
Flag: NONE
Change-Id: Id2bd12f5b8bb1249e6adba647fceaa0b581bc897
2024-02-21 13:02:30 -08:00
Andrew Cole ee8d92a943 Merge "Folder Previews Show Grey Pending Icon" into main 2024-02-21 20:37:17 +00:00
Vadim Tryshev 7959a851b1 Demote unstable test testUninstallFromAllApps from presubmit
Bug: 326130648
Test: presubmit
Flag: N/A
Change-Id: I65aca445568b1ce73a800ee30c1763b23312b08f
2024-02-21 11:05:03 -08:00
Vadim Tryshev 4bc503ca6d Demote unstable test testSessionUpdate_updates_pending_apps from presubmit
Bug: 325283522
Test: presubmit
Flag: N/A
Change-Id: I4a75f18c2d178508cb98b4c2e7decc5cca7f6562
2024-02-21 10:39:08 -08:00
Andrew Cole d462190ef2 Folder Previews Show Grey Pending Icon
When downloading an app previously the pending icon would show the full color icon when it was in a folder preview. To fix, we consolidated the logic for pending icons in PreloadIconDrawable and moved the logic of the pending state to the ItemInfoWithIcon model to represent the state of a pending application inside the model instead of in views.

Bug: b/324629535
Test: ItemInfoWithIconTest.kt
Flag: None
Change-Id: I4ffab44ddead046adcc84911039c87ea7c304e63
2024-02-20 21:15:21 +00:00
Brandon Dayauon c2173aac34 Merge "Collapse private space container and animate header." into main 2024-02-19 04:21:56 +00:00
Brandon Dayauon 08b06523a5 Collapse private space container and animate header.
- Just opposite of how it will expand.
- RecyclerView.SmoothScroller is needed to scroll the container.

- Need to separate the lock button because this way I can use animateLayout changes and it itself was its own drawable. Separated into icon and textView in a viewGroup.
- Give the background the 10padding on the left and right so that when in animation, the icon can adjust the padding/margins there.
- Using propertySetter to set animation
- Animates the alpha of the settings alpha

- updated test to account for the nested child views the test needs to inspect

bug: 299294792
test: manual:
Expand + Collapse Video: https://drive.google.com/file/d/1Og66eqmXv3THn0wO4_x6Tfp2AbwFWUwZ/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.private_space_animation TEAMFOOD

Change-Id: I96f1d172a481522d23b4cee996ddec65961fce78
2024-02-16 21:23:51 -08:00
Federico Baron 94c16073d3 Merge "Fix import for screenrecord" into main 2024-02-16 19:26:06 +00:00
fbaron bb13d787f0 Fix import for screenrecord
accidentally imported the wrong screenrecord

Bug: 322228038
Flag: NONE
Test: TaplOpenCloseAllAppsTest#testAllAppsFromHome
Change-Id: I80f0b3a9b376144ff4f75f5ce0fb98b1aed5985d
2024-02-16 09:15:46 -08:00
Vadim Tryshev 754f4ffa50 Merge "Add logs for uninstallWorkspaceIcon() test" into main 2024-02-15 18:10:10 +00:00
Vinit Nayak 574551e2a2 Add logs for uninstallWorkspaceIcon() test
Bug: 319501259
Change-Id: I2ac5c849e4551527eaf7f09a202f00a414d9d980
2024-02-14 23:29:04 +00:00
Vadim Tryshev 95dba8f278 Disable unstable testCacheUpdate_update_apps in presubmit
Bug: 325283522
Test: presubmit
Flag: N/A
Change-Id: Ia9b2b320780fef23d84f19ce140b9ce97b2bd20e
2024-02-14 18:18:46 +00:00
Federico Baron 33c719622f Merge "Add screenrecord for testAllAppsFromHome()" into main 2024-02-14 00:14:55 +00:00
Willie Koomson fda1b4b0d0 Merge "Use generated RemoteViews preview for widget picker if available" into main 2024-02-13 21:18:45 +00:00
Jakob Schneider 38e4471794 Merge "Version-2: Prioritize the session-provided icon & label for archived apps during unarchival in the iconCache." into main 2024-02-13 19:09:52 +00:00
Willie Koomson fedc18e9a8 Use generated RemoteViews preview for widget picker if available
WidgetCell will use the generated RemoteViews preview to display
previews in the widget picker. It will fallback to current preview
methods if not available.

Introduces WidgetManagerHelper.loadGeneratedPreviews as a utility
function. WidgetManagerHelper is passed into the constructor of
WidgetItem to avoid calling
context.getSystemService(AppWidgetManager.class) for each widget.

Bug: 308041327
Test: atest Launcher3Tests:GeneratedPreviewTest
Flag: ACONFIG com.android.launcher3.enable_generated_previews DEVELOPMENT
Change-Id: I37429057cda83a5321884ace2537038e050b9a58
2024-02-13 18:49:44 +00:00
Charlie Anderson e5b1215a2a Merge "Add additional unit tests for WorkspaceItemProcessor to cover shortcuts and folders. Also cleanup the test suite." into main 2024-02-13 16:51:45 +00:00
Charlie Anderson 887f49e231 Add additional unit tests for WorkspaceItemProcessor to cover shortcuts and folders. Also cleanup the test suite.
Bug: 294386159
Test: unit tests and presubmit
Flag: N/A

Change-Id: I33370f2a060d1e07fc7dbd37cc9a883501344551
2024-02-13 10:05:32 -05:00
fbaron 0c12987627 Add screenrecord for testAllAppsFromHome()
Bug: 322228038
Test: TaplOpenCloseAllAppsTest
Flag: NONE
Change-Id: I3bcb13c1256df8d0029dfe32d21e95d6b4183037
2024-02-12 16:35:49 -08:00
fbaron 88b89d68fb Restore state of widget picker on fold/unfold
Specifically:
-keep selected tab (personal/work)
-keep search results

Fix: 323406345
Test: WidgetPickerImageTest
Flag: ACONFIG com.android.launcher3.enable_unfolded_two_pane_picker TRUNKFOOD
Change-Id: I919e59484f3af7a2b3b007f5c234055a0f7276b3
2024-02-12 21:13:46 +00:00
Fengjiang Li 90ebc96e34 Merge "Override Launcher's window bottom inset to 0 on large screen (tablet + unfolded phone) if all display cutouts are at bottom left/right corners" into main 2024-02-11 08:48:58 +00:00
Fengjiang Li 1707575da3 Override Launcher's window bottom inset to 0 on large screen (tablet + unfolded phone) if all display cutouts are at bottom left/right corners
Bug: 321917681
Flag: NONE
Test: manual
Change-Id: I3c41d42e11413c73146c7ef59fc712971e96db19
2024-02-11 04:05:55 +00:00
Himanshu Gupta b12ff142a8 Making Settings Cog open PS Settings page.
Settings Cog action should direct to PS Settings page
instead of PS entry point page in Privacy&Security Center

Bug: 322484516
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space TRUNKFOOD
Flag: ACONFIG com.google.android.apps.nexuslauncher.Flags.enable_inject_private_space_tile TRUNKFOOD
Test: Launcher3 test.
Change-Id: I2bc7a95d591ccedb343909c159c3cbda2814e6bf
2024-02-09 19:38:45 +00:00
Jakob Schneider 4f5b60169d Version-2: Prioritize the session-provided icon & label for archived apps during unarchival in the iconCache.
* Also ensures that apps are sorted based on their actual name, so that
  they don't jump around when "Pending.." switches to "Downloading.."
* In case of faillure during unarchival, icons shown are reverted to that of PM supplied ones.

New UI: http://recall/-/gMbThhDGagWFqnJTbQCqSz/fPuzxUuU7cGXCNdygMkXAB

Test: atest CacheDataUpdatedTaskTest.java and locally verified.
Bug: 319495216
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving TRUNKFOOD
Change-Id: I6410482706af900e273fdc6f7cf0b0692442364c
2024-02-09 13:55:41 +00:00
Sebastián Franco e6bab556a1 Merge "Remove unnecesary AbstractLauncherUiTest.initialize whit two arguments" into main 2024-02-08 19:33:13 +00:00
Sebastián Franco 9a8ecd954e Merge "Investigating test" into main 2024-02-08 19:05:12 +00:00