Commit Graph

3926 Commits

Author SHA1 Message Date
Brian Isganitis c3320641bf Merge "Support zero-state suggestions in Taskbar All Apps." into udc-qpr-dev am: cca18d8028
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23376941

Change-Id: Ieed03c33837e85cc1002ed39d54be55e647167d2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-14 11:04:21 +00:00
Jon Miranda 362b87e159 Merge "Revert "Suspend immersive mode autohide while pending transient taskbar timeout"" into udc-dev am: 6352c9bc88 am: b77d65b5ae am: 036c169a17
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23678091

Change-Id: Ia150f6551153c0fb0a5461c38ba04b4afef912e3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-14 02:54:03 +00:00
Jon Miranda 6352c9bc88 Merge "Revert "Suspend immersive mode autohide while pending transient taskbar timeout"" into udc-dev 2023-06-14 01:10:08 +00:00
Jon Miranda a6653ae660 Revert "Suspend immersive mode autohide while pending transient taskbar timeout"
This reverts commit 0a074648c2.

Reason for revert: caused regression
Bug: 260765455
Fixes: 286808390

Change-Id: I0e017cf8e432f9c36b0ad34154c127c0dbe73504
2023-06-13 20:09:58 +00:00
Brian Isganitis cca18d8028 Merge "Support zero-state suggestions in Taskbar All Apps." into udc-qpr-dev 2023-06-13 18:26:36 +00:00
Randy Pfohl 732fe97d54 Merge "switching animation to screenshot to avoid visual jank" into udc-dev am: f5bec7dd30 am: c338164e7e am: 77344f8d6f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23665476

Change-Id: I5b94e9f5ace127166c07e6e4ed3a30394ac257a2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-13 07:31:13 +00:00
Randy Pfohl 27e1e8eddc Merge "switching animation to screenshot to avoid visual jank" into udc-dev am: f5bec7dd30 am: c338164e7e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23665476

Change-Id: Id99b6964e18cc7ec7daca9993ec2cffe5c8044b4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-13 06:50:06 +00:00
Randy Pfohl f5bec7dd30 Merge "switching animation to screenshot to avoid visual jank" into udc-dev 2023-06-13 05:43:21 +00:00
TreeHugger Robot a9d2db38f5 Merge changes from topics "draglayer-inline-qsb", "draglayer-search" into udc-qpr-dev
* changes:
  Allow LauncherState to define floating search side margins.
  Put the "floating" in ENABLE_FLOATING_SEARCH_BAR.
2023-06-13 03:19:49 +00:00
randypfohl d3cc664391 switching animation to screenshot to avoid visual jank
Test: built locally, recorded, and slow replayed it to verify no jank/visual anomalies visible.

Bug: 245750127
Change-Id: If7e72512d3303222f4d006a9e2a1639b2f86b1af
2023-06-12 18:28:57 -07:00
Andy Wickham bd9a180fbc Allow LauncherState to define floating search side margins.
This lets home screen align to workspace icons while All Apps
aligns with those icons. In addition, on tablets where the QSB
is inlined with the hotseat, floating search bar can also move
horizontally accordingly.

Bug: 275635606
Bug: 259619990
Test: Manual on tablet as well as foldable.
Flag: ENABLE_FLOATING_SEARCH_BAR

Change-Id: I67745c66390736cdf39d969ef7767096ae13c671
2023-06-13 00:28:59 +00:00
Vadim Tryshev 167ff73108 Merge "Revert "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test"" into udc-dev am: af641a6e80 am: 27e2251b7d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23662872

Change-Id: I81d60e0d7d92267cadad309450a90ed39be0bc84
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-12 23:07:01 +00:00
Andy Wickham 64896f3098 Put the "floating" in ENABLE_FLOATING_SEARCH_BAR.
This means adding the search view to the drag layer, so it can
persist and animate across Launcher states (i.e. Home, All Apps,
Overview, Overview from App).

Some high level things:
 - LauncherState now has a flag indicating if the floating
   search bar should be visible, as well as a method indicating
   how high it should rest when the keyboard is not showing. By
   default the height is set negative if the flag is not present,
   so the search bar will rest off screen in that state.
 - LauncherState also has a new method indicating if the search
   bar should show as a pill when not focused. Currently this is
   done in phone portrait mode in all apps and overview.
 - SearchUiManager now has a method for gestures to hint that
   the search bar will be focused or unfocused soon, e.g. for
   the app -> overview case, we hint that it will be focused
   when crossing the threshold, and unfocused if retracting.
   This allows the search bar to animate during the gesture
   and take or release focus after the state change completes.
 - AllAppsTransitionController lets the apps panel translate in
   from the bottom of the screen, for example when coming from
   an app and we don't want to pop it in halfway up the screen.
   Instead it can slide in gracefully from behind the keyboard
   and floating search bar.
 - KeyboardInsetAnimationCallback can now notify listeners of
   keyboard alpha changes during controlled animations. And
   StateAnimationConfig has a new animation type to control
   the keyboard alpha during the all apps transition.
 - This new ANIM_ALL_APPS_KEYBOARD_FADE is used to pop the
   keyboard in at the threshold for going from an app to all apps.
   Note that its position moves linearly before this, so the
   search bar starts moving up accordingly before the keyboard
   alpha is non-0.

Fix: 266761289
Fix: 268845147
Fix: 267683921
Fix: 265849321
Fix: 266446733
Fix: 269301440
Bug: 275635606
Bug: 259619990
Bug: 261866704
Test: Manual with all the state transitions on phone and tablet
(also folding/unfolding foldable).
Flag: ENABLE_FLOATING_SEARCH_BAR, ENABLE_ALL_APPS_FROM_OVERVIEW
(latter just for the background app interpolator changes).

Change-Id: I6f06552e95747348a62260279626cf407bf145b0
2023-06-12 21:55:24 +00:00
Vadim Tryshev af641a6e80 Merge "Revert "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test"" into udc-dev 2023-06-12 21:49:39 +00:00
Brian Isganitis 4337083b40 Merge changes If4669756,Ide702745 into udc-dev am: 77a40999e1 am: d0e61e3eef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23603557

Change-Id: I6140b46469c6e4251819afdd124bc869bceeadac
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-12 18:07:50 +00:00
Vadim Tryshev b5057c496a Revert "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test"
This reverts commit 1a2462914d.

Reason for revert: Likely culprit for b/286115393

Change-Id: I613ca9f62c5b9f43f2e3cd240e45bc1a0db0e661
2023-06-12 17:40:22 +00:00
Brian Isganitis d478b1464e Support zero-state suggestions in Taskbar All Apps.
Test: manual
Bug: 216683257
Flag: ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
Change-Id: I016d4e4e6a096ca4f5bd65fcda1bf24a444459f4
2023-06-12 17:19:16 +00:00
Brian Isganitis 77a40999e1 Merge changes If4669756,Ide702745 into udc-dev
* changes:
  Make sure FLAG_IN_APP is set when launching apps from keyguard.
  Report unstashed content insets for notification panel.
2023-06-12 16:51:37 +00:00
Jagrut Desai a2d86286fe Merge "Set AccessibilityPaneTitle for taskbar view" into udc-dev am: 2d5bb34b6b am: 45263ef98a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23624910

Change-Id: I9c8d22e27c3ec63047df5b9341e2541891b66ff0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-09 23:25:43 +00:00
Jagrut Desai 2d5bb34b6b Merge "Set AccessibilityPaneTitle for taskbar view" into udc-dev 2023-06-09 22:26:39 +00:00
Jagrut Desai a6a71d5ace Merge "Suspend immersive mode autohide while pending transient taskbar timeout" into udc-dev am: 5e9203e737 am: 72bd10ee95
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23544158

Change-Id: Ie67e22aa72f251eb608f8b7f8f4be929adc53cd3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-09 20:25:07 +00:00
Jagrut Desai 5e9203e737 Merge "Suspend immersive mode autohide while pending transient taskbar timeout" into udc-dev 2023-06-09 18:50:52 +00:00
Tony Wickham 0a074648c2 Suspend immersive mode autohide while pending transient taskbar timeout
Test: open Youtube fullscreen video, swipe up on taskbar; ensure taskbar autostashes before immersive mode autohides
Fixes: 260765455
Flag: none

Change-Id: I05c61de911f1bf326962d84c4f7c3e12135f23cf
2023-06-09 10:08:45 -07:00
Sunny Goyal 6e1e11bb5c Merge "Fising launcher stuck on blur" into udc-dev am: ef6fbb5be8 am: 81b856468e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23621509

Change-Id: I5eb5546f2df74bf236b70b38ed3e0f8d032faf6d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-09 07:39:16 +00:00
Sunny Goyal ef6fbb5be8 Merge "Fising launcher stuck on blur" into udc-dev 2023-06-09 06:07:31 +00:00
Jon Miranda cc51c84a46 Merge "Update taskbar paddings/sizes to match spec." into udc-dev am: 10b3e64d51 am: b6e38fb23f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23597945

Change-Id: Ib7fa92acf0049fae35b9dbb1c5b2676dc204556a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-09 01:33:29 +00:00
Jagrut Desai 78ddf47150 Set AccessibilityPaneTitle for taskbar view
we need to set pane title for taskbar view so accessibility service knows to focus/unfocus on it upon it appearing and disappearing

Test: Manual
Bug: 284081291
Flag: Not needed
Change-Id: I5404c97bdc3e1d3308942cd907e7f7701a04bee3
2023-06-08 17:08:40 -07:00
Jon Miranda 10b3e64d51 Merge "Update taskbar paddings/sizes to match spec." into udc-dev 2023-06-08 23:55:06 +00:00
Ats Jenk 5ed3a64974 Merge "Remove obsolete todo" into udc-qpr-dev 2023-06-08 22:42:52 +00:00
Andy Wickham e769a86dc5 Merge "Enable returning to the previous app after Overview -> All Apps." into udc-qpr-dev 2023-06-08 22:22:06 +00:00
Sunny Goyal 521c2a038b Fising launcher stuck on blur
The same surface can become invalid, in which case we need to wait
until the next draw to apply blur

Bug: 284411563
Test: Verified on device
Change-Id: Ifb6be94756fd00c5925e11a6b7d57f206e063a17
2023-06-08 13:18:34 -07:00
Liran Binyamin 42076f4645 Merge "Crash fix in BubbleStachedHandleViewController." into udc-qpr-dev 2023-06-08 16:24:06 +00:00
Ats Jenk 9f79d35ce2 Remove obsolete todo
Removing the todo. We may explore adding a desktop tile to alt+tab
quickswitch at some point in the future. But the design is not final
yet.

Flag: not requred, removing comment
Bug: 280468885
Test: m -j
Change-Id: I2c5293b336c6ba5ba8656bccc9439697dfcbbd27
2023-06-07 15:56:48 -07:00
Brian Isganitis fd896ed6bd Make sure FLAG_IN_APP is set when launching apps from keyguard.
This flag was not being set in the case where you lock from launcher and
then unlock by tapping on launcheable items from keyguard such as home
controls, notifications, smartspace, etc. This change makes sure we
double check if we are unlocking to launcher or not and then setting
FLAG_IN_APP accordingly.

Test: manual
Fix: 284314711
Change-Id: If46697566d252c649a00a7b3d728a14789dc6aed
2023-06-07 18:28:30 -04:00
Brian Isganitis 63582a0a00 Report unstashed content insets for notification panel.
Test: FlickerTests, manual
Bug: 284314711
Flag: no
Change-Id: Ide7027454f8b447f82778c8e24dbc39c5ade0248
2023-06-07 18:26:58 -04:00
Treehugger Robot 936722a71f Merge "Adds an overflow bubble to the bubble bar." into udc-qpr-dev 2023-06-07 22:09:31 +00:00
Sunny Goyal cda1842e7a Merge "Removing all usage of LauncherProvider" into udc-qpr-dev 2023-06-07 22:03:48 +00:00
Vadim Tryshev 544dff52af Merge "Switch ScrimView to use view alpha" into udc-qpr-dev 2023-06-07 21:47:59 +00:00
Sunny Goyal 7b9e28f152 Removing all usage of LauncherProvider
Also fixing a race condition in model when an item update/delete task
gets queued and executed after the model has reloaded (making the old
data obsolete)

Bug: 277345535
Bug: 263079498
Test: Presubmit
Flag: N/A
Change-Id: Ibd4bdbb3eece05b38b73a22a4be5f368df3754f0
2023-06-07 12:57:13 -07:00
Treehugger Robot 9c9764c28b Merge "Moved TISBinder lifecycle handling to TISBinderHelper" into udc-qpr-dev 2023-06-07 19:37:13 +00:00
Schneider Victor-tulias 19d085107a Merge "Add null-check to findLastActiveTaskAndRunCallback" into udc-dev am: bfa0fae851 am: 396bb7c262
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23590296

Change-Id: Ifd444206ac34ba591bf2f6033bf6961fadb5425f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-07 18:21:17 +00:00
Jon Miranda 95f4472ba9 Update taskbar paddings/sizes to match spec.
Bug: 282798528
Test: manual with screenshots
Change-Id: I00c646d9cd11a9015e14f8311ba2ff233d8321ac
2023-06-07 11:19:50 -07:00
Schneider Victor-tulias 871d7fc351 Moved TISBinder lifecycle handling to TISBinderHelper
- All instances where we used TISBinder will now use TISBinderHelper#getBinder. This will allow TISBinderHelper to handle its lifecycle
- Moved all instance of TaskbarManager and OverviewCommandHelper as well since TIS and TISBinder handle their lifecycles
- Cleaning up launcher instance from TaskbarManager when TISBinder is being destroyed

Flag: not needed
Bug: 283490010
Test: ran launcher and performed gestures
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:248794e698417b1156bf911adb31682186fe2e34)
Change-Id: I8415a6b2c1dba0776e7c0e1ee32ad3c683100bde
2023-06-07 17:15:18 +00:00
Schneider Victor-tulias bfa0fae851 Merge "Add null-check to findLastActiveTaskAndRunCallback" into udc-dev 2023-06-07 16:49:20 +00:00
Liran Binyamin 2f1b547a4b Crash fix in BubbleStachedHandleViewController.
Switching between gesture nav and 3 button nav may lead to a state where
the RegionSamplingHelper is unexpectedly null.

Bug: 269670598
Test: In Settings switch navigation modes until launcher crashes.
Change-Id: I56d6eea81070f367db292c1ded9866452f6e2650
2023-06-07 11:55:02 -04:00
Andy Wickham adce95394e Enable returning to the previous app after Overview -> All Apps.
Back gesture from All Apps (history for state):
If previous state was background, use quick switch state to return
to the previous app.

Swipe down from All Apps:
Return to previous state (which will be Normal or Quick Switch).

This animates from All Apps overview scale/translation to full
screen of the previous task. In this case we are animating from
0.5x Overview scale and 0 translation (centered).

Video: https://drive.google.com/file/d/1cpQjtFemtJ4zu9aWu7IiUftWWVGFrbtM/view?usp=drive_link&resourcekey=0-1zuMEvYNsk81YBxv8o10hA

Note: This is mostly for the gesture/state handling but it would
be nice to polish this transition in the future.

Bug: 283336332
Test: Manual
Flag: ENABLE_ALL_APPS_FROM_OVERVIEW
Change-Id: Iec92df933ce6522f181d3d5ca889b6a6469f4cc6
2023-06-06 17:13:59 -07:00
Fengjiang Li 7d6a8b1c3a Merge "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test" into udc-dev am: 3dca7b3c6a am: 69a9a4cd52
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23300979

Change-Id: If1ffa619e26ab7b76d6e0b946bcd29d121cd7219
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-06 19:43:54 +00:00
Fengjiang Li 3dca7b3c6a Merge "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test" into udc-dev 2023-06-06 18:19:38 +00:00
Schneider Victor-tulias ab51f2110a Add null-check to findLastActiveTaskAndRunCallback
ItemInfo.getTargetComponent is nullable, so we can't always create a ComponentKey. Added a null-check and proper creation of ComponentKeys

Flag: not needed
Fixes: 286053950
Test: started and completed splitscreen selection from home, taskbar and overview
Change-Id: Ifa30f194ae064fab8aad79c5116f8c859dfd8cf1
2023-06-06 11:02:09 -07:00
TreeHugger Robot 859d0d87e2 Merge "Simplifying some test utility methods" into udc-qpr-dev 2023-06-05 23:10:06 +00:00