Commit Graph

1679 Commits

Author SHA1 Message Date
Uwais Ashraf c1eecf21e9 Merge "[Trunk Stable] Use SetFlagsRule.initAllFlagsToReleaseConfigDefault instead of disabling all flags in setUp." into main 2023-10-17 14:09:47 +00:00
Anushree Ganjam 6ee3a32b12 [Trunk Stable] Use SetFlagsRule.initAllFlagsToReleaseConfigDefault instead of disabling all flags in setUp.
Bug: 294913042
Flag: NA
Test: Unit tests
Change-Id: Ib570ce67f53d4af7407b36f6fee1a3517800155f
2023-10-17 10:27:54 +00:00
Riddle Hsu aeb3ff6b5c Finish recents animation for standalone recents on home
(This is to reland with fixing FallbackRecentsTest#testOverview
by excluding fallback overview panel which doesn't show visual
difference from AnomalyDetector)
There was a check from RunningTask to avoid using transient-launch
when launching recents activity on a 3rd party home. But the info
may not be updated in time (from TaskStackChangeListener) if there
are several changes happen in a short time.

Then it may misjudge that home is still on top but the current top
is a normal app. Then the app will be paused unexpected because
setTransientLaunch() is not called.

Since FLAG_MOVED_TO_TOP is introduced, task reorder will also be
collected in transition, so the check of isHomeTask is longer needed.
But RecentsTransitionHandler still needs to cooperate with it about
how to animate the merging animation while recents animation is running.
To simplify it, just finish the recents animation when recents activity
is launched on top of home activity, i.e. consider it as a regular
launch because only the recents activity is on top and there are no
other apps need to keep visible for live-tile.

Note that setTransientLaunch() is still called for the case. However
its effect will be gone after the transition is finished.

This can also fix various issues when using a 3p launcher:
 - When auto rotation is enabled and put device in landscape:
    - Unable to enter recents from gesture mode
    - System bars are disappeared when pressing recents key
 - Jump-cut when pressing home key to leave recents on home.

Bug: 302703228
Bug: 294029838
Test: WindowInsetsBehaviorTests
Test: Rapidly click navigation bar while a regular app is on top.
      The app should not receive onPause.
Change-Id: I387fcb26aa01072dfd5a215107c9c15b28513a82
2023-10-17 05:45:16 +00:00
Alex Chau 74e68c69e8 Merge "Use SandboxContext in AbstractDeviceProfileTest" into main 2023-10-16 09:41:59 +00:00
Sebastián Franco 87d482cd3e Merge "Unifying constant app names used in Tests" into main 2023-10-13 18:28:38 +00:00
Vadim Tryshev aa5070f7e3 Merge "Adding an annotation for tests that change nothing on screen and may produce no view capture data" into main 2023-10-12 23:19:51 +00:00
Tyler Freeman 22781d97d9 Merge "Revert "Combine icon app tests to allow overriding flag for new ..."" into main 2023-10-12 20:06:56 +00:00
Vadim Tryshev ec072e081b Adding an annotation for tests that change nothing on screen and may produce no view capture data
Bug: 286251603
Test: presubmit
Flag: N/A
Change-Id: I3a6822648981400a426a09315aba36cb4977e6e9
2023-10-12 18:07:20 +00:00
Tyler Freeman 1468467706 Revert "Combine icon app tests to allow overriding flag for new ..."
Revert submission 25007147-tapl-flag

Reason for revert: Breaks build: https://b.corp.google.com/issues/305033049

Reverted changes: /q/submissionid:25007147-tapl-flag

Change-Id: I99b5883e64ae25476394a4207c5d6a4d22fc27dc
2023-10-12 18:04:05 +00:00
Pat Manning 18ce47f535 Merge "Set FastBitmapDrawable's badge alpha when updating drawable alpha." into main 2023-10-12 17:32:30 +00:00
Pat Manning 654c05837e Merge "Combine icon app tests to allow overriding flag for new icon app chip menu testing as well." into main 2023-10-12 15:59:17 +00:00
Pat Manning 236e738907 Combine icon app tests to allow overriding flag for new icon app chip menu testing as well.
Platinum exlude cl update: cl/572225659

Test: TaplOverviewAppIconMenuTest
Test: TaplAppIconAppChipMenuTest
Bug: 303329286
Bug: 303266562
Fix: 304470271
Change-Id: I4ca163401d6a42961e8955e06c164af0254b1231
2023-10-12 14:53:08 +01:00
Pat Manning 43e46a3d86 Set FastBitmapDrawable's badge alpha when updating drawable alpha.
Test: FastBitmapDrawableTest
Fix: 304559962
Change-Id: Ie545cc5da506c77af18f99b5d045cafc37110a5a
2023-10-12 13:57:26 +01:00
Alex Chau 1ce67a6122 Use SandboxContext in AbstractDeviceProfileTest
- Added a initializeForTesting method to SandboxContext
- Also made SandboxContext non-abstract, so it can be used in tests to inject mock MainThreadInitializedObject into the SandboxContext, this should avoid mocked MainThreadInitializedObject bled into another test

Test: presubmit
Flag: None
Bug: 303328913
Change-Id: I37157d81b08b80f1e90eacca7dc2ce482cd08aa4
2023-10-12 11:43:37 +01:00
Vadim Tryshev 9bf8a4bbc1 Merge "Moving verifyKeyguardInvisible() after other initializations" into main 2023-10-11 20:17:04 +00:00
Vadim Tryshev f782eaba73 Improving diagnostics from fallback recents tests when phone is not unlocked
Failing earlier so that we don't get strange messages from the middle of the test.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I1e3c70623e6f907bcc6bd0486b6c75afecb610e3
2023-10-10 19:18:22 -07:00
Vadim Tryshev 3c1def4810 Moving verifyKeyguardInvisible() after other initializations
verifyKeyguardInvisible can fail, and then tear down will be called,
potentially accessing fields that currently get assigned after this
call, causing crashes.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I865dfd70ce1821cee26800f57a13fb202626ea84
2023-10-10 16:37:14 -07:00
Sunny Goyal b834d6eca8 Merge "Removing some usage of shared prefs" into main 2023-10-10 18:44:15 +00:00
Sebastian Franco 02a4fb41c7 Unifying constant app names used in Tests
Bug: 298234173
Test: No-op changes, all test should pass
Change-Id: I3cd4854b150d827393bff6eada7aa9a9201dadaa
2023-10-09 14:25:49 -07:00
Vadim Tryshev 6bc3f5e0e1 Merge "Introducing a method for execution an action on Launcher for teardown" into main 2023-10-09 21:22:47 +00:00
Vadim Tryshev 39b4fad9b0 Introducing a method for execution an action on Launcher for teardown
If the test fails to initialize properly, tearDown is still called,
and we may have null Launcher activity.

We want to safely skip using that activity to avoid a NullPointerException
that would hide the original error message.

Bug: 304306290
Test: presubmit
Flag: N/A
Change-Id: I89774a92ede046fa3afadacc62df25f4f496f4e7
2023-10-09 11:29:42 -07:00
Sebastián Franco 07f3e9dc04 Merge "Move test from TaplTestsLauncher3 to TaplUninstallRemove" into main 2023-10-07 00:36:22 +00:00
Sunny Goyal 576f7a5e80 Removing some usage of shared prefs
Bug: 301661768
Test: Presubmit
Flag: N/A
Change-Id: I158e9a5148d2c9404ea4d2e9e239696b29dbeb20
2023-10-06 14:35:56 -07:00
Federico Baron 0bd2c4ea75 Merge "Add smartspace removal option as a toggle" into main 2023-10-06 20:35:14 +00:00
Vadim Tryshev acfb180a3d Merge "Next batch of modifications to ignore-lists of anomaly detectors" into main 2023-10-06 20:33:52 +00:00
Vadim Tryshev 75fae9b0b4 Next batch of modifications to ignore-lists of anomaly detectors
Bug: 286251603
Test: presubmit
Flag: N/A
Change-Id: Ic5eb0a7bfa95c5a3cd890582e7ddf3de2f2bda1c
2023-10-06 11:00:01 -07:00
Brian Isganitis 96224ef755 Merge "Migrate Kotlin tests to use mockito-kotlin2." into main 2023-10-06 17:54:56 +00:00
Stefan Andonian 9acb884c90 Merge "Permanently provide functionality for LauncherPref items that don't need to be migrated, but are boot aware." into main 2023-10-05 21:14:24 +00:00
Sebastian Franco 0b30453722 Move test from TaplTestsLauncher3 to TaplUninstallRemove
Bug: 298234173
Test: atest TaplUninstallRemove
Change-Id: I80fe1c73d08fcf1e310b86a8662c13a8775ade6e
2023-10-05 20:34:06 +00:00
Sebastián Franco 4823dca49e Merge "Moving tests form TaplTestsLauncher3 to TaplTestsAllAppsIconsWorking" into main 2023-10-05 19:56:58 +00:00
fbaron c0e687bad8 Add smartspace removal option as a toggle
Bug: 303471576
Test: try removing smartspace by going to home settings and turning it off
Flag: ENABLE_SMARTSPACE_REMOVAL
Change-Id: Idd95da1b302927885a8c469e38db6d3c5130f8c1
2023-10-05 17:26:03 +00:00
Stefan Andonian 865898e303 Delete App Icons from Test Data Assets
Previously, the test assets were being pulled into the release APK.
Unfortunately, it isn't possible to build the Release APK from within
SysUi Studio. Since the tests don't test the image loading, I am opting
to simply delete the large image strings, rather than try to figure out
why the release APK is including these test assets.

Bug: 301105199
Test: The tests still pass. That being said, it is difficult to test
this other than see if the APK size doesn't get flagged for growing too
large. It should be ok though, since the test assets are now WAY
smaller.

Change-Id: Ic52bede8296624740e4ca1573955494c3b94bf87
2023-10-05 03:51:54 +00:00
Stefan Andonian 18fe81864f Reapply "Add unit tests for LoaderTask"
This reverts commit e4735d77f1.

Bug: 301105199
Test: This already passed presubmit before.
Change-Id: I97ab28186ba1d4da4abe82686fe1a11d5e51c4b3
2023-10-05 03:51:44 +00:00
Sebastian Franco 547ddd4830 Moving tests form TaplTestsLauncher3 to TaplTestsAllAppsIconsWorking
Removing testGetAppIconName since that behaviour is already tested.

I'm also using this change to remove the TISBinder rule since it's not
needed.

Bug: 302869930
Test: atest TaplTestsAllAppsIconsWorking
Change-Id: Ie6b4f801254ca69b2485fe574914a73f947fc434
2023-10-04 16:43:19 -07:00
Stefan Andonian 54495f3018 Permanently provide functionality for LauncherPref items that don't need
to be migrated, but are boot aware.

Bug: 251502424
Test: Tested that Migration works as expected, as well as shared
preference information that doesn't need to be migrated. Also sanity
tested phone in general.

Change-Id: Ie8460e360856cbe20a7770b1747f75c7154759ab
2023-10-04 23:32:58 +00:00
Vadim Tryshev e8f7dd5a51 Merge "Further tightening leak detector checks" into main 2023-10-04 22:18:18 +00:00
Vadim Tryshev c116cee748 Further tightening leak detector checks
Some checks see 2 activities for some reason: Launcher and Overview.
Both active.
I'll have to decide what to do with these cases, but for now, I simply don't pass 'true' from places where this can happen.

When we have 2 activities:
Either Overview is present (and I guess we have to close it before the check) or the screenshot shows that there is no Overview, but internally, apparently, Overview activity is active and therefore, technically, is not leaked.
For the latter case, I may need to do some kind of investigation.
But for now, I'm tightening the check where there is no Overview.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I1f1619093e0948b8112f29fd7e94facbf7093983
2023-10-04 22:18:12 +00:00
Vadim Tryshev 174db38f34 Merge "Ignoring the whole fallback TaskView" into main 2023-10-04 22:15:17 +00:00
Sebastián Franco de846f3d76 Merge "Moving testWidgets from TaplTestsLauncher3 to TaplWorkspaceTest" into main 2023-10-04 21:42:05 +00:00
Sebastian Franco fd96b78d14 Moving testWidgets from TaplTestsLauncher3 to TaplWorkspaceTest
Also, I'm taking advange of this change to update the name of
OopTaplOpenCloseAllApps to follow the standard TaplOpenCloseAllApps
and I'm also moving testPressBack to TaplOpenCloseAllApps since is
similar to the other methods in that class.

Bug: 298234173
Test: atest TaplWorkspaceTest

Change-Id: Ie933828baedf48b45e55f20853e238ecc6a594bd
2023-10-04 10:21:43 -07:00
Brandon Dayauon 39276d643b Merge "Make DISPLAY_SEARCH_RESULT_SMALL not badged" into main 2023-10-04 16:13:10 +00:00
Vadim Tryshev 980769a857 Ignoring the whole fallback TaskView
Bug: 286251603
Test: presubmit
Flag: N/A
Change-Id: I9f8dad8ab2beebfcf37d0035096a5747a314c20a
2023-10-03 18:45:58 -07:00
Fengjiang Li 0c740c774e Merge "[Launcher] Fix launcher startup logging" into main 2023-10-03 21:26:39 +00:00
Brian Isganitis 06139e079c Migrate Kotlin tests to use mockito-kotlin2.
Test: atest
Bug: 300509464
Flag: No
Change-Id: I5e0d0f1f29d51cdbfacd51f7229afddf8bd66f7e
2023-10-03 16:04:19 -04:00
Brandon Dayauon 0ae52c9863 Make DISPLAY_SEARCH_RESULT_SMALL not badged
bug: 299364813
Test:Manual -
before: https://drive.google.com/file/d/1Gb_bV5oIEPAvNYnqMJwscX-r1iz967eY/view?usp=sharing
after: https://drive.google.com/file/d/1GTH1A8biVAVnWXaArMkdzWK9kiwFhVCn/view?usp=sharing

Flag: n/a
Change-Id: I6e928079d53bfa7f87cde4d420ee05b1edf875f5
2023-10-03 15:49:45 +00:00
Vadim Tryshev daa553c7a9 Merge "Starting to tighten leak detector checks" into main 2023-10-03 04:59:09 +00:00
Sebastián Franco bad922f50f Merge "Moving testWidgets from TaplTestsLauncher3 to it's own test TaplWidgetPickerTest" into main 2023-10-03 03:05:15 +00:00
Vadim Tryshev d8c049f2af Starting to tighten leak detector checks
This will help to detect leaks earlier, not when we have 3 activities in some cases, but when we have 2.

Adding a parameter that enables more strict detection, and using it in some places.

I'll try to convert as many places as possible to the more strict check after landing this CL.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: Idd5a0386005e46dad8aab222bd77c0240f23f43a
2023-10-02 18:34:32 -07:00
Vadim Tryshev a6b74ffdfc Merge "Verifying that workspace looks correct at the end of the test." into main 2023-10-02 21:48:04 +00:00
Fengjiang Li 188fbc92d1 [Launcher] Fix launcher startup logging
After reporting startup logs, we should tear down logger to prevent sending invalid logs

Bug: 302560751
Test: Verify rotating screen doesn't send startup logs to server
Change-Id: I8cf0a1a34aa9fffb67ddf83efe27908a28538551
2023-10-02 11:14:18 -07:00