Commit Graph

5851 Commits

Author SHA1 Message Date
Greg Kaiser d4ed91551d Merge "Revert "Change Overview Actions to round buttons."" into udc-qpr-dev am: b095594afd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24191951

Change-Id: I7deb680cbc3e6600e6cb3201628cfde98ede4f49
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-25 17:40:23 +00:00
Greg Kaiser b095594afd Merge "Revert "Change Overview Actions to round buttons."" into udc-qpr-dev 2023-07-25 16:44:28 +00:00
Greg Kaiser f849f2856f Revert "Change Overview Actions to round buttons."
Revert submission 23784078-overview-actions

Reason for revert: b/293081298

Reverted changes: /q/submissionid:23784078-overview-actions

Change-Id: I185cfc6baf8dd2243f6fb5a585c926f9df3b3934
2023-07-25 14:27:28 +00:00
Thales Lima a23bf8144b Merge "Add twoPanelId attribute for responsive grid in device profile" into udc-qpr-dev am: d9f4d93cbf
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24160393

Change-Id: Icdbd52e25f36d0b07bf33c168c65a40bee2b0bd5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-24 21:49:53 +00:00
Thales Lima d9f4d93cbf Merge "Add twoPanelId attribute for responsive grid in device profile" into udc-qpr-dev 2023-07-24 21:24:00 +00:00
Andy Wickham 48445a5fb2 Merge "Change Overview Actions to round buttons." into udc-qpr-dev am: 03b5f8b1d1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23783599

Change-Id: Idb64d2d1ca132ce80321af3a4714ff75c2b36b4d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-24 20:20:02 +00:00
Andy Wickham f98949cac3 Change Overview Actions to round buttons.
If floating search is active in Overview (flag enabled and we are
the active Launcher), these buttons will be aligned to the search
bar relative to the bottom of the screen. Otherwise, the buttons
will be aligned below the active task like before.

Demo for Launcher3 build:
https://drive.google.com/file/d/1fVzRRnW5AFDMPkW-E8_w4BOCzTAOURQ_/view?usp=drive_link&resourcekey=0-6-EbFZXkBqcu0rw7uuEzjw

Bug: 292000892
Test: Manual with floating enabled/disabled and
SEPARATE_RECENTS_ACTIVITY enabled/disabled (simulating not being
the active Launcher). Also tested with a 3P Launcher, Nova.
Flag: N/A; this change is enabled by default, but also verified
UI looks correct with ENABLE_FLOATING_SEARCH_BAR.

Change-Id: Ia45f88d2c691c4525b1e73cca4707498d058a917
2023-07-22 07:43:17 +00:00
Jordan Silva 575c3bddec Add twoPanelId attribute for responsive grid in device profile
Three new attributes were created to be used in device profile. These attributes will provide the responsive specs for two panel devices.

Fix: 292204121
Flag: ENABLE_RESPONSIVE_WORKSPACE
Test: DeviceProfileDumpTest
Test: DeviceProfileResponsiveDumpTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Change-Id: I35c93e16dde043b0fd611b81bf2de74e3621818e
2023-07-21 12:00:43 +01:00
Vinit Nayak da10e5472a Merge "Change split toast exit asset to "X"" into udc-qpr-dev am: 306c6e843f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24110227

Change-Id: I4c52f02a27d25a814103288c3cf077dba1f2ef73
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-20 23:15:29 +00:00
Vinit Nayak 306c6e843f Merge "Change split toast exit asset to "X"" into udc-qpr-dev 2023-07-20 22:58:17 +00:00
Thales Lima 9b915f6f73 Merge "Improving responsive grid xml parser" into udc-qpr-dev am: 6382afd657
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23766603

Change-Id: I399e20cfee26953f38b5614244f57b8be287b363
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-19 21:25:27 +00:00
Jordan Silva 8bd7af2b3f Improving responsive grid xml parser
Refactors AllAppsSpecs, FolderSpecs and WorkspaceSpecs initialization to use the same code to parse the xml with different map function. This CL improves the readability of the code and remove code duplication.

Fix: 286538013
Flag: ENABLE_RESPONSIVE_WORKSPACE
Test: AllAppsSpecsTes
Test: CalculatedAllAppsSpecTest
Test: CalculatedFolderSpecsTest
Test: CalculatedWorkspaceSpecTest
Test: FolderSpecsTest
Test: WorkspaceSpecsTest
Test: DeviceProfileResponsiveDumpTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Change-Id: Iec5863619399efd2e80f3db46b75c4d785e1656f
2023-07-18 18:03:16 +01:00
Vinit Nayak 78207fd80b Change split toast exit asset to "X"
* TODO: Probably need to change tint based on theme

Bug: 276361926
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE
Test: Shows up as expected
Change-Id: I28a2eefa115cb15aab560d750103c7946639c18b
2023-07-17 20:19:16 -07:00
Vinit Nayak 0a4e37506e Merge "Show split select instructions toast when starting split on workspace" into udc-qpr-dev am: b9a5c4551f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24062180

Change-Id: Ifac48dc2f1cbf06506ec4c59003e2224aba060ee
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-17 22:35:37 +00:00
Vinit Nayak b9a5c4551f Merge "Show split select instructions toast when starting split on workspace" into udc-qpr-dev 2023-07-17 22:11:36 +00:00
Pat Manning f2aa70c477 Merge "Show tooltips on cursor hover of taskbar icons." into udc-qpr-dev am: f351e515f7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23369318

Change-Id: I5f5e14c6d79a1c393ce04bae663aec1282296396
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-17 10:51:19 +00:00
Pat Manning f351e515f7 Merge "Show tooltips on cursor hover of taskbar icons." into udc-qpr-dev 2023-07-17 10:15:46 +00:00
Vinit Nayak 5f09091583 Show split select instructions toast when starting split on workspace
* Used same animation properties that RecentsView uses to
show the instructions view unfolding
* TODOs:
  * UI polish (correct asset, animation timings, etc)
  * Hook into existing animations (if possible)
  * Migrate recentsView splitInstructionsView to use same/similar code path;
    remove RecentsView#safeRemoveDragLayerView

Bug: 276361926
Test: Create split w/ and w/o flag, works as expected
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE
Change-Id: I7a51b71c358902399ad73b650287cdbf1dad07c6
2023-07-14 17:49:42 -07:00
Pat Manning da69661add Show tooltips on cursor hover of taskbar icons.
Fix: 250092437
Test: TaskbarHoverToolTipControllerTest
Flag: ENABLE_CURSOR_HOVER_STATES
Change-Id: Ia0463518d13b313b354328078685930215fb7636
2023-07-14 13:42:30 +01:00
Bill Yi 686e14eaf4 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I87e585d21fc93b5c397c49fb04ebdf8c9f987f21
2023-07-14 02:25:32 -07:00
Anushree Ganjam 84744648e8 Merge "Introduce Default Ime height." into udc-qpr-dev am: e1a4eb4a09
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23595397

Change-Id: I835dac8a27e4dea2b2fa5f12ee34b29086804430
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-13 07:16:25 +00:00
Anushree Ganjam 5730f03c9f Introduce Default Ime height.
Assume IME_DEFAULT_HEIGHT_DP = 300.
When ime is yet to be shown but the UI is ready, then use
IME_DEFAULT_HEIGHT_DP.

For the 2nd time onwards save the actual ime height and use it when the
keyboard is not shown yet.

Bug: 285166099
Test: Manual
Change-Id: I33e38cbd5c2910f4a6dc4cc83c8dc4b6d94fbcff
2023-07-12 17:21:40 +00:00
Bill Yi b2f9564e83 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I1909e37e82176edd16be4cb12dfd78b68393f92b
2023-07-07 04:33:59 -07:00
Lucas Dupin 0d8883469c Merge "Updating materialColorSurfaceContainerHighest color access" into udc-qpr-dev am: 6a925d0769
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23917471

Change-Id: Ia940de6f17a4ab9a49aad38a8699bfbcfa9fd5cb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-07 03:16:48 +00:00
Andrew Cole fe0a3b41d8 Updating materialColorSurfaceContainerHighest color access
For any view files applying the WidgetConatinerTheme via widgetsTheme they were incorrectly inheriting themes and skipping the AppTheme provided but only in light mode. In dark mode the WidgetContainerTheme.Dark was correctly inheriting the theme.

To avoid a risky theme update for all widgetsThemes we just modify the color accessor to use @color instead of ?attr as these colors should not be attributes AFAIKT

Bug: b/289305591
Test: Follow repro steps on the bug for smartspace
Change-Id: I26cc3239763f8eac3dfe5f094c6757692f46d1bc
2023-07-06 12:21:21 -07:00
Brandon Dayauon 69be4ccd17 Merge "Fix prediction row title consistency" into udc-qpr-dev am: aa9332af88
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23815838

Change-Id: I38ea618a57778e567608de1c5ecbc8e76d02030c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 22:38:46 +00:00
Brandon Dayauon aa9332af88 Merge "Fix prediction row title consistency" into udc-qpr-dev 2023-06-29 21:45:40 +00:00
Mateusz Cicheński 710b4c44e1 Merge "Remove the keep clear areas XML tag from Hotseat" into udc-dev am: 665524cc37 am: 1f113855f4 am: ea4fb36690
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23823197

Change-Id: I8b0a0951a8e4e6e1322274cd8c3612f843347418
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 19:52:10 +00:00
Mateusz Cicheński 865b576cf4 Merge "Remove the keep clear areas XML tag from Hotseat" into udc-dev am: 665524cc37 am: 1f113855f4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23823197

Change-Id: I65ba5c1fbd64c88ff4e67534e42e453320d45a80
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 19:05:12 +00:00
Mateusz Cicheński ea4fb36690 Merge "Remove the keep clear areas XML tag from Hotseat" into udc-dev am: 665524cc37 am: 1f113855f4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23823197

Change-Id: I50b0b0ca9e82dd33d5c64dec1352fc4b86db1665
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-29 19:02:51 +00:00
Brandon Dayauon f2ea399ec6 Fix prediction row title consistency
There's an inconsistency with prediction row in 0-state and all apps page.
This happens because we change the number of lines (to 1 line) after calculating and rendering the two lines.
Which is why if you look at the photos, in all apps, Amazon app just shows "Amazon" instead of "Amazon Sh.."

Instead of changing the number of lines after processing, just set a separate display to the prediction app row

bug:288811197
Flag: teamfood
Test: manual - locally added test BubbleTextView
before 0-state: https://screenshot.googleplex.com/5q9iYypgwwtDa8b
before allapps prediction row: https://screenshot.googleplex.com/BVxGMTT43stDzZ9
after allapps prediction row: https://screenshot.googleplex.com/BfNTFPXwf4FHuRN

Change-Id: Ifefe6dc8dd4a117be7b63f92ff837d0467a51f8b
2023-06-28 14:45:07 -07:00
Mateusz Cicheński b5b218eea9 Remove the keep clear areas XML tag from Hotseat
It reports its size through SystemUiProxy and this tag causes it to
report the region twice. Additionally upon screen rotation the value
is getting updated with a delay, so for a moment two keep clear areas
for Launcher are present - one from the previous orientation (on the
side), and one from the current orientation (matching the proxy value
in unrestrictedKeepClearAreas).

Bug: 285242520
Test: before http://recall/-/ekEuGtt9d9HWqkUtAzpHx8/cLtiXGYUyItm2kNCCEkkWA
Test: after http://recall/-/ekEuGtt9d9HWqkUtAzpHx8/iPs6fwdSXG3TE0IERmxA8
Change-Id: I40dfe08680c944f2be5db0f6b15515492f409565
2023-06-27 02:58:26 +00:00
Bill Yi cef317a762 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I547d78a7d45a8a7efdb2c1bb41c791fdd7bc1f3e
2023-06-23 09:41:48 -07:00
Federico Baron bc9e67c3bd Merge "Fix padding/margin for widgets in widgetpicker" into udc-qpr-dev am: 522665d2a4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23752205

Change-Id: I37d6cdaf25528b7afdbb6f178c2f201191b06d85
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-21 20:35:29 +00:00
Federico Baron 4848f89ad4 Merge "Revert "Fix padding/margin for widgets in widgetpicker"" into udc-qpr-dev am: c37899ecbd
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23752204

Change-Id: Id7e1bd4b5810692a5f496cd792e70b8813bb60e9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-21 20:35:26 +00:00
Federico Baron 522665d2a4 Merge "Fix padding/margin for widgets in widgetpicker" into udc-qpr-dev 2023-06-21 19:57:17 +00:00
Federico Baron c37899ecbd Merge "Revert "Fix padding/margin for widgets in widgetpicker"" into udc-qpr-dev 2023-06-21 19:57:17 +00:00
Jordan Silva 7b2c02f12e Merge "Update DeviceProfile to calculate responsive grid for folders" into udc-qpr-dev am: 54cfc5ea04
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23658954

Change-Id: I1ede028ee900b114aa1b840e3b872be1222678a5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-21 14:57:49 +00:00
Jordan Silva 637f4eb2f3 Update DeviceProfile to calculate responsive grid for folders
It uses the new responsive folder calculations and specs when responsive grid is enabled. The grid has to have folderSpecsId defined to use the new specifications, otherwise it will use the current scalable grid implementation.

Fix: 284155638
Test: DeviceProfileDumpTest
Test: ResponsiveHomeScreenFolderImageTest
Test: HomeScreenFolderImageTest
Flag: ENABLE_RESPONSIVE_WORKSPACE
Change-Id: I535cff4bb00e969f782447a898230fe2b2c05cc9
2023-06-21 12:18:58 +01:00
Jordan Silva ab04ddb59c Merge "Decrease icon size by steps" into udc-qpr-dev am: 03951ba556
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23563380

Change-Id: I58843eeaa4faa38f786e7841203e5e00c9f5ef29
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-21 10:39:48 +00:00
Jordan Silva 03951ba556 Merge "Decrease icon size by steps" into udc-qpr-dev 2023-06-21 10:12:30 +00:00
Bill Yi 6d701913d9 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ida888864c2129b6f52b8e3e850d982a40b0e2a33
2023-06-20 20:24:01 -07:00
Thales Lima 2759aa345b Decrease icon size by steps
When the icon can't fit the cell size, decrease it by steps defined by UX until it fits or reach a minimum size.

Fix: 283929701
Test: DeviceProfileAlternativeDisplaysDumpTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Test: IconSizeStepsTest
Flag: ENABLE_RESPONSIVE_WORKSPACE
Change-Id: I2875b669c0a24ecd1c4d785a33e2cffb78c9fe76
2023-06-20 20:37:38 +01:00
fbaron 05e428d6f7 Fix padding/margin for widgets in widgetpicker
Fix: 287079143
Test: Verify that the there's enough margin in between widgets and their container in widget picker
Change-Id: Ia0a7a43516554d113f011b8ac45afbf5e068ca37
2023-06-20 11:57:56 -07:00
Federico Baron c8aeb682cc Revert "Fix padding/margin for widgets in widgetpicker"
This reverts commit 3cc8de1268.

Reason for revert: when adding this extra margin to widget_cell it has the unintended effect of making text width available for the widgets shorter than it originally was (E.g Dynamic Colors becomes Dynamic Co...). Adding padding to widgets_table_container.xml instead seems to be a better solution to this issue.

Change-Id: I90b850a43aca573a26131a96d5d8f5fbde8b5f6e
2023-06-20 18:57:17 +00:00
Treehugger Robot 10d035e7fa Merge "Add a hint to align changes between taskbar and divider bar" into udc-dev am: 2095736367 am: a824567e34
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23726783

Change-Id: I40a40b2f65e397fb09e6041b8af574272200b80b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-20 16:56:50 +00:00
Treehugger Robot 2f1132a094 Merge "Add a hint to align changes between taskbar and divider bar" into udc-dev am: 2095736367 am: a824567e34 am: aa2749cb49
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23726783

Change-Id: I8a1c9d9e65cee09d9bc73aeb68aa5092bf1aecd8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-19 07:22:08 +00:00
Treehugger Robot aa2749cb49 Merge "Add a hint to align changes between taskbar and divider bar" into udc-dev am: 2095736367 am: a824567e34
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23726783

Change-Id: I4f7aa0a5058f3ae7dbd1b42c3503828f39947cec
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-19 06:39:05 +00:00
Jordan Silva accb40ad2c Merge "Implement calculations of Responsive Grid for AllApps" into udc-qpr-dev am: 1af98745f3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23468196

Change-Id: Ibfcff78b4e42a70b6e937c1a41d816b1755975ff
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-16 17:42:41 +00:00
Thales Lima abfe364629 Implement calculations of Responsive Grid for AllApps
All Apps follow the same sizes as the workspace, so we copy the measurements to AllApps values.

Bug: 284152932
Test: HomeScreenAllAppsImageTest
Test: DeviceProfileDumpTest
Test: HomeScreenResponsiveAllAppsImageTest
Test: DeviceProfileResponsiveDumpTest
Flag: ENABLE_RESPONSIVE_WORKSPACE
Change-Id: I12743a6ac5ab5f1a8bc911511bdc7e12b2261d86
2023-06-16 10:19:19 +00:00