Commit Graph

5954 Commits

Author SHA1 Message Date
Schneider Victor-tulias bfde6b2e5d Fix a potential null-pointer onActivityDestroyed
Fixes: 234082544
Test: started recents from a large screen and phone
Change-Id: I54ee93793ec146d1b0b0f00f23256aaca5975bc0
2022-06-21 12:34:02 -07:00
Schneider Victor-tulias 3bc7b93ea5 Merge "Forcefully move focused task to front when triggering the recents animation in 3-button nav" into tm-qpr-dev 2022-06-13 18:17:56 +00:00
Yunfan Chen 04d206b675 Merge "Modify the way of providing insets per WM change" into tm-qpr-dev 2022-06-13 11:38:14 +00:00
Hongwei Wang bf8528c21b Merge "Call setCanAffectSystemUiFlags(false) only for PiP" into tm-qpr-dev 2022-06-10 21:51:14 +00:00
Schneider Victor-tulias 920a86969a Forcefully move focused task to front when triggering the recents animation in 3-button nav
Quickly tapping the recents button can start a recents animation while a quick switch is running. This causes the the wrong page index to be used as the focused task index.

Test: manual on large screen
Fixes: 227562351
Change-Id: If99f74477e52ed0c7f7c5fd7b3dc8b201627068b
2022-06-10 20:11:18 +00:00
TreeHugger Robot adc7347719 Merge "Add grid_x field to DeviceSearchResultContainer." into tm-dev am: a37556ae5c am: 40ad40ed49
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18722495

Change-Id: I541a82b41bf5d4ae92c9cd9146271c73a03b19d0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-09 23:12:50 +00:00
TreeHugger Robot a37556ae5c Merge "Add grid_x field to DeviceSearchResultContainer." into tm-dev 2022-06-09 22:30:17 +00:00
Tracy Zhou c3ba24f06e Merge "Patch npe in TaskbarAllAppsController" into tm-qpr-dev 2022-06-09 22:12:08 +00:00
Hongwei Wang 40f049bcb4 Merge "Do not attempt auto-enter-pip if there is no valid leash" into tm-qpr-dev 2022-06-09 19:55:45 +00:00
Tracy Zhou 2583fb48b8 Patch npe in TaskbarAllAppsController
b/234617317#comment3

Bug: 234617317
Test: manual
Change-Id: I7cff0df86db4fdf58b33240594784598950f1a88
2022-06-09 19:22:31 +00:00
Hongwei Wang 24aeafaef1 Call setCanAffectSystemUiFlags(false) only for PiP
It was too aggressive to call that in all cases including swipe
split-screen to home.

Video: http://recall/-/b1EZhgUkQcpML5OwZekLBN/dlG6qSf9pT2f4YlIe2Klb3
Video: http://recall/-/b1EZhgUkQcpML5OwZekLBN/cfXwlpol5vi2AER32rKu2x
Bug: 213598210
Test: 1. follow the reproduce steps in the bug. \
      2. make sure PiP from split-screen has no regressions. \
      see also the videos.
Change-Id: I33d71294595729f8cdf72258c4d45c29a77935c2
2022-06-09 12:10:38 -07:00
Alex Chau 1965e1309c Merge "Use DISPLAY_CATEGORY_ALL_INCLUDING_DISABLED for getDisplays" into tm-dev 2022-06-09 17:40:07 +00:00
Hongwei Wang 1cd4162b82 Do not attempt auto-enter-pip if there is no valid leash
No reproduce path for the bug being reported, this fix is to ensure we
do not start the auto-enter-pip animation with invalid leash at the
first place.

Bug: 234796719
Test: N/A for the bug, verify the normal auto-enter-pip still works
Change-Id: I6f2164a322877f1b0213a1ee09eb476090300c7f
2022-06-09 10:27:18 -07:00
TreeHugger Robot e9f606f995 Merge "Hide taskbar while VoiceInteractionWindow is visible" into tm-qpr-dev 2022-06-09 16:55:38 +00:00
Alex Chau cbde3a3a8d Merge "Use normalized CachedDisplayInfo as key" into tm-qpr-dev 2022-06-09 15:10:27 +00:00
Alex Chau 2545e92264 Use DISPLAY_CATEGORY_ALL_INCLUDING_DISABLED for getDisplays
Bug: 227459045
Bug: 221071695
Test: manual
Change-Id: I8c1587e05a30abf75a01a84ebda6522606abb99b
2022-06-09 12:12:57 +00:00
Alex Chau 661f02de18 Use normalized CachedDisplayInfo as key
- For system Launcher, migrate to use getPossibleMaximumWindowMetrics instead of getDisplays
- Removed usage of displayId
- In estimateInternalDisplayBounds, use CachedDisplayInfo directly as a key
- When cache retunrs null for the current display (e.g. the 3P launcher case), invalidate the cache and estimate again, and only add to supportedBounds if current display is not found in the new cache

Bug: 227459045
Bug: 198965093
Test: manual
Change-Id: Ibcc05ba483ed31a40d16e3cf49c3f3d43af68cf6
2022-06-09 11:36:47 +01:00
Tony Wickham 9a54d2aa43 Hide taskbar while VoiceInteractionWindow is visible
- Fade out icons (or stashed handle if stashed)
- Move background to APPLICATION_OVERLAY layer (behind VIW)
  - Only for gesture nav
- On home screen in 3 button mode, translate buttons down when assistant
  is invoked

Test: Invoke assistant, ensure it draws above taskbar background and
taskbar stops drawing icons or stashed handle
Bug: 225200928

Change-Id: I7807d30df8f358295b8231d89217c7413f32c6f9
Merged-In: I7807d30df8f358295b8231d89217c7413f32c6f9
2022-06-09 05:21:42 +00:00
Jerry Chang 291115ce7e Merge "Prevent wallpaper flicker while entering split screen from overview" into tm-dev am: 0b944f6a4d am: 585411a3fa
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18797269

Change-Id: I7cf326d0a00c4b1dccbd3472b1adc5ec8aa9b418
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-09 02:07:24 +00:00
Jerry Chang 0b944f6a4d Merge "Prevent wallpaper flicker while entering split screen from overview" into tm-dev 2022-06-09 00:32:49 +00:00
Becky Qiu 9074e97780 Merge "[Toast] Add query_length for launcher latency logging." into tm-dev am: fe83fce489 am: f9dfd06424
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18783028

Change-Id: I339a468a49fc8490154dd0dc4d6266ab6e41f90e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-08 18:52:38 +00:00
Becky Qiu fe83fce489 Merge "[Toast] Add query_length for launcher latency logging." into tm-dev 2022-06-08 18:02:07 +00:00
Jerry Chang c04af333f5 Prevent wallpaper flicker while entering split screen from overview
When launching a pair of apps from overview panel, it will perform
cross-fade animations to transit from overview to the split pair. But
wallpaper might be visible for a while when both overveiw and split pair
is transparent during the transition. This updates to not fade-out
overview until the split pair is finishing showing in foregorund to
prevent the flicker of wallpaper.

Bug: 235137249
Test: swipe to home and enter overview panel, select and swipe down to
      enter a split pair, verified there's no flicker.
Change-Id: Iec1dc49e260f6e46640d47295d7f65dad5c24ab5
2022-06-08 15:26:25 +00:00
Winson Chung d3a7d37a57 Merge "Revert changes waiting for launcher to resume when transitioning to home" into tm-dev am: 46c9c66048 am: 0cf33355a0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18764661

Change-Id: I8b0f3b1e6a93f124ba16506872372f6e856dabf2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-08 03:50:20 +00:00
Winson Chung 46c9c66048 Merge "Revert changes waiting for launcher to resume when transitioning to home" into tm-dev 2022-06-08 03:11:16 +00:00
TreeHugger Robot 34bc21ffb0 Merge "Show split option without consider the "Lock task mode"" into tm-qpr-dev 2022-06-08 02:35:57 +00:00
Jon Miranda 2245de7674 Merge "Pause expensive view updates before setting hw/sw layers." into tm-dev am: 2dac4f7f4c am: dfe3b8b755
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18673700

Change-Id: Ib4dd2fdbc93a7ac05e9d141183770cb33db26db6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-08 01:07:18 +00:00
Jon Miranda 2dac4f7f4c Merge "Pause expensive view updates before setting hw/sw layers." into tm-dev 2022-06-08 00:15:35 +00:00
Vinit Nayak 2339933924 Merge "Rename split classes/variables for consistency" into tm-qpr-dev 2022-06-07 22:36:47 +00:00
Anushree Ganjam 8763cb57d4 Add grid_x field to DeviceSearchResultContainer.
Bug: 233297670
Test: Manual. https://paste.googleplex.com/4745437455056896

Change-Id: I63a0b2ad52282dbf836e5a26c983d3253d2aec43
2022-06-07 22:30:32 +00:00
Becky Qiu a61a2cc962 [Toast] Add query_length for launcher latency logging.
Bug: 235249335
Test: no test needed.
Change-Id: Ia16c241a2eb3cb50a17713216182192f7902be9e
2022-06-07 14:20:52 -07:00
Yunfan Chen a34340ef3a Modify the way of providing insets per WM change
The WM provides a new way to provide insets, modified the code to
reflect that change.

Bug: 161689946
Test: m
Merged-In: I31bd26a5ce4c3e47f8961d4fe528f3a97ec063f8
Change-Id: I31bd26a5ce4c3e47f8961d4fe528f3a97ec063f8
2022-06-07 17:13:47 +09:00
Jerry Chang 37d39619fa Merge "Fix Flicker of inner corners in split screen when quick switching to" into tm-qpr-dev 2022-06-07 00:55:51 +00:00
Winson Chung 29c68e73dc Revert changes waiting for launcher to resume when transitioning to home
- This was added for Go when they had their own recents implementation
  and isn't necessary for the default implementation

Bug: 229668039
Test: Follow steps using test apk from the bug
Change-Id: I0c36f98683e1bf9a3dc11cde2d1113ed1c4d6448
2022-06-06 22:28:09 +00:00
TreeHugger Robot 9307776597 Merge "Ensure null elements aren't added to TaskView shortcut list" into tm-qpr-dev 2022-06-06 21:36:43 +00:00
Vinit Nayak 5424fca602 Rename split classes/variables for consistency
* Use "select" when in the split screen
invocation process
* Drop usage of "staged" except when defining
constants

Fixes: 233006032
Change-Id: I809f0e1e9742aa6b6b09ad8731896ad3f0c9deb0
2022-06-06 14:02:15 -07:00
Vinit Nayak 2aa5a816e9 Merge "Remove old split screen overview related code" into tm-qpr-dev 2022-06-06 20:49:45 +00:00
Vinit Nayak da9213791e Ensure null elements aren't added to TaskView shortcut list
Bug: 234874147
Change-Id: I5ed84fdc64128264e5808b7d3b019c47e3740469
2022-06-06 09:18:42 -07:00
Jeff Chang 5ee83f3b5e Show split option without consider the "Lock task mode"
wm-core supports split-screen and lock-task mode work together now.
This CL enables the split-option to allow users to enjoy the
split-screen experience.

Bug: 199342537
Test: Options show up as expected
Change-Id: I38f58dec2985eaaabdbed1fdeeeece2d6e59945f
2022-06-06 14:47:47 +08:00
TreeHugger Robot 5b765189e2 Merge "Don't allow swiping to HintState if we're already in HintState" into tm-dev am: c012085c6c am: 774c53f919
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18521352

Change-Id: If494d52f37fd556dca2fd6960bb69490c812e5fb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-04 02:26:26 +00:00
TreeHugger Robot c012085c6c Merge "Don't allow swiping to HintState if we're already in HintState" into tm-dev 2022-06-04 01:38:29 +00:00
Tony Wickham 8d72018a87 Don't allow swiping to HintState if we're already in HintState
Context: there was a bug where you could get stuck in HintState if you
did the following (timing is critical):
1. Short swipe from nav region towards HintState, but not far enough or
   fast enough to commit before letting go; this cancels the state
   animation, returning towards Normal (but, crucially, StateManager
   still has state set as Hint)
2. While previous animation is animating back to Normal, swipe up again,
   but this time faster/farther to actually reach Hint; this time, the
   animation does go towards Hint, but gets stuck there. The reason it
   gets stuck is because StateManager thinks we're already in Hint from
   step 1, so doesn't call onStateTransitionEnd(Hint) in step 2. Thus,
   we never get QuickstepLauncher#onStateSetEnd(Hint), which is what we
   rely on to return to Normal.

The simple fix is to prevent the second swipe in the first place.

Test: short swipe followed immediately by fast fling from nav region on home successfully stays in Normal state intead of getting stuck in HintState
Test:
NexusLauncherOutOfProcTests: com.google.android.apps.nexuslauncher.TaplTestsNexus
Fixes: 228276181
Change-Id: I54c371c8518a9a220e75c98003331b552d8bf8af
2022-06-03 14:56:04 -07:00
Ats Jenk e048af300b Merge "Enable bubbles home gesture by default" into tm-qpr-dev 2022-06-03 18:46:20 +00:00
Vinit Nayak 690645b62e Remove old split screen overview related code
Bug: 233006032
Change-Id: I294dcde586da135af3bb33400e65d5f47edca3d8
2022-06-03 16:39:49 +00:00
Ats Jenk daccf18be1 Enable bubbles home gesture by default
Update feature flag for bubbles home gesture handling to be on by
default.

Bug: 170163464
Test: manually verified that home gesture feature is enabled on a a fresh build
Test: atest PlatformScenarioTests:android.platform.test.scenario.sysui.bubble
Change-Id: Ie6bdea919dfaf6448b3c57756cd06993a6a60ce7
2022-06-02 17:05:36 -07:00
Jon Miranda 46ecc0ca08 Pause expensive view updates before setting hw/sw layers.
Prevents widgets from updating mid animation.
Also pauses view updates during app close animation.

Bug: 220939231
Bug: 230617085
Bug: 226171754
Test: manual

Change-Id: I0138d57e6a7b2c22fd9a029e971b3e27c7e9f22e
2022-06-02 12:21:01 -07:00
Jerry Chang 202f45166d Fix Flicker of inner corners in split screen when quick switching to
Update divider bar visibility immediately when quick switching to split
pair

Fix: 234609814
Test: manual check quick switch with split pair
Change-Id: I4fc36302763bc0a7de9caca0ab370e3cedc18076
2022-06-02 03:53:19 +00:00
Vinit Nayak 28036435b6 Refactor TaskShortcutFactory to return List of SystemShortcuts
* Remove ENABLE_SPLIT_SELECT feature flag
* Remove unused SystemUiProxy methods

Bug: 233006032
Test: Options show up as expected
Change-Id: I9b98d962db79363a20ad41faa15404f1c156b9ec
2022-06-01 16:27:04 -07:00
Winson Chung c9e64b3c47 Merge "Ignore pinned tasks for purposes of gesture nav" into tm-dev am: 238f380853 am: 95afbb9982
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18638308

Change-Id: I276ce54df65697b0778c29864a8620733b6e0cbd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-01 22:55:52 +00:00
Winson Chung 238f380853 Merge "Ignore pinned tasks for purposes of gesture nav" into tm-dev 2022-06-01 22:06:48 +00:00