Commit Graph

21818 Commits

Author SHA1 Message Date
Jagrut Desai bf0727b60d Fix Taskbar not present in Desktop Mode after unlocking
The problem: with taskbar animation for Desktop mode we were checking, if we are already in DW then don't recreate taskbar. This was put in as condition so where DisplayController Info change we don't recreate twice. first being from transilition listerners and second being form info change in display controller.

The solution: Ignore the info change listener when there is already ongoing recreation is in progress.

Test: Presubmit
Bug: 399826787
Flag: EXEMPT bugfix

Change-Id: Ib86e79b3b4c86e515e44d1d1dd7ca98ed694c365
2025-03-05 18:58:38 -08:00
Treehugger Robot 7a7a92999c Merge "Making ActivityContext extend SavedStateRegistryOwner" into main 2025-03-05 11:44:19 -08:00
Mykola Podolian e5c9aadf2c Merge "Added logic to show the shell drop target and update the bubble location" into main 2025-03-05 09:24:38 -08:00
Sunny Goyal 84e0e6a188 Making ActivityContext extend SavedStateRegistryOwner
Bug: 390572144
Test: Presubmit
Flag: EXEMPT refactor

Change-Id: I8272e95a8d2da95b3c93ec616fdf877b89db5b26
2025-03-05 09:22:47 -08:00
Will Osborn 19bdf47a31 Merge "Make separate dependency scopes and graphs for different RecentsViews" into main 2025-03-05 07:29:04 -08:00
Treehugger Robot 806a9f1368 Merge "Use the safe getDisplayId() API when building the recents desktop task list." into main 2025-03-05 05:30:51 -08:00
Liran Binyamin d3a0c94067 Merge "Wire up bubble dragging to DropTargetManager" into main 2025-03-05 04:18:18 -08:00
Vania Desmonda 0d3cc4e75a Use the safe getDisplayId() API when building the recents desktop task list.
This avoids using -1 as the task's display ID and use the default
display ID instead.

In `TaskbarRecentAppsController#reloadRecentTasksIfNeeded()`, it filters
the first DesktopTask instance from allRecentsTask. Previously, the list
is built as nested lists with the same deskId = -1. This causes the
taskbar to show the running/minimized desktop apps incorrectly.

Fixes: 399859320
Fixes: 397956083
Flag: EXEMPT minor bug fix
Test: manual testing
Change-Id: Ie0a8817fc44dab69523547c79a6dfbcaef25ec20
2025-03-05 03:28:34 -08:00
Will Osborn 074a605827 Make separate dependency scopes and graphs for different RecentsViews
Test: locally tested on Tangor
Flag: EXEMPT - bugfix
Bug: 399364544

Change-Id: I788c5644f198ead206bb7512ec96eab838e51cdb
2025-03-05 10:56:25 +00:00
Treehugger Robot 325545ac2f Merge "Allow recent task to have long-press menu" into main 2025-03-04 20:11:42 -08:00
Treehugger Robot 57cab7794a Merge "Simplifying some view iteration methods" into main 2025-03-04 18:42:06 -08:00
Treehugger Robot 14eec9f1fc Merge "Spring neighboring tasks into place on task reflow after dismiss." into main 2025-03-04 18:14:33 -08:00
Treehugger Robot 15049ba552 Merge "Fix issue where tasks were not reliably marked as Perceptible" into main 2025-03-04 17:39:13 -08:00
Treehugger Robot 9b775dfdac Merge "Check horizontal touch slop for non-vertical flings" into main 2025-03-04 17:29:35 -08:00
mpodolian 132c99e4dd Added logic to show the shell drop target and update the bubble location
This change leverages a bubble bar location parameter when an app icon
is dropped and displays the shell expanded view drop target when an icon
is dragged over the bubble bar drop zone.

Fixes: 397459664
Flag: com.android.wm.shell.enable_create_any_bubble
Test: Manual.
Drag a taskbar app icon to the same side as the bubble bar. Confirm that
the expanded view from shell is displayed.
Continue dragging to the opposite side of the bubble bar location drop
zone. Confirm that the expanded view drop target is displayed on the
opposite side.
Release the dragged icon in the drop zone. Confirm that the bubble bar
expands at the new location.

Change-Id: I956d66b81810abce074b10e012cf5c873003d84c
2025-03-04 16:44:37 -08:00
Wen-Chien Wang 5ada92b966 Allow recent task to have long-press menu
Bug: 375648361
Bug: 344657629
Test: Manual, Recording uploaded to buganizer
Flag: com.android.launcher3.enable_pinning_app_with_context_menu

Change-Id: If496c56a3fe47905a3e9947407f51077f180d5a2
2025-03-04 21:47:32 +00:00
Jagrut Desai f26460f852 Merge "Support launching minimized task into desktop" into main 2025-03-04 12:51:18 -08:00
Brian Isganitis 14a7b56b5e Merge changes I34983821,I175e4282 into main
* changes:
  Initial overflow compatibility with layout transition.
  Migrate layout transition flag to DesktopModeFlag version.
2025-03-04 12:06:18 -08:00
Brian Isganitis 75d443ffdb Initial overflow compatibility with layout transition.
Also implements RTL support for overflow.

Flag: com.android.window.flags.enable_taskbar_recents_layout_transition
Bug: 343521765
Test: go/testedequals
Change-Id: I34983821a2a1a80793dc6d811d42cfeafe274ef4
2025-03-04 12:05:58 -08:00
Mykola Podolian 7781be068a Merge "Taskbar app icon drag interruption fix." into main 2025-03-04 11:57:24 -08:00
Treehugger Robot 13669ecb2a Merge "Add Two stages related flags to bug report's flag dump logs." into main 2025-03-04 11:15:27 -08:00
Bill Yi a3d557a359 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2025-03-04 10:54:52 -08:00
Pat Manning 0c8a5304b8 Spring neighboring tasks into place on task reflow after dismiss.
Fix: 389081477
Test: TaplTestsQuickstep
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I420c6c21b3172626603d7df01bd8cb024d3fb3a8
2025-03-04 18:43:02 +00:00
Sunny Goyal 476d926972 Simplifying some view iteration methods
Bug: 393703968
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: Ieffa3a66fbf8595d542995c348df578a3aec9083
2025-03-04 10:39:55 -08:00
Saumya Prakash f979f6518b Merge "Remove the step indicator for the gesture tutorial" into main 2025-03-04 09:32:41 -08:00
Randy Pfohl 4743e508e9 Merge "Enabling secondary deviceprofile creation in windowcontext" into main 2025-03-04 09:17:16 -08:00
Sunny Goyal 372c483eda Merge "Moving widgetFilter to dagger" into main 2025-03-04 09:03:10 -08:00
Brian Isganitis 42c58e39fd Migrate layout transition flag to DesktopModeFlag version.
Flag: com.android.window.flags.enable_taskbar_recents_layout_transition
Bug: 343521765
Test: go/testedequals
Change-Id: I175e428240bc52689efe0f6e4457620ac2efdbb5
2025-03-04 11:30:23 -05:00
Liran Binyamin 32dd27c8aa Wire up bubble dragging to DropTargetManager
This change creates DropTargetManager and DragZoneFactory in launcher
and supports dragging individual bubbles between bubble drag zones.

Flag: com.android.wm.shell.enable_bubble_to_fullscreen
Test: manual:
       - drag bubble across different sides and release
       - drag bubble to dismiss
Bug: 393173014
Change-Id: I58b2522baaf6b088bf8484913ba51c03aadfdd8c
2025-03-04 07:50:11 -08:00
Schneider Victor-Tulias fad57be97f Check horizontal touch slop for non-vertical flings
Flag: com.android.launcher3.enable_gesture_nav_horizontal_touch_slop
Fixes: 394364217
Test: Tested overview gesture with slight horizontal fling at the end
Change-Id: Ifb716b58486dd0bfadee467978b85150525af333
2025-03-04 07:42:08 -08:00
Treehugger Robot cfa59a3c26 Merge "Refactor OverviewComponentObserver for connected displays" into main 2025-03-04 07:22:38 -08:00
Will Osborn 2a19d636d7 Refactor OverviewComponentObserver for connected displays
Test: locally tested on Tangor
Flag: com.android.launcher3.enable_overview_on_connected_displays
Bug: 392858637
Change-Id: Icb619f59ef3acd9781eee1bf1f7cfd056a26c55f
2025-03-04 12:51:04 +00:00
Alex Chau 12d5e6aed8 Merge "Update gridTranslation of live tile when gestures ends" into main 2025-03-04 02:42:13 -08:00
Jon Miranda f792db712a Merge "Add enable_taskbar_behind_shade to DesktopModeFlags." into main 2025-03-03 18:14:25 -08:00
mpodolian a977d6b4ef Taskbar app icon drag interruption fix.
When there are no bubbles and the taskbar is not present on the screen,
the bubble bar drop target needs to be shown for the dragged taskbar
icon. To show the drop target, the view is added to the bubble bar's
parent layout. When the drop target should be hidden, the view is
removed.

The issue was caused by an incorrect parent container being passed to
the BubbleBarPinController. Instead of the bubble bar container, the
entire drag layer was used. Removing the view from the drag layer
interrupted the drag gesture.

Adding/removing the drop target view directly to the bubble bar
container does not affect the drag.

Bug: 397459664
Flag: com.android.wm.shell.enable_create_any_bubble
Test: Manual. Be on the overview screen with no bubbles present. Drag
the taskbar over the bubble drop zone and then back. Observe that the
drag is not interrupted.

Change-Id: I116883117b3da39528a4586a2436a10838625600
2025-03-03 18:14:05 -08:00
Bill Yi fe109a676c Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I9c2dfae2a37a985ced0ec6162042aec60dd998f1
2025-03-03 17:18:34 -08:00
Wen-chien Wang 8444f38c92 Merge "pin-shortcut: Tracks hotseat states and adds unpin option for taskbar" into main 2025-03-03 16:50:48 -08:00
Treehugger Robot 51a3a87b14 Merge "Arrows to scroll recent tasks in KQS" into main 2025-03-03 16:44:25 -08:00
Brian Isganitis 06d2e58105 Merge "Exclude All Apps divider in desktop mode." into main 2025-03-03 15:58:41 -08:00
Uwais Ashraf 994bc6dfcf Merge "Use Recents CoroutineScope with cancellable Jobs per TaskView." into main 2025-03-03 15:37:36 -08:00
Treehugger Robot 85ec44bcf9 Merge "Revert "Add debug logs to AbsSwipeUpHandler.calculateEndTarget"" into main 2025-03-03 15:14:01 -08:00
Saumya Prakash 6a32cf392b Remove the step indicator for the gesture tutorial
This change removes the pill indicator for the legacy gesture navigation
tutorial. It causes accessibility issues and is not needed for the current version
of the gesture tutorial.

Fix: 378415116
Bug: 400485351
Test: Run tutorial and observe no more indicator for the steps
Flag: EXEMPT bugfix
Change-Id: I33c3d7131752c2118ef03bf7d76389e855b836f4
2025-03-03 23:10:29 +00:00
Jagrut Desai b46953da5b Support launching minimized task into desktop
Test: Manual, Presubmit
Bug: 396615095
Flag: EXEMPT bugfix
Change-Id: I6489257df18aca2e696434aafee2c1d910b627da
2025-03-03 14:44:06 -08:00
Anushree Ganjam 17c6f2c4a1 Add Two stages related flags to bug report's flag dump logs.
Bug: 400141268
Test: Manual
Flag: EXEMPT legacy DeviceConfig ENABLE_LPNH_TWO_STAGES ENABLED
Change-Id: I264aef5256096df2ab5860d7d78fb890656bf7f0
2025-03-03 14:41:17 -08:00
Treehugger Robot 5fcd02dff6 Merge "Fix NPE from navbar touch cancel without down." into main 2025-03-03 13:05:39 -08:00
Jagrut Desai 47b0246c26 Merge "Fix SystemNav and Taskbar related Memory Leaks" into main 2025-03-03 12:24:47 -08:00
Treehugger Robot 19e93afd91 Merge "Test all apps -> workspace drag for taskbar on home" into main 2025-03-03 11:59:21 -08:00
Schneider Victor-tulias 55c543622c Revert "Add debug logs to AbsSwipeUpHandler.calculateEndTarget"
This reverts commit f9c1e29766.

Reason for revert: debug logs no longer needed. issue found

Change-Id: I633d5d6a7386349f19b64ed12aecbc163b5c1c21
2025-03-03 11:46:57 -08:00
Brian Isganitis 8127148e02 Exclude All Apps divider in desktop mode.
Flag: com.android.launcher3.taskbar_recents_layout_transition
Bug: 315354060
Test: go/testedequals
Change-Id: Ic9cf42ad9a81357fe7452ed576663bedb54fbcf7
2025-03-03 14:42:16 -05:00
Mykola Podolian c095f8b318 Merge "Added accessibility action to move taskbar icon to the bubble bar" into main 2025-03-03 10:31:03 -08:00