Commit Graph

14882 Commits

Author SHA1 Message Date
Treehugger Robot bee486a7da Merge "Use desktop mode autostashing on desktop devices" into main 2025-05-15 17:33:29 -07:00
Treehugger Robot 06483e2faa Merge "Clean up Recents window for connected displays when the screen is off" into main 2025-05-15 13:13:46 -07:00
Alex Chau 38efd382b7 Merge "Revert "Recreate Launcher activity when blur enabled changes"" into main 2025-05-15 13:07:22 -07:00
Priyanka Advani (xWF) 1f891a6b67 Revert "Recreate Launcher activity when blur enabled changes"
Revert submission 33554447-b/414789280

Reason for revert: Droidmonitor created revert due to b/417614196. Will be verifying through ABTD before submission.

Fix: 417614196

Reverted changes: /q/submissionid:33554447-b/414789280

Change-Id: Idf349cd39a3f86910f597f0f9ab4d46fb03e945c
2025-05-15 11:12:05 -07:00
Steven Ng 5447e27488 Clean up Recents window for connected displays when the screen is off
Root clause: In connected displays, the recents windows are rendered in a separated window instead of in Launcher / QuickStepLauncher. And thus, Launcher#onScreenOnChanged doesn't clean up the recents windows upon screen off.

This CL also updates RecentsState#toString to make it easier to differentiate RecentsState from LauncherState in the logs.

Flag: com.android.launcher3.enable_overview_on_connected_displays
Test: Manually verified that the recents windows UI shown on a connected display is cleaned up after screen
Bug: 415040428
Change-Id: Iac602237943f341f1ce46d651c5b98003f3914c9
2025-05-15 10:31:32 -07:00
Surbhi Kadam 550dbb0021 Merge "Launcher3: send token with early wakeup request to SurfaceFlinger" into main 2025-05-15 10:28:36 -07:00
Ebru Kurnaz 6ddc86dc7e Merge "Use wm callbacks for sys decor in Launcher instead of command queue." into main 2025-05-15 09:44:19 -07:00
Mykola Podolian 4703fef886 Merge "Reset -1 page progress when leaving it" into main 2025-05-15 09:37:10 -07:00
Jordan Silva 17b5284033 Merge "Clean-up TaskViewIcon to remove duplicated View methods." into main 2025-05-15 08:40:00 -07:00
Tony Wickham cb535f5330 Merge "Call updateOverivewDragState when mIsAnimatingToLauncher changes" into main 2025-05-15 08:11:56 -07:00
Sam Cackett 86957d29bc Merge "Switch to screenshot before animating split select" into main 2025-05-15 07:30:28 -07:00
Ebru Kurnaz 88185ac745 Use wm callbacks for sys decor in Launcher instead of command queue.
Bug: 412615955
Test: DisplayRepositoryTest
Flag: com.android.window.flags.enable_sys_decors_callbacks_via_wm
Change-Id: I42865b2b9169e99e35e09e239f6a1b3e455b7894
2025-05-15 13:39:33 +00:00
Alex Chau 6564f33184 Merge "Remove debug logs on a closed bug" into main 2025-05-15 06:37:49 -07:00
Alex Chau b7dd7bf1e0 Merge "Recreate Launcher activity when blur enabled changes" into main 2025-05-15 06:07:58 -07:00
Jordan Silva 18885ee426 Clean-up TaskViewIcon to remove duplicated View methods.
This change simplifies the TaskViewIcon interface by inheriting directly from View, removing redundant method declarations like `getWidth()`, `getHeight()`, `setOnClickListener()`, etc.

Affected classes are updated to use the new interface, primarily by calling `asView()` to access the underlying View methods where necessary.

Bug: 415265678
Flag: com.android.launcher3.enable_overview_icon_menu
Test: Manual.
Change-Id: I281f495116a841338075d0ff35effd19316aaeec
2025-05-15 13:07:00 +01:00
Sam Cackett 7ab01c539e Switch to screenshot before animating split select
Fixes an issue where the live tile would flicker and briefly show the
background, then switch to screenshot and animate

Fix: 399847132
Flag: EXEMPT. Bugfix
Test: Manual. See bug
Change-Id: I373e052f32af1b7fade4cce509c820d29deafe97
2025-05-15 12:07:53 +01:00
Mykola Podolian 12d5eae670 Merge "Clear bubble bar saved states if bubble bar controllers not present." into main 2025-05-14 17:38:07 -07:00
mpodolian ae8047b5c3 Reset -1 page progress when leaving it
Reset in-app display override progress when transitioning from home -1
page. In order to come back to the -1 page user has to swipe left from
home again so in-app display override progress will be updated again.

Fixes: 416163737
Flag: EXEMPT - bugfix
Test: Manual. enable 3 buttons navigation mode. Have bubble bar with
bubbles. Swipe to -1 page. Click recent apps button. Click home.

Change-Id: Ibc67f6e024f5c89efb7f80f420fc859aaa9d3e33
2025-05-14 17:16:28 -07:00
Treehugger Robot 8272b43675 Merge "Always allow first grid task to snap to top right" into main 2025-05-14 13:05:53 -07:00
Treehugger Robot a882e236bb Merge "Add shadow to KQS view" into main 2025-05-14 11:53:24 -07:00
Alex Chau f38d9c3ff3 Always allow first grid task to snap to top right
- Follow-up of ag/31609791 which introduced expectedCurrentTaskView to allow Home -> Overview's currentTask to snap on top-right corner
- This CL ensures the same extra spadce between expectedCurrentTaskView and ClearAllButton is applied when going from Desktopt -> Overview

Fix: 416061364
Test: Home/Fullscreen app/Desktop -> Overview with <=4 tasks, first grid task can always snap to top right
Flag: EXEMPT bug fix
Change-Id: I078eaef04bc951b755b1d83b0c8570c89978077b
2025-05-14 10:08:18 -07:00
Alex Chau a6fa3db580 Recreate Launcher activity when blur enabled changes
- When battery saver changes, WallpaperThemeManager always recreate activity to reapply theme base on wallpaper color hint changes
- Battery saver change can also result in light/dark theme changes, for which WallpaperThemeManager also recreate activity to apply theme changes
- As a result, it'll be much simpler to recreate activity whenever isBlurEnabled changes
- Exposed recreateToUpdateTheme API from WallpaperThemeManager to achieved this
- Greatly simplified Overview styling to read from styles

Bug: 414789280
Test: manually toggling battery saver and light/dark theme and WallpaperThemeManagerTest
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I90ad724867283fe3c62a9073a6e072491533f774
2025-05-14 17:45:04 +01:00
Surbhi Kadam e4b9306c59 Launcher3: send token with early wakeup request to SurfaceFlinger
Passes a binder token to SurfaceFlinger and adds tracing for debugging

Bug: 323292798
Bug: 409740673
Test: presubmit
Flag: EXEMPT log only update; bugfix

Change-Id: I0bc6df0a55cf747203b24b43596bed6ce5ebe76a
2025-05-14 08:07:43 -07:00
Treehugger Robot a65936447f Merge "Don't show overview via keyboard shortcut if blocked by SysUi state" into main 2025-05-14 06:44:39 -07:00
Vinay Joglekar 894224b3d2 Merge "Apply correct theme when launcher restarts" into main 2025-05-14 04:56:27 -07:00
Steven Ng d8f2df4124 Don't show overview via keyboard shortcut if blocked by SysUi state
Note: before this change, triggering overview keyboard (KB) shortcut at lock screen would result in the overview shown after the screen is unlocked. This behavior is counter-intuitive. And thus, this change will discard overview KB shortcut at lock screen regardless if an external display is connected,

Flag: EXEMPTED minor bug fix
Test: manually trigger overview KB shortcut at lockscreen in both the default & connected display. Observed that no overview is shown at lock screen and after unlock.
Test: manually trigger overview KB shortcut after lockscreen in both the default & connected display. Observed that the overview is shown at the focused display.
Test: atest NexusLauncherTests:RecentsAnimationDeviceState
Bug: 415040428
Change-Id: Ia585b7b62e5f8de5be6d7cda9ad24760398ca37a
2025-05-14 10:59:10 +00:00
vinayjoglekar d4bd12a763 Apply correct theme when launcher restarts
1. initialize DepthController before applyStyle()
2. initialize mBlurEnabled to correct value based on mCrossWindowBlursEnabled and mPauseBlurs.

Fix: 416687465
Test: Restart launcher and go to overview both from app and home.
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I018d25b66d925f201449400fc6bbb6a238a0f531
2025-05-14 10:08:41 +01:00
Hyunyoung Song 21284c8e13 Merge "Revert "Prevent CtS invocation in fake landscape mode"" into main 2025-05-13 23:03:08 -07:00
Toni Barzic 2cf0d817a3 Use desktop mode autostashing on desktop devices
Updates few autostashing related conditions to use
`isTaskbarShowingDesktopApps()` instead of `isInDesktopMode()`, as the
former covers the case where the desktop flavour taskbar is shown
consistently (on desktop devices).

Bug: 390665752
Bug: 415991381
Flag: com.android.window.flags.enable_desktop_taskbar_on_freeform_displays
Test: On desktop device, verify that "Always show taskbar" is shown on
      home/in overview/in app outside desktop mode, and verify that the popup
      value shown is consistent with the value in desktop mode. Verify
      that taskbar does not get auto-stashed on home, even if "Always
      show Taskbar" value is false.
Change-Id: I4edfe20f5526210fdf767231d0906875fe04f806
2025-05-14 05:53:51 +00:00
Treehugger Robot 847486372c Merge "Fix launching 2nd empty desk" into main 2025-05-13 19:06:25 -07:00
Treehugger Robot 4457d427e7 Merge "Update StatusBarTouchController to work on external display" into main 2025-05-13 15:59:22 -07:00
Tony Wickham 10615f8ef3 Call updateOverivewDragState when mIsAnimatingToLauncher changes
- updateOverviewDragState depends on mIsAnimatingToLauncher, so
  this change ensures it is always updated to reflect the latest.

Flag: EXEMPT bugfix
Fixes: 391266003
Test: swipe from an app to home, immediately swipe to All Apps
during the transition and verify that Taskbar logs show that
mDisallowLongClick=false and mIsAnimatingToLauncher=false; also
verify that long press on Taskbar icons works after launching
an app from All Apps.

Change-Id: Id18a3d4fba9357273dbeddd9220bac325b2e9b73
2025-05-13 22:54:51 +00:00
Suhua Lei 8e274f05dd Fix launching 2nd empty desk
Currently, there is a case that create 1 non-empty desk and
two empty desks, then launch the 2nd empty desk without activating the
1st empty desk, it will get stuck at waitForThumbnailsToUpdate.

The reason is the thumbnailData of the tasks that are checked
in waitForThumbnailsToUpdate has been reset to null.

This fix updates waitForThumbnailsToUpdate by firstly filtering the
tasks based on if they are still visible, and only wait on visible tasks.

Bug: 416040522
Flag: EXEMPT bug fix
Test: mauanl create empty desks and launching
Change-Id: I8741a6abe73511bd2b00f2fdbf375228f798ae21
2025-05-13 15:38:03 -07:00
Daniel Akinola 6efff5eeac Update StatusBarTouchController to work on external display
Dragging on launcher background on external display didn't do anything
because there was no StatusBarTouchController. Now by adding it to
SecondaryDragLayer, we can open the shade on external display via
launcher drag

Bug: 362719719
Bug: 416511740
Test: manual testing
Flag: EXEMPT refactor only
Change-Id: I1a587fe85bf2e7c6f212b3358646d5d282019eef
2025-05-13 13:26:41 -07:00
Helen Cheuk dda022a19b Merge "[Action Corner] Handle go home action" into main 2025-05-13 12:46:40 -07:00
Treehugger Robot 7bacd8f0b7 Merge "Only show the frontend UI on the display if it is supported" into main 2025-05-13 12:03:10 -07:00
Sunny Goyal 43841027b0 Merge "Removing some unnecessary launcher typecast" into main 2025-05-13 11:42:34 -07:00
Will Osborn 635ad53b4f Merge "Fix transition to home on connected display by passing correct displayId to startHomeIntentSafely" into main 2025-05-13 11:09:49 -07:00
helencheuk d681164fe3 [Action Corner] Handle go home action
Handle go home and go back to previous screen for overview, split and full screen task

Bug: 397182595
Test: ActionCornerHandlerTest
Flag: com.android.systemui.shared.cursor_hot_corner
Change-Id: Ia928f102df6908058c02949db02a73430cea5ef1
2025-05-13 17:03:12 +00:00
Treehugger Robot 8a868c571e Merge "Fix IllegalArgumentException in RecentsWindowManger.onDestroy" into main 2025-05-13 09:35:13 -07:00
Treehugger Robot 5b77862850 Merge "Only show the Desktop shortcut when appropriate" into main 2025-05-13 09:15:04 -07:00
Jagrut Desai ac309032ac Merge "Fix NavButton Position when in RTL and Lanscape" into main 2025-05-13 08:35:32 -07:00
Sunny Goyal b2315b69c2 Removing some unnecessary launcher typecast
Bug: 417227133
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: Ie794e4855441f86441d869d315699bf46fce0db5
2025-05-13 08:26:25 -07:00
Treehugger Robot 54cc5efead Merge "Use TaskViews only for RecentsView CollectionInfo" into main 2025-05-13 08:16:08 -07:00
Schneider Victor-Tulias 099cce39eb Fix IllegalArgumentException in RecentsWindowManger.onDestroy
Flag: com.android.launcher3.enable_launcher_overview_in_window
Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 413003643
Test: issue surfaced, and fix confirmed, in presubmit
Change-Id: I0c4f1ae44bc3868ac4dd8772d2a8989a3506db03
2025-05-13 07:11:57 -07:00
Will Osborn 770ab0cc00 Fix transition to home on connected display by passing correct displayId to startHomeIntentSafely
Bug: 415274390
Flag: EXEMPT bugfix
Test: local + presubmits
Change-Id: I6a825c93a683726c044024e411a8272004ede957
2025-05-13 14:03:01 +00:00
Pierre Barbier de Reuille 8ac46d7e37 Only show the Desktop shortcut when appropriate
The Desktop shortcut should only be shown if the task is on a display
that can host a desktop.

Bug: 405181230
Test: atest DesktopSystemShortcutTest
Test: Manual
Flag: EXEMPT (bug fix)
Change-Id: I4639aade4c3640a3c60b85e08981cbe46974df38
2025-05-13 14:41:13 +01:00
Sam Cackett 7ac8a04cbe Use TaskViews only for RecentsView CollectionInfo
getAccessibilityChildren includes the add desktop and clear all buttons
in the collection, so the list read outs are 2 bigger than they should
be

Fix: 411430606
Flag: EXEMPT. Bugfix
Test: Manual. Talkback
Change-Id: I3dbc4a9692396f7d8c094dd245745b878833c1a6
2025-05-13 05:45:03 -07:00
Treehugger Robot 61962ec222 Merge "Better null handling for OverviewComponentObserver.getContainerInterface" into main 2025-05-13 05:26:16 -07:00
Will Osborn 807d0f9ecf Better null handling for OverviewComponentObserver.getContainerInterface
Bug: 413634484
Test: local + unit tests
Flag: EXEMPT bugfix
Change-Id: I249cd1925ac416e9861be9d0c3c451e2b6cdff43
2025-05-13 09:28:29 +00:00