Commit Graph

19175 Commits

Author SHA1 Message Date
Charlie Anderson be6f04b11a Put shape options for picker behind it's own flag
Test: presubmit && locally verified switching flags
Flag: com.android.launcher3.enable_launcher_icon_shapes
Bug: 376293447

Change-Id: If2fb8b6dcdcfcaf6ba0f6f1acef45d5bf2b327cb
2024-12-19 17:34:08 -05:00
Treehugger Robot a429476ec6 Merge "If Pinned Shortcuts aren't available, then check for pinned shortcuts by id/package name" into main 2024-12-17 15:38:17 -08:00
Stefan Andonian fa1b2ba983 If Pinned Shortcuts aren't available, then check for pinned shortcuts by id/package name
Bug: 356096502
Test: Verified locally that if you hard-code the PINNED shortcut query to not return data, the backup query still allows the deep shortcuts to show up on the home screen.
Flag: EXEMPT bug fix
Change-Id: I7a9b2d2c3be2ecce38a5af71951f1a12bc1c20ee
2024-12-17 18:06:48 +00:00
Treehugger Robot d3f591f614 Merge "Prevent bad grid configuration by making sure RestoreDbTask updates IDP correctly." into main 2024-12-16 22:06:32 -08:00
Treehugger Robot 254ba3092e Merge "Handle cancelled All Apps transitions." into main 2024-12-16 19:33:00 -08:00
Charlie Anderson 3eec1895ed Prevent bad grid configuration by making sure RestoreDbTask updates IDP correctly.
IPD#reset() was resetting the internal IDP dbFile to the factory default instead of current grid/db

This lead to LoaderTask and grid migration creating an empty DB for the wrong grid size, while the restored DB remained unused. Leading to an empty home screen because an empty DB file was used.

Bug: 377510898
Flag: EXEMPT bugfix
Test: manually testing backup & restore with various grid sizes
Change-Id: I709201e484afb8f12a4fde21198d2c5793d89ca1
2024-12-16 14:39:41 -08:00
Brandon Dayauon 9f481bb2ea Merge "Fix swipe up to home gesture when entering scheduler page" into main 2024-12-16 13:07:04 -08:00
Treehugger Robot eeebf0111b Merge "Don't allow drag n drops to auto-switch pages during accessibility item moves." into main 2024-12-16 09:36:34 -08:00
Andy Wickham f6850bd4f2 Handle cancelled All Apps transitions.
Previously if this was cancelled mid-animation, the background
panel could get stuck on the screen.

To reproduce this consistently, I automatically cancelled the
animation 50ms after it started. Here's how that looked:
 - Before: https://drive.google.com/file/d/1tiW7mFehk3of-qYe1_HBZSmJLjU4VVmv/view?usp=drive_link&resourcekey=0-tH7YccjcNuXe8qKaL_8H2w
 - After: https://drive.google.com/file/d/1XpRy8FusaSZkJTGa7FHhUuqMUHkeI_UA/view?usp=drive_link&resourcekey=0-gvoyXE3puv7lW78kgKLEng

Fix: 383731295
Test: Manual
Flag: EXEMPT bugfix
Change-Id: I9423b75800a002419a56a3fe3f93b2e7350aeaa0
2024-12-13 17:59:32 -08:00
Mykola Podolian 19e6afa1f6 Merge "Align the adjusted hotseat drop animation with the hotseat" into main 2024-12-13 17:13:30 -08:00
Wen-chien Wang ad0b62daad Merge "pin-shortcut: Add pin shortcut to the context menu" into main 2024-12-13 17:00:42 -08:00
Stefan Andonian 0f4e5e974d Don't allow drag n drops to auto-switch pages during accessibility item moves.
Bug: 379798547
Test: Manually tested this on device.
Flag: EXEMPT bug fix
Change-Id: Ic19a0d167525d5500ed1dacd3dcaaa4550b11261
2024-12-13 16:11:08 -08:00
Wen-Chien Wang 2badfc7ebc pin-shortcut: Add pin shortcut to the context menu
This cl adds the pin shortcut option to the context menu, where
it works on Home launcher, hotseat, and pinned apps on the
taskbar.
Currently the option is a no-op.

Bug: 375648361
Test: Manual. Recording uploaded to buganizer
Flag: com.android.launcher3.enable_pinning_app_with_context_menu
Change-Id: I5d1284a6e909fd75f14e81c3ae713da3cdc01ce3
2024-12-13 22:49:52 +00:00
Treehugger Robot 5849df4002 Merge "[-1] Fix flicker of -1 when swipe up to exit -1 isn't fast enough" into main 2024-12-13 14:02:46 -08:00
Fengjiang Li b8b16bd288 [-1] Fix flicker of -1 when swipe up to exit -1 isn't fast enough
Fix: 381017761
Flag: NONE - released code
Test: manual - record a video
Change-Id: I5bda4a234cdcc8227d4feb9a92a174d07e46f7a2
2024-12-13 12:11:41 -08:00
Sebastián Franco 6f3213b260 Merge "Prevent Hotseat jank when switching Fixed Landscape setting" into main 2024-12-13 11:51:46 -08:00
Stefan Andonian 4e3d6a5d6e Merge "Log.wtf if DeleteDropTarget "canRemove", but doesn't remove item from the database." into main 2024-12-13 11:33:34 -08:00
Sebastian Franco f2b9190c64 Adding logs to see what is triggering rotation changes
Bug: 380940677
Test: NA
Flag: com.android.launcher3.one_grid_specs
Change-Id: I393232b410a4b961d3cbdd39766a403f994610e7
2024-12-13 11:08:43 -08:00
Sebastián Franco 24e9e55bca Merge "Setting mIsFixedLandscape as the first if condition while fixing 380940677" into main 2024-12-13 11:08:09 -08:00
Charlie Anderson 9a2e3a715b Merge "Add new failsafe to disable new archiving broadcast" into main 2024-12-13 07:33:49 -08:00
Sunny Goyal 18e480838a Replacing all int lookup flags and boolean overrides with an object to make it easier to extend options
Bug: 381897614
Bug: 366237794
Flag: EXEMPT refactor
Test: atest CacheLookupFlagTest
Change-Id: Ic89d48dd1c5dc8b0a89b1898cd7b00d9c61d6513
2024-12-12 18:32:55 -08:00
mpodolian 8a28b39f4d Align the adjusted hotseat drop animation with the hotseat
Adjusted the hotseat drop animation to ensure the drop target moves to
the correct position.

Fixes: 383199528
Flag: com.android.wm.shell.enable_bubble_bar
Test: Manual:
http: //recall/-/gx8ASgewUeUS3QYohfrd1J/cL46nBGrr6yCA19FD9I5vs
Change-Id: I16fa9710246ce263374d06cfa796a72a7a4d5437
2024-12-12 17:58:23 -08:00
Sebastian Franco dabf02fd86 Prevent Hotseat jank when switching Fixed Landscape setting
Fix: 380998389
Test: HomeScreenImageTest
Flag: com.android.launcher3.one_grid_specs
Change-Id: I6e7334b9f5b3d6abab57d461987db64fe3700ac4
2024-12-12 17:32:11 -08:00
Stefan Andonian b64026135f Log.wtf if DeleteDropTarget "canRemove", but doesn't remove item from the database.
Bug: 379606516
Test: Verified locally that these logs show when hard-coded to appear. Also verified that normal usage doesn't cause crashes.
Flag: EXEMPT bug logs
Change-Id: Iadc67f4a063f5924c758468c6b227b23368fc192
2024-12-13 00:41:06 +00:00
Sunny Goyal daf46a09b2 Merge "Moving WMProxy to dagger" into main 2024-12-12 15:27:19 -08:00
Brandon Dayauon d660052416 Fix swipe up to home gesture when entering scheduler page
bug: 383491628
Test video: https://drive.google.com/file/d/1brSO55cBeZZMTLq5dZ-rNO7Z-aeytghe/view?usp=sharing
Flag: com.android.launcher3.work_scheduler_in_work_profile

Change-Id: I0a8e0b64ac175ef6ccfc4f2db1b751ea6aef6995
2024-12-12 15:16:12 -08:00
Charlie Anderson 2885a6639c Add new failsafe to disable new archiving broadcast
Bug: 322314760
Test: presubmit and LoaderTaskTest
Flag: com.android.launcher3.enable_first_screen_broadcast_archiving_extras

Change-Id: I7c7b94a81dd717ed6f32de2ae986616b93dbbcc0
2024-12-11 18:59:05 -05:00
Treehugger Robot 5a5cf9e698 Merge "Fixing nullpointer error in genering error description" into main 2024-12-11 13:37:05 -08:00
Sunny Goyal 41e8057bbf Moving WMProxy to dagger
Bug: 361850561
Flag: EXEMPT dagger migration
Test: Presubmit
Change-Id: I9a8031037f2167658b7bc212b59c9b11abbf2f03
2024-12-11 13:24:26 -08:00
Treehugger Robot 4d4eb7d685 Merge "Introduce mTaskViewCount inside the RecentsView" into main 2024-12-11 12:36:00 -08:00
Sunny Goyal 0cb0166a2c Fixing nullpointer error in genering error description
Bug: 383492095
Flag: EXEMPT bug fix
Test: Presubmit
Change-Id: I43c71bb62df45d53bd757daa3203f216229946a0
2024-12-11 11:41:39 -08:00
minch 58abc8b0a6 Introduce mTaskViewCount inside the RecentsView
Add a member property `mTaskViewCount` inside the RecentsView to track
the number of TaskView inside it. Its value will be increased
`onViewAdded` and decreased `onViewRemoved`.
- Then `getTaskViewCount()` can just return this variable directly.
- Invalidate the `PagedView.mPageScrolls` on a view addition and
  removal util they have been updated on next `onLayout`. This is done
  to guarantee that `mOnPageScrollsInitializedCallbacks` is run with
  up to date `mPageScrolls`.

Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Tested on Tangor, ensure `mTaskViewCount` is correct in the
      following scenarios:
      1. Adding more tasks and enter overview
      2. Dismissing one and more tasks
      3. Dismissing all tasks
Change-Id: I32407e77dd2a9b3d8200efc334c1eadea1336b31
2024-12-11 10:43:31 -08:00
Mykola Podolian 29ccf8703b Merge "Remove usage of the enableBubbleBarInPersistentTaskBar flag." into main 2024-12-11 09:24:25 -08:00
ELIYAZ MOMIN (xWF) 931a86396f Merge "Revert "Making sure that test go to FixedLandscape on landscape"" into main 2024-12-11 04:05:30 -08:00
ELIYAZ MOMIN (xWF) d98bb0b979 Revert "Making sure that test go to FixedLandscape on landscape"
This reverts commit 279b77a882.

Reason for revert: <Potential culprit for b/383424365 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.>

Change-Id: I4b1c81a8e458432c880ad68fa5bd0e2062f2680f
2024-12-11 02:38:04 -08:00
Sebastián Franco 485c57044d Merge "Making sure that test go to FixedLandscape on landscape" into main 2024-12-11 00:40:31 +00:00
Treehugger Robot 4d8f0d5a8f Merge "Add Aster logging for entering and exiting desktop mode via quick switch" into main 2024-12-10 23:31:50 +00:00
mpodolian 3e419ebbf1 Remove usage of the enableBubbleBarInPersistentTaskBar flag.
Remove and merge the usage of the enableBubbleBarInPersistentTaskBar
flag to the enableBubbleBar flag.

Bug: 383181643
Flag: com.android.wm.shell.enable_bubble_bar
Test: NONE - removed and merged flag usage.
Change-Id: I4f131e1ddf8367425b91c8fb597857ee222b75d8
2024-12-10 15:10:49 -08:00
Jeremy Sim 41cdb7ffee Merge "App Groups: Allow app pairs to take more than 2 members" into main 2024-12-10 22:37:31 +00:00
Fengjiang Li b0ce150306 Merge "[PostBoot] Support post boot animation on launcher3" into main 2024-12-10 21:43:33 +00:00
Shamali Patwa 5f5b1a3f56 Merge "Fix missing IME back animation in widget picker" into main 2024-12-10 19:44:47 +00:00
Mykola Podolian 9763990e9e Merge "Align hotseat drop target with the adjusted hotseat" into main 2024-12-10 18:50:22 +00:00
Fengjiang Li c290787cf7 [PostBoot] Support post boot animation on launcher3
Add ALPHA_CHANNEL_COUNT to DragLayer

Test: manual
Flag: NONE - gated in xml
Bug: 346332241
Change-Id: Ie7cf4c11b4e606e01d54d8a87e7f1dc5906e97b0
2024-12-10 10:07:29 -08:00
Sebastian Franco 279b77a882 Making sure that test go to FixedLandscape on landscape
Fix: 379871292
Test: TaplDragTest
Flag: com.android.launcher3.one_grid_specs
Change-Id: I56027c22e4c3b1b0532ba0ac00eb0f4caea24abb
2024-12-10 17:08:54 +00:00
Shamali P aaf585aef2 Fix missing IME back animation in widget picker
Discussed with folks who worked on IME animation, and root cause seemed
to be picker unconditionally clearing the focus. Also, there is no
in-built way for clearing focus on other user interactions. So, had to
write custom logic to conditionally clear the focus.

Bug: 369933372
Test: See screencast (tested back, and other user interactions)
Flag: EXEMPT BUGFIX
Change-Id: I693bd27662563e5320159c082eb955a3bd5386f8
2024-12-10 16:28:05 +00:00
Vania Desmonda 7fd479c454 Add Aster logging for entering and exiting desktop mode via quick switch
Fixes: 360874817
Fixes: 381214742
Flag: com.android.window.flags.enable_desktop_windowing_quick_switch
Test: manual test
Change-Id: I7bae2aaff614a5590fa107d0c102c520b14b85d9
2024-12-10 13:35:15 +00:00
Jeremy Sim 0c3b2e9540 App Groups: Allow app pairs to take more than 2 members
Changes saveAppPair to take a general number of apps, rather than just 2. At the moment, this will not change anything, since GroupedTaskViews are still hard coded to contain 2 apps.

Bug: 349828130
Flag: com.android.wm.shell.enable_flexible_split
Test: No effect on behavior, just a small refactor.
Change-Id: I6f86210ab4662f0d3a8fba1f6bb6fd78391e7fa2
2024-12-09 16:41:24 -08:00
Treehugger Robot 07e6109dc6 Merge "Add logs to output intent string for NPE in DbEntry." into main 2024-12-09 23:41:08 +00:00
Stefan Andonian e2c19253b2 Add logs to output intent string for NPE in DbEntry.
Bug: 380555381
Test: No tests, just changed log string.
Flag: EXEMPT bug fix logs
Change-Id: I0b0a36ebce0db38c89afb22a89b7e969fdc16bd9
2024-12-09 13:41:57 -08:00
Stefan Andonian 3d76150128 Merge "Convert SpringLoadedDragController to Kotlin" into main 2024-12-09 21:04:16 +00:00