Commit Graph

2016 Commits

Author SHA1 Message Date
Sunny Goyal bb84ab3d66 Fixing recents orientation (when home rotation is allowed) during swipe-up am: 52f2392405 am: e58055d79d am: a63a7a0471 am: f2d234834c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12102312

Change-Id: I077a4f24565d8c4dfb989171b34a96f89b16a32a
2020-07-08 05:57:38 +00:00
Sunny Goyal 52f2392405 Fixing recents orientation (when home rotation is allowed) during swipe-up
Bug: 158781568
Bug: 160149607
Change-Id: I27be09febcdb6f19687469db34b002ce682aa0cb
Merged-In: I27be09febcdb6f19687469db34b002ce682aa0cb
(cherry picked from commit 141c231d2f)
2020-07-08 00:24:29 +00:00
TreeHugger Robot 289aca6a0e Merge "Guard swipe to notification gesture with system settings preference" 2020-07-07 02:02:11 +00:00
Jerry Chang 779efaca91 Guard swipe to notification gesture with system settings preference
Bug: 154080211
Test: make and install, check the gesture works as expectedly
Change-Id: Ibd6bbd595d2fba5d68e66eb54e4a7fec160b9bf8
2020-07-01 11:44:02 +08:00
Zak Cohen 1562c3de18 Thumbnail Cache - check canceled status on the right thread. am: 19797b419b am: 987ba0261f am: 4163325b9c am: c01ab27bce
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12029198

Change-Id: Ib5e004cae554832050f1a3efff5276bf3399d126
2020-06-29 22:59:17 +00:00
Zak Cohen 19797b419b Thumbnail Cache - check canceled status on the right thread.
The cache was checking the canceled status on the background
thread, but the cancel call was being made on the main thread.
This was leading to canceled requests still delivering this thumbnail
in some cases.

Bug: 159840851
Test: local build and non-repo of bug
Change-Id: I9a3556f6570eee1db39ebec202c115d58010d7f8
2020-06-29 04:11:04 +00:00
TreeHugger Robot 879ba9803d Merge "Add NPE check for prediction controller" into rvc-dev am: f8e12b78bf am: 53c7ddd7fd am: 39e1af9a27 am: 4585f9f3c5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12001481

Change-Id: I18caa4806f4933059fb1bdc5165e5aa80b5bd605
2020-06-26 20:45:18 +00:00
Samuel Fufa 0036b2b67a Add NPE check for prediction controller
Bug: 159835714
Test: Manual
Change-Id: I9cc03f6491f4e14462be6c01edf3ed4ca1d82136
2020-06-25 20:10:01 +00:00
Andy Wickham 3b98451394 Updates Assistant gesture regions when no longer tracking multiple. am: d2731957ea am: 3fef2dd92d am: 98f26d1a15 am: 5cf822dff3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11992046

Change-Id: I2769af25a543a8860d7533f8e677e958d2b4b0ef
2020-06-25 03:21:00 +00:00
Andy Wickham d2731957ea Updates Assistant gesture regions when no longer tracking multiple.
This should prevent states where Assistant triggers from
the vertical-center of the screen in portrait (see bug).

Also fleshes out OrientationTouchTransformerTests and
adds some new ones that fail without this change:
 - enableMultipleRegions_assistantTriggersInMostRecent
 - enableMultipleRegions_assistantTriggersInCurrentOrientationAfterDisable

Fixes: 158686674
Change-Id: I6d045a485f62e4010e9e3d00805a50fdd953a2fc
(cherry picked from commit 4b531b972d)
2020-06-24 22:32:14 +00:00
TreeHugger Robot 44035d9d17 Merge "Merging from ub-launcher3-rvc-dev @ build 6621659" into rvc-dev am: 738b1af342 am: f7897465e3 am: 808a7c1920 am: dde7797ec5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11975976

Change-Id: Ifdd13981f0e61d248e89a1f10eec3b51369840f4
2020-06-24 04:26:33 +00:00
TreeHugger Robot 18575b5c77 Merge "Prevent premature resetting of quickswitch mode" into rvc-dev am: 1c90b51de6 am: 995cab35af am: 3d040cfadd am: 34f04fe1df
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11977176

Change-Id: Ic81575a194a8c86ea57b40752d1f3d3ba2ee0705
2020-06-24 03:45:24 +00:00
Sunny Goyal 315eb02012 Merging from ub-launcher3-rvc-dev @ build 6621659
Bug:150504032
Test: manual, presubmit on the source branch
x20/teams/android-launcher/merge/ub-launcher3-rvc-dev_rvc-dev_6621659.html

Change-Id: Id9689e3dfa641c0e004c9dc975e281358bed7ad7
2020-06-23 16:28:38 -07:00
Vinit Nayak d92946356e Prevent premature resetting of quickswitch mode
Previously, whenever a user returned to the same
rotation that they had started quickswitch in,
we were sending sysui the reset flag(-1) indicating
that quickstep was complete instead of sending
the rotation of the device the user was in.

This was intentional and it worked, however we now
always send the active rotation while the user
is in a quickswitch session because sysui needs
to show the fake home handle for immersive apps,
which can occur in any rotation. This state is
distinct from not being in quickswitch at all, in
which no fake handles are shown.

Fixes: 158677967

Change-Id: I910324abf781b4b30fe981139712bcb5b653c318
(cherry picked from commit f2daafcdf8)
2020-06-23 22:45:44 +00:00
Vinit Nayak f2daafcdf8 Prevent premature resetting of quickswitch mode
Previously, whenever a user returned to the same
rotation that they had started quickswitch in,
we were sending sysui the reset flag(-1) indicating
that quickstep was complete instead of sending
the rotation of the device the user was in.

This was intentional and it worked, however we now
always send the active rotation while the user
is in a quickswitch session because sysui needs
to show the fake home handle for immersive apps,
which can occur in any rotation. This state is
distinct from not being in quickswitch at all, in
which no fake handles are shown.

Fixes: 158677967

Change-Id: I910324abf781b4b30fe981139712bcb5b653c318
2020-06-23 15:07:22 -07:00
Hyunyoung Song 85d90a16bc Merging from ub-launcher3-rvc-dev @ build 6617269
Bug: 150504032
Test: manual, presubmit on the source branch
https://android-launcher.teams.x20web.corp.google.com/merge/ub-launcher3-rvc-dev_rvc-dev_6617269.html

Change-Id: I7a13230553f9c42d5f67164234c33cf77efa9cf2
Merged-In: I2a168bfa8e3979ade26ab1d3cddbbae84cf79590
2020-06-23 05:11:31 +00:00
Hyunyoung Song 0b51b916b0 Merging from ub-launcher3-rvc-dev @ build 6617269
Bug: 150504032
Test: manual, presubmit on the source branch
https: //android-launcher.teams.x20web.corp.google.com/merge/ub-launcher3-rvc-dev_master_6617269.html
Change-Id: I2a168bfa8e3979ade26ab1d3cddbbae84cf79590
2020-06-22 18:53:39 -07:00
thiruram dbd61d4026 Log query_length & parent_container for actions on search results.
Bug: 154717227
Change-Id: I8e7d725014f60a2fd9a7fe13fce705acbc7623ad
2020-06-22 18:14:12 -07:00
TreeHugger Robot ceaad08f06 Merge "Fixing rotation watcher not enabled in landscape" into ub-launcher3-rvc-dev 2020-06-22 21:00:07 +00:00
Hyunyoung Song 5c9a1ef5cd Merge "Log Launcher transitions to WW" into ub-launcher3-rvc-dev 2020-06-22 20:21:10 +00:00
Sunny Goyal f67deb8e06 Fixing rotation watcher not enabled in landscape
Bug: 159636793
Change-Id: Ia7e5d90e9d441dfbe9877293957eff1ae7f69877
2020-06-22 13:02:53 -07:00
Hyunyoung Song 801f81fba5 Log Launcher transitions to WW
- ONRESUME / ONSTOP
- HOME_GESTURE
- OVERVIEW_GESTURE
- QUICKSWITCH
- SWIPELEFT/SWIPERIGHT

Bug: 156875719
Bug: 148822714
Bug: 137777105

Debug log: go/launcher-log-parity

Change-Id: I64a0deab4996b5be36320fbe0339f320891c53e0
2020-06-22 12:09:06 -07:00
TreeHugger Robot ce629ff837 Merge "Handling Launcher configuration change between touchDown and Launcher.onStart" into ub-launcher3-rvc-dev 2020-06-22 18:04:14 +00:00
TreeHugger Robot 845f135d17 Merge "Add depth animation when multiwindow mode changes." into ub-launcher3-rvc-dev 2020-06-22 17:31:35 +00:00
Sunny Goyal 6fe83da57c Handling Launcher configuration change between touchDown and Launcher.onStart
If activity rotation is allowed, Launcher/recents can rotate while swipe animation
is running leading to inconsistencies between deviceProfile and rotation
> Using activity configuration to determine the rotation instead of using display rotation
> Removing rotation watcher when rotation is enabled as it is not used anymore

Bug: 158781568
Change-Id: I107d856cae80af111c0514656fac7ab1fa0c21cb
2020-06-22 10:04:35 -07:00
TreeHugger Robot 5ec76de182 Merge "Deleting old cache images before saving new ones." into ub-launcher3-rvc-dev 2020-06-20 20:19:01 +00:00
Hyunyoung Song ac3f71269e Merge "Remove ConcurrentModificationException for snapshot logging Bug: 159282737" into ub-launcher3-rvc-dev 2020-06-20 06:27:01 +00:00
Sreyas ae74a618bd Deleting old cache images before saving new ones.
Change-Id: I5947fe43b0e1bfac35247bf64f08e49560d58cac
2020-06-19 17:28:19 -07:00
thiruram b53764bd4b Fixes folder logging.
Only LAUNCHER_FOLDER_LABEL_UPDATED events will have FromState, ToState
and FolderLabelInfo. Other folder events such as OPEN, DRAG etc will have
basic fields only populated.

Sample Log: https://paste.googleplex.com/5468394805526528
Screencast: http://rcll/hSUQjtQXfQM5i9DjjAQTf2/Zn5FeiVDONaQj0mK1JNjg

Bug: 159164315
Change-Id: I903fc7b62bcee748aa3ef695453be3e14d388712
2020-06-19 17:06:46 -07:00
Jon Miranda 36d1015997 Add depth animation when multiwindow mode changes.
This is a workaround until we can support app transitions when starting
an activity in mw mode.

Bug: 158613217
Change-Id: I843d6669722c543728ab532e1c4fbd4643f6f135
2020-06-19 16:36:57 -07:00
Hyunyoung Song 5eae3c0a0a Remove ConcurrentModificationException for snapshot logging
Bug: 159282737

Change-Id: I37edcf6aa11272b488a0633716567c48e56e5433
2020-06-19 16:12:43 -07:00
Zak Cohen aef8b86b4a Image actions - fix uri permissions.
Feedback wasn't working, also Share wasn't showing its preview.

Bug: 159122067
Test: built and run locally
Change-Id: Iccea012a8fc0009a6a980f6233f42c4e7619f4ec
2020-06-19 18:02:44 +00:00
TreeHugger Robot a5e45ad485 Merge "Fixing jump when swiping up in landscape and in waterfall cutout" into ub-launcher3-rvc-dev 2020-06-19 07:17:02 +00:00
Bill Lin 70b5ca2505 Update state and touch region after one handed overlay changed
The matrix for overall modes x state changes:
-----------------------------------------------------
   Mode     |      State changed     | *Before|*After
-----------------------------------------------------
  OneHanded |  Portrait->Landscape   |  80dp  |  32dp
  OneHanded |  Landscape->Portrait   |  32dp  |  80dp
-----------------------------------------------------
  OneHanded |  Disable->Enable       |  32dp  |  32dp
 (Landscape)|  Enable->Disable       |  32dp  |  32dp
-----------------------------------------------------
  OneHanded |  Disable->Enable       |  32dp  |  80dp
 (Portrait) |  Enable->Disable       |  80dp  |  32dp
-----------------------------------------------------
  NO_BUTTON |  Portrait->Landscape   |  32dp  |  32dp
  NO_BUTTON |  Landscape->Portrait   |  32dp  |  32dp
  2 BUTTON  |  Portrait->Landscape   |  48dp  |  48dp
  2 BUTTON  |  Landscape->Portrait   |  48dp  |  48dp
  3 BUTTON  |  Portrait->Landscape   |  48dp  |  48dp
  3 BUTTON  |  Landscape->Portrait   |  48dp  |  48dp
-----------------------------------------------------
* dimen : navigation_bar_gesture_height

Test: adb bugrepot | grep mOneHandedModeRegion
Test: manually triger one handed
Test: atest WindowInsetsBehaviorTests
Test: atest com.android.launcher3.memory.MemoryTests
Test: flake -once
Test: rnlot -t com.android.launcher3.memory.MemoryTests
Bug: 157958539
Bug: 159183864
Change-Id: I19755938c3c93eb59a9f621af5722f5679c1da14
2020-06-19 10:23:43 +08:00
Samuel Fufa a529cd0f5f Merge "Allow Users to migrate their hotseat when returning from AiAi" into ub-launcher3-rvc-dev 2020-06-19 00:51:18 +00:00
Samuel Fufa d25a112b0e Allow Users to migrate their hotseat when returning from AiAi
- If a user has mostly predicted hotseat, show a snack bar. otherwise, show migration option.
- Guard onboarding activity with permission `com.google.android.apps.nexuslauncher.permission.HOTSEAT_EDU`

Bug: 158569583
Test: Manual
Change-Id: Id0c1c812233fcf288a2f49848720199dedd2015d
2020-06-18 16:38:58 -07:00
thiruram ffb55ddece Deprecates LAUNCHER_ALL_APPS_RANKED event.
LauncherUiChanged.rank field is repurposed to store all apps rank.

Change-Id: Iabad98312589d8f53b6547433540f3ec9dff0b3f
2020-06-18 15:08:16 -07:00
Jon Miranda 1bbd2831f3 Fix bug where All Apps Edu gets closed via user input before animation ends.
Also fixes bug where user continuously swipes to hint view causes count
to increase more than the max count which prevents all apps edu from showing.

Bug: 151768994
Change-Id: I3186398d441e723a2cfb6e396b03944502a65cf5
2020-06-18 13:40:33 -07:00
Sunny Goyal b64fc6c26f Fixing jump when swiping up in landscape and in waterfall cutout
> Adding tests for TaskViewSimulator to ensure proper calculations
> Disabling orientation listener while user is interacting with quickstep

Bug: 158781568
Bug: 156891776
Change-Id: I299c3b1243ac0dbf28faee1b8566c77ea3954e33
2020-06-18 00:29:00 -07:00
Hyunyoung Song 714659f6d0 Add LAUNCHER_WORKSPACE_SNAPSHOT event_id
Bug: 159210161
Change-Id: Ie8e843ee10bf4ab0761232a3e61eb28e487666ab
2020-06-17 22:39:36 -07:00
TreeHugger Robot adb6352bac Merge "Don't rely on nav mode change listener for oriented state" into ub-launcher3-rvc-dev 2020-06-18 04:44:31 +00:00
TreeHugger Robot 9c126682d7 Merge "Snapshot logging only use cloned model thread folder contents Bug: 158826147" into ub-launcher3-rvc-dev 2020-06-18 04:34:56 +00:00
Hyunyoung Song 398c42fe6b Snapshot logging only use cloned model thread folder contents
Bug: 158826147

Change-Id: I9aea9fbc706b0dffa3f6abeaac663b072d62ad58
2020-06-17 20:59:45 -07:00
TreeHugger Robot 27ed32ac7e Merge "Updated recents oriented state on split screen" into ub-launcher3-rvc-dev 2020-06-18 02:35:16 +00:00
Miranda Kephart 1bb17f2658 Merging from ub-launcher3-rvc-dev @ build 6595814 am: efdc4e2318 am: 9cb1795a71 am: ad4bd43b8f am: 9269333de9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11885879

Change-Id: Ie7d2e841b2d41504e07633f116d80b4e3adde59f
2020-06-17 20:49:31 +00:00
TreeHugger Robot c0c0991231 Merge "Disabling OverviewActions when rotated." into ub-launcher3-rvc-dev 2020-06-17 20:40:56 +00:00
Sreyas f91c1d0ef1 Disabling OverviewActions when rotated.
Bug: 157272300
Bug: 159135247
Change-Id: I9c9eeb49b7d18c1c81a830b7a35113070e7ac793
2020-06-17 12:37:14 -07:00
thiruram c6a38ba5d8 Replaces StatsLogManager.log with StatsLogManager.logger()
Bug: 159170445
Change-Id: Ice6c8a9ae30d8e6b3843bfe42926053849bf9fe0
2020-06-17 17:32:54 +00:00
thiruram d8405a63d2 Replace StatsLogManager with builder pattern.
Follow up CLs will remove the deprecating log methods and update their references.

Bug: 159170445
Change-Id: I5dfd30209eeba561df1b528a6305ca5923ba42a2
2020-06-17 08:46:43 -07:00
Bill Lin f69563e935 Revert "Update state and touch region after one handed overlay changed"
This reverts commit a66dafe617.

Reason for revert: b/159183864 introduce com.android.launcher3.memory.MemoryTests failed after this CL merged.

Due to I need more time to investigate the root cause and do not block MemoryTests, revert this CL temporary. 

Change-Id: I0408123e36c55a262ee0f1080cd6612785b3f527
2020-06-17 11:21:24 +00:00