Commit Graph

6709 Commits

Author SHA1 Message Date
Schneider Victor-tulias bc5815d89d Merge "Expand on gesture navigation error detection." into tm-qpr-dev am: 2ae4420a12 am: 38fb33bfca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19671572

Change-Id: I34a81001da26c18a810aaf6b02e202b506791cc0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-06 18:35:47 +00:00
Schneider Victor-tulias 2ae4420a12 Merge "Expand on gesture navigation error detection." into tm-qpr-dev 2022-09-06 17:32:02 +00:00
TreeHugger Robot db32818a4e Merge "Made getOnBoardingPrefs @Nullable & avoid NPE" into tm-qpr-dev 2022-09-06 17:29:28 +00:00
Mateusz Cicheński fc2f0a835f Merge "The shelf height was mistakenly provided as width, making it equal to 0." into tm-qpr-dev am: 77593150da am: e1b2d018ed
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19836119

Change-Id: Ic9c1cd8a0139cf4461eb73de58a77958dfdc40d5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-06 17:24:12 +00:00
Mateusz Cicheński 77593150da Merge "The shelf height was mistakenly provided as width, making it equal to 0." into tm-qpr-dev 2022-09-06 16:36:48 +00:00
Alex Chau 5e4d93b9dc Merge "Enable adjacent task animation for grid" into tm-qpr-dev am: cec6e2c914 am: c47cb0463c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19619264

Change-Id: I129f15c6bde07d6baa5155a4fb10d69eb03d676d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-06 16:02:46 +00:00
Alex Chau 4a206837c9 Enable adjacent task animation for grid
- Enable adjacent task animation for grid tasks
- Only parallax for focused task and only when it's fully visible

Bug: 236963497
Test: manual
Change-Id: I6c681e112f3eb2c7075bc98fab405d978f5057d1
2022-09-05 11:09:28 +01:00
Mateusz Cicheński 26db3bb62a The shelf height was mistakenly provided as width, making it equal to 0.
Bug: 244797561
Test: manually
Change-Id: I28e9c34bb0feb643c5d7b652c055d5fdceaec878
2022-09-03 04:33:18 +00:00
Schneider Victor-tulias 7ad70b6066 Expand on gesture navigation error detection.
- Added some missing error detection:
    1. screenshot capture errors
    2. recents scrolling errors
    3. end-of-gesture callbacks
- Added some more explanation for OverviewInputConsumer selection reason
- Added logging the current task's package name to help identify gestures

Bug: 227514916
Bug: 243471493
Test: Ran launcher, performed multiple gestures and checked logs
Change-Id: I8b10cc75f8640a674c6fed6b06efa4763c9635a2
2022-09-02 15:53:24 -07:00
Jeremy Sim ac2807cf43 Merge "Fix bug with Launcher animation canceling, esp. around OverviewSplitSelect" into tm-qpr-dev am: afff936235 am: 5ebdb63a9d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19659546

Change-Id: I38c4ec5d6305dd986ce785c1a01496d1147592fe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-02 21:49:40 +00:00
Tracy Zhou fe53edbbce Merge "Do not change layering for non live tile tasks rendering" into tm-qpr-dev am: 1649163334 am: 902a57c7d9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19805291

Change-Id: Ib37565c378580d75220a9fce768cbb700b456387
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-02 21:08:04 +00:00
Jeremy Sim afff936235 Merge "Fix bug with Launcher animation canceling, esp. around OverviewSplitSelect" into tm-qpr-dev 2022-09-02 20:46:41 +00:00
Tracy Zhou 1649163334 Merge "Do not change layering for non live tile tasks rendering" into tm-qpr-dev 2022-09-02 19:18:22 +00:00
Alex Chau 1cf8d0895d Merge "Change wallpaper depth value in AllApps bottomsheet" into tm-qpr-dev am: f28c9f14a4 am: 18d7004c76
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19607219

Change-Id: Ic3f9e45cb7ea5ab0427b9b2f9250385cd283ba8d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-02 11:10:32 +00:00
Jerry Chang 454b838abe Support launching a shortcut and a task to split screen am: bf9ce9c096 am: b3ff2ee352
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19801551

Change-Id: Ifba337408874d33e9f9ba70ce351e44f4ca4ff97
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-02 11:10:11 +00:00
Alex Chau f28c9f14a4 Merge "Change wallpaper depth value in AllApps bottomsheet" into tm-qpr-dev 2022-09-02 10:06:37 +00:00
Tracy Zhou 668eec1e08 Do not change layering for non live tile tasks rendering
TaskViewSimulator#onBuildTargetParams is called for every single task rendering. Given the layering change doesn't work for the non live tile case (and we shouldn't change the layering in that case anyways), an additional check is added to prevent that from happening

Fixes: 242593058
Test: launch overview from home and app, and make sure that in both cases, task launch animation is intact
Change-Id: Ia242dc767499689547dfa8acae56d39e9b0c3189
2022-09-02 00:43:03 -07:00
Jerry Chang bf9ce9c096 Support launching a shortcut and a task to split screen
Fix: 243101552
Test: long press on a shortcut to enter split screen works
Change-Id: Icaabf2e1c8be086bd1b79e0a2cf05878767caa15
2022-09-02 06:58:08 +00:00
Mateusz Cicheński d9a065c71f Merge "Replace shelf height with keep clear areas registration in Launcher." into tm-qpr-dev am: f6b782344c am: 094c12fcfc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19271435

Change-Id: I842c21106e9039e1af2be4e9a387341fa0360b07
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-02 05:48:53 +00:00
Mateusz Cicheński f6b782344c Merge "Replace shelf height with keep clear areas registration in Launcher." into tm-qpr-dev 2022-09-02 05:19:13 +00:00
Jeremy Sim b33471a21f Fix bug with Launcher animation canceling, esp. around OverviewSplitSelect
This commit fixes a bug where the user could cancel animations when transitioning between Launcher states, potentially resulting in a state where Overview elements (task thumbnails etc.) were wrongly hidden or invisible.

The bug occurred because functions such as createInitialSplitSelectAnimation() and createAtomicAnimation() did not carry out any cleanup upon animation failure. This resulted in RecentsView potentially being in a polluted state for the next launch.

Bug was fixed by adding cleanup routines to two onAnimationEnd listeners.

Fixes: 242715097
Test: Manual
Change-Id: I05415ecf515e247aa535e3ca8371e540c3189b01
2022-09-01 20:51:53 -07:00
Hyunyoung Song 6464249302 Merge "Update container for ItemInfo." into tm-qpr-dev am: c9be6ca870 am: 04e4550c3c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19683198

Change-Id: Ia80d2af49bb8f311b987b5da60d8f5ba00143240
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-02 00:46:55 +00:00
Hyunyoung Song c9be6ca870 Merge "Update container for ItemInfo." into tm-qpr-dev 2022-09-01 23:38:36 +00:00
Sukesh Ram 82da9fc5be Made getOnBoardingPrefs @Nullable & avoid NPE
Bug: 236679197
Test: Manual
Change-Id: I3cbb0891cbfcf7cab956a4e05a28dbbcc2b33e19
(cherry picked from commit c0650e7725)
2022-09-01 22:20:35 +00:00
Evan Rosky 6daf573a85 Merge "Only animate to hotseat when launcher is on home screen" into tm-qpr-dev am: eaaf065b73 am: 9d95abe6b0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19775938

Change-Id: I56505b93a08e44495512067ed682fb0e8aab57b4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-01 22:07:28 +00:00
Evan Rosky eaaf065b73 Merge "Only animate to hotseat when launcher is on home screen" into tm-qpr-dev 2022-09-01 21:11:01 +00:00
Alex Chau 3193522616 Change wallpaper depth value in AllApps bottomsheet
- Cap AllApps wallpaper zoom to workspaceContentScale rather than all the way to max depth (config_wallpaperMaxScale)
- Changed both workspace scale and depth interpolator to correlate with AllApps threshold

Bug: 240580498
Test: manual
Change-Id: I0342a37c72206268dcffc5697a212704a41b020f
2022-09-01 21:26:30 +01:00
Hyunyoung Song a0de27c120 Merge "Fix blurry wallpaper when user locks on all apps surface" into tm-qpr-dev am: 0397cb0ce7 am: b8be0b7594
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19806634

Change-Id: I2aa6182f90da775239ad1c27ab518614386bb759
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-01 19:57:06 +00:00
Holly Sun 03caf49826 Update container for ItemInfo.
See https://docs.google.com/document/d/1eAxQ9p263FI8-ZdkOsiQoarhpwm9aOdncqfJUD42o1Q/edit?resourcekey=0-GJyyDut-Tfy29akzHyoz0Q for the debugging process.
Test: see video https://drive.google.com/file/d/1qpD7070v0qOaBEuYS0WoZauawyhL54MQ/view
Fix: 234848972

Change-Id: I2ed5d24d11ab2081c6faa5d040d72a9d1646e5ca
2022-09-01 12:10:31 -07:00
Hyunyoung Song 0397cb0ce7 Merge "Fix blurry wallpaper when user locks on all apps surface" into tm-qpr-dev 2022-09-01 15:50:39 +00:00
Pat Manning ee1caf18c6 Merge "Undim kids nav icons on a11y focus and click." into tm-qpr-dev am: e51e6446ad am: ff3accd144
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19659547

Change-Id: Ie1d9cf06bf012a9ae596ff1e7cc1240ae50b7e90
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-01 14:46:18 +00:00
Pat Manning d8d75c104d Merge "Update grouped task view thumbnail splash interpolation to match regular task." into tm-qpr-dev am: a3ebbbeba5 am: 0934cb2770
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19803194

Change-Id: Iab0a378396176f019bd42d700ef36dce13c1a16a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-01 14:45:51 +00:00
Pat Manning e51e6446ad Merge "Undim kids nav icons on a11y focus and click." into tm-qpr-dev 2022-09-01 14:01:57 +00:00
Pat Manning a3ebbbeba5 Merge "Update grouped task view thumbnail splash interpolation to match regular task." into tm-qpr-dev 2022-09-01 13:30:33 +00:00
Pat Manning 401f6bb0d4 Undim kids nav icons on a11y focus and click.
Fix: 241298057
Test: manual
Change-Id: I9a330bde4641a01b4d19dc83c8f25f56a69328c8
2022-09-01 12:42:04 +01:00
hyunyoungs 91ca748819 Fix blurry wallpaper when user locks on all apps surface
Bug: 242746421
Test: manual

TL;DR;;
setState toState= NORMAL called when locking screen on ALLAPPS screen
but mSurface==null
hence depth is not reset to NORMAL state

Change-Id: I26a37f7de8b0ecd481b36eebf07e1b79f8b0035c
2022-08-31 22:05:45 -07:00
Tony Wickham 2be2312543 Merge changes Ie55bd70e,I69bcfa97,I222522bc into tm-qpr-dev am: d833fe4a12 am: 94894d8d88
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19472817

Change-Id: Ib419b6f6fad396917f5b477e5c20ca5bd425a165
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-01 01:43:50 +00:00
Tony Wickham d833fe4a12 Merge changes Ie55bd70e,I69bcfa97,I222522bc into tm-qpr-dev
* changes:
  Fix taskbar stash state not persisting properly across recreate
  Add support to Tapl to recreateTaskbar
  Don't rely on QuickstepLauncher instance for tests
2022-09-01 00:52:54 +00:00
Evan Rosky 10c1c017c9 Only animate to hotseat when launcher is on home screen
Was assuming that resume == home-screen; however, in shell
transitions, launcher is resumed while overview is active,
so make sure it is both resumed AND "isTaskbarAligned"
before making the to-hotseat animation

Bug: 241800590
Test: Open an app, long-press taskbar to stash, long-press again
      to unstash
Change-Id: I117afcb006c363e50205f27f014ffc30d6f2896a
2022-08-31 22:53:02 +00:00
Pat Manning 038e112e9d Update grouped task view thumbnail splash interpolation to match regular task.
Follow-up to ag/19730966

Fix: 244433374
Test: follow up after b/238405972
Change-Id: I5c3c05dd51234b568e8f99c075e0f3384bca4741
2022-08-31 18:10:11 +01:00
Brian Isganitis 1e2fde5232 Merge "Snap to last task if swiping down at a greater Y than X velocity." into tm-qpr-dev am: 5166c5da3f am: b28748f662
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19290025

Change-Id: I32fdcd76559f05ecd0f6d890f49f62ea532bccae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-31 03:16:14 +00:00
Brian Isganitis 5166c5da3f Merge "Snap to last task if swiping down at a greater Y than X velocity." into tm-qpr-dev 2022-08-31 02:14:38 +00:00
TreeHugger Robot bcbba897fc Merge "Add app predictions to secondary display app drawer & fix tab UI." into tm-qpr-dev 2022-08-31 00:01:21 +00:00
Schneider Victor-tulias 7ba044f10b Merge "Add gesture nav error state tracking and logging" into tm-qpr-dev am: ff5ad47a06 am: 520bf2e892
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19300928

Change-Id: I7830f925e70d89f84fce7da317403e03dacbb419
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-30 23:55:39 +00:00
Schneider Victor-tulias ff5ad47a06 Merge "Add gesture nav error state tracking and logging" into tm-qpr-dev 2022-08-30 22:42:46 +00:00
Sukesh Ram 1b4869fcbc Add app predictions to secondary display app drawer & fix tab UI.
Bug: 233926067
Test: Manual
Change-Id: I2f45a4b30964b365bf149e8864a3af2ea909a237
(cherry picked from commit 9e5fe63a22)
Merged-In: I2f45a4b30964b365bf149e8864a3af2ea909a237
2022-08-30 22:30:03 +00:00
Brian Isganitis 14aa82a02a Merge "Simplify calculateEndTarget logic." into tm-qpr-dev am: 168482688a am: f898db348a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19283295

Change-Id: Id8c0372759306567ed50b2d3e33cdbb060c7f65d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-30 21:13:38 +00:00
Brian Isganitis c043d45c42 Snap to last task if swiping down at a greater Y than X velocity.
If you swipe down slightly diagonally, it will almost always be treated as a swipe to the next task rather than a return to the current task. If we are swiping down and the Y velocity is grater, we should snap to the current task instead.

Test: Manually in fully gestural mode.
Bug: 222117127
Change-Id: I8c3cd483f7ceefe0de1e24b6e98918b12428ed10
2022-08-30 20:59:40 +00:00
Tony Wickham e74569e935 Fix taskbar stash state not persisting properly across recreate
Because we check supportsVisualStashing() in
TaskbarStashController#init(), we need to avoid using
TaskbarUIController to provide that value since TaskbarUIController
isn't initialized until a bit later than the other controllers. So I
moved the logic from supportsVisualStashing() back to
TaskbarStashController, but still allow TaskbarUIController to override
it (e.g. for DesktopTaskbarUIController).

After that fix, I noticed that force stopping launcher (to test the fix)
would briefly show the taskbar background before resetting the stashed
state. This is also due to LauncherTaskbarUIController not being ready
immediately, since that's what sets FLAG_IN_APP due to launcher being
paused. To work around this, I set FLAG_IN_APP to true by default in
TaskbarStashController#init(), since that is the most common case, and
taskbar background/stashed handle isn't shown on home anyway.

Test: Force stop launcher while taskbar is stashed, verify it recreates
as stashed without background flicker; same when changing wallpaper
color on home or in app; also tested when taskbar isn't stashed and in 3
button mode for good measure
Test: testHideTaskbarPersistsOnRecreate
Fixes: 235986838

Change-Id: Ie55bd70e8288d5ad7433dde970f18c176831d747
2022-08-30 13:42:04 -07:00
Tony Wickham c8e824dbdb Add support to Tapl to recreateTaskbar
Also moved references of "tasbkar_view" to share TASKBAR_RES_ID constant

Test: compiles; see follow up CLs
Bug: 235986838
Change-Id: I69bcfa975550e567f3daa35af8a810546297d79c
2022-08-30 13:40:45 -07:00