Commit Graph

10638 Commits

Author SHA1 Message Date
Jerry Chang bc2fbc78e3 Merge "Fix divider bar won't fade-in as the other splitting tasks" into tm-dev am: 59939e9e94 am: d49286cc28
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17935107

Change-Id: I9723a3669b746b8fc79eeddad63cf0199f054c17
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-27 19:03:42 +00:00
Jerry Chang d49286cc28 Merge "Fix divider bar won't fade-in as the other splitting tasks" into tm-dev am: 59939e9e94
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17935107

Change-Id: I41284058237af64b5d08cf98af125b59ed8fac84
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-27 03:49:17 +00:00
Jerry Chang 59939e9e94 Merge "Fix divider bar won't fade-in as the other splitting tasks" into tm-dev 2022-04-27 03:02:57 +00:00
Tracy Zhou 4622349c69 Merge "Add originalView of the menu to SystemShortcut" into tm-dev am: 7183e4b460 am: dbb368b40f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17677218

Change-Id: I7d029e2545795697f30dcb064139d48cc525b6ba
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-26 18:24:49 +00:00
Tracy Zhou dbb368b40f Merge "Add originalView of the menu to SystemShortcut" into tm-dev am: 7183e4b460
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17677218

Change-Id: Ie84f32d3946dccb7a65863b0e3bc42d3679d6593
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-26 17:52:28 +00:00
Tracy Zhou 7183e4b460 Merge "Add originalView of the menu to SystemShortcut" into tm-dev 2022-04-26 17:28:40 +00:00
TreeHugger Robot cea10a4fb4 Merge "Refactors Search results into separate RV for Toast." into tm-dev am: 0a6e9b4751 am: eb4fa04985
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17699868

Change-Id: I76d64e3b7cd443423b3bbe291e82717c4f4d2ffa
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-26 16:11:14 +00:00
TreeHugger Robot eb4fa04985 Merge "Refactors Search results into separate RV for Toast." into tm-dev am: 0a6e9b4751
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17699868

Change-Id: Ibdf49c7fd6e0f485445c3e4cbfd9abbb214a6539
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-26 15:35:50 +00:00
Jerry Chang c3865b86e4 Fix divider bar won't fade-in as the other splitting tasks
Bug: 226271407
Test: manual check the divider bar fade-in animation after launchTasks
Change-Id: I5ea7c6ea5ac3f3550b28e9c0f854e70edcfc97b0
2022-04-25 15:41:28 +00:00
Andy Wickham 6729f0b950 Refactors Search results into separate RV for Toast.
This will help enable transitions between A-Z apps lists and
search results because both can be seen simultaneously and
manipulated independently.

Some high level items of the refactor:
 - SearchRecyclerView is added; logic that populated the main
   (personal) tab with search results was simply redirected to
   this RV instead.
 - BaseAllAppsContainerView added isSearching() method. Returns
   false, and ActivityAllAppsContainerView overrides (as search
   is handled there).
 - Renamed BaseRecyclerView to FastScrollRecyclerView to better
   describe what it does. SearchRecyclerView extends this, but
   returns false for supportsFastScrolling().
 - AlphabeticalAppsList#mAllAppsStore is now optional, so the
   Search RV doesn't need to store/listen to apps. Note this
   doesn't affect the predicted app row which is still updated
   if one of the predicted apps is uninstalled (I tested this).

Future work:
 - Determine why dispatchRestoreInstanceState is not called for
   BaseAllAppsContainerView. Save is called, e.g. on rotation.
   Effect of restore not called: rotating while searching goes
   back to A-Z list.
 - Keep suggested apps in Header while searching. Currently they
   are rendered in the SearchRV above search results, as before.
 - Potentially extract Personal/Work tabs to move independently of
   header.
 - AlphabeticalAppsList is a misleading name because it can also
   contains search results. However, things are pretty intertwined
   between that and BaseAllAppsAdapter (effectively a circular
   dependency), so I figured cleaning all that up was out of the
   immediate scope of this refactor, which is mainly meant to
   unblock transition work.

Bug: 206905515
Test: Manually checked for regressions, ran tests.
Change-Id: I4d3757c8a8f9b774956ca6be541dd4fcdad1de13
2022-04-24 17:36:48 -07:00
TreeHugger Robot 418bcb0979 Merge "Provide more accurate feedback on nav bar region gestures during the back gesture tutorial." into tm-dev am: 1582aafbc0 am: ea1c7379d0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17921423

Change-Id: I18d80825ce6d1392080592ded2b86228adb7ec9e
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-23 03:55:20 +00:00
TreeHugger Robot ea1c7379d0 Merge "Provide more accurate feedback on nav bar region gestures during the back gesture tutorial." into tm-dev am: 1582aafbc0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17921423

Change-Id: Ic36a100130d355753606e24cb27ebc4ed4c0dbb7
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-23 03:24:03 +00:00
Bill Yi 2baf5dc792 Merge "Import translations. DO NOT MERGE ANYWHERE" 2022-04-23 03:05:32 +00:00
TreeHugger Robot 1582aafbc0 Merge "Provide more accurate feedback on nav bar region gestures during the back gesture tutorial." into tm-dev 2022-04-23 02:51:20 +00:00
Tony Wickham 33474c4f7a Defer onIsStashedChanged() until all controllers are initialized am: aed0c4d73e am: a9359fc943
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17921731

Change-Id: I629c619a20e39c327fb20f788a02f610b7c8bbf3
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-23 01:47:01 +00:00
Tony Wickham a9359fc943 Defer onIsStashedChanged() until all controllers are initialized am: aed0c4d73e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17921731

Change-Id: I261e5476d977a0c3784a241f543812cc31ffdcd0
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-23 01:17:24 +00:00
Tony Wickham aed0c4d73e Defer onIsStashedChanged() until all controllers are initialized
Test: N/A
Fixes: 230133882
Change-Id: I27df993a08327d28669963e3cecfaa133daf11c9
2022-04-22 17:28:35 -07:00
Tony Wickham efdae030a6 Merge "Address a couple small followups for TaskbarInsetsController" into tm-dev am: 357c622572 am: b8bfa20d79
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17873349

Change-Id: I14e26af5f266999bbc7f7a3ad528f96fa652ebff
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 23:42:28 +00:00
Schneider Victor-tulias 04169cd3fc Provide more accurate feedback on nav bar region gestures during the back gesture tutorial.
Test: manual
Fixes: 221192860
Change-Id: Id9f912e7db2d89fc948566f5cd16f4b641cdfa31
2022-04-22 16:37:49 -07:00
Tony Wickham b8bfa20d79 Merge "Address a couple small followups for TaskbarInsetsController" into tm-dev am: 357c622572
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17873349

Change-Id: I738ec06f57015fd664944b87204e2f6919173f31
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 23:18:20 +00:00
Tony Wickham 357c622572 Merge "Address a couple small followups for TaskbarInsetsController" into tm-dev 2022-04-22 22:55:10 +00:00
Santiago Etchebehere e9f490374c Merge "Revert "Use new onStartSplitLegacy when starting split from overview"" into tm-dev am: 8340cb6d7d am: f52e543389
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17918609

Change-Id: I8e138883c1440327abb6e0e595a0b5e47e17d545
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 21:52:37 +00:00
Santiago Etchebehere f52e543389 Merge "Revert "Use new onStartSplitLegacy when starting split from overview"" into tm-dev am: 8340cb6d7d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17918609

Change-Id: I8745066261a7fa93870ba9b1860c39d112888420
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 21:27:38 +00:00
Sunny Goyal ba0a00eec9 Merge "Removing fade in logic during load." into tm-dev am: 84151d2bca am: 77d7797f83
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17768817

Change-Id: Icaa4a4a6863e43f6b499d0c21be0614e11b4381c
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 21:19:48 +00:00
Santiago Etchebehere 8340cb6d7d Merge "Revert "Use new onStartSplitLegacy when starting split from overview"" into tm-dev 2022-04-22 21:07:18 +00:00
Sunny Goyal 77d7797f83 Merge "Removing fade in logic during load." into tm-dev am: 84151d2bca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17768817

Change-Id: I19c237bf97f40a37f2f537ed165b802236a26b89
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 21:02:25 +00:00
Santiago Etchebehere b8ad6e08cf Revert "Use new onStartSplitLegacy when starting split from overview"
Revert submission 17779173-startSplitLegacy

Reason for revert: Broken build: b/230129218
Reverted Changes:
I01590e53c:Remove check for preventing re-parenting non-split...
I696749f76:Use new onStartSplitLegacy when starting split fro...

Change-Id: I6d81e0584bbfda3694772dcf293a4d064b2e8517
2022-04-22 21:02:22 +00:00
Sunny Goyal 84151d2bca Merge "Removing fade in logic during load." into tm-dev 2022-04-22 20:29:34 +00:00
Jeremy Sim d0b1258d27 Merge "Fix crash bug when splitting with animations disabled" into tm-dev am: 602b46c399 am: 8f00e9bc55
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17807433

Change-Id: I95cf7e35b7f7424d30e978214135476e86da12ff
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:24:24 +00:00
TreeHugger Robot 936a3e1239 Merge "Use new onStartSplitLegacy when starting split from overview" into tm-dev am: 8aead5503f am: 1a3002207b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17779173

Change-Id: I9d130eb8e5d070dfd2f5f3fe6e94978eb0fbf8f3
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:23:43 +00:00
Tony Wickham ae15c42ce6 Merge "Migrate from InsetsInfo.contentInsets to WindowManager.LayoutParams#providedInternalInsets" into tm-dev am: 741e4aeb95 am: 8426275608
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17778392

Change-Id: I90101494f32fa6b15b5085b75a78fb80bc8d3cfc
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:22:09 +00:00
Jeremy Sim 8f00e9bc55 Merge "Fix crash bug when splitting with animations disabled" into tm-dev am: 602b46c399
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17807433

Change-Id: I74d9711a7e60d2ecfa61565e67060c6b9c9aa6b0
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:09:35 +00:00
TreeHugger Robot 1a3002207b Merge "Use new onStartSplitLegacy when starting split from overview" into tm-dev am: 8aead5503f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17779173

Change-Id: I6ed16e6d0a59e4804eaa30b1c7849150a6fcd6bb
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:09:17 +00:00
Jeremy Sim 602b46c399 Merge "Fix crash bug when splitting with animations disabled" into tm-dev 2022-04-22 20:05:09 +00:00
TreeHugger Robot 8aead5503f Merge "Use new onStartSplitLegacy when starting split from overview" into tm-dev 2022-04-22 20:03:36 +00:00
Tony Wickham 8426275608 Merge "Migrate from InsetsInfo.contentInsets to WindowManager.LayoutParams#providedInternalInsets" into tm-dev am: 741e4aeb95
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17778392

Change-Id: I37bc83970d5dd6b1c1d59cfd95079826d5c2400f
Ignore-AOSP-First: this is an automerge
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 20:01:47 +00:00
Jeremy Sim 42276318b9 Fix crash bug when splitting with animations disabled
Fixes a bug where disabling animations (through Settings) would cause split staging to crash.

The crash occurs because when animations are disabled, StateManager advances to OVERVIEW_SPLIT_SELECT too quickly, and does not trigger the appropriate code block in RecentsViewStateController#handleSplitSelectionState(). This causes a crash.

Fixed by changing the conditional so that it always runs when OVERVIEW_SPLIT_SELECT is the target state, no matter the starting state.

Note: If more animations are added for this state in the future, the conditional may need to be tweaked further.

Fixes: 223598955
Test: Confirmed not crashing on 2 devices when splitting in a variety of ways.
Change-Id: I7f3def88f124fa1babe9a943adf72c10f58b7131
2022-04-22 19:58:40 +00:00
Tony Wickham 741e4aeb95 Merge "Migrate from InsetsInfo.contentInsets to WindowManager.LayoutParams#providedInternalInsets" into tm-dev 2022-04-22 19:55:31 +00:00
TreeHugger Robot da0d7d3fcc Merge "Reset touch state when removing all tasks in RecentsView.applyLoadPlan" into tm-dev am: 37fa1392ec am: e03e7e1f5f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17586926

Change-Id: I44be923da02284b6edf86e2b1f3d539ccd6a6c15
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 18:20:07 +00:00
Alex Chau d5620750fc Update pull back animation for tablet AllApps am: e3b806366a am: 24771d2ef7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17757987

Change-Id: If13ee7fdfaced3a40e45be7e817e03bbcc911413
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 18:18:37 +00:00
TreeHugger Robot e03e7e1f5f Merge "Reset touch state when removing all tasks in RecentsView.applyLoadPlan" into tm-dev am: 37fa1392ec
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17586926

Change-Id: I182643138fa930f634d313a426725a8603487360
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 17:52:52 +00:00
Alex Chau 24771d2ef7 Update pull back animation for tablet AllApps am: e3b806366a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17757987

Change-Id: I82187136a89e794aff6719d2623926f2aa3f159a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 17:52:30 +00:00
TreeHugger Robot 37fa1392ec Merge "Reset touch state when removing all tasks in RecentsView.applyLoadPlan" into tm-dev 2022-04-22 17:33:06 +00:00
Sunny Goyal 7b8d63fcf8 Removing fade in logic during load.
Launcher already blocks the draw during load, which ensures
that system draws the loading screen. Additional fade animation
is not visible since the Launcher window is already getting fade in

Bug: 199120420
Bug: 199120420
Test: Verified on device

Change-Id: I7089cea4c5f97f6ef92eabcba56451de407c98b8
2022-04-22 16:35:40 +00:00
Alex Chau e3b806366a Update pull back animation for tablet AllApps
- This is a follow-up of http://ag/17636490
- Introduced animation property specifically for pullback translation and alpha, which will invoke getRecyclerViewContainer directly on tablet, and invoke aggregate setter of appsView on phones
- Delay reset of pullback animation to after dismiss animation to avoid jump in value during state transition animation
- Introduced property factory for addictive properties similar to MultiScalePropertyFactory

Fix: 220345008
Test: manual on small and large screen
Change-Id: I7b5c0019c1d4d36c3c7ca4ec79e38e4eb09c32ca
2022-04-22 16:27:25 +01:00
TreeHugger Robot 71a63918c6 Merge "Snap to last task if swiping down at a greater Y than X velocity." into tm-dev am: df436c364c am: dc06e3be5e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17891361

Change-Id: I49cffc67fb9b7ae6b2cbcd40840f0b4109614c01
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 04:15:13 +00:00
TreeHugger Robot dc06e3be5e Merge "Snap to last task if swiping down at a greater Y than X velocity." into tm-dev am: df436c364c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17891361

Change-Id: I1de502b9faaa12f98a2e1838216afe61295730d4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-22 03:28:10 +00:00
Brian Isganitis e10ab8cdcd Snap to last task if swiping down at a greater Y than X velocity.
If you swipe down slightly diagonally, it will almost always be treated as a swipe to the next task rather than a return to the current task. If we are swiping down and the Y velocity is grater, we should snap to the current task instead.

Test: Manually in fully gestural mode.
Bug: 222117127
Change-Id: I0f591fa5117291a9c095c2b733280464d29103d9
2022-04-21 22:50:39 +00:00
Vinit Nayak dd7e132db5 Use new onStartSplitLegacy when starting split from overview
Bug: 223396876
Change-Id: I696749f7674a09b2a12c6ef2c2b7d19d0884049a
2022-04-21 11:51:24 -07:00
TreeHugger Robot 6a75aaee52 Merge "Fixing potential NullPointer exceptions when Launcher is created before TouchInteractionService is initialized" into tm-dev am: d880a4fa63 am: b12c1b938d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/17805037

Change-Id: Ibd1567306b78855ce80602be657b623598048681
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-21 18:39:56 +00:00