Commit Graph

3454 Commits

Author SHA1 Message Date
TreeHugger Robot cb6dff62d9 Merge changes I6ce23251,I56fca1b7 into sc-dev
* changes:
  Update the resize frame to use the forced radius.
  Enforce rounded corners on App Widgets.
2021-03-24 00:39:17 +00:00
TreeHugger Robot acb3cac938 Merge "Update Pin widget dialog UI according to mocks." into sc-dev 2021-03-24 00:29:41 +00:00
Jonathan Miranda 0fa5225d57 Merge "Updating deep shortcut container to new width." into sc-dev 2021-03-23 21:30:46 +00:00
Pierre Barbier de Reuille 452df2d5bb Update the resize frame to use the forced radius.
When forcing the rounded corners, the radius may be smaller than the
default one. When this happens, we should change how the frame is drawn
to only use that reduced radius, or this looks weird.

Bug: 183097166
Test: Manual tests with top 1P App Widgets
Change-Id: I6ce232515ce14059e1168e16735719ea2370132c
2021-03-23 20:57:33 +00:00
Pierre Barbier de Reuille 298526e812 Enforce rounded corners on App Widgets.
The feature is controlled by the ENABLE_ENFORCED_ROUNDED_CORNERS flag
(currently set to false).

If does not yet handle P/H flags to control its behavior.

Bug: 183097166
Test: Manual tests with top 1P App Widgets (See bug for results)
Change-Id: I56fca1b717f37ad518588115409f2144a71d4b98
2021-03-23 20:57:33 +00:00
Tony Wickham 3629b93546 Merge "Add TaskbarView as a child of Hotseat" into sc-dev 2021-03-23 18:36:53 +00:00
Steven Ng d8c2a7b2da Merge "Update title of bottom widgets tray" into sc-dev 2021-03-23 17:19:01 +00:00
Jon Miranda e888b08b70 Updating deep shortcut container to new width.
Bug: 175329686
Test: manual, visual
Change-Id: I0487d240523ab3de4bf3e381ec359267eaa33a71
2021-03-23 12:00:38 -04:00
Alina Zaidi 6d97d893e0 Update Pin widget dialog UI according to mocks.
Test: Tested manually and RequestPinItemTest passed
Bug: 182982143
Bug: 182994819
Bug: 182929673
Change-Id: I905ea0c1860d28ee9fbb456ddf6abd728b65bac4
2021-03-23 13:36:48 +00:00
Jonathan Miranda b40025756a Merge "Account for children margins when orienting popup container." into sc-dev 2021-03-23 09:38:37 +00:00
Tony Wickham 9ce3b25ef6 Add TaskbarView as a child of Hotseat
Instead of keeping the Taskbar window showing above the home screen,
we now integrate a copy of TaskbarView directly into Launcher's view
hierarchy. Most TaskbarController calls apply to both TaskbarViews
(mTaskbarViewInApp and mTaskbarViewOnHome), except for calls related
to Hotseat, which only apply to mTasbkarViewInApp given the real
Hotseat will be showing with mTaskbarViewOnHome.

More cleanup will follow this change.

Test: All taskbar interactions (e.g. drag and drop) continue to work
Bug: 182512211
Bug: 171917176
Change-Id: I0f0b124f652daa85f866e1df8f9e2981540331a0
2021-03-22 15:26:01 -07:00
Steven Ng 867ff5f60c Update title of bottom widgets tray
Only use the "app name" instead of "app name widgets" as title
Remove "Touch & hold to move a widget" subtitle.

Test: manual

Bug: 179797520
Change-Id: I7a5954af73aa5b480096e93ade3520cef6c93f17
2021-03-22 22:23:46 +00:00
Steven Ng d14e76867b Merge "Exact common layout from widgets bottom sheet" into sc-dev 2021-03-22 22:23:06 +00:00
Steven Ng f45f875232 Merge "Fix corner radius for single item in the widgets tray." into sc-dev 2021-03-22 18:51:41 +00:00
Steven Ng e4c0e954d3 Exact common layout from widgets bottom sheet
Test: open widgets bottom sheet and drag and drop widgets & shortcuts.

Bug: 182305634
Change-Id: I82e3e584edf64177ffa6e677f5b3f487823d3e1b
2021-03-22 17:50:49 +00:00
Lucas Dupin 8b9365d4ad Merge "Apply new color scheme" into sc-dev 2021-03-22 16:57:18 +00:00
Steven Ng f4fb4d9429 Fix corner radius for single item in the widgets tray.
If there is only one item, corner radius at 4 corners should be 28dp.

Test: Corner radius of one item is correctly shown in the widgets
      picker.

Bug: 183382610
Change-Id: Ief46af8c41ce944792d08212e93f7d68c6278d05
2021-03-22 16:30:57 +00:00
Lucas Dupin 554a1bee39 Apply new color scheme
Bug: 173553055
Test: manual
Test: atest SystemPalette
Test: atest ThemeOverlayControllerTest
Test: atest DeviceDefaultThemeTest
Change-Id: Ie06160ed322ceac2e1078c24db287dd1f26a0a65
2021-03-20 11:00:13 -07:00
Steven Ng 682af23651 Merge "Renders widget recommendations" into sc-dev 2021-03-19 23:18:22 +00:00
Jon Miranda 116e94e0a7 Account for children margins when orienting popup container.
Instead of recalculating the orientation after adding margins,
we account for the margins in the initial calls to orientAboutObject.

This ensures consistent mIsAboveIcon throughout calls to show the popup.

- Also updates the smaller radius to match the middle items.

Bug: 175329686
Test: long press on item where height and height without margins would
      result in differing mIsAboveIcon values
      eg. the 3rd item in a folder in the top middle of 5x5 workspace

Change-Id: I6132b544a89c7948339d17f219ad75c797233f55
2021-03-19 18:30:03 -04:00
Steven Ng 4235fc129c Renders widget recommendations
Update the tapl test logic to scroll a smaller distance to avoid the
search bar blocking the target touch area.

Test: Open full widgets sheet and observe the widget recommendations
      shown at the top.
      Run AddConfigWidgetTest

Bug: 179797520

Change-Id: I6d53bbb46e2cb928ed7d015aaac604be17d33178
2021-03-19 21:11:32 +00:00
Jonathan Miranda 48a2f09349 Merge "Add separate background colors to each popup container child." into sc-dev 2021-03-19 20:34:10 +00:00
Steven Ng 1e29433fc6 Merge "A11y fix for all widgets tray (Part 1 / n)" into sc-dev 2021-03-19 17:44:59 +00:00
Jon Miranda 2a58d13b9b Add separate background colors to each popup container child.
- Colors interpolate between the primary and secondary popup colors
- Removed condensed height and icon scale

Bug: 175329686
Test: visual, manual checking apps with different shortcut options
Change-Id: I064c329dc8ad3ae6f408056c74372cca3ce20b68
2021-03-19 13:41:07 -04:00
Alina Zaidi 7358069a91 Merge "Fix bugs for Widgets picker Search UI." into sc-dev 2021-03-19 16:57:11 +00:00
Alina Zaidi c4f3f49805 Fix bugs for Widgets picker Search UI.
- On orientation change, clear search bar.
- Change text and search bar color to make similar to mocks/ all apps search bar.
- Fix search recycler view visual bugs.
- If back is pressed in search mode, exit search mode instead of exiting widget picker.

Test: Manually seen widget picker on phone.
Bug: 183103133
Bug: 183103936
Bug: 183115050
Bug: 157286785
Change-Id: I056f089eada84d00133038f4a3d7b18bc51be564
2021-03-19 14:42:47 +00:00
Jonathan Miranda b0cb399d21 Merge "Update deep shortcut to new ui." into sc-dev 2021-03-19 13:31:08 +00:00
Steven Ng 8eb1f73d58 A11y fix for all widgets tray (Part 1 / n)
Mark some image view unimportant for accessibility.
Still need to update the content description for widget list
header to describe the expand / collapse action.

Test: Navigate all widgets tray with talkback enabled.

Bug: 183120145
Change-Id: I1801d8351ac7f22a0135a96a36de706377781b31
2021-03-18 23:42:56 +00:00
Sunny Goyal fa699566f5 Merge "Adding an optional QSB in hotseat" into sc-dev 2021-03-18 16:07:45 +00:00
Samuel Fufa 74bd4f32e2 Merge "[Search] Update search input hint" into sc-dev 2021-03-18 16:03:20 +00:00
Alina Zaidi cc2c8a5cb1 Merge "Improvements to widget picker search." into sc-dev 2021-03-18 15:29:16 +00:00
Jon Miranda c79316740b Update deep shortcut to new ui.
- Removed divider views, using margin to separate views
- Removed elevations
- Added a ViewGroup to hold all notification views, and applied an outline

Bug: 175329686
Test: visual
Change-Id: Iad70dcfdaeba6050c2b17c07f76bb7bfb728e544
2021-03-18 11:09:34 -04:00
Alina Zaidi cb76e7d16f Improvements to widget picker search.
-Expand clickable area on search bar.

Test: Tested prototype locally.
Bug: b/157286785
Change-Id: I70a4edb1ce207f4dae9a0909c05e0823840500dd
2021-03-18 12:13:18 +00:00
Steven Ng 66ccd29a3d Adjust bottom picker padding / margin & add a drag handle
Test: Manual
Bug: 179797520
Change-Id: I594bf2cf140a31f20d41fbb9804197724478caf9
2021-03-18 12:09:45 +00:00
Alina Zaidi 378ca5e920 Merge "Bug fixes for widget picker search." into sc-dev 2021-03-18 10:32:18 +00:00
Steven Ng 99060b30ca Merge "Adjust font, color, margin, corners for all widgets tray" into sc-dev 2021-03-18 10:25:00 +00:00
Steven Ng 08ef694509 Adjust font, color, margin, corners for all widgets tray
Test: manually
Bug: 179797520
Change-Id: Ib78aae05e021da272ef2f754c876d24a4c14bcb0
2021-03-17 22:43:12 +00:00
Sunny Goyal c373e1c642 Adding an optional QSB in hotseat
Removing sections in all-apps during transition and treating
it as a single unit

Bug: 175137718
Test: Manual
Change-Id: I55a501d80b5903f1a9d92a26b3784784fd9e50fd
2021-03-17 12:21:44 -07:00
Alina Zaidi 2e732e95d9 Bug fixes for widget picker search.
SearchBarController
- Use Extended Edit Text to handle close keyboard action well.
- On press enter while search remove focus from bar and hide keyboard.
- On cancel button press hide keyboard and also reset search targets to empty so that on next search session the previous results dont flash (show for a short time before reflecting users query).

WidgetsFullSheet
- Make sure expanded header are reset when user leaves personal/work recycler views. Search recycler view resets its expanded header on every search already.
- Show 'no search results' view if no search result present.
- Update WidgetListBaseRowEntryComparator to show personal profile widgets first.

Test: Tested prototype locally.
Bug: b/157286785
Change-Id: Ibaa208c4091783e14ac0887caf559e867185df5a
2021-03-17 14:43:04 +00:00
Alex Chau 1e024358ad Merge "Two panel & two page swipe & currentPage fixes" into sc-dev 2021-03-17 13:47:01 +00:00
Andras Kloczl 8e57cce4ee Two panel & two page swipe & currentPage fixes
- Pagespacing set to 0 to have similar design to figma
- Added padding to left side of left panel and right side of right panel to match figma
- getPageScrolls changed to support two page scrolling
- validateNewPage changed so that only even indexed pages can be switched to
- getPageWidthSize added for measurements, it returns half screen width when two panel is active
- onMeasure changed to use getPageWidthSize
- panelCount has been increased from 1 to 2 when two panel is active
- add feature flag for two panel home
- shouldConsumeTouch changed so not only currentpage is checked but currentpage+1 screen as well
- add one more extra check for setDropLayoutForDragObject for currentpage + 2, next to right panel
- using new grid option for two panel home screen

Test: manual
Bug: 174464115
Change-Id: I1bad7eecc67f65fb833608744a5aa5aca65373b4
2021-03-17 12:19:02 +01:00
Yogisha Dixit 6d593d891e Merge "Fix bug with resize frame disappearing." into sc-dev 2021-03-17 10:27:33 +00:00
Samuel Fufa fa3316e8db [Search] Update search input hint
Bug: 182927397
Test: Manual
Change-Id: I6ea7e70d0ddf3672187bd1936bc46c841a2618fb
2021-03-16 18:53:49 -05:00
Yogisha Dixit f9954cc4cc Fix bug with resize frame disappearing.
Currently, if you resize the widget to the top, bottom or right, the
resize frame disappears. This is because the AppWidgetResizeFrame code
relies on the indices of the child elements to find the drag handles.

I updated the code to instead use IDs since that is more robust.

Test: manual
Bug: 182305670
Change-Id: Iaa9d32c9190fb579101914f03d57bb48dcecb88d
2021-03-16 21:31:46 +00:00
Alina Zaidi 1632752a72 Have an interface for WidgetsSearchBar so Nexus Launcher can override the search bar.
Test: Tested prototype locally.
Bug: b/157286785
Change-Id: I263063a451862755efe3d6e4a5a2eb69f2ea29b8
2021-03-16 09:25:22 +00:00
Vinit Nayak d987a828e8 Initial commit of new split screen work.
TODO:
* Extract out common elements in TaskShortcutFactory.MultiWindowFactory
for commonalities between new and old way of
invoking split screen
* Integrate with WM APIs (b/182002789)
* Write tests for SplitSelectStateController

Bug: 181704764

Change-Id: Ice35adb4ea82897f5e2433dc9b93a549f3d511b5
2021-03-15 15:42:32 -07:00
Alina Zaidi e17f4651d0 Merge changes from topic "SEARCH_INTEGRATE" into sc-dev
* changes:
  Add a WidgetsSearchBar(Launcher3) and a WidgetsSearchController.
  Have a recycler view to show search results.
2021-03-15 13:24:20 +00:00
Alina Zaidi d07acba048 Add a WidgetsSearchBar(Launcher3) and a WidgetsSearchController.
- Make WidgetsSearchBar in Launcher3 initialize WidgetsSearchController with SimpleWidgetsSearchPipeline
- Modify SimpleWidgetsSearchPipeline to filter widgets entries on widgets/shortcut labels also.

Test: Tested prototype locally. Also added robolectric test.
Bug: b/157286785
Change-Id: I65f5fa0240ffb6d22023167e4e86d94d83bbd9f7
2021-03-15 11:25:08 +00:00
Steven Ng 53d1364e8b Better estimate the height of widget recycler view
Test: Expand and collapse apps in the widgets picker. Then, observe
      the height of the fast scroller is correctly displayed.

Bug: 181629430
Change-Id: I9efcf902f8548fc5c8a398609758d43123228e5e
2021-03-12 22:58:45 +00:00
Sunny Goyal da2ecb3095 Merge "Adding support for listening for app launch animation completion" into sc-dev 2021-03-11 21:36:43 +00:00