Commit Graph

1254 Commits

Author SHA1 Message Date
Sunny Goyal 6b543872fb Merge "Removing unnecessary device sumaltion code" into tm-qpr-dev am: 08a13d6aae am: e2d73bf57d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22432108

Change-Id: I007c3bcd9a5d5dd8c986efc089420f73f7bad18f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-04 17:50:24 +00:00
TreeHugger Robot 0770b619ed Merge "Ensuring that badge override is respected even if component name is set on the Shortcut" into udc-dev 2023-04-04 00:40:14 +00:00
Sunny Goyal 076e04bcc2 Removing unnecessary device sumaltion code
Bug: 276774148
Test: Verified on device
Change-Id: Icb8c2e7649e5b0e107af184b63f7e30f2df717bd
2023-04-03 12:38:52 -07:00
Sunny Goyal 899bf30fe8 Ensuring that badge override is respected even if component name
is set on the Shortcut

Bug: 276319271
Test: atest IconCacheTest
Flag: N/A
Change-Id: I33802ecd23485ba092f842ec3c3d58e2fc286f92
2023-04-03 08:31:02 -07:00
vadimt 59cc1714ce Demoting WorkProfileTest#testEdu from presubmit due to high flakiness
Test: presubmit
Bug: 243688989
Change-Id: Ib477e9f749a6f7117008d65316f32080c719167c
2023-03-30 17:53:52 -07:00
vadimt a2918038fc Demoting WorkProfileTest#workTabExists from presubmit due to high flakiness
Test: presubmit
Bug: 243688989
Change-Id: I2edbd94a79d8f66e006ce0087bf4ab617e6ba041
2023-03-30 10:45:01 -07:00
Schneider Victor-tulias f8f602d76c Merge "Fix TwoPanelWorkspaceTests" into tm-qpr-dev am: 90259a6db4 am: d8e5795131
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22185922

Change-Id: Ic5d6ce2a870f19c960baab3af8abfb1faee248f1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-30 17:16:22 +00:00
Vinit Nayak e6d86e20aa Consolidate WorkProfileTest "@After" methods
* There were two separate methods, which can run in
any order. Consolidate to reduce variability

Bug: 243688989
Change-Id: Ic924aa8a5d75505aecf6c830c63a85a0d2028d83
2023-03-29 18:21:45 +00:00
Schneider Victor-tulias 7cd0ae3f73 Fix TwoPanelWorkspaceTests
- Marking the hotseat long press edu as seen on setup to allow the popup menu to be shown immediately in tests
- Recording onWorkspaceItemLongClick on prediction item long click

Flag: not needed
Fixes: 273239675
Test: TwoPanelWorkspaceTest
Change-Id: I76354fd2e3adde11b2a428374fa9c8855ce2ece9
2023-03-27 14:24:35 -07:00
Hyunyoung Song 42dcf69c2f Merge "Icon should not disappear on drag and drop" into tm-qpr-dev am: 7eae6a4ce1 am: 739dcca38a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22255567

Change-Id: I64f193bd8d5d7a47cc686f1e4759161d6ad6f5e7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-26 08:24:39 +00:00
Hyunyoung Song 7eae6a4ce1 Merge "Icon should not disappear on drag and drop" into tm-qpr-dev 2023-03-26 07:22:55 +00:00
Jon Miranda a97dc04478 Merge "Add taskbarIconSize to GridOption/DisplayOptions" into tm-qpr-dev am: 085c53869f am: 3cd39729dc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22228076

Change-Id: I3cb2d462cef1df514c87418ed70ac624899c21fd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 23:02:51 +00:00
hyunyoungs 825480fbcc Icon should not disappear on drag and drop
Bug: 275009677
Test: BubbleTextViewTest

Change-Id: Iddff7a0130c9a0ddb76223064338459dbe9b52e8
2023-03-24 15:16:20 -07:00
Jon Miranda 085c53869f Merge "Add taskbarIconSize to GridOption/DisplayOptions" into tm-qpr-dev 2023-03-24 21:51:42 +00:00
Jon Miranda 9c478b6c29 Add taskbarIconSize to GridOption/DisplayOptions
- Renamed variables to make it more clear what they represent
- DeviceProfile will be source of truth for taskbar
  sizes

Bug: 265144213
Test: phone, multi-display, tablet
Change-Id: Id9c19d15a65894fd7645e0f876a4b6527b713c34
Flag: ENABLE_TRANSIENT_TASKBAR=true
2023-03-24 12:29:11 -07:00
Vinit Nayak 8bdea9da7f Merge "Log receiving broadcast for managed user unlocked" into tm-qpr-dev am: 4ed9562b37 am: cbc884e191
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22238827

Change-Id: Ic751581c09fd82949f78e8cd58baaaf2424ff124
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 19:25:24 +00:00
Vinit Nayak 4ed9562b37 Merge "Log receiving broadcast for managed user unlocked" into tm-qpr-dev 2023-03-24 18:25:51 +00:00
Vinit Nayak d3925b662d Log receiving broadcast for managed user unlocked
Bug: 243688989
Change-Id: I6f1b575a90e51ad1674154f60199ffef5004a224
2023-03-23 15:38:19 -07:00
Stefan Andonian 1e45b3b949 Merge "Stop enabling the Boot Aware Launcher prefs code during Tests after running LauncherPref unit tests." into tm-qpr-dev am: acaecb6511 am: e78b57101d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22163308

Change-Id: I93ba6cface532a19e7e73dc35125289e77f6cffd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-22 18:44:07 +00:00
Stefan Andonian acaecb6511 Merge "Stop enabling the Boot Aware Launcher prefs code during Tests after running LauncherPref unit tests." into tm-qpr-dev 2023-03-22 17:17:57 +00:00
Sebastián Franco 2a40823a78 Merge "Fixing test that fail when FOLDABLE_SINGLE_PAGE is set to true" into udc-dev 2023-03-21 22:32:42 +00:00
Federico Baron c3ab820144 Add test for widget picker on landscape mode for tablets
When we added widget picker two pane layout, it broke some tests with the flag on. Here we fix those tests.
Bug: 256684299
Test: AddWidgetsTest and TaplTestsLauncher3#testWidget

Change-Id: I383c754016d82fba51fa0b7b0459cd7e83b274d8
2023-03-21 16:48:12 +00:00
Sunny Goyal 717072d1d5 Merge "Scale folder if it doesn't fit the screen" into tm-qpr-dev am: d2a34a2d54 am: 92e392d55b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22139063

Change-Id: I5df3d13170ae2125f9113f0c3cd41d9c47b093a3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-20 21:13:42 +00:00
Stefan Andonian 956b88e561 Stop enabling the Boot Aware Launcher prefs code during Tests after
running LauncherPref unit tests.

There is something in the LauncherPrefs code that interacts with the
boot aware shared preference data that is not compatible with the
Widgets.Reorder tests. A todo has been added to fix that before
releasing that feature. For now, implementing a simple fix to stop
enabling this feature for while doing post submit testing.

Bug: 271434610
Test: Used go/abdt to verify that this CL fixes the post submit tests.
They no longer fail like they did before this was pushed.

Change-Id: Id6bd94f5d0e0ee9afc2ccea3a4808cf723a4e688
2023-03-20 20:59:50 +00:00
Sunny Goyal d2a34a2d54 Merge "Scale folder if it doesn't fit the screen" into tm-qpr-dev 2023-03-20 20:01:52 +00:00
Sebastian Franco 25423867af Fixing test that fail when FOLDABLE_SINGLE_PAGE is set to true
We need to change the result of REQUEST_IS_TWO_PANELS when the
flag is on because now we don't have two panels only 1.

Another of the issues is a rounding error when calling
getUnusedHorizontalSpace().

And lastly updating workspaceToBoards so that it maps the coordinate
of workspace items to their right position.

Bug: 270395274
Test: atest ReorderWidgets
Change-Id: I2620e5bf1ba132f984e00d2a6c21081953d259fd
2023-03-20 17:06:20 +00:00
Thales Lima 7eee74b3f8 Scale folder if it doesn't fit the screen
Scale folder attrs if a full folder doesn't fit the screen width. This will make icons and text smaller than the workspace.

As a follow-up, another bug will be created to only scale full folders instead of all folders.

Bug: 271554689
Test: manually create a full folder, change the display size to large+
Change-Id: I47dc4bd4fe0c9eae989095fc1d179b81d350ef77
2023-03-17 14:13:04 -03:00
Vinit Nayak 8ec9348b47 Merge "Add debug logs for WorkTabExists test" into tm-qpr-dev am: 51a864893b am: e1a0fab43d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21550343

Change-Id: I49f743b9fff0d2c58f4a6fdd1d58e91fc7c56406
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-15 00:25:39 +00:00
Vinit Nayak 51a864893b Merge "Add debug logs for WorkTabExists test" into tm-qpr-dev 2023-03-14 22:46:07 +00:00
Andrew Cole ce0c9d4a12 Merge "Asking the test to wait for launcher to commit the uninstall transaction before opening all apps." into tm-qpr-dev am: f905365e5a am: ff70e24a50
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21961037

Change-Id: I52bf2e754f24cf086f1d0281dbfbc2cd5232a9ed
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-13 22:03:37 +00:00
Vinit Nayak 7a68378fe4 Add debug logs for WorkTabExists test
Bug: 243688989
Change-Id: Iafec4cae86f1527acac9a25fceb501609ca308f6
2023-03-13 14:27:55 -07:00
Andrew Cole f905365e5a Merge "Asking the test to wait for launcher to commit the uninstall transaction before opening all apps." into tm-qpr-dev 2023-03-13 20:51:38 +00:00
Andrew Cole 66e5c91380 Asking the test to wait for launcher to commit the uninstall transaction before opening all apps.
Bug: 258071914
Test: Run testUnintallFromAllApps
Change-Id: Iceba2650e24b06c162f42767955fa6ae3e3b19c8
2023-03-13 09:58:26 -07:00
Brandon Dayauon 06f2134aa6 Merge "Clean up bubble text view test so that the feature flag is off at the end" into tm-qpr-dev am: c5677f824f am: 888291b866
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21964113

Change-Id: I7f355aad8e562c1f43ac8acdf8f524a999344863
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-11 03:19:29 +00:00
Brandon Dayauon c5677f824f Merge "Clean up bubble text view test so that the feature flag is off at the end" into tm-qpr-dev 2023-03-11 01:48:38 +00:00
Brandon Dayauon 7d10db66de Clean up bubble text view test so that the feature flag is off at the end
- When running the test with feature flag is on, the TestLauncherApp is unable to be found when rerunning the failed TaplTests the bug states. I suspect this because the BubbleTextViewTest.java test is not properly torn down in the test environment which seems to be the case.

bug: 272798314
bug: 272797678
test: locally - able to repro when two line is on
Change-Id: I7379a5411de70f24804b404dbe5c7cf7f6769977
2023-03-10 15:51:28 -08:00
Sebastián Franco fef518da3d Merge "Making sure there is a propper Chrome icon for the test to long press" into tm-qpr-dev am: 4122868216 am: b8614e298c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21778872

Change-Id: I124c235e0dcdeab04b3fe2eb40083118778b9fa2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-10 20:32:00 +00:00
Sebastián Franco 4122868216 Merge "Making sure there is a propper Chrome icon for the test to long press" into tm-qpr-dev 2023-03-10 19:19:42 +00:00
Brandon Dayauon 061cf0d4e9 Merge "Support two line text in AllApps/OnDeviceSearch w/ feature flag" into tm-qpr-dev am: 5ddc6ab4da am: e0bddb5b42
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20898210

Change-Id: I097b55e72e2c07d75a45ff044f581b1f5d30af6c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-10 18:34:30 +00:00
Brandon Dayauon cf88ea1e62 Support two line text in AllApps/OnDeviceSearch w/ feature flag
Made separate feature flag for on device search
Add unit test to test twoLine string
- Unit tests for testing newStringThatShouldSupportTwoLineText() in BubbleTextView.java. This class tests a couple of strings
and uses the getLineCount() to determine if the test passes. Verifying with getLineCount() is sufficient since BubbleTextView can only be in one line or two lines,
and this is enough to ensure whether the string should be specifically wrapped onto the second line and to ensure truncation.

bug: 201388851
test: presubmit, ran locally on big and small device, before: https://screenshot.googleplex.com/3Q6pwveFDZqxDXL (ORIGINAL TWO LINE TEXT)
after:  https://screenshot.googleplex.com/7pkwUto6HGzMYoT

Change-Id: I93e6ed179e1081d5cdffc6db9c7ae34de8021c24
2023-03-09 15:13:04 -08:00
Sebastian Franco 239ae0a995 Making sure there is a propper Chrome icon for the test to long press
In some cases, the test was long pressing on a recommendation for
google chrome and not a regular chrome icon and the events didn't
match. I don't think is good to relly on chrome getting recommended
so I'm making sure there is always a chrome app icon on the hotseat

Fix: 269163620
Test: atest TaplTestsLauncher3:testWorkspace (run on pixel 7 pro)
Change-Id: Ic8ee744a9af18d60de9bbedd42043f5abbbd7356
2023-03-09 14:59:21 -08:00
Schneider Victor-tulias 07f324cd9f Merge "Fix flaky RequestPinItemTests" into tm-qpr-dev am: bd98aef4a4 am: f15fc66db2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21733879

Change-Id: Ied4aba061cee7b58a6cc524e2dbf4960839c5211
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-08 00:27:12 +00:00
Schneider Victor-tulias bd98aef4a4 Merge "Fix flaky RequestPinItemTests" into tm-qpr-dev 2023-03-07 23:36:10 +00:00
Brandon Dayauon a679877d2c Merge "Add logging to testDragAppIconToWorkspaceCell()" into tm-qpr-dev am: 9de1c05cbf am: 6a1f4f0ddb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21532182

Change-Id: I8e07781f484c049dd51982c21ec9e66fe1f0cc5b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-07 21:30:09 +00:00
Sihua Ma c6996dd5ef Merge "Update widget picker row logic to resolve cropping" into tm-qpr-dev am: a245873fed am: 8fa10370ef
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20696781

Change-Id: I67453fe97d423d2548e6eb160352a6bf8dea0d75
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-07 21:28:59 +00:00
Brandon Dayauon 9de1c05cbf Merge "Add logging to testDragAppIconToWorkspaceCell()" into tm-qpr-dev 2023-03-07 19:37:44 +00:00
Sihua Ma a245873fed Merge "Update widget picker row logic to resolve cropping" into tm-qpr-dev 2023-03-07 18:42:46 +00:00
Schneider Victor-tulias c3281a42a8 Fix flaky RequestPinItemTests
RequestPinItemTest is flaking because launcher hasn't started yet before the tests try to complete gestures. Waiting for launcher to intitialize before running tests.

Fixes: 267201968
Test: RequestPinItemTest
Change-Id: Ib52e00a1ce68fba5d9af9d1c875078f2f60ea248
2023-03-07 10:36:02 -08:00
Sunny Goyal dd971133d8 Merge "Adding support for overriding flag values in test" into tm-qpr-dev am: f450476c7a am: c2cc5c57c4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21733882

Change-Id: I097c16c9e47a0dc341fe6c39896a432c9205746c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-07 00:07:23 +00:00
Sihua Ma 16180801e8 Update widget picker row logic to resolve cropping
Using pixels instead of cell spans for calculating the widget picker row
binding logic.

Before: https://screenshot.googleplex.com/3uXX2m7xWh3om5t
Now: https://screenshot.googleplex.com/C593mrQfqTahNrQ

Test: Manual
Fix: 269790954
Change-Id: Ib591a6f6d3cf8b72766e0714b9bc8ceb86b2ba4f
2023-03-06 13:41:24 -08:00