Commit Graph

12 Commits

Author SHA1 Message Date
Jagrut Desai 3fc1e3a45d Fix TaskbarDividerPopupView vertrical Arrow offset
Test: Manual
Bug: 310673489
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning TEAMFOOD
Change-Id: I6c6af315cb058c8da599af8120a6a903ab247006
2024-01-11 14:00:37 -08:00
Jagrut Desai 25cb918a37 Refactor TaskbarDividerPopup Open/close animation
Test: Manual
Bug: 315848479
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED
Change-Id: I3c43bd718cef24ec334f7f4884167ecb2ce0cfd5
2024-01-02 15:25:42 -08:00
Jagrut Desai 61526a7413 Merge "Improvements to TaskbarDividerPopupView" into main 2023-11-03 02:02:28 +00:00
Jagrut Desai 9af2084a56 Improvements to TaskbarDividerPopupView
- Close Animation improvement for popup.
- Popup location changed to  16dp above the taskbar view.
- Support for disabled state when user is in 3-button mode. (design changes to come in separate cl)

Test: Manual
Bug: 265170176
Flag: LEGACY ENABLE_TASKBAR_PINNING DISABLED
Change-Id: I9c91e6eb2b29c85433ba1c3d34505f0519448a6f
2023-11-02 17:24:50 -07:00
Jagrut Desai c554d5fa46 Fix TaskbarDividerPopupMenu Switch Style
we recently added support for settings app style switches to Launcher. Use that style for TaskbarDividerPopupMenu Switch

Test: Manual
Bug: 308682758
Flag: LEGACY ENABLE_TASKBAR_PINNING DISABLED
Change-Id: If61a426e4051ebce67601055942667ed93928d15
2023-11-02 14:23:48 -07:00
Jagrut Desai 631b284836 Taskbar pinning animation with no recreate
Test: Manual, Visual
Bug: 265436799
Flag: LEGACY ENABLE_TASKBAR_PINNING DISABLED

Change-Id: I84a4d1efdb0bd4a0f856fa1f46b6489ef54a3841
2023-10-26 10:36:48 -07:00
Jagrut Desai cd667ed4ad Clear TaskbarDividerPopupView callback upon closing
- Breakout CL part 4
- This is a breakout cl from ag/24272821 to make it more readable and atomic.
- This cl consist of clearing callbacks after calling close once, so that we don't run into scenario where user is able to close popup multiple times leading to crash.

Test: Manual, Visual
Bug: 265170176
Flag: ENABLE_TASKBAR_PINNING
Change-Id: Ie4cd95c69a559a17b7c19a64a71ccf6ac20542d7
2023-09-06 17:53:34 +00:00
Jagrut Desai 8923830f74 Remove Change Navigation Mode option for Taskbar Divider Popup Menu
- Breakout CL part 3
- This is a breakout cl from ag/24272821 to make it more readable and atomic.
- This cl consist removal of an option from taskbar divider popup meu which is no longer required and other changes regarding the removal like ripple.

Test: Manual, Visual
Bug: 265170176
Flag: ENABLE_TASKBAR_PINNING
Change-Id: I3664df7a134cc0eb5b4ed856c7e0730ef1b75dea
2023-08-17 22:13:49 +00:00
Colin Cross abf18e9c03 Fix kotlin nullable errors in Launcher3
Fix kotlin nullable errors that were exposed by setting the retention
of android.annotation.NonNull and android.annotation.Nullable to
class retention.

This relands I26edfec35dca14abe90b08e3c74de0446eda95d2 with a fix in
SplitSelectDataHolder.kt to call createPackageContext when user is null
instead of asserting that it is not null.

Bug: 294110802
Test: builds
Test: WMShellFlickerServiceTests
Change-Id: I4525d0fa83a1db9cc5cff90f340fc3f863537c01
2023-08-11 11:28:54 -07:00
Jagrut Desai 5b3161ef3e Android U: GM3 Color Tokens for Taskbar and quickstep
Test: Manual, Design Review
Bug: 268505871
Flag: not needed
Change-Id: I68e5092ccc69cf8a0d40aa4cc49fe9e8d82a68f4
2023-05-23 11:44:15 -07:00
Jagrut Desai 95a8b526a7 Adding Support for Change Navigation Mode Taskbar Divider Menu Option
Invoking setting app with going navigation mode fragment upon clicking "Change navigation mode" from Taskbar Divider menu.

Test: manual
Bug: 279084093
Flag: ENABLE_TASKBAR_PINNING
Change-Id: I17b109231e68459934a5658d74c0061254c7f7a6
2023-04-24 10:01:32 -07:00
Jagrut Desai c6d625b8db Exposing functionality to pin Taskbar from TaskbarDividerPopupView.
This CL allows user to long press on Taskbar divider view to bring up divider popup view. It also included functionality of allowing user to turn on always show taskbar from the divider popup view.

Test: Manual
Bug: 265436055
Bug: 265434718
Bug: 265434902
Bug: 265434705
Flag: ENABLE_TASKBAR_PINNING

Change-Id: Ied54d718483a9b06b053d68988e5c294a786002a
2023-04-20 22:04:21 -07:00