Commit Graph

2181 Commits

Author SHA1 Message Date
Saumya Prakash bb3af5d904 Add insets for taskbar when a camera cutout interrupts it
Certain devices have camera cutouts that taskbar's insets did not account for previously. This change adds in the cutout's height as a bottom inset (if it is present) to avoid a black bar being drawn in the taskbar area.

Fix: 322954760
Test: Open a full screen app on a large screen device and ensure that a black bar doesn't show up when rotating the screen to 90 degrees and 180 degrees.
Flag: N/A
Change-Id: I876274b561c7f0101554654ce758fc9c08180de7
2024-02-13 23:00:21 +00:00
Jagrut Desai 2fee4eb040 Fixing NullPointerException in TaskbarUIController
Test: Presubmit
Bug: 322617093
Flag: NONE
Change-Id: I648ff17bbc666f30bd43fdab3320d058ac9e1f9f
2024-01-29 08:52:16 -08:00
Tracy Zhou b8bf90cd1f Merge "Init with mIsLumaSamplingEnabled = true" into main 2024-01-27 03:45:54 +00:00
Vinit Nayak 64af5ca348 Merge "Revert "Ignore taskbar launch request if app(s) are already running"" into main 2024-01-26 21:33:47 +00:00
Vinit Nayak 8a13e275ec Revert "Ignore taskbar launch request if app(s) are already running"
This reverts commit 9a7b6f972b.

Reason for revert: b/319750648

Change-Id: I778453cf65bb48e31062365a069cfe5b1cb77b96
2024-01-26 19:01:48 +00:00
Sunny Goyal 4b67d7f47f Adding an abort listener in app launches to clear state
Bug: 318394698
Test: Verified on device
Flag: None
Change-Id: Ib6108782429abb5dfd9c4e42246e4a93ddf10f55
2024-01-26 17:16:31 +00:00
Tracy Zhou 1c15229be6 Init with mIsLumaSamplingEnabled = true
Bug: 230395757
Test: Factory reset in unfolded. Check bar sampling. Fold and swipe up from an app different from system color to overview. Observe the bar color change.
Change-Id: I7d94a3a8f17a40fbabd4d65629846eb12bdbd3d6
2024-01-25 22:54:57 -08:00
Vinit Nayak e4826e9346 Merge "Prevent taskbar animation for contextual split from home" into main 2024-01-25 19:14:12 +00:00
Vinit Nayak febd61fb3f Prevent taskbar animation for contextual split from home
* Ideal animation TODO, this is to help
unblock for now.

Flag: Flag: ACONFIG com.android.wm.shell.enable_split_contextual DEVELOPMENT
Test: With flag on and off, from home, overview, all apps
Bug: 296351434
Change-Id: Ida743a881519796ed8ce3e5966aa708c84521c51
2024-01-24 19:46:30 -08:00
Tracy Zhou e49c26dd79 Merge "Use nearest region for all the nav buttons in 3-button folded mode" into main 2024-01-24 22:12:14 +00:00
Ats Jenk feb2b098cb Merge "Move bubble bar stashed handle to the left for RTL" into main 2024-01-24 19:22:58 +00:00
Tracy Zhou 9c9befae5f Use nearest region for all the nav buttons in 3-button folded mode
Bug: 230395757
Test: In 3-button folded mode, make sure that the touches that happen between nav buttons go to the nearest button. No regression in other modes.

Change-Id: Icb776a9a4ed4fc31d33dc3267c7053f2b0da0bfc
2024-01-24 11:06:01 -08:00
Vinit Nayak 5f3b761451 Merge "Rename isSplitSelectionEnabled() to isSplitSelectionActive()" into main 2024-01-24 05:53:44 +00:00
Ats Jenk e1701b05f0 Merge "Skip bubble bar arrow animation if arrow detached" into main 2024-01-24 01:23:49 +00:00
Ats Jenk 14f76fe13b Move bubble bar stashed handle to the left for RTL
When system language is set to an RTL language, we move the bubble bar
to the left.
Move the stashed bubble bar handle to the left in this case.
Tweak the bubble bar expand animation so that the bubbles expand from
the left edge.

Flag: LEGACY persist.wm.debug.bubble_bar DEVELOPMENT
Bug: 273310265
Test: repeat following steps with LTR and RTL system languages
  - add couple of bubbles to bubble bar, open an app, observe stashed
    handle on the left
  - swipe up from system navbar to show taskbar and bubble bar
  - swipe up from bubble bar handle to show bubble bar and expand it
  - drag bubble bar to dismiss target and back out and release
Change-Id: Ia3b7892bba732a5278168d63db0594087f55fad4
2024-01-23 17:16:49 -08:00
Vinit Nayak 7c7ece3efe Rename isSplitSelectionEnabled() to isSplitSelectionActive()
Bug: 295467097
Change-Id: I5c518c3e7227c034956fb92590b7472ba4a71d39
2024-01-23 15:41:14 -08:00
Ats Jenk e0b2ef481c Skip bubble bar arrow animation if arrow detached
Arrow can become detached from the bubble bar background. This can
happen when bubble bar is pinned to the left and the right-most bubble
is selected. When the selected, right-most bubble is removed by drag and
dismiss, the view is removed and bubble bar background is immediately
updated. But we try to animate the arrow to the new selected position.
Before starting to animate arrow position, check if arrow position is
greater than bubble bar width. If it is, the arrow is detached and we
should not try to animate it to the new position. Just move it.

Flag: LEGACY persist.wm.debug.bubble_bar DEVELOPMENT
Bug: 273310265
Test: switch to RTL language, have 3 bubbles in bar, expand and select
  the right-most bubble, then dismiss it via drag, observe arrow jumps
  to new position and does not become detached from background
Test: switch to LTR language, try the same, 3 bubbles and dismiss the
  left-most bubble, observe arrow jumps the same and does not become
  detached
Test: select other bubbles, observe arrow position animates to the new
  position
Change-Id: I399db3c3e32b65b9125262bba0a0c32e45865bba
2024-01-23 15:18:09 -08:00
Ats Jenk 1721e8a7ae Merge "Bubble bar expland/collapse animation when on left" into main 2024-01-23 21:44:25 +00:00
Ats Jenk feb3a68db7 Bubble bar expland/collapse animation when on left
Fix bubble bar collapse and expand animations when bubble bar is pinned
to the left.
When system language is set to an RTL language, bubble bar gets pinned
to the left edge of the screen.
Bubble bar should expand to the right and collapse to the left. Bubbles
in the bubble bar should be ordered from right to left. The most recent
bubble should be at the right in the bubble bar.

Known issue:
  - when the most recent bubble is removed, the arrow animates to a new
    position, but the background is not animated, resulting in arrow
    getting detached from the container. Will be fixed by animating the
    background.

Flag: LEGACY persist.wm.debug.bubble_bar DEVELOPMENT
Bug: 273310265
Test: with LTR language set as the system language
  - expand bubble bar with 1 bubble
  - expand bubble bar with multiple bubbles
  - select second bubble, observe after collapse it is set as first
  - dismiss a bubble from bubble bar by dragging
Test: with RTL language set as the system language
  - expand bubble bar with 1 bubble
  - expand bubble bar with multiple bubbles
  - select second bubble, observe after collapse it is set as first
  - dismiss a bubble from bubble bar by dragging

Change-Id: Ic46a5b1a6e45ad225ba509a61147cc6a8cdd0397
2024-01-22 19:06:29 -08:00
Mady Mellor 0e08d300e4 Merge "Add Ats and Liran as owners to taskbar bubbles" into main 2024-01-23 00:34:10 +00:00
Jagrut Desai d176477b7f Merge "Fixing folder drawLeaveBehind() with Taskbar Pinning enabled" into main 2024-01-22 19:40:58 +00:00
Mady Mellor befb26ca11 Add Ats and Liran as owners to taskbar bubbles
Flag: N/A
Test: treehugger
Bug: none
Change-Id: I16c3c45c109d0bcc4f536dfebc5d40c8ea3d2f31
2024-01-22 11:28:47 -08:00
Sunny Goyal 7ec2e11b0c Merge "Implementing an unfold animation using CannedAnimationController" into main 2024-01-22 19:06:41 +00:00
Jagrut Desai f5a27ac0c5 Fixing folder drawLeaveBehind() with Taskbar Pinning enabled
Test: Manual
Bug: 320579559
Flag: NONE
Change-Id: If0c7cb7cf8deb89868cb34c310c91fd0cf028643
2024-01-22 10:08:09 -08:00
Tracy Zhou e66ed03992 Merge "Update task bar height update logic to consider screen rotation cases" into main 2024-01-20 02:12:19 +00:00
Sunny Goyal 3ef2768922 Merge "Simplyfing SystemShortcut rendering" into main 2024-01-20 01:11:36 +00:00
Tracy Zhou a009a5e82e Update task bar height update logic to consider screen rotation cases
When home screen rotation is enabled, instead of updating taskbar height (assuming that folded task bar is always on the bottom of screen display), we should update taskbar width instead.

Bug: 313371759
Test: try out both folded and unfolded 3-button and gesture nav modes, enable home rotation, make sure all the nav buttons are functional and visible when they should be.
Change-Id: I16f53d9e9c3cd0229fc50b73613b032a96322b97
2024-01-19 16:58:03 -08:00
Tony Wickham c4df8c2ec6 Revert to passing mIsStashed to StashedHandleViewController again
- Fixes case where handle is initially invisible but will be stashed
  and visible, e.g. when launching an app from home screen
- To fix the original issue of sampling happening unnecessarily for
  three button nav, also check supportsVisualStashing()

Fixes: 321257120
Flag: None
Test: Launch an app from home in gesture nav mode
Test: testThreeButtonsTaskbarBoundsAfterConfigChangeDuringIme
Change-Id: I1f26436de3081fd00f75a5921010e361e9a9f34e
2024-01-19 20:25:25 +00:00
Sunny Goyal 9f226dff72 Simplyfing SystemShortcut rendering
Instead of opening the popup again when the status of AppSharing
changes, updating the UI in-place.

Bug: 321179015
Test: Presubmit
Flag: N/A
Change-Id: I6d7bd8cdf2014fd881324347e3e01b8e7e84ef1e
2024-01-19 10:48:54 -08:00
Sunny Goyal e0c1649d87 Cleaning up some unused notifications functionality
Bug: 321154530
Test: Presubmit
Flag: N/A
Change-Id: I1ff2a4f19595659d89e7d72ee1b29036bbd54d8f
2024-01-19 00:21:02 -08:00
Sunny Goyal 2c206400a2 Implementing an unfold animation using CannedAnimationController
Bug: 297057373
Flag: aconfig enable_unfold_state_animation DISABLED
Test: Manual
Change-Id: Iaa352133ebf06ab74b9ba4b8c4d3523f27666089
2024-01-18 11:49:37 -08:00
Saumya Prakash b617daa6c6 Merge "Add standalone taskbar edu tooltip for the pinnable taskbar feature" into main 2024-01-18 01:41:14 +00:00
Saumya Prakash dddebdff0c Add standalone taskbar edu tooltip for the pinnable taskbar feature
This change adds in a standalone edu window for the pinnable taskbar
feature. The reason for the change is to educate users about pinnable
taskbar to those who have already seen taskbar edu before.

Fixes: 302589411, 300161174
Test: Went through taskbar education taskbar with the flag on and off.
Check that the standalone pinning taskbar only shows up if previous
taskbar education was already completed.
Flag:  ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED

Change-Id: I03a5fb05ae5f15892421a57355f6d503de56d9fd
2024-01-17 21:23:30 +00:00
Andy Wickham 32f2cae290 Merge "Allow stashed taskbar to be long pressed." into main 2024-01-17 21:09:15 +00:00
Andy Wickham caf0c35661 Allow stashed taskbar to be long pressed.
Bug: 319175012
Test: Manual and unit test
Flag: NA
(see other change)

Change-Id: Ic8ac68d21c64a909a1035339d36f9c3b50a8963c
2024-01-16 21:43:46 -08:00
Schneider Victor-tulias 0c8439e17d Merge "Update the KQS app launch animation to match the spec exactly" into main 2024-01-15 18:42:37 +00:00
Tony Wickham dc566559d0 Merge "Improve Taskbar touchableRegion debuggability" into main 2024-01-13 01:38:18 +00:00
Jagrut Desai a15b88f484 Merge "Adding Taskbar Pinning Analytics again." into main 2024-01-13 00:54:14 +00:00
Jagrut Desai fff93577e8 Merge "Update enableTaskbarNoRecreate logic" into main 2024-01-12 22:31:15 +00:00
Jagrut Desai 777f3a4b9d Merge "Fix TaskbarDividerPopupView vertrical Arrow offset" into main 2024-01-12 21:18:27 +00:00
Jagrut Desai 057144e0f6 Update enableTaskbarNoRecreate logic
Test: Presubmit
Bug: 318567569
Flag: NONE
Change-Id: I6927f0bab0317219a00a7c09c08640825d54e91b
2024-01-12 10:59:10 -08:00
Tracy Zhou 7a30de2fc3 Merge "Remove taskbar window from WindowManager in TaskbarManager.destroy()" into main 2024-01-12 06:05:44 +00:00
Tracy Zhou 78c548a829 Remove taskbar window from WindowManager in TaskbarManager.destroy()
When task bar crashes (from anything), task bar window is not cleaned up properly. This is because destroyExistingTaskbar() only removes the root layout from the window when we are no longer rendering task bar (one use case of that is folding the device). We need to clean it up in onDestroy() also.

Fixes: 319105323
Test: adb shell am crash com.android.systemui and make sure there is only one task bar window
Change-Id: Ia9c808e903422707bf4c270b2631fc913dde65d9
2024-01-11 16:13:06 -08:00
Tony Wickham 480448b059 Merge "Temporary workaround for taskbar hiding in Desktop" into main 2024-01-11 23:21:42 +00:00
Jagrut Desai 3fc1e3a45d Fix TaskbarDividerPopupView vertrical Arrow offset
Test: Manual
Bug: 310673489
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning TEAMFOOD
Change-Id: I6c6af315cb058c8da599af8120a6a903ab247006
2024-01-11 14:00:37 -08:00
Jagrut Desai 80cc62173e Adding Taskbar Pinning Analytics again.
Test: Presubmit
Bug: 265436916
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning TEAMFOOD
Change-Id: I742dccccc7648bb7ec8bf94d5f5f55430a5543ab
2024-01-11 11:33:02 -08:00
Tony Wickham 4e7411c54c Temporary workaround for taskbar hiding in Desktop
Taskbar still hides during the transition, but then reappears
after settling.

Flag: LEGACY ENABLE_HOME_TRANSITION_LISTENER enabled
Bug: 314207404
Test: manual
Change-Id: Ie3d29b3d40e513f39cb34176baa781c9f2853e57
2024-01-10 19:59:25 +00:00
Schneider Victor-tulias 7b019ef700 Update the KQS app launch animation to match the spec exactly
Updated the KQS to look exactly like the default app launch animation, in the opposite direction:
- animation interpolator
- task corner radius
- task margin
- animation duration

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 313606549
Fixes: 313607264
Test: launched tasks from KQS from home and launched app
Change-Id: I3f49f9430b2148680816d904aced93d14f366123
2024-01-10 15:34:00 +00:00
Tracy Zhou cf5407dfc6 Hook up luma sampling state change from CommandQueue
Currently when swiping up from some apps (maps), the stashed task bar color changes. Instead, sampling should be disabled during the transition (with a signal from the frameworks).

Bug: 230395757
Test: Swipe up from maps. Make sure the bar color doesn't change during transition
 to overview
Change-Id: Ifc30f4067a0e4d134b422d152f5b5caee0a77a33
2024-01-09 21:56:58 -08:00
Schneider Victor-tulias 818b3ba092 Merge "Update KQS task launch animation" into main 2024-01-09 15:04:20 +00:00