Commit Graph

2152 Commits

Author SHA1 Message Date
Sunny Goyal 29b86863f2 Merge "Making workspaceData immutable" into main 2025-05-08 08:06:06 -07:00
Sunny Goyal 57a195b790 Making workspaceData immutable
BgDataModel holds a mutable handle of the data, which ensures that all edits go through this class and there is a single place to keep the repository updated

Bug: 390572144
Test: Updated existing model tests
Flag: EXEMPT refactor
Change-Id: I991b707dd21801d1abd00510f676549947285012
2025-05-07 13:21:21 -07:00
Uwais Ashraf cbb16c2fac Merge "Make state of TTV xml match Uninitialized state" into main 2025-05-07 10:13:34 -07:00
Treehugger Robot dadf9f45a3 Merge "Delete Ignored test" into main 2025-05-07 08:36:45 -07:00
Uwais Ashraf 882a6a22bf Make state of TTV xml match Uninitialized state
Flag: EXEMPT - test only
Bug: 416195253
Test: Presubmits
Change-Id: I82250915bf35b4ce9583dd58c6fc736530c25461
2025-05-07 05:28:28 -07:00
Treehugger Robot bf27d46837 Merge "Ignore flaky tests" into main 2025-05-07 04:58:56 -07:00
Uwais Ashraf d425f4ef99 Ignore flaky tests
Flag: EXEMPT - test only
Bug: 416195253
Bug: 415780503
Test: Presubmits
Change-Id: I8b4dc0890b1186bb32e70adccc872e2174b6e168
2025-05-07 11:14:36 +00:00
Sam Cackett c81daa36ae Delete Ignored test
testOverviewForTablet was ignored for over a year and other tests cover
most of the test cases of the original test so removing

Add separate tests for grid re-balancing

Fix: 315376057
Flag: EXEMPT. Test
Test: TaplTestsQuickstep
Change-Id: I33016ccdb68b1c2039c626a6d32821de71509506
2025-05-07 11:33:21 +01:00
Sunny Goyal 02a41c7e5c Moving PredictionHelper to kotlin
Bug: 390572144
Flag: EXEMPT refactor
Test: atest PredictionHelperTest
Change-Id: If94ae62d7e1412e6760423cf8ab43acba236c3e9
2025-05-06 10:49:30 -07:00
Sunny Goyal 53cc9a7806 Merge "Moving predicted items to ItemIdMap instead of extraItems" into main 2025-05-06 10:29:39 -07:00
Pat Manning a0b00e8c47 Merge "Add screen recording to failing testOverview test." into main 2025-05-06 10:15:35 -07:00
Pat Manning 7c7167e2f2 Add screen recording to failing testOverview test.
Bug: 415773066
Test: TaplTestsQuickstep#testOverview
Flag: EXEMPT bugfix.
Change-Id: Ifb0bcd7fe3fa34bd4da911f0d943bf96db062828
2025-05-06 15:46:21 +01:00
Steven Ng a5bc3c5677 Merge "Use grantManageKeyGesturesToRecents flag for granting recents key gesture events" into main 2025-05-06 04:22:26 -07:00
Sunny Goyal aef6c7932e Moving predicted items to ItemIdMap instead of extraItems
> This allows the whole workspace model to be contained in itemIdMap instead of spread across multiple data containers
> Deprecating extraItems, all non-workspace data should use separate repositories
> Design: http://go/launchermodel-re-arch?#heading=h.5y8n4r164d5s

Bug: 390572144
Test: atest PredictionUpdateTaskTest
Flag: EXEMPT refactor
Change-Id: I886d0a8d5bbbf9f5c2054d4a2442bf03f9c4eab5
2025-05-05 15:52:37 -07:00
Sebastián Franco 24a321d835 Merge "Creating NexusLauncherE2ETests test suite, this cl only adds the Launcher3 part" into main 2025-05-05 14:30:04 -07:00
Sebastian Franco fc8537d5de Creating NexusLauncherE2ETests test suite, this cl only adds the Launcher3 part
The test don't run yet in presubmit, first I will have the NexusLauncherE2ETests
target ready and then I will add it to the presubmit.

Bug: 324261526
Flag: EXEMPT test only
Test: atest NexusLauncherE2ETests
Change-Id: I4daa204ec735456c481b0682ca518da381af7bb7
2025-05-05 18:53:08 +00:00
Treehugger Robot 51c9c19e89 Merge "Remove RecentTasksList implement of DesktopVisibilityController" into main 2025-05-02 18:26:06 -07:00
Treehugger Robot 1a597d619b Merge "Remove IME-specific touch passthrough for Taskbar" into main 2025-05-02 14:42:04 -07:00
Liran Binyamin 00dc879e2c Merge "Send bubble bar distance to shell" into main 2025-05-02 14:35:40 -07:00
Treehugger Robot 21779a4192 Merge "Moving WorkspaceItemFactory to dagger as PredictedItemFactory so that it can be reused" into main 2025-05-02 11:46:48 -07:00
Treehugger Robot d2cf9a98f2 Merge "Ignore KeyboardQuickSwitchControllerTest to fix robo failure" into main 2025-05-02 11:06:08 -07:00
Sunny Goyal 46b13eb184 Moving WorkspaceItemFactory to dagger as PredictedItemFactory so that it can be reused
Bug: 390572144
Flag: EXEMPTY refactor
Test: Presubmit
Change-Id: I41c5fea73452d7f4c1fd9980a89bcb7199eb19d7
2025-05-02 08:55:21 -07:00
Liran Binyamin 34024fe26a Send bubble bar distance to shell
We previously sent the top coordinate of the bubble bar to shell.
However when the screen height changes, launcher takes a bit longer
to update than shell. So instead of calculating the top coordinate
on the launcher side, we now send the amount of space between the
bubble bar and the bottom of the screen to shell, where we can offset
that as needed.

Bug: 392893178
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual
       - send some bubbles
       - launch app
       - expand
       - swipe to home
       - fold and unfold
Change-Id: I57b96db49dab1e2304fde8dc55a99eaaf85e40f8
2025-05-02 10:54:39 -04:00
Schneider Victor-tulias 9b468c5b24 Merge changes Id95b36da,I6a2225be into main
* changes:
  Fix recents window activity leak
  Update TAPL tests to dismiss all tasks safely
2025-05-02 07:38:30 -07:00
Vadim Tryshev bc6b9ea148 Merge "Failures caught by launcher.checkForAnomaly did not produce screenshots." into main 2025-05-01 16:29:38 -07:00
Ajinkya Chalke 98ce0f4ccb Ignore KeyboardQuickSwitchControllerTest to fix robo failure
Bug: 413540825
Flag: EXEMPT ignoring test
Test: atest
Change-Id: I75a15563fbc8cc500df73c9b1d1e9bf2e2d378b8
2025-05-01 16:16:19 -07:00
Vadim Tryshev 9b0d61a803 Failures caught by launcher.checkForAnomaly did not produce screenshots.
Fix to handle failures caught by launcher.checkForAnomaly so that they
are also reported to the test watcher.

Bug: 406906811
Test: presubmit
Flag: NONE Not production code
Change-Id: I379fcf09e3cd2e6321be9f4bc3dd6f3272e9c2fd
2025-05-01 13:29:18 -07:00
Schneider Victor-Tulias a56aa0d539 Update TAPL tests to dismiss all tasks safely
Flag: EXEMPT test refactor
Bug: 377678992
Test: pre/post-submit tests
Change-Id: I6a2225bea4f004bdc598e2c67ce26da9fd42f7a6
2025-05-01 16:04:32 -04:00
Schneider Victor-Tulias 42d6c08d41 Move ExtendedLongPressTimeoutRule implementation to shared sysui test library
Flag: EXEMPT test fix
Fixes: 396862825
Test: TaskbarExpandCollapse
Change-Id: I950ed4ede8db150234d843422982792f5b6bfd8e
2025-05-01 11:38:27 -07:00
Tony Wickham 41b1c52c7f Remove IME-specific touch passthrough for Taskbar
It doesn't seem necessary anymore (and anyway, existing cases like
Taskbar being stashed while IME is showing handle this as well).
Removing the specific block fixes a bug where touches were going
to the underlying app even though Taskbar window is fullscreen
while editing a Folder name.

Fixes: 400859085
Test: TaskbarInsetsControllerTest
Flag: EXEMPT bugfix

Change-Id: If30acd0b3b9c3fd0b29b94ca963beb1c70162416
2025-05-01 16:43:31 +00:00
Steven Ng 84cde92450 Use grantManageKeyGesturesToRecents flag for granting recents key gesture events
Reason: Recents app can only listen to key gesture events after ag/33295605, which is gated by a read only flag, com.android.window.flags.grant_manage_key_gestures_to_recents.

Test: atest NexusLauncherTests:QuickstepKeyGestureEventsHandlerTest
Test: atest NexusLauncherTests:AllAppsActionManagerTest
Flag: com.android.window.flags.grant_manage_key_gestures_to_recents
Bug: 406452076
Change-Id: I66f8c9b2f23eb65bafc986321ff971c855ce00a3
2025-05-01 02:54:17 -07:00
Jagrut Desai f52ffc1232 Auto-Stashing Functionality for Pinned Taskbar
This cl includes :
- Refactor to remove unpinning/pinning in desktop mode with refactor of DisplayController, TaksbarPinningController, and its tests.
- Combined the auto stashing conditions under one method shouldAllowTaskbarToAutoStash() which takes in consideration isTransientTaskbar, isInDesktop, and Always Show Taskbar option is turned on/off in desktop mode.
- enabled taksbar divider popup support in desktop mode.
- Intorduced animation for pinned taksbar when autostadhing is enabled.
- Enable to onSwipeToUnstashTaskbar for TaskbarInputStashController for pinned taksbar in desktop mode.

Test: Presubmit, Unit, Manual
Bug: 381535785
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: Ie5ecf3a3c72bf8dfadf2d0c908269305fe5bad0b
2025-04-30 10:39:58 -07:00
Sunny Goyal dd367a2218 Merge "Converting BgDataModel to Kotlin" into main 2025-04-30 10:19:46 -07:00
Mykola Podolian 5259038c6f Merge "Launcher TAPL test for dragging task bar icon to the bubble bar." into main 2025-04-30 09:29:47 -07:00
Schneider Victor-tulias b4692a9ea4 Merge "Update AbstractLauncherUiTest to use recents window when possible" into main 2025-04-30 06:54:19 -07:00
Sunny Goyal 036ced4703 Converting BgDataModel to Kotlin
This will allow the use of Flows in BgDataModel

Flag: EXEMPT refactor
Bug: 390572144
Test: Presubmit
Change-Id: I8fdd1635a19ae4d75260fb1ddb9cd7ab00cd0496
2025-04-29 15:37:11 -07:00
mpodolian 9764250b60 Launcher TAPL test for dragging task bar icon to the bubble bar.
Added a test and TAPL objects to check dragging taskbar icons to the
bubble bar.

Fixes: 388910897
Test: TaplTestTaskBarIconDrag
Flag: EXEMPT test
Change-Id: I8a3e64a83c72a9f6b89b2f8a875ca6565d501701
2025-04-29 15:32:41 -07:00
Schneider Victor-Tulias b8440b75ef Update AbstractLauncherUiTest to use recents window when possible
Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/postsubmit
Change-Id: Id3ddc11aa9163df3f2914edba66e1db36fdde63b
2025-04-29 14:13:26 -07:00
Ats Jenk 861f887dfe Merge changes I91a3b558,Ifc9c391a,I3da2bc22,Ied187c63,I859b7359 into main
* changes:
  Store bubble bar stashed state during rotation [6/N]
  Restore bubbles without affecting bar state [5/N]
  Do not animate bubbles from initial update [4/N]
  Store and restore selected bubble and expanded state [3/N]
  Do not animate bubble bar for initial state [2/N]
2025-04-29 13:17:42 -07:00
Treehugger Robot 7103e478b3 Merge "Register KEY_GESTURE_TYPE_RECENT_APPS[_SWITCHER] in the quickstep" into main 2025-04-29 04:53:12 -07:00
Ats Jenk 6c7cb1a5f0 Do not animate bubbles from initial update [4/N]
Bubbles that are restored with initial update should not be animated in.
If we restore the bubble bar after rotation, we need to show it
immediately. Attempting to animate the bubbles from initial update
causes the UI to flicker.

Bug: 357115534
Test: on home screen, have bubble bar expanded, rotate device, check
  bubble bar bubbles do not flicker after rotation
Test: have no bubbles in bubble bar, trigger a bubble, check it is
  animated
Flag: com.android.wm.shell.enable_bubble_bar
Change-Id: I3da2bc22588c0f5d2dd9c7a3adfcd2c19c339809
2025-04-28 18:44:26 -07:00
Li Lin 6e718cffb1 Merge "Show Growth Framework nudge driven by nudge payload." into main 2025-04-28 17:01:20 -07:00
Min Chen 31f5e79ffd Merge "Fix integration tests with multi-desks on" into main 2025-04-28 16:44:30 -07:00
Li Lin 0f82810cdb Show Growth Framework nudge driven by nudge payload.
Current implementation of the nudge will show at default position
(bottom left corner) and may extended to other position in the future.
More detail at: go/al-growth-framework-nudge

Bug: 398033012
Test: NudgeControllerTest.*
Flag: com.android.launcher3.enable_growth_nudge
Change-Id: Idff9d62a5b1b26aa1cfbef5817f5425f8e94b7c9
2025-04-28 13:59:30 -07:00
Steven Ng 776e157934 Register KEY_GESTURE_TYPE_RECENT_APPS[_SWITCHER] in the quickstep
Before this change, the overview keyboard shortcut pipeline is as follow:
PhoneWindowManager (System server)
StatusBarManagerService (System server)
CommandQueue (SysUi)
Recent (SysUi)
OverviewProxyRecentsImpl (SysUi)
TISBinder (Quickstep launcher)
This cross-process communication chain through the system server, SysUI, and quick step launcher created significant challenges. Firstly, it complicated efforts to pass additional data to the key gesture handler. Secondly, it was less performant than the streamlined new approach. Lastly, the StatusBarManagerService's responsibilities were ambiguous because it also handled unrelated tasks, such as overview, wallet.

Flag: com.android.window.flags.enable_key_gesture_handler_for_recents
Test: atest NexusLauncherTests:com.android.quickstep.input.QuickstepKeyGestureEventsHandlerTest
Test: atest NexusLauncherTests:AllAppsActionManagerTest
Bug: 406452076
Change-Id: I2899e49c8c0a44c6ad58228db1c9eb587daf68c4
2025-04-28 17:19:35 +00:00
Sunny Goyal 07cfe33533 Renaming CONTAINER_PREDICTION to CONTAINER_ALL_APPS_PREDICTION
This avoids confusion with CONTAINER_HOTSEAT_PREDICTION

Bug: 390572144
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: I0e110e2884dd0566bd2e621e60e7458605b9bad7
2025-04-28 09:30:12 -07:00
Jordan Silva af7016c3ef Merge "Make repeated recents button double tap return to previous task" into main 2025-04-28 04:36:13 -07:00
Pat Manning 9fd78aa76d Merge "Drag tasks from center when perfoming dismiss cancel for tests." into main 2025-04-28 04:08:39 -07:00
minch 4e3d48e998 Fix integration tests with multi-desks on
Bug: 362720309
Test: Presubmit
Flag: EXEMPT tests failure fix
Change-Id: I381b8751083a7fb235cf597fd35314ca6f2c0a9b
2025-04-26 15:59:18 +00:00
Ats Jenk 963df5dca3 Merge "Rename method to set bubble bar expanded state [1/N]" into main 2025-04-25 14:21:49 -07:00