Commit Graph

11724 Commits

Author SHA1 Message Date
Vinit Nayak 2af60c9c11 Merge "Add test for vertical and horizontal split apps" into tm-qpr-dev am: 03695ba0f2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20446857

Change-Id: Iea6287903462277f8c494582229b6d602d08f918
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-16 20:59:53 +00:00
Jon Miranda ee5baf1555 Merge "Check NPE and log error condition for enableTransientTaskbar in test harness." into tm-qpr-dev am: c3fc8da433
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20493898

Change-Id: Ic1bf71066475770d2a86b6880cfad73323e5d54c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-16 20:58:48 +00:00
Vinit Nayak 03695ba0f2 Merge "Add test for vertical and horizontal split apps" into tm-qpr-dev 2022-11-16 20:45:01 +00:00
Jon Miranda c3fc8da433 Merge "Check NPE and log error condition for enableTransientTaskbar in test harness." into tm-qpr-dev 2022-11-16 20:43:27 +00:00
Jon Miranda c1ee357b6b Merge "Revert "Revert "Allow transient taskbar to unstash over soft ime""" into tm-qpr-dev am: 12771e002c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20493899

Change-Id: Ic1ccfb2f0a326f6446c42bd68e2038b402184c53
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-16 20:25:20 +00:00
Jon Miranda 12771e002c Merge "Revert "Revert "Allow transient taskbar to unstash over soft ime""" into tm-qpr-dev 2022-11-16 20:18:27 +00:00
Jon Miranda f641ddd27e Revert "Revert "Allow transient taskbar to unstash over soft ime""
This reverts commit c8c81a3425.

Reason for revert: fix tests by not auto stashing when ime comes up, but still allow taskbar to show if user initiaties it

Bug: 255818649
Change-Id: Id3ab27dcc205e5a72dbd0481e3eabc10b2e1b643
Test: pull up ime, swipe to reveal taskbar
2022-11-16 16:13:26 +00:00
Jon Miranda 182d1e93dd Check NPE and log error condition for enableTransientTaskbar in test harness.
Fixes: 259337908
Bug: 257549303
Test: TaplTestsTaskbar
Change-Id: Ifa929dca18437ae101cf3290feda4209790604d2
2022-11-16 08:04:57 -08:00
Sam Dubey efef582110 Merge "Revert "Allow transient taskbar to unstash over soft ime"" into tm-qpr-dev am: b6acf00e3c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20487451

Change-Id: Ibed10114446b622bd13b4d2eed04b76adafc66bb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-16 15:46:01 +00:00
Sam Dubey b6acf00e3c Merge "Revert "Allow transient taskbar to unstash over soft ime"" into tm-qpr-dev 2022-11-16 15:20:30 +00:00
Sam Dubey c8c81a3425 Revert "Allow transient taskbar to unstash over soft ime"
This reverts commit 9787ae6ad9.

Reason for revert: Breaking launcher tests on Tablet

Bug: 259347305

Change-Id: Idfd9e412f143370b6b8a4c6f86aac94d17bc1846
2022-11-16 11:31:55 +00:00
Jon Miranda bc06d45036 Merge "Allow transient taskbar to unstash over soft ime" into tm-qpr-dev am: 49c7469672
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20426457

Change-Id: I1ad96043225399fbba5913dc1ba5c189ae852126
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-16 00:12:37 +00:00
TreeHugger Robot 12e48efb9a Merge "Add ImpressionLogger to StatsLogManager" into tm-qpr-dev am: c2f03ae080
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20445919

Change-Id: I0b74a4469f7c401c9fa04989e5f82048407960a8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-16 00:12:09 +00:00
Jon Miranda 49c7469672 Merge "Allow transient taskbar to unstash over soft ime" into tm-qpr-dev 2022-11-15 23:59:16 +00:00
TreeHugger Robot c2f03ae080 Merge "Add ImpressionLogger to StatsLogManager" into tm-qpr-dev 2022-11-15 23:35:21 +00:00
TreeHugger Robot 8c49ddde2f Merge "Revert "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar.""" into tm-qpr-dev am: 87ccecb6fc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20425196

Change-Id: Iee51b45263db80c85dd480d9061e0ca6b7fc1c46
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-15 23:00:27 +00:00
TreeHugger Robot 87ccecb6fc Merge "Revert "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar.""" into tm-qpr-dev 2022-11-15 22:31:55 +00:00
Vinit Nayak cf41cc7baa Merge "Update unsupported split app error text" into tm-qpr-dev am: bddda819d2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20472165

Change-Id: I12da6dde8f8e5efce24c1ef0b3f3b05453c8b489
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-15 20:42:25 +00:00
Vinit Nayak bddda819d2 Merge "Update unsupported split app error text" into tm-qpr-dev 2022-11-15 20:06:46 +00:00
Vinit Nayak 7545f20268 Add test for vertical and horizontal split apps
* More work still needs to be done for portrait
split apps with stashed taskbar

Bug: 258714015
Test: Existing tests pass, visually saw slight
improvement in stashed portrait gesture clipping.

Change-Id: Id1b9bb28a1a2676a5da1b5e5824e0835290cb616
2022-11-15 11:23:38 -08:00
TreeHugger Robot 48f73b2e53 Merge "Update string for "swipe to go home" when in button nav." into tm-qpr-dev am: ab61359a81
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20311607

Change-Id: Iadaabcbfcc59b57916beb3e1077680ae87733177
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-15 16:39:57 +00:00
TreeHugger Robot ab61359a81 Merge "Update string for "swipe to go home" when in button nav." into tm-qpr-dev 2022-11-15 16:30:32 +00:00
Pat Manning 39a3ac6fe5 Update string for "swipe to go home" when in button nav.
Bug: 252938555
Test: manual
Change-Id: Id52867ec6a9b82a44ab0a803a9824258d9ad4044
2022-11-15 11:19:32 +00:00
Vinit Nayak b2711a81e6 Update unsupported split app error text
Bug: 258822425
Change-Id: I8ac24d094d14a5f65a1d83303a9fd087c76bf066
2022-11-14 15:20:25 -08:00
Schneider Victor-tulias 7d9e1d6fb9 Merge "Return to home when overview command fails." into tm-qpr-dev am: 62b9f80d1e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20442700

Change-Id: I0a5517e8d26e276e021f49dd39deacffaec79b5d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-14 21:08:08 +00:00
Schneider Victor-tulias 62b9f80d1e Merge "Return to home when overview command fails." into tm-qpr-dev 2022-11-14 20:44:52 +00:00
Jon Miranda 9787ae6ad9 Allow transient taskbar to unstash over soft ime
Bug: 255818649
Test: pull up ime, swipe to reveal taskbar
Change-Id: Ibae77c8a29d06093823f2421fbf851979f9babed
2022-11-14 11:30:55 -08:00
Vinit Nayak f47e27ee4f Merge "Prevent dropping a drag from TaskbarAllApps in Overview" into tm-qpr-dev am: 50306445a1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20324839

Change-Id: Ie80c46c5c86fde41f259ff2e07ca4213b45a673d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-14 19:21:19 +00:00
Vinit Nayak 50306445a1 Merge "Prevent dropping a drag from TaskbarAllApps in Overview" into tm-qpr-dev 2022-11-14 19:07:59 +00:00
Jerry Chang b4f100354e Merge "Make multi-instances split opt-in based" into tm-qpr-dev am: 168c204f49
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20306070

Change-Id: Icec4268adf433679226a7cb26dbdfd0327e899a2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-14 13:51:16 +00:00
Jerry Chang 168c204f49 Merge "Make multi-instances split opt-in based" into tm-qpr-dev 2022-11-14 13:29:46 +00:00
Vinit Nayak b8ef284a6c Only show split button for single fullscreen task if taskbar is present in Overview am: 584332202c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20442504

Change-Id: Ifde61fadc084a707e60a0d66db2f4fd06b7ef669
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-12 03:11:16 +00:00
Anushree Ganjam 96c72745ae Add ImpressionLogger to StatsLogManager
go/toast-search-impression-logging

Bug: 204781396
Test: Manual
Change-Id: If00027581000d315590ce2fac46428cbf173da49
2022-11-11 18:23:25 +00:00
Vinit Nayak eae4c99434 Prevent dropping a drag from TaskbarAllApps in Overview
* Don't close TaskbarAllApps once drag starts
(see comment in code regarding needing multiple shared drag
layers)
* Hide app menu split options for taskbar in overview
* One TODO is that the animation needs to be tweaked
because the scale of the icon when it's returned is too large.
* I think maybe we have to change the
TaskbarDragController#mDragIconSize since that gets directly
set from a resource. Unclear.

Test: Dragged in TaskbarAllApps in overivew and in split
select, app returned to original position and not taskbar
Bug: 251747761

Change-Id: I785f34b0bdb0b0abfc440450494074f8dfe7c31a
2022-11-10 16:17:26 -08:00
Vinit Nayak 584332202c Only show split button for single fullscreen task if taskbar is present in Overview
* Taskbar in overview allows second app to be
selected so user wouldn't be stuck in split
select state

Fixes: 258543259
Test: Tested w/ flag on and off
w/ one and multiple flags
w/ fullscreen and split single focused task

Change-Id: Ie588ad66fde4e012e08d8f5abbe1eef5a1a5db6b
2022-11-10 14:20:03 -08:00
Pat Manning e6d4939db8 Merge "Align system navigation setting link in AllSet page for tablets to top/start." into tm-qpr-dev am: 3c7a7a92b3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20411892

Change-Id: Ib44b14ba9fb1781efc443d6d10668aac4fdabeae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-10 20:11:14 +00:00
Pat Manning 3c7a7a92b3 Merge "Align system navigation setting link in AllSet page for tablets to top/start." into tm-qpr-dev 2022-11-10 19:58:48 +00:00
Schneider Victor-tulias 0844f2e8ef Return to home when overview command fails.
Returning a runnable list that doesn't get run later causes the overview command to be added to the pending command queue, but never gets removed. This causes following overview (and home on tablets) commands not to respond.

Test: forcefully caused the error condition programmatically; checked the queue is cleared and the user is sent home.
Fixes: 255851262
Change-Id: I9d2f54960c54963b1e7480a597d05911201c152b
2022-11-10 11:56:09 -08:00
Saumya Prakash 8d2f42ddd2 Merge "Add padding around clear all button in overview." into tm-qpr-dev am: 6db7d31ced
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20413157

Change-Id: I0f9883e153ddb2ab09f17ac3ed453f73ad626496
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-10 19:29:43 +00:00
Vinit Nayak 4b6c05c2ef Merge "Improve Split portrait gesture animation" into tm-qpr-dev am: 2ca82f38e4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20330754

Change-Id: I6cd4962097e2c72762cf28f8c4feb01efa66f22b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-10 19:28:59 +00:00
Saumya Prakash 6db7d31ced Merge "Add padding around clear all button in overview." into tm-qpr-dev 2022-11-10 19:27:53 +00:00
Jeremy Sim 3d0b47a5ea Merge "Allow user to select second split app from Taskbar" into tm-qpr-dev am: d5525c3bda
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20365694

Change-Id: I8d1e153a3d9f2b04293a41a0e008cc348fe028d9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-10 19:25:02 +00:00
Vinit Nayak 2ca82f38e4 Merge "Improve Split portrait gesture animation" into tm-qpr-dev 2022-11-10 19:19:39 +00:00
Jon Miranda f0349354ec Revert "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar.""
This reverts commit e7011d2b87.

Reason for revert: attempt to fix test issues

- Instead of using SharedPrefs which can be flaky anyways,
  we pass along a boolean to test transient taskbar when
  we are in the test harness

Bug: 257549303
Test: TaplTestsTaskbar
Change-Id: I7c15a97363adc377f29853c1fe60b1960c77bfc3
2022-11-10 11:11:14 -08:00
Jeremy Sim d5525c3bda Merge "Allow user to select second split app from Taskbar" into tm-qpr-dev 2022-11-10 18:56:22 +00:00
Saumya Prakash d82fc92b2d Add padding around clear all button in overview.
With different languages, the length of the string "clear all" varies,
leading to the clear all button in overview looking different. This
change adds padding to account for these different lengths to
ensure that users have a consistent experience.

Screenshot for English: https://screenshot.googleplex.com/4oijo96WSfGNwWp.png
Screenshot for Ukrainian: https://screenshot.googleplex.com/Bv2963Vn96BkMeT.png

Test: Manual
Fix: 225119413
Change-Id: I09fe7bc95ca0c2fd7fe620997d1298f2670b50a4
2022-11-09 23:02:12 +00:00
Pat Manning 2335490fe6 Align system navigation setting link in AllSet page for tablets to top/start.
Fix: 233610579
Test: manual
Change-Id: If6d462df02bf795e8a6e73fbb040a6a84ea99404
2022-11-09 13:19:33 +00:00
TreeHugger Robot 10b0703a40 Merge "Add CUJ_LAUNCHER_APP_SWIPE_TO_RECENTS" into tm-qpr-dev am: eaa5703f75
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20339809

Change-Id: Ib8d77e7a1ec40f44b8bccc1dd485c6e10411b616
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-09 13:08:47 +00:00
TreeHugger Robot eaa5703f75 Merge "Add CUJ_LAUNCHER_APP_SWIPE_TO_RECENTS" into tm-qpr-dev 2022-11-09 12:27:25 +00:00
TreeHugger Robot b5c134d72c Merge "Revert "Add TaskbarModeSwitchRule to test both transient/persistent taskbar."" into tm-qpr-dev am: 8dd01f3ac2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20416308

Change-Id: I1c271f89300a0483af71aac53dafebfe7c45429e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-09 01:32:38 +00:00