Commit Graph

12429 Commits

Author SHA1 Message Date
Vinit Nayak 6174106f68 Add Split button in OverviewActions
Shows up only for large screen devices, not phones.
Tested for NexusLauncher, general 3P launcher support
needed for staged split (TODO b/195607777)

Bug: 195423591
Change-Id: I4d455769b17637174b590c640516b9fbb6352c3d
2021-08-26 11:49:38 -07:00
András Klöczl 701c76013c Merge "Two panel home empty page removing logic change" into sc-v2-dev 2021-08-26 11:09:05 +00:00
Andras Kloczl 8c574de97f Two panel home empty page removing logic change
- Don't remove a single page if it's empty, only if both pages are empty.
- Add back empty pages after they were removed while the phone
  was on single panel home.
- On two panel home don't add new workspace items onto the second screen

Test: manual
Bug: 196376162
Change-Id: I4c54ffa3b359a236deb3ab67adb54111e77ec896
2021-08-26 12:06:50 +01:00
Vinit Nayak f1aa726e9f Merge "Fix public variables to not have 'm' prefix" into sc-v2-dev 2021-08-26 00:07:45 +00:00
Android Build Prod User 14a7d63c23 Merge changes I54e39cc5,Iec62abae into sc-v2-dev
* changes:
  Set thumbnails for GroupedTaskView based on split layout bounds
  Implement swipe gesture for staged split in landscape
2021-08-25 20:30:43 +00:00
Android Build Prod User 543bf45c9b Merge "Add feature flag to control two panel home in portrait" into sc-v2-dev 2021-08-25 20:04:40 +00:00
Vinit Nayak aa11976cc5 Fix public variables to not have 'm' prefix
Bug: 181704764
Change-Id: I89e43ce6cc74119514c8124e7cc61b11dc475f58
2021-08-25 11:59:43 -07:00
Vinit Nayak c35507dc29 Set thumbnails for GroupedTaskView based on split layout bounds
Bug: 181704764
Test: Go to stage split in landscape w/
home rotation on/off, swipe up.
Thumbnails aren't perfectly overlaid, polish needed

Change-Id: I54e39cc5a18f527e80a664d60aca72dfd706ebdc
2021-08-25 11:59:00 -07:00
Thales Lima 653ae0a524 Merge "workspace: get the correct page when setting paddings" into sc-v2-dev 2021-08-25 11:54:13 +00:00
Alex Chau b1c36ce938 Add feature flag to control two panel home in portrait
Bug: 197723099
Test: manual
Change-Id: I20d7751e09053dc90c495f398334431f390f64bf
2021-08-25 11:54:08 +01:00
Thales Lima 41f33c3cfd workspace: get the correct page when setting paddings
When adding a new page to the workspace, mWorkspaceScreens doesn't
necessarily keeps the order. We should use the mScreenOrder field to get
 the correct index of pages.

Fixes: 197198491
Test: drag an app from first page and paddings should be correct
Change-Id: I4f79c164391348b53b71a87d5d49cfc4d3d35e5a
2021-08-25 11:16:13 +01:00
Vinit Nayak 8b78c138d4 Implement swipe gesture for staged split in landscape
* Maintain task split percentages when swiping up.
* Split percentages not maintained in GroupedTaskView, however.
That is a TODO.

Bug: 181704764, 181705607
Test: Swiped up in landscape with home rotation on/off.
Portrait still works.

Change-Id: Iec62abae34f6ccadf98e2afdc9409cf3160f8223
2021-08-24 17:32:47 -07:00
Alex Chau 204e749f06 Merge "Revert "Migrating all model tests to Instrumentation tests"" into sc-v2-dev 2021-08-24 17:29:06 +00:00
Alex Chau 7a4a30d86d Revert "Migrating all model tests to Instrumentation tests"
This reverts commit 455ba62b5d.

Reason for revert: Breaks tests on all targets

Bug: 196825541
Bug: 197570389
Change-Id: Ida6792a09c54dee46105b6b914a0dd1545bdf48d
2021-08-24 17:27:52 +00:00
TreeHugger Robot c817d2a633 Merge "Migrating all model tests to Instrumentation tests" into sc-v2-dev 2021-08-23 21:08:51 +00:00
Sunny Goyal 455ba62b5d Migrating all model tests to Instrumentation tests
Bug: 196825541
Test: Presubmit
Change-Id: Iebd46eb41eb46c187d569197f4b97b4fddc0f6f7
2021-08-23 12:34:44 -07:00
TreeHugger Robot a71426811e Merge "Fixing crash when the adapter is no longer available" into sc-v2-dev 2021-08-19 19:00:39 +00:00
Sunny Goyal 8e3a60648a Fixing crash when the adapter is no longer available
Bug: 197176748
Test: trivial change
Change-Id: Ie55a248c1998168c45bfa346186d61d7456ff7fb
2021-08-19 10:26:35 -07:00
TreeHugger Robot 46db057249 Merge "Fix NPE when converting final screen to empty screen." into sc-qpr1-dev am: 70dd01be85
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15583988

Change-Id: Ie6d11b74141ff777b10f05919b9a61f7af809900
2021-08-19 15:43:06 +00:00
TreeHugger Robot 70dd01be85 Merge "Fix NPE when converting final screen to empty screen." into sc-qpr1-dev 2021-08-19 15:30:20 +00:00
Sunny Goyal 177785eccf Moving all widget picker tests to instrumentation tests
Bug: 196825541
Test: Presubmit
Change-Id: I946f29baedb2e6b29044f8df1bc73b74e9999efe
2021-08-18 15:06:53 -07:00
Sunny Goyal 7dcf197821 Merge "Removing widget preview caching" into sc-v2-dev 2021-08-18 16:13:22 +00:00
Lucas Dupin 482f983a7b Add depth to -1 screen
Wallpaper will zoom out as you drag the overlay

Test: manually pull overlay
Fixes: 192502999
Change-Id: I9067b70d10497d4e16a5ef601161fbedfa9307e1
Merged-In: I9067b70d10497d4e16a5ef601161fbedfa9307e1
(cherry picked from commit 87d752062e)
2021-08-18 15:34:45 +00:00
TreeHugger Robot a7f7c4b432 Merge "Logging for Nexus home activity appearing after to-home gesture in L3." into sc-v2-dev 2021-08-18 11:19:26 +00:00
Alex Chau 2683bd7728 Merge "Support different task icon margin for grid tasks" into sc-v2-dev 2021-08-18 08:41:42 +00:00
TreeHugger Robot 04c4f94223 Merge "Fixing ModelPreload cancelling existing load" into sc-qpr1-dev am: 8782ad4f99
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15524186

Change-Id: Ib89cd2bbe854242c87f52d2edc384ae864af01c2
2021-08-18 05:21:30 +00:00
TreeHugger Robot 8782ad4f99 Merge "Fixing ModelPreload cancelling existing load" into sc-qpr1-dev 2021-08-18 05:09:49 +00:00
vadimt bc79473313 Logging for Nexus home activity appearing after to-home gesture in L3.
Utilities.IS_RUNNING_IN_TEST_HARNESS is used as a condition
for logging in the background NexusLauncher where sDebugTracing is
not set.

Bug: 192018189
Test: presubmit
Change-Id: Ib08656a12c778b7bf968532e3ba899a03031fd7b
2021-08-17 18:13:50 -07:00
Sunny Goyal ed2a55f413 Removing widget preview caching
> All previews are generated on demand when the corresponding
  header expands
> Using ItemAnimator to animate layout changes when preview loads

Bug: 196238313
Test: Manual
Change-Id: I0cb859c8443c2c536399e4063f58baecfc7416ad
2021-08-17 17:50:30 -07:00
Vinit Nayak ca1d523734 Merge "Add GroupedTaskView for gestures in staged split." into sc-v2-dev 2021-08-17 23:26:53 +00:00
Vinit Nayak 17c4b33db6 Add GroupedTaskView for gestures in staged split.
* Currently only works for portrait 50/50 split
* Have gesture swipe animation flow use multiple
TaskViewSimulators, one for each app in split
* Added new APIs in shell to query for actively running
tasks to determine if we're in split screen
* Lots of UI polish needed during gesture
* Launching into staged split after live tile ends
not implemented yet.

Bug: 181704764
Change-Id: Ib90e99e1e10b19121e8709385e1334b9380d6502
2021-08-17 13:46:43 -07:00
TreeHugger Robot 54ce7e6cf8 Merge changes I2cc102d7,Ifba9aa59 into sc-v2-dev
* changes:
  Only show Taskbar Edu once (first time an app is opened).
  Adds initial Taskbar Edu implementation.
2021-08-17 19:13:31 +00:00
Nick Chameyev caa713bc1a Merge "Add quick search bar width unfold animation" into sc-v2-dev 2021-08-17 17:58:50 +00:00
Alex Chau eaa6d682d4 Support different task icon margin for grid tasks
- Focused and non focused grid now have differnt margin between icon and snapshot
- The overall margin above snapshot is still the same
- Invoke updateChildTaskOrientations when focus task changes to update the margin
- Also lowered the row spacing according to spec

Bug: 194194694
Test: manual
Change-Id: I25267bef19d5a8b1dc1cf96fc1babdc3ebc39330
2021-08-17 18:33:21 +01:00
Andy Wickham b8eac86b63 Only show Taskbar Edu once (first time an app is opened).
Bug: 180605356
Test: Manual
Change-Id: I2cc102d7ce36e0b1c2c75482e2bbb97218618e61
2021-08-17 09:57:55 -07:00
Andy Wickham 13f3ffed95 Adds initial Taskbar Edu implementation.
Currently it just pops up with one placeholder image for splitscreen.
The Next button doesn't do anything.

Screenshots:
Light: https://screenshot.googleplex.com/B27CwBcwobHTghN.png
Dark: https://screenshot.googleplex.com/48EuJZv8evd5RGW.png

Known issues:
 - Back gesture is picked up behind by the app behind the taskbar.
 - When the flag is enabled, the Edu shows up each time you open
   an app, rather than only the first time.

Bug: 180605356
Test: Manual
Change-Id: Ifba9aa59abf1501b5f8ddebb3fcc13df85f6efaa
2021-08-17 09:57:47 -07:00
Nick Chameyev 4ba48cdb8b Add quick search bar width unfold animation
Adds unfold animation to quick search bar in launcher
which changes the width of the quick search bar
from 70% to 100%.

Bug: 193795041
Test: manual
Change-Id: I8c55ca1cc5b5894847503beac8ecd8adec3e5674
2021-08-17 16:58:57 +01:00
Tony Wickham 40f86763bc Merge changes from topic "taskbar-crop-tasks" into sc-v2-dev
* changes:
  Extend taskbar color to entire screen in overview
  Use WindowBounds#insets instead of WindowInsets in DeviceProfile
2021-08-17 14:52:50 +00:00
Alex Chau dc57b06e29 Merge "Remove widget panel" into sc-v2-dev 2021-08-17 08:48:26 +00:00
Tony Wickham 635e180e56 Extend taskbar color to entire screen in overview
Only when taskbar is unstashed in apps:
- Scrim workspace with the taskbar color when opening apps and in BackgroundAppState
- Crop opening apps to above the taskbar
- Crop TaskViews to above the taskbar during gestures

If taskbar is stashed in apps, behavior is the same as before, i.e. no scrim over the wallpaper and no cropping of tasks.

Added a field DeviceProfile#taskbkarPresentInApps to distinguish these cases. LauncherTaskbarUIController and TaskbarStashController ensure this value is set appropriately.

Test: Ensure tasks don't appear behind taskbar when it's unstashed; set ENABLE_SCRIM_FOR_APP_LAUNCH = true to test the whole screen scrimming when opening an app

Bug: 196257194
Fixes: 190681228
Change-Id: I481501457a5a6d49c380feea3db3b4058e4cf3f8
2021-08-16 16:50:52 -07:00
Tony Wickham f5ce2f624d Use WindowBounds#insets instead of WindowInsets in DeviceProfile
This reports more consistently and is cheaper.

Test: Log windowBounds.insets.bottom vs windowInsets.getSystemWindowInsetBottom() and note that the former is correct after fold/unfold even though the latter starts reporting 0
Bug: 196874770
Change-Id: I41eb0ab51d3761a988e680cd6d61e40bcacf567f
2021-08-16 16:45:12 -07:00
Sunny Goyal 48b012b148 Merge "Fixing header jump" into sc-v2-dev 2021-08-16 18:20:00 +00:00
Jon Miranda 26de7be984 Fix NPE when converting final screen to empty screen.
Bug: 194553613
Test: manual
Change-Id: Id29b8574964688f6f6aa96dd5b1b8a4d8b9110c0
2021-08-16 16:47:11 +00:00
Sunny Goyal 77acf12905 Fixing header jump
Linking header position to an empty entry in the recyclerView,
instead of calculating the vertical scroll position. This
allows the header to be in sync with the recyclerView scroll and
item animations

Other simplifications:
> Moving top collapse handle out of header view (it doesn't scroll)
> Removing background clipping logic from full-sheet
> Moving tab bar inside the header view

Bug: 196464142
Test: Verified on device
Change-Id: Iae5a0ae9af7ce258e1b391b8e85c5c270fe56197
2021-08-16 09:45:14 -07:00
Alex Chau 1e4484669d Remove widget panel
- Remove all usage of LEFT_PANEL_ID and fixed left panel code
- For preview renderer, load screen 0 + screen 1 instead
- Added a split display specific default workspace layout, with a placeholder app to pass test before we implement page pairing(b/196376162)
- Known issue: If screenId 1 is deleted, right panel will disappear from Wallpaepr & Style because there is no screenId 1. Will be resovled after page pairing(b/196376162)

Bug: 175939730
Test: manual and TaplTestsLauncher3#testWorkSpace
Change-Id: Icac1c94165c14a49c17897c45355b6cdc4d87e91
2021-08-13 21:48:35 +01:00
Alex Chau 0cba30e990 Merge "launcher: hide grid options for foldables" into sc-v2-dev 2021-08-13 20:44:34 +00:00
TreeHugger Robot f952fd9256 Merge "launcher: correct the amount of padding for preview" into sc-v2-dev 2021-08-13 19:19:18 +00:00
Thales Lima dab1b2922c launcher: correct the amount of padding for preview
The padding on left and right should be added only on the left for left
page and only on the right for right page.

Fixes: 195410512
Test: open Wallpaper & Style and check the space between the pages
Change-Id: Ib27c632d2fb07d4708bd101e555e14e31a26ff9d
2021-08-13 18:22:26 +01:00
Thales Lima 7ec8382044 launcher: hide grid options for foldables
Some grid options are too dense for foldables (those with 5 icons), so
we are hiding them on those devices.

This also move the parsing to be done on InvariantDeviceProfile only.

Fixes: 183140646
Test: open Wallpaper & style and change app grid options
Change-Id: I771571db02709db5d0f814236060c57ce0180cd1
2021-08-13 16:07:05 +00:00
Sunny Goyal 57e0866fdd Fixing ModelPreload cancelling existing load
When a model preload call was made while the loader task is running
(eg: on enabling/disabling icon theme, Launcher reloads and then
launcher preview start a model-preload), it would cancel the original
loader and then start a new loader with empty callbacks. So the
model indeed get loaded, but the original callbacks never got notified
of it.

> Instead we only start preload if an existing task is not running.
> Also when preloading, we use existing callbacks, instead of using
  empty callbacks

Bug: 193851085
Bug: 195155924
Test: Verified repro steps
Change-Id: I0a96310be8489756f364aa2a12e4345e1418733d
2021-08-12 21:33:33 +00:00