Commit Graph

4642 Commits

Author SHA1 Message Date
Min Chen 31f5e79ffd Merge "Fix integration tests with multi-desks on" into main 2025-04-28 16:44:30 -07:00
Priyanka Advani (xWF) 9d5903bb10 Merge "Revert "Restrict nav mode UI checks within primary display"" into main 2025-04-28 12:18:34 -07:00
Priyanka Advani (xWF) 9d7b814eec Revert "Restrict nav mode UI checks within primary display"
This reverts commit 3ccfdbf6c4.

Reason for revert: Droidmonitor created revert due to Jank regression b/413244466.

Change-Id: I09276810e3611b54526ed3d2af7a35949a412b0c
2025-04-28 09:13:46 -07:00
Pat Manning edaab56ed6 Merge "Cancel ongoing dismiss animation when Launcher state changes." into main 2025-04-28 05:14:24 -07:00
Pat Manning 9fd78aa76d Merge "Drag tasks from center when perfoming dismiss cancel for tests." into main 2025-04-28 04:08:39 -07:00
Pat Manning 9ee290e81f Cancel ongoing dismiss animation when Launcher state changes.
Fix: 410744889
Test: Manual
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I5e81de6762e7d0ea47f8574599901aac1bb8bb77
2025-04-28 10:27:29 +01:00
minch 4e3d48e998 Fix integration tests with multi-desks on
Bug: 362720309
Test: Presubmit
Flag: EXEMPT tests failure fix
Change-Id: I381b8751083a7fb235cf597fd35314ca6f2c0a9b
2025-04-26 15:59:18 +00:00
Pat Manning 8eeaa6009c Drag tasks from center when perfoming dismiss cancel for tests.
Follow up to Change-Id: I14f3012973ddee0d850db5de284a0efde6122d2c

Fix: 412766455
Test: TaplTestsQuickstep#dismissCancel
Flag: EXEMPT bugfix.
Change-Id: Idcf17fe810a935c325d043519d2b8d216b3f5c13
2025-04-25 16:12:32 +01:00
Treehugger Robot b6f127d82c Merge "Make Tapl check if actions view is enabled on overview" into main 2025-04-24 03:12:55 -07:00
Treehugger Robot 59e208c28e Merge "Moving various launcher binding logic, outside LauncherModel" into main 2025-04-23 12:32:54 -07:00
Treehugger Robot ab4794a638 Merge "Fixing crashes due to code 1032 SQLITE_READONLY_DBMOVED" into main 2025-04-23 12:31:46 -07:00
Sunny Goyal 3678af5a81 Fixing crashes due to code 1032 SQLITE_READONLY_DBMOVED
1) Moving any DB file deletion before opening the DB to avoid deleting already opened file
2) Using a sandbox directory for BackupAndRestoreDBSelectionTest which can delete actively opened files causing other tests to fail

Bug: 403551539
Flag: EXEMPT bugfix
Test: Presubmit
Change-Id: Ib1088a0e486edf755e5f7dcd738eb835af78b4c4
2025-04-22 16:09:52 -07:00
Sunny Goyal c078d6554c Moving various launcher binding logic, outside LauncherModel
This brings the BgCallbacks closer to a repository pattern making is easier to switch eventually

Bug: 390572144
Flag: EXEMPT refactor
Test: Updated AsyncBindingTest to use real ModelCalbacks
Change-Id: I9c932b00ea8ac7330473b9c0f5d778453fe7a390
2025-04-22 14:12:17 -07:00
Sam Cackett e8628ac605 Make Tapl check if actions view is enabled on overview
Bug: 391276638
Flag: EXEMPT. Bugfix
Test: TaplTestsQuickstep
Change-Id: Ib167cc89244b34471a7bd84d6958ee4d2f006e51
2025-04-22 07:43:23 -07:00
Toshiki Kikuchi 3ccfdbf6c4 Restrict nav mode UI checks within primary display
This CL fixes the nav mode UI checks which currently assumes “navigation
mode” takes effect on all displays although the mode is only effective
on the primary display.

Flag: EXEMPT - test fix
Fix: 408631713
Test: atest WMShellFlickerTestsDesktopMode:com.android.wm.shell.flicker.OpenAppWithExternalDisplayConnected
Change-Id: I29f33957d696e9d5afda844f69388b74a8f78b77
2025-04-20 19:09:38 -07:00
Sebastián Franco 8c96a1528c Merge "Adding screenrecord for IntegrationReorderWidgetsTest" into main 2025-04-18 11:38:20 -07:00
Sunny Goyal 54e5ed0d36 Creating a dumpmanager class to allow dumping state from singleton objects
Bug: 410927105
Flag: EXEMPT refactor
Test: atest DumpManagerTest
Change-Id: Idcd1c74b1edf7a79ec8e4fa91676e617afa04907
2025-04-17 11:05:20 -07:00
Treehugger Robot 2711f8d0d9 Merge "Removing flag enable_smartspace_removal_toggle" into main 2025-04-16 18:57:40 -07:00
Jeff DeCew 9593f2b612 Merge "Set shouldForceThemeIcon = true in ThemeManager" into main 2025-04-16 18:16:17 -07:00
Sunny Goyal 613db2b609 Removing flag enable_smartspace_removal_toggle
Test: Presubmit
Flag: EXEMPT cleanup
Bug: 303471576
Change-Id: Iae8cc3afbf15c66612589fd1e19377e4339af7fc
2025-04-16 10:54:45 -07:00
Treehugger Robot a9bb3b53a5 Merge "Adds Blur and BlurFallback styles for All Apps." into main 2025-04-16 10:21:48 -07:00
Sebastián Franco 95aa4a3267 Merge "Revert "No-op change, remove methods from BaseLauncherActivityTe..."" into main 2025-04-16 09:58:09 -07:00
Ioana Alexandru a58f02bcec Set shouldForceThemeIcon = true in ThemeManager
This is now preferred over a boolean config value.

Bug: 406507218
Test: manual
Flag: EXEMPT minor change
Change-Id: I3c6f359d7eb78784ea4c9a9f462bc6a6f1914bb6
2025-04-16 09:03:13 +02:00
Andy Wickham 16a024df71 Adds Blur and BlurFallback styles for All Apps.
Technically these styles can be used throughout Launcher, e.g.
Widget Picker and Folders, but this CL only applies it to All Apps.

At a high level, views wishing to apply transparency to show blur
should use these new attr values rather than colors directly.

When blur changes, e.g. starting or stopping battery saver, the
style is re-applied and revelant views are invalidated. For
Launcher, this is handled by DepthController, and for Taskbar it's
handled by a CrossWindowBlurListener.

Also updated the Private Space animation slightly to account for
the translucent decorators (specifically, we can't use the mask
view to cover them when blur is enabled).

Screenshots: https://drive.google.com/drive/folders/1tU472KHotgEBpT-Ec9VOBWPBf_YdVqv2?resourcekey=0-ebf7W8O6iDJ4UVMtRzTABg&usp=sharing
Private Space animations: https://drive.google.com/file/d/1h5pn8Xb17TPcbujr7uSAJNTq8kwNZoIp/view?usp=drive_link&resourcekey=0-TzpaJ16Gg8_QJctBx4oiIg
Private Space QS Tile animations: https://drive.google.com/file/d/1dCuqnqd5z2kSBEakGobMlEkMwFDBWRbJ/view?usp=drive_link&resourcekey=0-qRVFPb-a6OzaZQOf4x86Jw

Bug: 371343636
Test: Manual
Flag: com.android.launcher3.all_apps_blur
Change-Id: Ia9f581f50d1adc0830569656bdeb751deb710a9c
2025-04-15 16:42:56 -07:00
Sebastián Franco a746ec8aa4 Revert "No-op change, remove methods from BaseLauncherActivityTe..."
Revert submission 32999330-activity-test-refactor-1

Reason for revert: b/410713970

Reverted changes: /q/submissionid:32999330-activity-test-refactor-1

Change-Id: Id9dd4692bc5c500fd8831a2edad80a034c4fa405
2025-04-15 15:55:35 -07:00
Treehugger Robot 0aa937de1a Merge "Enforce a mutex in all remote tapl tests" into main 2025-04-15 14:52:13 -07:00
Treehugger Robot 14a18dbf9b Merge "Fix launcher tests in studio" into main 2025-04-15 13:05:00 -07:00
Dave Mankoff 396d69956b Fix launcher tests in studio
Fixes: 410874290
Flag: EXEMPT small fixes for gradle
Test: test_gradle_build.sh
Change-Id: Iab8ad757d11e1d0ba5f85a7063e2d087ffc38d2b
2025-04-15 19:05:48 +00:00
Schneider Victor-Tulias d079748134 Enforce a mutex in all remote tapl tests
Flag: EXEMPT test fix
Fixes: 405849365
Test: TAPL tests; pre/postsubmit
Change-Id: Icf5b3c6b43b4d8ecc39246f3eb03e32738af7444
2025-04-15 15:05:26 -04:00
Adnan Begovic ee79e0f5d2 launcher3: Use @UiExecutor within ThemeManager.
Use the provided @UiExecutor within the ThemeManager
instead of referencing the MAIN_EXECUTOR directly.

Bug: 407593767
Test: ThemeManagerTest
Flag: NONE - new module
Change-Id: I6359adc1308bdb209dcf6c6e1c2d3fc7f4438585
2025-04-15 09:04:44 -07:00
Sebastián Franco 526d80a550 Merge "No-op change, remove methods from BaseLauncherActivityTest into Utilities" into main 2025-04-14 16:21:19 -07:00
Sebastian Franco d330fdce3a Adding screenrecord for IntegrationReorderWidgetsTest
Bug: 408279425
Flag: EXEMPT bug fix
Test: IntegrationReorderWidgetsTest
Change-Id: I302a35304a145f90d7d49f93044787350c466ad1
2025-04-14 13:56:48 -07:00
Sebastian Franco c08c7de5e3 No-op change, remove methods from BaseLauncherActivityTest into Utilities
Bug: 324261526
Test: all test that inherit BaseLauncherActivityTest
Flag: TEST_ONLY
Change-Id: I0851373d179f064721a3a618853a05796cc1379f
2025-04-14 13:38:20 -07:00
Brandon Dayauon e42fd21462 Merge "Update Tapl test for Private Space Add button" into main 2025-04-14 13:07:21 -07:00
Brandon Dayauon 3759f1428b Update Tapl test for Private Space Add button
See artifact: https://android-build.corp.google.com/test_investigate/invocation/I00100010386298382/test/TR74629693245670294/?itab=tests&ttab=artifacts

When aconfig flag is moved to staging the button is now "Add" rather than "Install" which will need to fix.

bug: 360313403
Test: presubmit
Flag: android.multiuser.enable_moving_content_into_private_space
Change-Id: I3a3e658d1a9d2b9d0795b5cef5d062ddfbe2b8ba
2025-04-14 10:38:10 -07:00
Sunny Goyal 040ff3a7bf Adding HomeScreenRepo to expose homescreen data as repository
Bug: 390572144
Test: Presubmit
Flag: com.android.launcher3.model_repository
Change-Id: If82a388a44d7a9c448f6eb4901c2acdb508ccfdc
2025-04-11 13:28:08 -07:00
samcackett 2244b633cc Add TaskContentView wrapper to TaskThumbnailView
- Keep TaskThumbnailViewDeprecated as-is
- Due to flag guarding and xml changes, added bottomright_snapshot id
- Remove redundant FrameLayout from task_header_view.xml and refactor
the view to handle alignment correctly
- Move feature flag logic to the state mapper
- Extract TaskThumbnailViewHeader logic and any related state out of
TaskThumbnailView and move to TaskContentView
- Use vertical LinearLayoutManager to hold the TaskThumbnailViewHeader
and TaskThumbnailView
- Rename TaskThumbnailViewHeader to TaskHeaderView. Rename xml and state
 similarly

This reverts commit df6dc455a7.
This reverts commit 714370a9bfb2e53738b0cd9958acd6540d8d649c.

Reason for revert: Reland previously reverted CL's with fixes

Fix: 408971730
Fix: 397889146
Fix: 401469907
Fix: 402277471
Fix: 403826044
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: TaskUiStateMapperTest & TaskContentViewScreenshotTest & TaskThumbnailViewScreenshotTest & TaskHeaderViewScreenshotTest & SwitchBetweenSplitPairsGesturalNavPortrait
Change-Id: I01758447ad1194ebbeab748113621b42f3384db8
2025-04-09 16:36:51 +01:00
Sebastián Franco 59ae5808c7 Merge "Use LauncherActivityScenarioRule in BaseLauncherActivityTest" into main 2025-04-08 15:28:11 -07:00
Treehugger Robot 3dd0f30ac5 Merge "Remove 5x grid from canBeDefault grids" into main 2025-04-08 09:35:20 -07:00
Federico Baron eec1d1d8f9 Remove 5x grid from canBeDefault grids
Bug: 407819792
Test: manual test
Flag: com.android.launcher3.one_grid_specs
Change-Id: I77c2fddc470d0dbaa6fc248ec30a5dbd4a86e0c2
2025-04-07 23:20:02 +00:00
Pat Manning f6ee091c9c Merge "Dismiss tasks from center of task, not bottom." into main 2025-04-04 07:26:26 -07:00
Pat Manning a1e23ded55 Dismiss tasks from center of task, not bottom.
Overview shows tooltip the first time it is opened, which blocks the bottom of the task, preventing the touch. By dismissing from the center of the task, we avoid this.

Bug: 403883013
Test: DismissTaskFromOverview#testDismissCurrentTaskFromOverview
Flag: EXEMPT bugfix
Change-Id: I14f3012973ddee0d850db5de284a0efde6122d2c
2025-04-04 07:25:45 -07:00
Charlie Anderson e3defaa8e6 Merge "Update folder previews to new specs" into main 2025-04-04 00:02:52 -07:00
Charlie Anderson 6f5f8cac25 Update folder previews to new specs
Bug: 403616844
Flag: com.android.launcher3.enable_launcher_icon_shapes
Test: visually comparing against spec

Change-Id: I671b3de7d4ac574122ee3a33451f6cb1d6155f29
2025-04-03 16:42:35 -07:00
Sebastian Franco 089f07c2b6 Use LauncherActivityScenarioRule in BaseLauncherActivityTest
The goal is that eventually remove BaseLauncherActivityTest and
uase LauncherActivityScenarioRule by compositions instead of
using inheritance and move methods that make sense to have in
LauncherActivityScenarioRule and other in utility classes.

Bug: 324261526
Test: All Tests that inherit from BaseLauncherActivityTest
Flag: TEST_ONLY
Change-Id: I1b2f3ed9e9d41a9185711ba682895b0b3fffe2df
2025-04-03 15:35:20 -07:00
Jordan Silva f0d253ef9d Merge "Remove unused overviewActionsButtonSpacing from DeviceProfile" into main 2025-04-03 13:48:07 -07:00
Jordan Silva 17fd5f13f4 Remove unused overviewActionsButtonSpacing from DeviceProfile
Bug: 404479758
Flag: EXEMPT. Clean-up code.
Test: DeviceProfileDumpTest
Test: DeviceProfileAlternativeDisplaysDumpTest
Test: DeviceDefaultGridTest
Change-Id: Ieb9ec81f82e80d293f04de71d5c2575a4ce50301
2025-04-03 10:18:23 -07:00
Pat Manning cb855eeeaf Fling cancel at same rate as fling so it is detected by touch controller.
Fix: 396447643
Test: TaplTestsQuickstep#testDismissCancel
Flag: EXEMPT bugfix
Change-Id: I1cf3ae6944d4765b54b78a86d4a81af1ed81e661
2025-04-01 09:33:49 -07:00
Sunny Goyal 50884dadfe Lazily loading theme icons
Theme icons are generated and stored in cache, but only loaded if requested in lookup flags
This allows to keep the memory usage low, but not loading theme icons for all the apps

Bug: 381897614
Flag: com.android.launcher3.extendible_theme_manager
Test: Updated tests
Change-Id: I494eab9c4f70670e6f5aeb864ed5287f6b9f1b9e
2025-03-31 13:07:03 -07:00
Uwais Ashraf 207d5fa3b5 Merge "Remove flag rule to turn off one grid in all image tests" into main 2025-03-30 14:11:59 -07:00