PawletOS/Lawnchair
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
63,237 Commits 1 Branch 0 Tags
b79fa567c5fa54dad072165e89ecfbd098d7e5a3
Commit Graph
15139 Commits
Author SHA1 Message Date
Colin CrossandAutomerger Merge Worker ae14bc26e2 Fix kotlin nullable errors in Launcher3 am: 4cc251e6c1 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24406718

Change-Id: Id52bac704d54d31eafda8c8b648a576ab56617c8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-14 19:00:56 +00:00
Colin Cross 4cc251e6c1 Fix kotlin nullable errors in Launcher3 
Fix kotlin nullable errors that were exposed by setting the retention
of android.annotation.NonNull and android.annotation.Nullable to
class retention.

This relands I26edfec35dca14abe90b08e3c74de0446eda95d2 with a fix in
SplitSelectDataHolder.kt to call createPackageContext when user is null
instead of asserting that it is not null.

Bug: 294110802
Test: builds
Test: WMShellFlickerServiceTests
Change-Id: I4525d0fa83a1db9cc5cff90f340fc3f863537c01
Merged-In: I4525d0fa83a1db9cc5cff90f340fc3f863537c01
 2023-08-11 11:29:10 -07:00
Colin CrossandAutomerger Merge Worker 4b5bfb7096 Fix kotlin nullable errors in Launcher3 am: 2608381792 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24392740

Change-Id: Ia6fd37aa0a437da84b5b3108b49f0e9edb95a794
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-11 05:20:53 +00:00
Colin Cross 2608381792 Fix kotlin nullable errors in Launcher3 
Fix kotlin nullable errors that were exposed by setting the retention
of android.annotation.NonNull and android.annotation.Nullable to
class retention.

Bug: 294110802
Test: builds
Change-Id: I26edfec35dca14abe90b08e3c74de0446eda95d2
Merged-In: I26edfec35dca14abe90b08e3c74de0446eda95d2
 2023-08-10 11:16:17 -07:00
Sunny GoyalandAutomerger Merge Worker adfbec8d4e Merge "Log appear animation's scale factor" into udc-dev am: 7a080a7e0f am: 0b1089978f 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24154592

Change-Id: I23624392e6bcde0f97ee4302c75a6e5b7f3fa671
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-04 21:03:39 +00:00
Sunny GoyalandAutomerger Merge Worker 0c5ddeb3af Merge "Log appear animation's scale factor" into udc-dev am: 7a080a7e0f 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24154592

Change-Id: Id507b9d9faf1c209e11fcf7ece9d87119cf9d4f4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-04 20:44:28 +00:00
Sunny GoyalandAutomerger Merge Worker 0b1089978f Merge "Log appear animation's scale factor" into udc-dev am: 7a080a7e0f 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24154592

Change-Id: Ibf1f54176e73578fc9cd1cc2510022e3c6a84237
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-04 20:39:57 +00:00
Sunny GoyalandAndroid (Google) Code Review 7a080a7e0f Merge "Log appear animation's scale factor" into udc-dev 2023-08-04 20:13:43 +00:00
Bill Yi 39e9688873 Import translations. DO NOT MERGE ANYWHERE 
Auto-generated-cl: translation import
Change-Id: Ic65ee5796da63c3999571e23307fffec332bebfe
 2023-08-03 21:56:20 -07:00
Fengjiang Li 2303acd7d4 Log appear animation's scale factor 
Test: Grabbed a bug report b/291974797
Flag: N/A
Bug: 290320302
Change-Id: Ic33dc94806b838a03a2203bdd5701a1eeaeeb7bf
Merged-In: Ic33dc94806b838a03a2203bdd5701a1eeaeeb7bf
 2023-08-03 14:25:00 -07:00
Treehugger RobotandAndroid (Google) Code Review 2234a8252d Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-d1-dev 2023-08-03 00:02:58 +00:00
Sunny GoyalandAutomerger Merge Worker 644d85ad0d Merge "[Unfold animation] Do not preemptively start the animation if it has run already" into udc-dev am: 343b896081 am: 9e10ffc553 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23447960

Change-Id: I9587890282eacc4cb29f626591aefedad9078208
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-02 22:00:22 +00:00
Sunny GoyalandAutomerger Merge Worker 85d1a1cea1 Merge "[Unfold animation] Do not preemptively start the animation if it has run already" into udc-dev am: 343b896081 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23447960

Change-Id: I7fa7f4ae8e69f8ae07f1b38053d2f738c2e35726
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-02 21:35:37 +00:00
Sunny GoyalandAutomerger Merge Worker 9e10ffc553 Merge "[Unfold animation] Do not preemptively start the animation if it has run already" into udc-dev am: 343b896081 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23447960

Change-Id: I38c903a70bb637d78403a29a468d6722269553dd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-08-02 21:34:25 +00:00
Bill Yi 22c51bf135 Import translations. DO NOT MERGE ANYWHERE 
Auto-generated-cl: translation import
Change-Id: I289e821ff4b091ffa506a3176f27a884e0c1dde3
 2023-08-02 14:18:50 -07:00
Nick ChameyevandNicolò Mazzucato 2e53f5ef97 [Unfold animation] Do not preemptively start the animation if it has run already 
Currently if we open an app, unfold the device and then go to home
screen we will start the unfold animation preemptively in Launcher
because Launcher activity will receive updated configuration change
(where isTablet = true) only after going back to home screen, not
when unfolding the device.

This causes a problem because SystemUI won't send the unfold animation
events after going back home as the animation has already run, so we
end up with wrongly started animation in Launcher.

This CL fixes the issues by checking if SystemUI has finished the
animation (or if it is currently running) to avoid preemptive animation
start in this case. This is done by subscribing to the original
unfold transition progress provider which emits progress events
sent through IPC from SystemUI.

Bug: 285150685
Bug: 293131586
Test: open an app on folded screen, unfold, go to home screen =>
  check that icons are not squished
Test: fold/unfold when launcher is open
Change-Id: Ic437ff4d19cbd5764635f3007d99880622150f5b
Merged-In: Ic437ff4d19cbd5764635f3007d99880622150f5b
(cherry picked from commit 6d756970e7)
 2023-08-02 11:41:53 +00:00
Bill Yi efdab72c00 Import translations. DO NOT MERGE ANYWHERE 
Auto-generated-cl: translation import
Change-Id: I4e2edca61ed43c235d0ad175d9c763f137a1858d
 2023-07-26 07:58:46 -07:00
randypfohlandAutomerger Merge Worker 3998e16bba Removing obsolete call to start home activity with shell transitions am: 2b3dc6f730 am: d6091ac2d7 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24156953

Change-Id: I2a4c7683a2aa80c9c151943b8abc3af76b87261d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-25 20:04:36 +00:00
randypfohlandAutomerger Merge Worker d6091ac2d7 Removing obsolete call to start home activity with shell transitions am: 2b3dc6f730 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24156953

Change-Id: If35e00543826daa19eefa2045105561817d3c494
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-25 19:11:58 +00:00
randypfohlandAutomerger Merge Worker b947238a9e Removing obsolete call to start home activity with shell transitions am: 2b3dc6f730 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24156953

Change-Id: Ife4db9cda8ecd85ee21e51575a7bc24c37882ee7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-25 19:07:48 +00:00
randypfohlandWinson Chung 2b3dc6f730 Removing obsolete call to start home activity with shell transitions 
- The second start activity was causing issues with 3p launchers which
  may not expect another new intent (ie. if it handles gestures at
  the bottom of the screen).  We can't completely remove this logic
  because for button navigation we don't want to fall through to the
  launch-next-task animation below, but we can can continue to
  finish the recents animation immediately.
- With shell transitions, leashes for opening apps are always hidden
  by default so when transitioning to a 3p launcher from
  RecentsActivity we also need to show the surface if we want to
  animate it in

Bug: 289609734
Test: Set 3p Launcher as default, in both gesture & button navigation
      - Go from 3p home -> overview, then overview -> 3p home
      - Go from app -> 3p home
      - Go from app -> overview, then overview -> 3p home
      - Quickswitch from app

Change-Id: I6875083931de63a8097d23d180553885ed7cfb01
Signed-off-by: Winson Chung <winsonc@google.com>
 2023-07-21 04:20:29 +00:00
Bill Yi 877e7fe5ef Import translations. DO NOT MERGE ANYWHERE 
Auto-generated-cl: translation import
Change-Id: I8ad0866b24b4f2bc66cc943681fbbb54c69485c4
 2023-07-20 17:23:58 -07:00
Bill Yi 31855be8d4 Import translations. DO NOT MERGE ANYWHERE 
Auto-generated-cl: translation import
Change-Id: I3dc01f06b2302cea0b5435a745e0e96c8a465bea
 2023-07-18 11:56:05 -07:00
Bill YiandAndroid (Google) Code Review 112ba79d1b Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-d1-dev 2023-07-14 19:56:06 +00:00
Treehugger RobotandAutomerger Merge Worker 6f59fcc079 Merge "[a11y] Fix crash when using talkback to add to home screen." into udc-d1-dev am: 2a749f1e60 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23877939

Change-Id: I1723336f35a1bc75ef29743c02e8437b6959242d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-14 18:20:13 +00:00
Treehugger RobotandAndroid (Google) Code Review 2a749f1e60 Merge "[a11y] Fix crash when using talkback to add to home screen." into udc-d1-dev 2023-07-14 17:49:46 +00:00
Bill Yi 0835d8178d Import translations. DO NOT MERGE ANYWHERE 
Auto-generated-cl: translation import
Change-Id: I30cabeea6af5c4f7469baa1b10051c0f546786ac
 2023-07-13 19:56:50 -07:00
Schneider Victor-tuliasandAutomerger Merge Worker 5a96798f21 Merge "Handle onFlingFinished onRecentsAnimationStart" into udc-dev am: 3d1e78a496 am: ea547ecb4a 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23796565

Change-Id: I50091bfa0af884e3990c939af5e576fcab511bc9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-10 19:49:36 +00:00
Schneider Victor-tuliasandAutomerger Merge Worker abf59f658c Merge "Handle onFlingFinished onRecentsAnimationStart" into udc-dev am: 3d1e78a496 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23796565

Change-Id: I65672b6fdd803cd1f7d6ed069b3a254a2c85b8c0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-10 19:08:49 +00:00
Schneider Victor-tuliasandAndroid (Google) Code Review 3d1e78a496 Merge "Handle onFlingFinished onRecentsAnimationStart" into udc-dev 2023-07-10 18:33:25 +00:00
Bill YiandAndroid (Google) Code Review 039df45c67 Merge "Import translations. DO NOT MERGE ANYWHERE" into udc-dev 2023-07-08 17:48:12 +00:00
Winson ChungandAutomerger Merge Worker 1108507fcb Merge "Fix an issue with nav bar translations not being updated" into udc-dev am: a53261b9cd am: a8e08175ad 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23923806

Change-Id: Ie3fb097de6ced28d239dc129b10335e0b10448bd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-07 19:59:08 +00:00
Winson ChungandAutomerger Merge Worker 3537a91808 Ignore recents transition if there are no closing tasks am: 6f7e15ff64 am: b06c5f7a2b 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23909000

Change-Id: If676c1f88a4bab7299fca8d97a0d33090accb269
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-07 19:58:56 +00:00
Winson ChungandAutomerger Merge Worker e4b98ea44d Merge "Fix an issue with nav bar translations not being updated" into udc-dev am: a53261b9cd 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23923806

Change-Id: Ifc99248dda1a45f3034a80ddca47e8dcc506cd3a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-07 19:20:03 +00:00
Winson ChungandAutomerger Merge Worker 38e763613b Ignore recents transition if there are no closing tasks am: 6f7e15ff64 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23909000

Change-Id: I25d6e8f6b1cadf1a102980258dd5842f4e7277b9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-07-07 19:19:53 +00:00
Winson ChungandAndroid (Google) Code Review a53261b9cd Merge "Fix an issue with nav bar translations not being updated" into udc-dev 2023-07-07 18:33:16 +00:00
Bill Yi 14d76c5fe6 Import translations. DO NOT MERGE ANYWHERE 
Auto-generated-cl: translation import
Change-Id: I1527753aecdfc71c57ef5ba94e62fe7426b1442e
 2023-07-06 22:40:58 -07:00
Winson Chung ccd359d76c Fix an issue with nav bar translations not being updated 
- There are flows where the shared taskbar state is updated prior
  to being destroyed, and not updated to the latest values when
  the taskbar is recreated.

  ie.
    unfolded -> lock screen -> LauncherTaskbarUiController's
      mTaskbarInAppDisplayProgress[SYSUI_SURFACE_PROGRESS_INDEX]
      is set to 1 due to the notif shade (lockscreen) showing.
      This is written into TaskbarSharedState's sysuiStateFlags
      and inAppDisplayProgressMultiPropValues.
    fold -> TaskbarActivityContext is destroyed
    unlock -> TaskbarManager and TaskbarSharedState's
      sysuiStateFlags are updated while the device is folded
    unfold -> TaskbarActivityContext is recreated and initialized
      which restores from the shared state's
      inAppDisplayProgressMultiPropValues. It also tries to reapply
      the shared state's sysuiStateFlags, but this doesn't update
      inAppDisplayProgressMultiPropValues because the state's
      "enabled" state is not updated (default is no flag set, and
      lockscreen sysui state is not set anymore).
    -> The restored inAppDisplayProgressMultiPropValues value
       results in the wrong translation.

- Note that after the above, the NavbarButtonsViewController state
  is actually correct and reflects the SysUI state, but the
  LauncherTaskbarUiController state is wrong.  This CL tries to
  manually update the ui controller to the correct state when it
  is recreated.
- CL also fixes a separate issue where LauncherTaskbarUIController
  could potentially overwrite the saved state progresses while
  restoring them due to the state callback being called

Bug: 283346744
Test: Unfold -> Lockscreen -> Fold -> Unlock -> Unfold and ensure
      the buttons are translated correctly



Change-Id: I43e473faf4fa2a493b9705506e3755df8f6264e7
Signed-off-by: Winson Chung <winsonc@google.com>
 2023-07-06 22:01:49 +00:00
Winson Chung 6f7e15ff64 Ignore recents transition if there are no closing tasks 
- In the case where Launcher calls startRecentsTransition while there
  are no other visible tasks, we should not be continuing with the
  transition as there are no tasks for Launcher to control.  This was
  previously handled in RecentsAnimationController in legacy
  transitions, but the safer fix is to ignore it on the Launcher
  side for this release.

Bug: 289175232
Test: Manually trigger empty targets and verify no issues
Change-Id: I3657c000cbc8c14c9ac989c2a57715515c96edb6
 2023-07-06 18:09:52 +00:00
Jagrut DesaiandAutomerger Merge Worker 62dd220b69 Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f am: d4b4e95bea 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: I2c06c2637c4d7fefab71ea87af677b210cd2829c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-06-30 23:45:46 +00:00
Jagrut DesaiandAutomerger Merge Worker 982dacc7ef Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev am: fa2a81844f 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23845422

Change-Id: I5c4b401023efb9cd5fcdbff50819dc95ad6cc4c2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-06-30 23:06:12 +00:00
Jagrut DesaiandAndroid (Google) Code Review fa2a81844f Merge "Taskbar All Apps Shortcut Menu Acccessibility Focus" into udc-dev 2023-06-30 22:29:20 +00:00
Holly Sun 1a9a98005d [a11y] Fix crash when using talkback to add to home screen. 
1. Fix a crash from http://cs/android-internal/packages/apps/Launcher3/src/com/android/launcher3/Launcher.java;l=1928;rcl=d677caa75de74f1c3a88367cad67ae405fd2903d. It can also be `ITEM_TYPE_SEARCH_ACTION`. Remove the `itemType` check and just use the `PendingAddItemInfo` class type.
2. Override `startConfigActivity` in `PinShortcutRequestActivityInfo`, so that `Launcher#onActivityResult` can be triggered properly from `Launcher#processShortcutFromDrop` (http://cs/android-internal/packages/apps/Launcher3/src/com/android/launcher3/Launcher.java;l=1939;rcl=d677caa75de74f1c3a88367cad67ae405fd2903d )
3. Then we call to `Launcher#completeAdd` -> `completeAddShortcut`. The original `info` passed to `processShortcutFromDrop` doesn’t have a `componentName` (new code), so remove the component non-null check from `completeAddShortcut`.

Bug: 287166186
Bug: 287167527
Bug: 287166771
Test: manual
Flag: N/A
Change-Id: Id3e1444de188f2d2af760f58e3d9814a2b7abd88
Merged-In: Id3e1444de188f2d2af760f58e3d9814a2b7abd88
(cherry picked from commit 35b9960b63)
 2023-06-30 20:49:33 +00:00
Treehugger RobotandAutomerger Merge Worker 120c78d24f Merge "Cleans up bad state when transient taskbar shows on home." into udc-dev am: 2c3c1e46c0 am: 4de15620c2 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23852178

Change-Id: I1302f2aeaeb17fa95a1a64cb2e095febadcacba1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-06-30 19:03:05 +00:00
Treehugger RobotandAutomerger Merge Worker 4264a7d135 Merge "Cleans up bad state when transient taskbar shows on home." into udc-dev am: 2c3c1e46c0 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23852178

Change-Id: I9db459debe4075642f868ca1f46c05ee14d7bd2f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-06-30 18:22:57 +00:00
Treehugger RobotandAndroid (Google) Code Review 2c3c1e46c0 Merge "Cleans up bad state when transient taskbar shows on home." into udc-dev 2023-06-30 17:45:50 +00:00
Hongwei WangandAutomerger Merge Worker 263aceeeea Merge "Polish home-key from split to pip transition" into udc-dev am: ca08d75e4a am: 93551e9496 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23833485

Change-Id: I6d23eca98f12691d3f87af8fedf8049f27125194
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-06-29 17:56:29 +00:00
Hongwei WangandAutomerger Merge Worker 858a3c1659 Merge "Polish home-key from split to pip transition" into udc-dev am: ca08d75e4a 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23833485

Change-Id: I4e379dab3bfd5096bb2550a226e1d2b5b84c7bcf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-06-29 17:35:55 +00:00
Hongwei WangandAndroid (Google) Code Review ca08d75e4a Merge "Polish home-key from split to pip transition" into udc-dev 2023-06-29 17:17:03 +00:00
Jon Miranda 3bad3ebaad Cleans up bad state when transient taskbar shows on home. 
Bug: 279514548
Test: open transparent activity on top of launcher
      unstash taskbar
      go home

Change-Id: I13ab79b334e1f8feda441a82cc4d035c0142f513
 2023-06-29 02:51:38 +00:00