Commit Graph

14880 Commits

Author SHA1 Message Date
Stefan Andonian b7221177b4 Merge "Revert "Migrate IDP_GRID_NAME usage to LauncherPrefs"" into tm-qpr-dev 2023-02-21 18:12:55 +00:00
Stefan Andonian df11959779 Revert "Migrate IDP_GRID_NAME usage to LauncherPrefs"
This reverts commit 6f9a57186c.

Reason for revert: A Bug where only device preferences were being used, not the main shared preference file.

Bug: 269569568
Test: Verified this on device.
Change-Id: I8422b2d7073537bd46c3a91033bd2281bbd306b7
2023-02-21 18:12:11 +00:00
TreeHugger Robot 9769b2844c Merge "Translate the taskbar icons to match nav handle shape." into tm-qpr-dev 2023-02-21 03:24:41 +00:00
Ale Nijamkin 7729aa4cc6 Merge "[Launcher] App grid support for reset (1/4)." into tm-qpr-dev 2023-02-18 00:14:25 +00:00
Andy Wickham 5969e0524a Merge "Reset fast scroller when All Apps resets." into tm-qpr-dev 2023-02-17 23:57:56 +00:00
Stefan Andonian 8989f839f5 Merge "Revert "Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and"" into tm-qpr-dev 2023-02-17 23:12:08 +00:00
Sunny Goyal 82864d5e13 Merge "Using internal format cache for loading user badged label" into tm-qpr-dev 2023-02-17 21:09:26 +00:00
Robin Lee aafeb82613 Revert "Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and"
This reverts commit 2a58ddb89f.

Reason for revert: b/266987957

Change-Id: I4a4a1f01a693d703f4dc87e8169fbf374729d274
2023-02-17 19:45:27 +00:00
Jon Miranda 13e9b9f889 Translate the taskbar icons to match nav handle shape.
- We need to reset icon alignment whenever icon layout bound
  changes. This fixes the issue where we build an icon
  alignment animator before any of the views are laid out.
- Separated animation logic between.
  createTransientAnimToIsStashed and createAnimToIsStashed
* The values still require a bit more tuning but this gets us
  a lot closer to spec for many of the motion polish.

Bug: 267806083
Bug: 246634367
Bug: 246635237
Test: manual
Change-Id: Id122134b22ef4e418ce632e4a8137239dc8bb313
2023-02-17 10:56:59 -08:00
Sunny Goyal 239d6e9b8d Adding support for customizing shortcut pinning logic
> Allowing support for overring shortcut badge
> Updating pendingShortcutInfo so that the
  handler can be easily overridden

Bug: 268253894
Test: Verified on device
Change-Id: I3184cb6494bc98c7eed33798b35b4e6e6a1e7ddc
2023-02-17 18:07:23 +00:00
Sunny Goyal efad3c2f92 Using internal format cache for loading user badged label
Bug: 267683009
Test: Manual
Change-Id: I7d1df2704c4513bd80e2b6adb7a3921637fa617b
2023-02-17 18:05:25 +00:00
Helen Cheuk 6187ecc12b Merge "Pad large screen hotseat in RTL 3 button nav mode by swapping left and right padding to avoid overlapping with nav buttons" into tm-qpr-dev 2023-02-17 15:44:54 +00:00
Sunny Goyal cc10ed5532 Merge "Using DiffUtil for calculating widget diff instead of a custom implementation" into tm-qpr-dev 2023-02-16 23:28:19 +00:00
Fengjiang Li 56ebfc4900 Merge "[Predictive Back] Widget to home polish: show extra rows at bottom during animation" into tm-qpr-dev 2023-02-16 19:40:24 +00:00
Alejandro Nijamkin e8dd1a78ff [Launcher] App grid support for reset (1/4).
This CL chain provides a rewritten implementation of the UI for the app
grid selector which supports the new wallpaper picker "reset"
functionality. A previous attempt that kept the UI's old implementation
required the introduction of many hacks in classes that are shared
across multiple selector-like experiences.

Bug: 267804479
Test: unit and integration JUnit tests added for the data, domain, and
ui layers of the wallpaper picker code
Test: manually made sure that the selector works to switch between
different launcher app icon grid options; the preview of the launcher
updates correctly; when exiting back to the main wallpaper picker
screen, the reset button appears and the section item is updated to show
the currently-selected option; touching the reset button and confirming
the reset correctly reverts to the original option, updating the section
item as well

Change-Id: If1f8c96ef5004125b61ff6b4ae19848932693e0f
2023-02-16 11:34:07 -08:00
Jagrut Desai 202c68c8a2 Merge "Removing ENABLE_ALL_APPS_IN_TASKBAR and FLAG_STASHED_IN_APP_EMPTY Test: Visual(pics in buganizer) Bug: 265462138 Bug: 267382941" into tm-qpr-dev 2023-02-16 17:39:35 +00:00
Helen Cheuk e76291f55c Pad large screen hotseat in RTL 3 button nav mode by swapping left and right padding to avoid overlapping with nav buttons
Hotseat was overlapped with 3 navigation buttons in large screen RTL mode. This fix is to pad hotseat properly by swapping the left and right paddings in RTL mode
Bug: 268178394
Test: manual

Change-Id: I2b073a1b532bf3aae3ab1bec98ad70713742c672
2023-02-16 14:43:01 +00:00
Fengjiang Li cb640da2bb [Predictive Back] Widget to home polish: show extra rows at bottom during animation
1. setClipChildren(false) for WidgetFullSheet and content view during animation
2. setClipToOutline(true) for WidgetsRecyclerView and provide ViewOutlineProvider to expand bottom by 5% of height
3. Override calculateExtraLayoutSpace() for ScrollableLayoutManager
4. Manually modify AbstractSlideInView#mContent's background drawable during scale animation

bug: b/260956481
Test: manual

Change-Id: Ic391639de887cf4a70bc4965dc0b1fd9bc12dd2c
2023-02-15 15:33:29 -08:00
TreeHugger Robot 1b7a140693 Merge "Making ReorderWidget test more reliable" into tm-qpr-dev 2023-02-15 22:50:20 +00:00
Stefan Andonian 3a14f1331d Merge "Refactor Workspace Loading / Processing code." into tm-qpr-dev 2023-02-15 22:16:29 +00:00
TreeHugger Robot 3f07d154fb Merge "Deferred widget update" into tm-qpr-dev 2023-02-15 20:01:07 +00:00
Stefan Andonian 3788da6285 Merge "Migrate IDP_GRID_NAME usage to LauncherPrefs" into tm-qpr-dev 2023-02-15 18:58:41 +00:00
Stefan Andonian 05ca3a8089 Refactor Workspace Loading / Processing code.
There are no behavioral changes (other than we no longer are recycling
objects while processing workspace items), but this refactor will setup
the next change to load the first workspace page before other workspace
pages.

Bug: 251502424
Test: Workspace, app widgets, and containers loaded properly.
Change-Id: I437aab40000d841d7fcc4380d05ab4a8f5d5c2ad
2023-02-15 17:36:27 +00:00
Charlie Anderson 9af03389d6 Merge "adding the new Material U App Shortcut Popup design" into tm-qpr-dev 2023-02-15 15:11:49 +00:00
Luca Zuccarini 190992e6fb Merge "[Toast] Disable decorator updates if background drawables are used." into tm-qpr-dev 2023-02-15 11:37:11 +00:00
Stefan Andonian 6f9a57186c Migrate IDP_GRID_NAME usage to LauncherPrefs
Bug: 251502424
Test: Grid functionality still worked just fine on device when I tested
it locally.

Change-Id: I23676572637f194e1f739e4b39159311870abc32
2023-02-15 06:01:47 +00:00
Sebastián Franco aa6f00af01 Merge "Fix issue where bottom scrim appears in homescreen when it shouldn't" into tm-qpr-dev 2023-02-15 01:57:03 +00:00
Federico Baron e958fb2e7f Merge "Remove unused file WidgetsListSearchHeaderHolder" into tm-qpr-dev 2023-02-15 00:46:18 +00:00
Sebastian Franco 40f94c84f8 Fix issue where bottom scrim appears in homescreen when it shouldn't
The bottom scrim should be shown for the Pixel Launcher, other third
party launchers show it when the 3 bottom navigation is activated.

The existing condition for 3 bottom navigation is no longer valid
because the insets at the bottom can be greather than 0 in other
situations other than 3 bottom navigation.

Test: the scrom should not show at all
Test: It appears in some situations where the taskbar is showing
and the scrim gets updates which not always happens so it's hard to
manually recreate, but there is a test that is flaky because of it
HomeScreenImageTabletTest#comparePixelTablet2023HomeScreen.
Fix: 267614579

Change-Id: Iacaf93011aa3f2f643186560fe34b4b26ce52314
2023-02-14 13:46:44 -08:00
Charlie Anderson 8ad9144ca2 adding the new Material U App Shortcut Popup design
Bug: 247880037
Test: tested manually
Change-Id: I66c291df54dfc2a76fc974082a19091deb167f73
2023-02-14 16:03:15 -05:00
Sunny Goyal 892fab2c14 Using DiffUtil for calculating widget diff instead
of a custom implementation

This uses the same version as all-apps and avoids whole list refresh
when a widget entry is expanded for the first time

Removing tests which were essentially testing the diffing logic

Bug: 268646258
Test: Verified on device
Change-Id: I4799c66b4674e754547317317e7a63f098fce735
2023-02-14 20:59:29 +00:00
Federico Baron 521e3748d8 Merge "Fix wrong widget appearing in widget picker for tablet" into tm-qpr-dev 2023-02-14 19:28:19 +00:00
Schneider Victor-tulias 673e6437b8 Merge "Add the KeyboardQuickSwitchView (1/2)" into tm-qpr-dev 2023-02-14 17:46:23 +00:00
Federico Baron b215c5416e Remove unused file WidgetsListSearchHeaderHolder
WidgetsListSearchHeaderHolder was the only file that remained after all the redundant widget search header logic got removed. It is dead code now so this CL deletes it.

Bug: 268646258
Test: Verified on device
Change-Id: I670364bd7c2d5ce46d2c8837ef483e5ac2315547
2023-02-14 01:49:55 -08:00
Schneider Victor-tulias f908729fa8 Add the KeyboardQuickSwitchView (1/2)
Preparatory change for adding the KeyboardQuickSwitchView and associated flows.

Test: Manually tested alt-tab and alt-shift-tab in and out of overview on a tablet and phone
Bug: 258854035
Change-Id: I468481a023e82d3ef7c7d4d44c5b9435173b49ae
2023-02-13 15:34:39 -08:00
Sunny Goyal a13cc8167f Deferred widget update
Maintaing a list of pending updates while the host
is not listening, so that these can be applied when
host starts listening again

Bug: 267351283
Test: Manual
Change-Id: I38423862a3461724b36f17ffe44e44c55fee06de
2023-02-13 14:54:25 -08:00
Federico Baron ecb0532597 Fix wrong widget appearing in widget picker for tablet
The wrong widget would appear in tablets because we were finding the widgets by PackageUserKey title instead of comparing the PackageUserKey objects themselves.

Fix: 269160189
Test: Turn on LARGE_SCREEN_WIDGET_PICKER and verify that in landscape mode in tablet clicking the battery header shows the correct widget
Change-Id: I4f17ba057d9287fc83e3b1e0072cacf0eee3deef
2023-02-13 13:53:55 -08:00
Jagrut Desai ec0b4e1693 Removing ENABLE_ALL_APPS_IN_TASKBAR and FLAG_STASHED_IN_APP_EMPTY
Test: Visual(pics in buganizer)
Bug: 265462138
Bug: 267382941

Change-Id: I223cd5ea7e5b553619dfc81c36f1be93e399639d
2023-02-13 13:34:23 -08:00
Andy Wickham 82ab3fb3e3 Reset fast scroller when All Apps resets.
This ensures the scrollbar is not left in a bad state, in
particular if you close All Apps while still scrolling (e.g.
pressing the Home button while holding the scroll bar).

Fix: 267583704
Test: Manual
Change-Id: I0e159f8e5ed289bf1628f77eab1879743b5aea00
2023-02-13 13:32:09 -08:00
Sebastian Franco 81b82720de Making ReorderWidget test more reliable
In some cases when starting to drag you can go to the next
CellLayout wich end in an error. Now the dragging functions
will move the item to the desired CellLayout no matter what
CellLayout you start in.

Fix: 266116487
Test: atest ReorderWidgets
Change-Id: Ie3ad2ff88f734856e2c66d5d51b7578482877b5a
2023-02-13 11:02:09 -08:00
Sunny Goyal a75105ef03 Merge "Moving widget background to xml, so that the same constantstate is used for all entries" into tm-qpr-dev 2023-02-13 18:12:43 +00:00
Brandon Dayauon 0abe8af6a6 Merge "Add featureFlag for icon in textheader" into tm-qpr-dev 2023-02-13 17:52:58 +00:00
Sunny Goyal 77e732a1c4 Moving widget background to xml, so that the same constantstate is
used for all entries

This helps reduce launcher memory by avoiding multuple duplicate
drawable generation

Bug: 268646258
Test: Verified on device
Change-Id: I829750f081cfce65063b35a614b903066d9a4bed
2023-02-13 05:49:31 +00:00
Nicolò Mazzucato 5147b1d509 Merge "Drive Launcher unfold animation from System UI" into tm-qpr-dev 2023-02-11 09:24:42 +00:00
Brandon Dayauon b648c9eda3 Merge "Zero state feature flag" into tm-qpr-dev 2023-02-11 05:50:46 +00:00
Sunny Goyal 290998522c Merge "Removing unnecessary search header duplication" into tm-qpr-dev 2023-02-10 23:10:49 +00:00
Nicolo' Mazzucato 8d9edd292b Drive Launcher unfold animation from System UI
Before this cl, both Launcher and System UI processes were registering for hinge angle and device state (e.g. folded/unfolded) change events to calculate the current unfold animation progress. In some cases, launcher ui thread was busy, delaying the progress calculation from the hinge angle value (that was received ~at the same time by both processes). This resulted in launcher and sysui unfold animation not being synchronized in some cases.

With this cl, System UI process uses OverviewProxyService to send the unfold events to Launcher. In this way, both process always have the exact same progress (+- 1 frame)

This is currently guarded by a launcher flag, by default with the new behaviour, to allow devs to compare the experience and easily debug potential regressions.

Bug: 268490854
Test: Analysed perfetto trace + RemoteUnfoldTransitionProgressProviderTest + manual
Change-Id: If15fd6fe39abb3d922c5fdb327100206dfa3665d
2023-02-10 22:04:19 +00:00
Lucas Silva bc333343ec Merge "Allow QuickstepTransitionManager to be overridden" into tm-qpr-dev 2023-02-10 20:47:27 +00:00
Sunny Goyal 62a4932310 Removing unnecessary search header duplication
Bug: 268646258
Test: Verified on device
Change-Id: I33a7df6a523e5600dc6251c3d8feff1236362705
2023-02-10 11:26:05 -08:00
Federico Baron 740541e0a0 Merge "Implement two pane widget picker" into tm-qpr-dev 2023-02-10 17:20:55 +00:00