Commit Graph

1120 Commits

Author SHA1 Message Date
TreeHugger Robot b59cdf26ab Merge "Add @ScreenRecord to testPressHomeOnAllAppsContextMenu" into tm-qpr-dev am: 18be12d0dd am: fda08cb9cb
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21136643

Change-Id: Id5d7459eb28d8c4cf9e992e1f2ac61d05e11dd19
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-01 21:28:20 +00:00
TreeHugger Robot 18be12d0dd Merge "Add @ScreenRecord to testPressHomeOnAllAppsContextMenu" into tm-qpr-dev 2023-02-01 18:51:31 +00:00
Sunny Goyal 5fc8131b60 Merge "Introducing CellPosMapper which allows mapping between UI position and model position" into tm-qpr-dev am: 126ac14112 am: a19f661961
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21128574

Change-Id: Id2cdf2a5262def0401cd2a60fbe89044f55a9c98
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-31 19:30:30 +00:00
Sunny Goyal 669b71f5b3 Introducing CellPosMapper which allows mapping between UI position
and model position

Test: atest CellPosMapperTest
Bug: 188081026
Change-Id: If5c6b3df5ad240317bb535c675f6ead94084238e
2023-01-30 12:17:09 -08:00
hyunyoungs 50b824392a Add @ScreenRecord to testPressHomeOnAllAppsContextMenu
Bug: 264538883
Test: seems to run fin on tm-qpr-dev
Change-Id: If395260ba58496282b651e1938e28f3cef22654f
2023-01-28 18:55:05 -08:00
Thales Lima d852d65693 Create attr for padding between icon and text in cells
Bug: 265210314
Test: DeviceProfileDumpTest
Change-Id: I00af790d0c21c35f1cbce1362e63d3ab8259244a
Merged-In: I00af790d0c21c35f1cbce1362e63d3ab8259244a
2023-01-26 22:50:18 +00:00
Thales Lima 903d0a3e63 Create attr for padding between icon and text in cells
Bug: 265210314
Test: DeviceProfileDumpTest
Change-Id: I00af790d0c21c35f1cbce1362e63d3ab8259244a
(cherry picked from commit 60cab75576e9f844fcaae8f0723a075f2a00bb1f)
Merged-In: I00af790d0c21c35f1cbce1362e63d3ab8259244a
2023-01-26 15:40:27 +00:00
Sebastián Franco 1b3d1cfa64 Merge "Adding the avility to add icons on multiple CellLayouts on tests." into tm-qpr-dev am: 68f5667338 am: 56f91702d2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20890013

Change-Id: I3b9bad730707d9e5dca8f10acdb43991cd51c290
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-24 23:11:45 +00:00
Sebastián Franco 68f5667338 Merge "Adding the avility to add icons on multiple CellLayouts on tests." into tm-qpr-dev 2023-01-24 20:02:35 +00:00
Sunny Goyal a992ac9e8d Moving all intent receiver register calls to a single place
This is eventually allow us to move all register to background thread
Also creating a single ScreenOn tracked which is used at multiple places

Bug: 264465756
Test: Verified on device
Change-Id: Ibadf9ca43218e578954420d97a733adfa0a94fc7
Merged-In: Ib410e5bf02773cefde5bf0a0a1f2f1c108718d24
2023-01-22 05:24:48 +00:00
Sunny Goyal a1692a467f Moving all intent receiver register calls to a single place
This is eventually allow us to move all register to background thread
Also creating a single ScreenOn tracked which is used at multiple places

Bug: 264465756
Test: Verified on device
Change-Id: Ibadf9ca43218e578954420d97a733adfa0a94fc7
2023-01-20 23:50:00 +00:00
Sebastián Franco a1707e3007 Merge "Remove unused Throw Throwable from clearHomescreen method" into tm-qpr-dev am: 48651b2109 am: c18a4081d5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20831584

Change-Id: Ie10f728d6e544214f2ac91a209fd500635030a5a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-18 02:29:42 +00:00
Sebastián Franco 48651b2109 Merge "Remove unused Throw Throwable from clearHomescreen method" into tm-qpr-dev 2023-01-18 01:12:23 +00:00
Stefan Andonian 6a651e63c9 Merge "Expanded LauncherPrefs APIs to Replace Direct Shared Preference Usage." into tm-qpr-dev am: 1eb59d6c6a am: 60e3b74522
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20764866

Change-Id: I7a69b534e3df890034eb897e8d61517e75828702
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-17 19:29:02 +00:00
Stefan Andonian 1eb59d6c6a Merge "Expanded LauncherPrefs APIs to Replace Direct Shared Preference Usage." into tm-qpr-dev 2023-01-17 18:23:10 +00:00
Sebastian Franco de1fe14a47 Adding the avility to add icons on multiple CellLayouts on tests.
I needed to change the code so that you can pass the CellX/Y
position to the drag function instead of the pixel coordinates
and we can pass X position bigger than one CellLayout.

Also, I notice that getCellCenter only worked for 1x1 items
so I added the option to specify the widget size.

Fix: 262431878
Test: atest ReorderWidgets#multipleCellLayoutsSimpleReorder
Change-Id: I3b09de770e8f99aa10cae8cea32e7e6bc02c7b8b
2023-01-16 10:32:40 -06:00
Stefan Andonian d1b33b311c Expanded LauncherPrefs APIs to Replace Direct Shared Preference Usage.
LauncherPrefs will contain Launcher's shared preference functionality.
It controls optimizations and classifications such as restorable vs
non-restorable data, bootaware vs non-bootaware data, and configurations
such as default values  so the calling code doesn't need to and our code
base can have a single source of truth for items that are used in
multiple places.

The old APIs remain in place, but are deprecated and will be removed
after all Shared Preference usage has been gated by LauncherPrefs in
future CLs.

Bug: 261635315
Test: Manually tested themed icon, Workspace configuration, and app
install functionality.

Change-Id: I29fd516468bc93fda393062e95be26b6d55c816e
2023-01-14 00:54:15 +00:00
Sebastian Franco 877088e6c3 Change the access of cellX/Y of CellLayoutLayoutParams to private
Bug: 188081026
Test: no op change, should compile
Test: ReorderWidgets
Change-Id: I20367974e5a4cead406e18eb66dafd4d59651b2a
Merged-In: I20367974e5a4cead406e18eb66dafd4d59651b2a
2023-01-13 18:25:10 +00:00
Sebastián Franco f55e3690ea Merge "Change the access of cellX/Y of CellLayoutLayoutParams to private" 2023-01-12 21:14:23 +00:00
Christophe Pinelli 2acf5a8492 Merge "Make mutable PendingIntent explicit" into tm-qpr-dev am: 3cd6cbe6b4 am: ab2c2d9576
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20953789

Change-Id: Iafef3bf70a5dfb0c5a72bf814d23d952cfd7f2f9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-12 20:02:04 +00:00
Sebastian Franco 9db35f7a37 Remove unused Throw Throwable from clearHomescreen method
Test: presubmit
Bug: 263802298
Change-Id: I4b81e044eb4f6a84730fb4d61403cbfcadefd282
2023-01-12 10:41:34 -06:00
Christophe Pinelli 9d46bca1b9 Make mutable PendingIntent explicit
Starting from target SDK U, we will block creation of mutable
PendingIntents with implicit Intents because attackers can mutate the
Intent object within and launch altered behavior on behalf of victim
apps. For more details on the vulnerability, see go/pendingintent-rca.

From a quick analysis, we concluded that the PendingIntent here was only
destined to the test app/to the app, so it was made explicit. Reviewers,
please call out if this is not the case.

Bug: 236704164
Test: atest NexusLauncherTests:com.android.quickstep.DigitalWellBeingToastTest
Test: atest RequestPinItemTest
Change-Id: I81311b0588b7b712c97de6cb016a62bb91c7a77c
2023-01-12 01:51:44 +00:00
Stefan Andonian 53b21fae3b Merge "Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and into its own class." into tm-qpr-dev am: fb602d4db7 am: 167d350981
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20878611

Change-Id: I7591e1af8af6bcd6b11dea1571668d80ada06201
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-11 23:57:55 +00:00
Stefan Andonian 2a58ddb89f Refactor the OnUserUnlock code out of RecentsAnimationDeviceState and
into its own class.

Bug: 251502424
Test: Compilation threw no errors and user unlock behavior worked
correctly.

Change-Id: Ifa42dc32f90dfa4fda8df0e52811ddfe20cc5a9b
2023-01-11 19:33:32 +00:00
Sebastian Franco a955403ba9 Change the access of cellX/Y of CellLayoutLayoutParams to private
Cherry pick needed for changes on workspace lily

Bug: 188081026
Test: no op change, should compile
Test: ReorderWidgets
Change-Id: I20367974e5a4cead406e18eb66dafd4d59651b2a
2023-01-11 15:25:23 +00:00
Thales Lima bdfc07f1f0 Merge "Check kotlin format before uploading" into tm-qpr-dev 2023-01-10 16:41:58 +00:00
Thales Lima 03ac377a34 Check kotlin format before uploading
This uses ktfmt on the PREUPLOAD hook to check file formatting.

Bug: 264851618
Test: manual
Change-Id: I8bdeabd9c1ed571a464707e6912419ad3190a169
Merged-In: I8bdeabd9c1ed571a464707e6912419ad3190a169
2023-01-10 13:24:43 +00:00
Thales Lima 47a40a8bd3 Merge "Check kotlin format before uploading" 2023-01-10 13:23:59 +00:00
Sebastián Franco aeaaef068d Merge "Printing the workspace items to improve flake investigation." into tm-qpr-dev am: b66293e96d am: b1bb6d37d7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20680953

Change-Id: I6556acee7b4a44ed4a39aefa749cdfca4f305f26
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-10 00:25:48 +00:00
Sebastian Franco 1328764f1e Removing screen recording for testShortcutIconWithTheme am: 1cf1e3b025 am: 4a1dd0b422
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20913765

Change-Id: Ia76ee43a6ba9c1643f11a12670716b7b4bee5c28
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-10 00:25:14 +00:00
Sebastián Franco b66293e96d Merge "Printing the workspace items to improve flake investigation." into tm-qpr-dev 2023-01-09 23:20:51 +00:00
Sebastian Franco 1cf1e3b025 Removing screen recording for testShortcutIconWithTheme
Bug: 260722220
Test: compiles
Change-Id: I7f5ac09bc7e9deb9af3e90dbd99826bb8c4db11f
2023-01-09 14:19:14 -06:00
Thales Lima 7a3c1e10a7 Check kotlin format before uploading
This uses ktfmt on the PREUPLOAD hook to check file formatting.

Bug: 264851618
Test: manual
Change-Id: I8bdeabd9c1ed571a464707e6912419ad3190a169
2023-01-09 17:45:42 +00:00
TreeHugger Robot 791b4d1962 Merge "Re-enable AddConfigWidgetTest" into tm-qpr-dev am: 2f4a1b9980 am: a64545be52
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20683730

Change-Id: I2b5d0a71be067b460aa7aebf546e38130a5d1a47
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-06 22:37:52 +00:00
TreeHugger Robot 2f4a1b9980 Merge "Re-enable AddConfigWidgetTest" into tm-qpr-dev 2023-01-06 21:34:05 +00:00
Sebastian Franco f34f35fddb Printing the workspace items to improve flake investigation.
Recording the screen to investigates flakes on ReorderWidgets
is really useful but it requires changing the code for that and
storing the video and most of the time the useful information
is just the end state so by logging the end state makes resolving
flakes easier

Fix: 261877803
Test: atest ReorderWidgets
Change-Id: If5d9745ebb57826a55b5df9d3599eed56c48298f
2023-01-06 12:29:11 -06:00
TreeHugger Robot f2df42fdca Merge "Revert "Add logging to help debug additional app infos being updated by CacheDataUpdatedTask"" into tm-qpr-dev am: 1973056e40 am: 3c57751362
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20747317

Change-Id: I7c98fa2b687ff8af976b4cffe389afb3d8eb4304
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-05 21:15:58 +00:00
TreeHugger Robot 35f483de1c Merge "Re-enabling testShortcutIconWithTheme" into tm-qpr-dev am: 2825d06382 am: 7e22f8bb79
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20873332

Change-Id: I4bce02d741a462465585d7bb1a297e4c67eae714
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-05 21:15:13 +00:00
TreeHugger Robot 1973056e40 Merge "Revert "Add logging to help debug additional app infos being updated by CacheDataUpdatedTask"" into tm-qpr-dev 2023-01-05 20:04:07 +00:00
TreeHugger Robot 2825d06382 Merge "Re-enabling testShortcutIconWithTheme" into tm-qpr-dev 2023-01-05 19:46:30 +00:00
Sunny Goyal 62ea1f1cb7 Re-enabling testShortcutIconWithTheme
> Updating shortcut id incache the icon cache was the culprit

Bug: 260722220
Test: Verified locally
Change-Id: I0e6bc9b06d1b99e33cb9b1a248647d54bf47dea4
2023-01-04 13:05:42 -08:00
Schneider Victor-tulias 5455b85291 Revert "Add logging to help debug additional app infos being updated by CacheDataUpdatedTask"
This reverts commit 62511de74e.

Reason for revert: bug not reproducing

Fixes: 20747317
Change-Id: I55c1fe8005fee66db53052aab15e152e6d39a34c
2023-01-04 18:27:00 +00:00
vadimt 6dde898959 Ignoring failing out-of-SLO test am: d9ca71b1d9 am: bafcbaa216
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20861031

Change-Id: Icaa5de20e160e4b0decb50cf5773af84b6bb2686
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-01-04 01:12:43 +00:00
vadimt d9ca71b1d9 Ignoring failing out-of-SLO test
Test: presubmit
Bug: 243855320
Change-Id: I7795bdae6b30cd663fa4e6cbba118d84d57ec96d
2023-01-03 12:46:43 -08:00
Luca Zuccarini b25ea2d33f Add Tapl support for swiping from All Apps to Workspace. am: 55d828b6f5 am: 242eeea4ea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20551691

Change-Id: Idff9df5162ef48783beb8eb6662838948b8d2d90
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-27 15:01:14 +00:00
Luca Zuccarini 55d828b6f5 Add Tapl support for swiping from All Apps to Workspace.
This mirrors the way we swipe from Workspace to All Apps, with minor
differences for selecting the start position of the swipe motion.

Bug: 260218332
Test: included
Change-Id: I9fe2284b1c920ebed87a6bab3dfc9c8c29aa2d5d
2022-12-21 15:38:51 +00:00
Sihua Ma 45149d9036 Merge "Add QuickstepWidgetHolder for widget handling" into tm-qpr-dev am: 04c89fe38e am: f8ab32a8bc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20418248

Change-Id: I8cc2d48f94aaa415fb7b9bd8137502b27de33d5d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-19 19:55:49 +00:00
Sihua Ma 04c89fe38e Merge "Add QuickstepWidgetHolder for widget handling" into tm-qpr-dev 2022-12-19 18:22:38 +00:00
Alex Chau e13b1a22f9 Merge "Polish hotseat and taskbar with 3 buttons" into tm-qpr-dev am: 4537638dfd am: 0d5ca5fe6f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20533919

Change-Id: I37921b47514fc4823b2c6ee7d61fbf1ff6ca7c67
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-19 12:26:25 +00:00
Thales Lima 6a59006592 Polish hotseat and taskbar with 3 buttons
Change margin spaces and logic of how many items the hotseat and taskbar should show.

Fix: 246424857
Test: DeviceProfileDumpTest
Test: HotseatWidthCalculationTest
Change-Id: I8ec71c56a0aa362483c43d6400c762d12cf45f5b
2022-12-17 11:20:21 +00:00