Commit Graph

2475 Commits

Author SHA1 Message Date
Hyunyoung Song e1c1b76884 Merging from ub-launcher3-qt-qpr1-dev @ build 5834630 am: 151970d535
am: b6d7a85a2b

Change-Id: If79242dd021c9a2c3fa6e1a87a5c8d792e45dc1a
2019-09-10 11:26:04 -07:00
Hyunyoung Song 151970d535 Merging from ub-launcher3-qt-qpr1-dev @ build 5834630
Test: manual, presubmit on the source branch
http://x20/teams/android-sysui/merge/ub-launcher3-qt-qpr1-dev_5834630.html

Change-Id: I39968f831d707800207303e7661193fd74e56124
2019-08-28 11:28:39 -07:00
vadimt f13eaa0242 Saving screenshots for failures in NavigationModeSwitchRule
Change-Id: I732076a5eb14b181f560024e2780e2012a81fd95
2019-08-23 14:18:32 -07:00
vadimt 197ae725a0 Adding debug tracing for All Apps appearing instead of Overview
Bug: 139941530
Change-Id: Ia9827c6edd48c559e9602e1e37de83293517ad5e
2019-08-23 12:11:00 -07:00
Becky Qiu f0a014d7ff Move swipe actions on container logging to west world.
Test: manual
Bug: 137777105

Log result for swiping in and out of -1 screen.
  data {
    elapsed_timestamp_nanos: 597609736235111
    atom {
      launcher_event {
        action: SWIPE_LEFT
        src_state: HOME
        dst_state: HOME
        is_swipe_up_enabled: true
      }
    }
  }

  data {
    elapsed_timestamp_nanos: 597610569783111
    atom {
      launcher_event {
        action: SWIPE_RIGHT
        src_state: HOME
        dst_state: HOME
        is_swipe_up_enabled: true
      }
    }
  }


Change-Id: Ic84d3c32d1c9f780f13ec5cd6320e9f1d610f018
2019-08-22 16:27:49 -07:00
Hyunyoung Song 551e033da1 ub-launcher3-qt-qpr1-dev @ build 5818303 am: 227daf0108
am: b5d3d5ee26

Change-Id: If173e2df39c600baf95bea6adcaa2a7c15c88447
2019-08-22 10:38:50 -07:00
Hyunyoung Song 227daf0108 ub-launcher3-qt-qpr1-dev @ build 5818303
Test: presubmit setup on source branch

Bug: 112282235  Starting an app from Launcher sometimes takes > 10 sec
Bug: 125027540  Apps to be searchable in different languages
Bug: 132336512  Notification dots on pinned shortcuts
Bug: 135218095  Disable unnecessary services
Bug: 136277517  Widgets often don’t support scroll direction up/down, left/right and use forward/backward instead
Bug: 137777105  Make clearcut launcher logging feature parity with westworld logging
Bug: 137952354  OnResume() and onStop logging doesn't reflect the real source id for -1 screen
Bug: 137953006  Swiping/fling up from workspace logged as hotseat
Bug: 138273985  The pause app message takes more than 30 seconds to display after restarting the device.
Bug: 138683199  Pass the captured snapshot data to Launcher when recents animation is cancelled
Bug: 138729456  [Flaky test] java.lang.AssertionError: http://go/tapl : Can't find an object with selector: BySelector [CLASS='\Qandroid.widget.TextView\E', PKG='\Qcom.google.android.apps.nexuslauncher\E', TEXT='\QShortcut 3\E'] (visible state: Workspace)
Bug: 138743758  [Flaky test] java.lang.AssertionError: App still doesn't have Pause action: com.google.android.calculator
Bug: 138743792  [Flaky test] java.lang.AssertionError: ensureScrollable didn't add Chrome app
Bug: 138964490  Investigate if ToggleableFlags can be connected with DeviceConfig
Bug: 139416391  CTS tests crash when app_prediction service is disabled
Bug: 139498375  Flake:     java.lang.SecurityException: Injecting to another application requires INJECT_EVENTS permission
Bug: 139540363  Launcher goes in crash loop

Change-Id: Iaba4ed67e9fe4f8f5858324201e4c4e8711f59fa
2019-08-21 22:20:03 +00:00
Tracy Zhou d3ef57b4dd Make sure that live tile overlay is added only once.
Users report seeing empty launcher. After adding some logging, live tile
overlay can be added twice and removed only once. I added some logic to
make sure that it can only be added once.

Test: manual
Fixes: 135864059
Change-Id: I9d3325c56e76654f1397cc65979b97a6c0a80aee
2019-08-19 23:38:41 -07:00
Vadim Tryshev 1cbdcb2961 Merge "Extending the list of test owners" into ub-launcher3-qt-qpr1-dev 2019-08-16 17:36:54 +00:00
Hyunyoung Song 96eba3aea6 Merge "Make TogglableFlag backed by DeviceConfig for e2e testing" into ub-launcher3-qt-qpr1-dev 2019-08-15 22:25:33 +00:00
Hyunyoung Song d4204437de Make TogglableFlag backed by DeviceConfig for e2e testing
Bug: 138964490

TL;DR;; need this to be part of QQ1 or QD1 to verify if DeviceConfig
can be supported for launcher toggleableFlags.

Not handled in this CL:
- When flag is locally modified, that will override the flag value
How that scenario is handled should be discussed separately and is not
within scope of this CL.

Change-Id: I2e6694a40bee9202ed0b0d559e3b5607634071bf
2019-08-15 14:02:28 -07:00
vadimt a81be5003c Extending the list of test owners
Otherwise, changes in tests would require my-only approval.

Change-Id: Ia957a28a5a8e55dc2ee4efdf9a46c91511d3e611
2019-08-14 17:18:45 -07:00
TreeHugger Robot 46463f6a19 Merge "Adding support for storing keywords in iconCache" into ub-launcher3-qt-qpr1-dev 2019-08-14 23:08:43 +00:00
Sunny Goyal 2f8fe6bb1f Merging ub-launcher3-qt-r1-dev, build 5800211 am: 26bf127983 am: 04d97d9da3
am: 7830db8205

Change-Id: I94fd54c629a3fa5e7576ab910514430b5616e851
2019-08-14 15:47:05 -07:00
TreeHugger Robot 2083fd9b9f Merge "Fixed PredictionAppTracker as service might not be available on device." into qt-qpr1-dev 2019-08-14 22:28:34 +00:00
Sunny Goyal 934ebd087b Adding support for storing keywords in iconCache
Change-Id: I1183e63a6556ebfb3eee5df23d149e09728193a9
Merged-In: I1183e63a6556ebfb3eee5df23d149e09728193a9
(cherry picked from commit e529a86fbd)
2019-08-14 22:12:49 +00:00
Felipe Leme 7ca46ba2ee Fixed PredictionAppTracker as service might not be available on device.
Fixes: 139416391
Bug: 135218095

Test: echo 'in TreeHugger we trust'

Change-Id: Iea89b3d379792327657e01869c9494975e7b0306
(cherry picked from commit 214a45ee02)
2019-08-14 22:02:22 +00:00
Sunny Goyal 04d97d9da3 Merging ub-launcher3-qt-r1-dev, build 5800211
am: 26bf127983

Change-Id: I1b57843c3d753f7441b2a6cb707106cc9c8414b3
2019-08-14 14:37:59 -07:00
Felipe Leme 6e4a1ef16c Fixed PredictionAppTracker as service might not be available on device.
Fixes: 139416391
Bug: 135218095

Test: echo 'in TreeHugger we trust'

Change-Id: Iea89b3d379792327657e01869c9494975e7b0306
(cherry picked from commit 214a45ee02)
2019-08-14 11:20:20 -07:00
Becky Qiu 22edac9bf5 Merge "Log the event for swiping up to dismiss a task in Overview." into ub-launcher3-qt-qpr1-dev 2019-08-14 17:48:45 +00:00
Felipe Leme 214a45ee02 Fixed PredictionAppTracker as service might not be available on device.
Fixes: 139416391
Bug: 135218095

Test: echo 'in TreeHugger we trust'

Change-Id: Iea89b3d379792327657e01869c9494975e7b0306
2019-08-14 09:53:04 -07:00
Sunny Goyal 26bf127983 Merging ub-launcher3-qt-r1-dev, build 5800211
Test: Manual

Bug:138881088 P1 Sometimes home gesture mis-interpreted as overview
Change-Id: Ic0b841c32910f77592b4a6eb372751a85350bae5
2019-08-13 16:35:28 -07:00
Sunny Goyal f3dac0ef13 Always go to home in case of fling-up
am: a2cfc2d95e

Change-Id: I560fd690882998a9b503d5c30eda7f9397db138e
2019-08-13 14:58:45 -07:00
Sunny Goyal a2cfc2d95e Always go to home in case of fling-up
Bug: 138881088
Change-Id: I86bf4c7a495805d5912b102470e72a51e843a222
2019-08-13 11:45:06 -07:00
Becky Qiu 90ea00b399 Log the event for swiping up to dismiss a task in Overview.
Test: manual
Bug: 137777105

Demo logging for dismissing a task:
  data {
    elapsed_timestamp_nanos: 70772067228810
    atom {
      launcher_event {
        action: DISMISS_TASK
        src_state: OVERVIEW
        dst_state: BACKGROUND
        is_swipe_up_enabled: true
      }
    }
  }

Change-Id: I5569b80e2e1f35661bc5e9e343c6c298791a1ec1
2019-08-09 10:57:05 -07:00
Sunny Goyal 103974c88f Merging ub-launcher3-qt-r1-dev, build 5782058
am: c128131a10

Change-Id: I0ffb8dfc13fa2c7a23015c1324abf1f15f981bc8
2019-08-07 10:40:16 -07:00
Sunny Goyal c128131a10 Merging ub-launcher3-qt-r1-dev, build 5782058
Test: Manual

Bug:132455160 P1 [Gesture Nav] Home to Overview Transition Improvement
Bug:133472746 P1 "Now playing History" widget can't be added to desired area.
Bug:135558924 P4 Pixel Launcher app crash after applying custom Style
Bug:136282913 P1 Swipe up from Assistant Fulfillment Card Jank
Bug:136591785 P2 Tune swipe up to home animation
Bug:138117089 P1 Random misses in GL comp on Pixel 3a/XL
Bug:138609751 P2 Trying to start an app before it was downloaded caused pixel launcher crash
Bug:138620399 P1 Quick switch flicker / artifacts
Bug:138646754 P4 Switching from 3-button to gesture nav - all apps disappeared
Bug:138793362 P4 With animation disabled, Launcher crashing on docking apps in split screen from overview screen.
Change-Id: I4f3b286ae79566fd53072df621be98646d0457d7
2019-08-06 12:09:08 -07:00
Pinyao Ting e4061fc931 show dot in deep shortcuts when notification contains exactly identical
set of person

Bug: 132336512
Change-Id: I975524e28168c10a186cdc24b188c161faf433cf
Merged-In: I975524e28168c10a186cdc24b188c161faf433cf
2019-08-05 23:31:35 -07:00
Sunny Goyal bafd62971a Merge "Use task display id when starting split screen" into ub-launcher3-qt-r1-dev
am: 6cf32a2e95

Change-Id: I7313eb81291d3fbe353882446d7da39bba355ec9
2019-08-05 17:33:42 -07:00
TreeHugger Robot 6cf32a2e95 Merge "Use task display id when starting split screen" into ub-launcher3-qt-r1-dev 2019-08-06 00:21:01 +00:00
James O'Leary c714f1657b Merge "Fix inability to dismiss Assistant answer when launcher frontmost" into ub-launcher3-qt-r1-dev
am: 290a9a814a

Change-Id: I128fb662ea38a00f3a14734aae9c5c1bbb849b09
2019-08-05 15:20:46 -07:00
Sunny Goyal 1eade2f947 Use task display id when starting split screen
Before starting split screen animation, we dismiss the task view, which
can detach the clicked view immediately, if animations are dissabled.
That will cause NPE as view.getDisplay will be null

Bug: 138793362
Change-Id: I611f6a824f756eceeed57aac5afdf38f421ff8d2
2019-08-05 11:24:43 -07:00
TreeHugger Robot 71b6d24964 Fix inability to dismiss Assistant answer when launcher frontmost
Bug: 136282913
Test: Verify Assistant answer card be dismissed from Home
Change-Id: I84d0a9bda333bc2f99161096299acfaa387ecf1e
2019-08-05 14:01:08 -04:00
Tracy Zhou bd7acf7665 Change RecentsAnimationListenerSet interface (Launcher)
Bug: 138683199
Test: N/A
Change-Id: Ic53ef92fe4d5b55ff1d105a250accdf6f6c0916b
(cherry picked from commit 8e8a36f673)
2019-08-02 03:44:37 +00:00
Tracy Zhou 528647df2d Merge "Change RecentsAnimationListenerSet interface (Launcher)" into qt-qpr1-dev 2019-08-02 01:44:53 +00:00
Tony Wickham f489a71365 Return mIconLastSetTextAlpha from TEXT_ALPHA property
am: 8ed3b437b1

Change-Id: I01cada1a1cca22e2e7792b019dd74221c0451cf3
2019-08-01 15:44:40 -07:00
Becky Qiu 84fa94e2fc Fill the log container as hotseat or workspace based on position.
Test: manual
Bug: 137953006

Swipe from workspace:
07-30 15:15:44.031  9779  9779 D UserEvent: action:FLING direction=UP direction=UP
07-30 15:15:44.031  9779  9779 D UserEvent:  Source child:WORKSPACE id=0 span(951,1313)	parent:WORKSPACE id=0
07-30 15:15:44.031  9779  9779 D UserEvent:  Destination child:ALLAPPS
07-30 15:15:44.031  9779  9779 D UserEvent:  Elapsed container 826 ms, session 9361 ms, action 0 ms

Swipe from hotseat:
07-30 15:15:46.010  9779  9779 D UserEvent: action:FLING direction=UP direction=UP
07-30 15:15:46.010  9779  9779 D UserEvent:  Source child:HOTSEAT id=0 span(786,1908)	parent:WORKSPACE id=0
07-30 15:15:46.010  9779  9779 D UserEvent:  Destination child:ALLAPPS
07-30 15:15:46.010  9779  9779 D UserEvent:  Elapsed container 1139 ms, session 11339 ms, action 0 ms

Change-Id: I959528889fda778efc569bb59e7f44d3bd5b81bc
2019-08-01 22:24:44 +00:00
Tony Wickham 8ed3b437b1 Return mIconLastSetTextAlpha from TEXT_ALPHA property
This was supposed to go in the last CL but I forgot to commit...

Bug: 132455160
Change-Id: Ieb66b1f256d7b14c84bbd4d10af1aa8b073d5ac3
2019-08-01 15:20:03 -07:00
Jon Miranda 783717c0c6 Merge "Fix bug where rounded corners were being set despite being disabled." into ub-launcher3-qt-dev am: 9da9a2bd21
am: f20a7d252c

Change-Id: I3fcfe4dc137756d5b4a049468632d111ca7fa4f6
2019-08-01 15:19:01 -07:00
Tony 13bdbffe29 Don't end launcher components anim early even if it does nothing am: 03c548901f
am: 1d7e474c69

Change-Id: I1f1f70c2791755535d1318b636e37a745e97d057
2019-08-01 15:18:36 -07:00
Jon Miranda f20a7d252c Merge "Fix bug where rounded corners were being set despite being disabled." into ub-launcher3-qt-dev
am: 9da9a2bd21

Change-Id: Icae4fd3fef3ad221d45e8d9ecdcc018813d560f3
2019-08-01 15:05:00 -07:00
Tony 1d7e474c69 Don't end launcher components anim early even if it does nothing
am: 03c548901f

Change-Id: Ifb228b935659e971facfd8d6bb4c56ab54424e68
2019-08-01 15:04:36 -07:00
TreeHugger Robot 9da9a2bd21 Merge "Fix bug where rounded corners were being set despite being disabled." into ub-launcher3-qt-dev 2019-08-01 21:47:47 +00:00
Tony 03c548901f Don't end launcher components anim early even if it does nothing
The janky animation that ends on the home screen with an invisible
task on top is caused by the following scenario (for example):
- Quick switch from task A to task B
- After landing on B, but before we get the callback that it was
  successfully launched, switch back to A (or you could go to C)

Now we are animating back to A, but we are still waiting to hear
whether B was successfully launched. If we hear that the launch
was indeed successful, we dutifully clean up after ourselves  by
returning launcher to its default state. Unfortunately, that
clobbers the current animation that is scrolling back to A, and
we end up in the bad state where we are showing the default
launcher state even though we just launched task B and were
about to launch task A.

Normally we avoid cleaning up the state animation if the user
is still controlling it. The reason we weren't doing that here
is because we ended the launcher animation early even though
the window animation was still running. Instead, we should keep
the launcher animation running for the full duration, so that
it prevents a cleanup from occurring in the middle.

Bug: 138620399
Change-Id: I959e62a52638a5b974ef9b406555078c928b91f1
2019-08-01 13:28:43 -07:00
Tracy Zhou 8e8a36f673 Change RecentsAnimationListenerSet interface (Launcher)
Bug: 138683199
Test: N/A
Change-Id: Ic53ef92fe4d5b55ff1d105a250accdf6f6c0916b
2019-08-01 11:18:15 -07:00
Tony Wickham 70f539cd45 Merge changes Ib3e373c2,Ia5d6f545 into ub-launcher3-qt-r1-dev
am: 1343f03e2e

Change-Id: Ie3f4c2c15e331c84f0f048c6337ae4e58111ec56
2019-07-31 15:36:50 -07:00
Tony Wickham 1343f03e2e Merge changes Ib3e373c2,Ia5d6f545 into ub-launcher3-qt-r1-dev
* changes:
  Tie prediction text to all apps interpolator
  Add OverviewScrim to show below overview but above workspace
2019-07-31 22:12:54 +00:00
Tony Wickham 35a4e0eec9 Tie prediction text to all apps interpolator
Now floating headers get 2 interpolators: one for the header content
itselt, and one for the all apps content that follows. That way, they
can choose to intperolate part of their content as if it were part of
all apps instead of the header. Currently, we do this to animate
predicted icons quickly, followed by the all apps icons, predictions
text, all apps scrollbar, and all apps divider as you continue swiping.

Bug: 132455160
Change-Id: Ib3e373c291e174e1306a53854d0ad4dc29eb4b76
2019-07-31 14:45:18 -07:00
Tony Wickham c088051c29 Add OverviewScrim to show below overview but above workspace
- Refactor some basic scrim logic to Scrim class and have
  WorkspaceAndHotseatScrim and OverviewScrim extend it
- Draw OverviewScrim under recents unless predictions are disabled, in
  which case draw it under hotseat (since that is in recents)
- Remove sysui scrim (behind status bar and nav bar) when overview is
  peeking

Bug: 132455160
Change-Id: Ia5d6f54582a4c5a70e3b2d4a98281567edd68519
2019-07-31 14:44:28 -07:00
Vinit Nayak 45c12ff1b5 Set recents view to be visible from alt+tab
Recents was being initialized but was not
marked as attached to app window. This
was causing it's animator to never make it
View.VISIBLE.

Test: Open any app
On physical keyboard press alt+tab
Observe that overview shows up

fixes: 138396234
Change-Id: I9e6c001242f4552027e79b162fb812f476823a37
2019-07-31 20:10:55 +00:00