Test: open a random app that hasn't been opened in a while, touch down
on nav handle and see if RecentsView scrolls partially or fully
offscreen; repeat 20 times to be sure
Bug: 233112195
Fixes: 235369468
Change-Id: Ie8b3dbea7c4826af037edf22360946105ab22134
This crash will occur every time user swipes back and
there is not a view to return to
Introduced in I56cda07f3eccc11e8909f7fb28210f65cc6e0f1d
Bug: 235494234
Test: manual
Change-Id: I1261afcefec8fed4be20ab9ef439a50bc706d464
Bug: 234648831
Test: touch outside recycler view inside container, doesn't swipe left/right
TL;DR;;
As the definition of ActiveRecyclerView changed in latest refactor,
scrollbar existence is no longer a condition to consume
touch event if user is in isSearching state.
Change-Id: Iec97fb036ad45796a77c59d35f329744398d4953
When you start searching, the header is set to "collapsed" mode.
This normally hides the tabs indirectly if the height of the
header changed as a result, which happens if there is a prediction
row because the previous height is non-zero but is considered 0
after the collapse. However, if there was no prediction row, the
height was already 0, so the header was not re-initialized, which
is where the tab visibility takes effect.
Fix: 235299156
Test: Manually with and without app predictions enabled and
keyboard default on/off.
Change-Id: I192a700ac83776f30d3207f92636113bdb8a86c5
The full padding was accounted for between the search bar and the
work/personal tabs, but only part of it was there when the tabs
were not shown.
Screenshot: https://screenshot.googleplex.com/8axV9QQ5Qy8MaUn.png
Test: Manually with and without work profile added. In the latter
case, nothing changed. The screenshot reflects the former case.
Fix: 233010483
Change-Id: I11b3c8cc814be48c25cbd9f454c3e122fff96fa0
Bug: 213314628
Test: work with UX to pick something darker than T80, present options
from T70 to T90, get feedback to use T80, verify at runtime via
screenshot dot is T80.
Change-Id: Ic5b47a419eb7697c22c4dd9ab849b8a00d73be9f
Hide keyboard with WindowInsetsController if could. In case
hideSoftInputFromWindow may ignored by input connection being finished
when the screen is off.
Bug: 233158645
Test: manual as steps:
1. Launch AllApps.
2. Tap search bar to invoke IME.
3. Screen off.
4. Screen on.
And all other keyboard hide cases such as back gesture, swipe down, etc.
Change-Id: I4154f38f94b6760a430f7510a650422020d8f59a
This just enables the setting for this feature. The default
value of the setting itself is still false.
Bug: 231433168
Test: Manually verified the option worked as expected, including
showing the user education when typing directly in All Apps
without tapping the QSB. Also verified previous features like
the snackbar to enable keyboard by default worked as before.
Change-Id: If423ae49436d1bf71579d52a99aea5ca3f2407dc
Bug: 230707341
Test: enter all apps
scroll so icon is covered by header
open app, swipe back to return to all apps
confirm fallback animation plays
repeat but scroll so icon is not covered by header
confirm normal animation plays
Change-Id: I56cda07f3eccc11e8909f7fb28210f65cc6e0f1d
Revert submission 17935777-lightDarkDetection
Reason for revert: Talked with Adam Cohen, white shadows are controverstial and we'd need to escalate to senior UX if we want to ship. James would rather do it in U timeframe, will flag to UXers we work with that the opportunity to escalate is available if needed.
Reverted Changes:
Ia91221427:Update light/dark detection.
Ie12d3d054:Update app icon shadows
Icc88c3496:Update smartspace shadow
Change-Id: I8bc90e79073b8e088f2912fef2af4c6c99a33553
Previously, if a user tapped on the clock icon then rapidly swiped back,
the clock icon would stop updating. This fixes that issue by avoiding
changes to the original icon's inner callback state while preparing and
displaying the FloatingIconView.
Bug: 188377749
Test: Locally enabled the second hand on the clock icon in addition to
the minute and hour hands, then verified that it was incrementing
correctly every second even after tapping then rapidly swiping back on
the clock icon.
Change-Id: Ib8eddb53de293194e5f9dce2fcafe8a481a6116c
This applies to phones only for the one-off transition (Home gesture or
swipe back. See before and after videos in the bug.
Bug: 234359814
Test: manual
Change-Id: I8f4fc9ec40687b641a721bd28b32fcf50514861f
The spec had a typo (EMPHASIZED_DECELERATE instead of
EMPHASIZED_ACCELERATE). In addition, we're now using LINEAR for the
background since the feel is smoother this way. Cleared with motion
(simonroberts@).
Bug: 232418544
Test: manual
Change-Id: I492dbe8008856d331836793177f1dd58c3265ca2
Hyunyoung Song
Tony Wickham
Becky Qiu
TreeHugger Robot
Andy Wickham
Jon Miranda
Sunny Goyal
Alex Chau
James O'Leary
Stefan Andonian
Luca Zuccarini
Winson Chung
Brian Isganitis
