Commit Graph

71 Commits

Author SHA1 Message Date
vadimt 6327dabc2a Not assuming reverse order of menu shortcuts
For Launcher3 tests the order can be either
Shortcut 0
Shortcut 1
Shortcut 2

or
Shortcut 2
Shortcut 1
Shortcut 0

Test: presubmit
Bug: 182006150
Change-Id: Ie014f5e5655a5b0bff05316c2a1457a5b5f703ef
2021-03-17 15:53:49 -07:00
Lucas Dupin 2268d7a937 Merge "Revert "Ignore broken launcher tests"" into sc-dev 2021-02-12 17:24:59 +00:00
Lucas Dupin db3f34f956 Revert "Ignore broken launcher tests"
This reverts commit 03c5a46235.

Reason for revert: Fixed tests
Bug: 180016597

Change-Id: I45390f157c6c3a379d686e8802648aa948071b72
2021-02-12 02:57:58 +00:00
Lucas Dupin 5fc546d09c Merge "Ignore broken launcher tests" into sc-dev 2021-02-11 23:15:39 +00:00
Ryan Mitchell 03c5a46235 Ignore broken launcher tests
Fabricated overlay changes seem to have made these tests flaky. Ignore
them for now while we figure out why the tests are flaky.

Bug: 180016597
Test: atest NexusLauncherOutOfProcTests
Change-Id: I639dabb2d6d57243882e0bc7100cc4947b32e37f
2021-02-11 18:20:43 +00:00
Steven Ng 2f5648a911 Refactoring before adding a new view type in the WidgetsListAdapter
Changes made:
1. Model: added an abstract class for storing common information for
   entries shown in the full page widgets picker.
2. Introduced a ViewHolderBinder interface to split the logic of binding
   data to ViewHolder into separate classes.
3. Move the view holder binding of WidgetsListRow from WidgetListAdapter
   to its new class.
4. Move some widgets picker classes into a new picker package.

Test: Auto: Run WidgetsListAdapterTest, WidgetsListRowEntryTest and
      WidgetsListRowViewHolderBinderTest.
      Manual: open the all apps widgets tray and navigate the list.

Bug: 179797520
Change-Id: Iab29557842bb79156cad84d00a4c5d0db0c5aa06
2021-02-10 21:23:40 +00:00
vadimt 0d9cb19453 Checking menu item test to improve test fail diags
Test: atest
Bug: 75641613
Change-Id: Idb5c7fe744e4a3e69ee0fdb59d1a5a58bc6ce0b2
2020-12-14 19:57:59 -08:00
Hyunyoung Song bb71582658 Merge remote-tracking branch 'goog/ub-launcher3-master' into temp
Test: make builds

Change-Id: I4e845aa51c9247328159e5aa0d95d425bffa435c
2020-08-06 11:04:41 -07:00
vadimt b3e8ae8230 Makeshift analog of Strictmode leak detector
Strictmode leak detector is still a goal, but we might not be able to
achieve it in R. Strictmode has several framework-side bugs that perhaps
hide Launcher-side strictmode violations, while the time to fix
everything is limited, and new leaks get introduced all the time.

For now, implementing a check that is slightly more relaxed than
Strictmode, but still ensures the absence of leaks. I’ll keep
eliminating Strictmode violations as well as keep strengthening the
makeshift checker conditions until we’ll be able to enable Strictmode in
continuous testing.

I’m disabling Strictmode checks for now so that they don’t generate
unnecessary hprof dumps, but leaving the code dealing with strictmode.

Bug: 139137636
Change-Id: Ib10136b0d4e9892f70a19cd052ae5a54cf0a4efb
2020-04-22 19:00:12 -07:00
vadimt cf275c1bd7 Choosing better points to output "start" events for TAPL
Now doing this before branching points, thus avoiding flakes when the
execution can go to an unexpected branch and not produce an event.

Bug: 153824894
Change-Id: If117da0498eaf2d94c9610552724981be34c6569
2020-04-15 12:45:11 -07:00
vadimt 0dd1bd1113 TAPL: Verifying activity start/stop events
It also turned out that Pilfer event seems to come in a
non-deterministic order relative to the events from the Main and TIS
sequences. So I moved it to its own sequence.

Change-Id: Ie4ea5865afd900bebbd8287dad2372c94dce8ad5
2020-03-27 10:23:33 -07:00
TreeHugger Robot 3ba6800552 Merge "Using StrictMode to detect activity leaks" into ub-launcher3-master 2020-02-27 19:19:14 +00:00
vadimt dbc7583054 Remove unnecessary PilferPointer events and enable testPressHomeOnAllAppsContextMenu
Change-Id: I04199f46024b05f05d04ba2be7a797842bb48527
2020-02-25 18:17:04 -08:00
vadimt 1779a38290 Using StrictMode to detect activity leaks
Change-Id: I615f641897d57be0cd31be944796c6931ef9ab00
2020-02-25 14:46:27 -08:00
vadimt b79614cc93 Performing a check for a crashed Launcher process for each UI test 2020-02-25 02:28:32 +00:00
Vadim Tryshev 47b3588ba5 Revert "Enabling testPressHomeOnAllAppsContextMenu while fixing failure cause"
This reverts commit c2842d8f4a.

Reason for revert: CL broke TaplTestsLauncher3.testDevicePressMenu in 2-button mode

Change-Id: Idebda69a36b94686415434e8e3f158a8a7abc5bb
2020-02-15 02:25:35 +00:00
vadimt c2842d8f4a Enabling testPressHomeOnAllAppsContextMenu while fixing failure cause
Change-Id: I012d5144651f5e7fb362caaef6eec8cee7622fb4
2020-02-14 14:50:28 -08:00
Pinyao Ting 796891bc06 remove stability annotation since it hasn't been flaking in the last
month

Bug: 146432215
Test: run flake locally
Change-Id: Ie7604088e82451f2c705f143d70af3f5c3b9c52d
2020-02-07 13:50:20 -08:00
TreeHugger Robot 0618d689e8 Merge changes from topic "state-supplier" into ub-launcher3-master
* changes:
  Translate recents slightly while dragging after pausing
  Two-zone model: swipe up from nav bar vs above it
  Change LauncherState to Supplier<LauncherState> in tests
2020-01-29 03:06:04 +00:00
Tony Wickham 8a054061ef Change LauncherState to Supplier<LauncherState> in tests
This prevents the test from statically initializing LauncherState and
all its static dependencies, which might lead to runtime exceptions in
out-of-proc tests.

Change-Id: I0e4e09dfb31a8b256c2c0c0b3d1d2ecd0cc92230
2020-01-28 18:07:33 -08:00
vadimt fcaab044a3 Avoid confusing errors "Launcher pid should be 0" when test setup fails
Change-Id: Ic5e8114a0f86d1a08738785c4098645e59a24975
2020-01-24 14:30:40 -08:00
Pinyao Ting 654adf657e integration test for open settings menu from workspace.
compare pid of launcher process after test execution to verify launcher isn't crashed when running in oop test.

Bug: 147235759
Change-Id: Id13c47f5c4e388cc8e95b19d099e94a2e540bf3f
Test: fun flake locally
2020-01-08 17:01:39 -08:00
Pinyao Ting cd1cc0efc1 Revert "include integration test for open settings menu from workspace"
This reverts commit e94baee999.

Reason for revert: Test failing

Change-Id: Icb5d27488618a9b70b83d7ab582082c396578700
2020-01-08 01:15:29 +00:00
Pinyao Ting e94baee999 include integration test for open settings menu from workspace
Bug: 146432215
Change-Id: I2d42984dd77506385230744361ae74944cc9b3bd
2019-12-20 15:37:36 -08:00
Pinyao Ting 44677f7e88 fix custom shortcut test
Bug: 143725213
Change-Id: I296452faea67568b39a35968bb813dc4e51a51fc
2019-11-14 14:13:22 -08:00
Pinyao Ting fed4d8e8da disable custom shortcut test in oop
am: d9dd8ef3ba

Change-Id: I6cb1f18c3e7ca1cd79aa5f58a0e03ef07eb797ee
2019-11-13 10:40:01 -08:00
Pinyao Ting d9dd8ef3ba disable custom shortcut test in oop
Bug: 142154748
Change-Id: I08ec8f665a3cc45610f8f2b27a60f7334a2b1b24
2019-11-12 23:37:20 -08:00
vadimt b0a14e96ae Removing temporary tweaks to make tests pass in presubmit
Now that we have a more reliable build of CF

Bug: 142828227
Change-Id: Ib385443048b6ccd9e1eb3372dc39947536f948bd
2019-11-11 09:23:28 -08:00
Pinyao Ting 5eee5f4da0 enable custom shortcut test
Bug: 141568904
Change-Id: Ie51ef6f7a2f5d4579689a82184bdd7681a266d04
2019-10-31 17:09:40 -07:00
vadimt ad81b816f0 Step 4 from the plan below:
1. Skip all tests that fail in inproc mode on CF (this CL)
2. Observe postsubmit and make sure no inproc tests are failing or too
flaky on CF
3. Enable presubmit
4. Switch to skipping tests from step 1 only for inproc presubmit;
they'll start failing in postsubmit
5. Gradually make all tests pass and not flaky and enable them back on
presubmit

Bug: 142828227
Change-Id: I0092d6b92b0358866f8cbf9e00dbe3fabe23703d
2019-10-17 17:52:29 -07:00
vadimt 3680357a67 Preparing to enabling Inproc launcher tests as presubmit
The plan:
1. Skip all tests that fail in inproc mode on CF (this CL)
2. Observe postsubmit and make sure no inproc tests are failing or too
flaky on CF
3. Enable presubmit
4. Switch to skipping tests from step 1 only for inproc presubmit;
they'll start failing in postsubmit
5. Gradually make all tests pass and not flaky and enable them back on
presubmit

Bug: 142828227
Change-Id: I6ea3d53771503e8fd968555bb2e4cb1be10d83ef
2019-10-16 17:35:18 -07:00
vadimt 36d7be7fc9 Implementing test stability attribute
Change-Id: I5d78a19039ab2bcdb217886fdaca29e3df412780
2019-10-15 18:40:53 -07:00
Pinyao Ting b3d3ca87dd temporarily disable a regression test to unblock merging to master
The test case testDragCustomShortcut was created initially to prevent future regression on custom shortcut (b/141568904), which was caused by ag/9342399.

Some times after ag/9342399 was reverted on ub-launcher3-master, a different error is causing custom shortcut to not working intermittently (b/141528961). Since this is different from b/141568904, it should not be a blocker to merging to master.

Bug: 141568904
Change-Id: Ia11e1ae44d0ef86c16876c002954aa662f1edbc8
2019-10-15 21:32:47 +00:00
Pinyao Ting d7fdcab612 correct naming and add comments for test case of custom shortcut.
Bug: 141934188
Change-Id: I69ce5f05214df10e2a376ff68c713efe8874df15
2019-10-03 10:15:30 -07:00
Pinyao Ting d625e49552 include integration test for adding shortcut widget
this integration test help us catching app crashes when adding shortcut
widgets to the workplace. see b/141568904 for more context.

Bug: 141934188
Change-Id: I4d33d6127793efe2071d0d146aef24db6b676360
2019-10-03 07:46:50 -07:00
vadimt fead086f2d Experimenting with detecting whether a test runs in presubmit
Change-Id: I386c6ad29182170326c557252fe6e20a8d2af34a
Merged-in: I386c6ad29182170326c557252fe6e20a8d2af34a
2019-09-19 01:18:46 +00:00
vadimt 0ce38af957 Enabling debug tracing for all UI tests
Change-Id: I434ee378baf35de955c8a589b8380e1751e4107a
2019-09-03 17:16:34 -07:00
vadimt f1726290d4 Adding debug tracing to catch non-dragging to workspace
Bug: 138729456
Change-Id: I28f1eaeb17a75cbc6f52b259d0226deaff42e0bb
2019-08-05 13:52:36 -07:00
vadimt 6b466783b7 Improvements in getting workspace app icon
Bug: 138743792

Change-Id: I11981774397b82bdad0352343a52341c2e3a5099
2019-07-31 21:48:04 +00:00
Vadim Tryshev 004a5fe6c5 Revert "Reenabling testPressHomeOnAllAppsContextMenu"
This reverts commit 86f5da2d8f.

Reason for revert: Test fails in 2-button mode

Change-Id: I20163a658f731cf6ef27ce84f5f7c06919b7b9cd
2019-07-25 21:51:10 +00:00
vadimt 86f5da2d8f Reenabling testPressHomeOnAllAppsContextMenu
Bug: 134074554
Change-Id: Icd23e2dcafab091e5406e84bb827bfc7177832ff
2019-07-25 12:06:32 -07:00
vadimt 0b20a11d66 Converting even more tests to TAPL
Bug: 131116002
Bug: 115582915
Change-Id: Id36fca232b5aff5f6692142ce4a0c937d0531f4e
2019-06-27 18:38:09 +00:00
Vadim Tryshev 1703eb8b88 Merge "Revert "Converting even more tests to TAPL"" into ub-launcher3-qt-dev 2019-06-27 00:20:51 +00:00
Vadim Tryshev 007e7e94b3 Revert "Converting even more tests to TAPL"
This reverts commit 406d49bdd7.

Reason for revert: Breaks tests on Crosshatch

Change-Id: I95ff541dfe8f6f1d7e1913d209b53abfbebe5336
2019-06-27 00:03:14 +00:00
vadimt f45509ec8e Reenabling tests in OOP
Bug: 124524897
Change-Id: I8bdaa0d129c7366616359a3505f3d6b2d397e18f
2019-06-26 15:16:26 -07:00
vadimt 406d49bdd7 Converting even more tests to TAPL
Bug: 131116002
Bug: 115582915
Change-Id: I08587e7a50420e57970ed8feec4524111145dc31
2019-06-26 13:58:33 -07:00
vadimt 06d30e54d5 Enabling tests in landscape mode
Bug: 121280703
Change-Id: I3245ca8d0b0496035658ce2a602882a62942f3f1
2019-06-17 15:13:25 -07:00
vadimt d4c90e12e9 Freezing all apps updates during certain tests
This CL adds a very low risk because most (but not all) changes affect
only Launcher behavior during the test.

This should fix a lab-only flake when all apps keeps changing while
the test is working with it.

Example: test figures out which icon to click, by the moment it clicks
there, there is another icon there, or the icon is under the search box,
and clicking opens IME.

Switching test devices to airplane mode didn't help. The earlier change
that prevents popup menu cancellation is not general enough.

Now the tests are given an API to explicitly freeze and unfreeze
all-apps, which should be a final solution.

Bug: 132900132
Bug: 133765434
Change-Id: I8b81cc9be004482beb6cdcdd05406e2d9b4c7629
2019-06-06 11:10:56 -07:00
vadimt 3369d7308f Ignoring testPressHomeOnAllAppsContextMenu for now as it flakes
Bug: 132460627
Change-Id: I2af5bba289781a122cf9253833915b0e8cddd79c
2019-05-28 19:15:04 -07:00
vadimt aa8019308b Fixing pressHome when a context menu is visible
Bug: 132460627
Change-Id: I78064166fccd3a29bcb3fa6175bd4937ae032a98
2019-05-28 17:31:03 -07:00