For devices with smaller screens and the largest fonts and display
sizes, the end screen of the gesture navigation tutorial would cut off
the `Done` button at the bottom. This adds margins so that the button
remains visible on the screen.
Screenshot of Pixel 5 with the largest font and display:
https://screenshot.googleplex.com/AU5rYYBisZ9Azbr.png
Fix: 275540512
Test: Went through the tutorial with default and largest font sizes on both smaller devices and tablets to ensure the button is always visible.
Change-Id: I66baf9b9044211550395bb3823797127de5e1f99
This simplifies insets handling for All Apps and EDU, and also fixes
some edge cases with All Apps popup menus. KeyboardQuickSwitchView now
needs to ignore insets since it has a hardcoded top margin,
keyboard_quick_switch_margin_top.
Fix: 276804708
Test: All Apps, EDU, and Quick Switch all have proper insets handling.
Change-Id: I93237a057b4f9ae62f71a70c59a58f3c8401c102
This reverts commit 0263a679f2.
Reason for revert: Trying again to confirm if this was the actual cause of regression
Change-Id: I2a663015d7ecdcf315634d8a976bf8294b58981d
- Added the gesture tutorial menu page (launched using an intent extra)
- tutorial steps now launch the menu when complete if launched from the menu
- the new default set of tutorial steps is home -> back -> overview. this is to handle the case where an intent is launched that is meant to launch the tutorial menu, but ENABLE_NEW_GESTURE_NAV_TUTORIAL is false
Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Bug: 274463555
Test: Ran the tutorial and menu on a large screen, foldable and phone
Change-Id: I2eb5f658115be4d5ecb0233a8f09d22efe6ebadc
- Renamed variables to make it more clear what they represent
- DeviceProfile will be source of truth for taskbar
sizes
Bug: 265144213
Test: phone, multi-display, tablet
Change-Id: Id9c19d15a65894fd7645e0f876a4b6527b713c34
Flag: ENABLE_TRANSIENT_TASKBAR=true
test: built and tested on multiple devices. recorded videos and shared in chat.
bug: b/253520701, b/253521660, b/241813570
Change-Id: I57f88f5fb35c6a7b1219fac6e992bb84354b91ef
This change adds in a new animation and layout to change the existing back tutorial as part of the effort to redesign gesture navigation education for users. This temporarily uses placeholder animations for the overview gesture. Large screen animations are also added for Home and Back tutorial.
Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Bug: 241813570
Bug: 253521922
Bug: 253520701
Test: Manual
Change-Id: Ied18b88a83a3b673a7cf40fd33b6013f24998e44
be easily modularized
> Moving the color configuration to xml
> Moving auto-hide logic to a subclass as it doesn't
need to be in the main library
Bug: 274011949
Test: Verified on device
Change-Id: Icf7bd5d1cbde3daa9441f2af51f98a931bcd6ee2
Do not show the desktop tile in overview when there are no apps on the
desktop.
Bug: 270399069
Test: have desktop mode proto 2 enabled, launch an app in fullscreen,
open overview, observe no desktop tile
Test: move an app to desktop, be on desktop, open overview, observe
overview is opened with desktop tile focused
Test: have an app on desktop, go home and launch an app in fullscreen,
open overview, observe fullscreen app is focused, desktop is peeking
in from right
Test: have an app on desktop and a fullscreen app in overview, open
desktop from overview, close the desktop app, open overview, observe
desktop tile is not shown
Change-Id: Ia8657d5b260043a630f32b35f2560ea93273d421
On large fonts and display sizes, the navigation settings text can overlap with the home gesture hint. Adding some additional translation to account for this.
Fixes: 269716511
Test: Launched all set page on the largest and default font and display sizes on a phone
Change-Id: I4a40b06b827667de9b0bdb893320b0a9890f6699
Show an empty view when there are no tasks on the desktop.
Bug: 267326725
Test: have a fullscreen task, open overview, observe empty view for
desktop tile
Test: have a desktop task, open overview, observe desktop task thumbnail
is shown in overview and empty view is hidden
Change-Id: Ifb6d96d42bf602e9cc9e397efc0e07e2accdf16b
When a external keyboard is connected and ENABLE_KEYBOARD_QUICK_SWITCH
feature flag is enabled, we highlight the selected tile in overview.
Add support to the new desktop tile to show the highlight.
Bug: 269342116
Test: connect an external keyboard, use alt+tab to open overview and
switch between the tiles
Change-Id: I29ac5864776a9a251ecdb0cb4b741b12747de564
Adding KeyboardQuickSwitchView and associated flows.
Test: Manually tested alt-tab and alt-shift-tab in and out of overview on a tablet and phone
Bug: 258854035
Change-Id: Ifb48b005067b3a9c66acfd5ecdbae144b359d3be
Preparatory change for adding the KeyboardQuickSwitchView and associated flows.
Test: Manually tested alt-tab and alt-shift-tab in and out of overview on a tablet and phone
Bug: 258854035
Change-Id: I468481a023e82d3ef7c7d4d44c5b9435173b49ae
Copied over icon from caption desktop button in WMShell. Temporary icon
for now.
Refactored some logic in TaskView to better support for custom
orientation handling in subclasses. Subclasses can override setting
orientation for icon or thumbnail.
Bug: 267326722
Test: manual, enable desktop windowing proto 2 and go to overview
Change-Id: Id66d48fa52a418a07b954a384b2c3ea22f091b1f
Use Views in layouts for the gesture navigation tutorial instead of CardViews. We only migrate the classes that will end up being used in the redesigned gesture tutorial.
Fix: 268259319
Test: Manual
Change-Id: I510c8b3f840d0267dd6dfca573cc69c4996d525c
When desktop windowing prototype is enabled, pin desktop tile to the
right of the focused tile.
Also making desktop tile persistent so it will always show up,
regardless whether there are tasks added to the desktop or not.
Fixing some nullpointer issues that stem from that.
Bug: 261234155
Test: no recent tasks, go to overview, shows empty view
Test: only desktop tasks, go to overview from home, desktop tile focused
Test: only desktop tasks, desktop open, go to overview, desktop tile
focused
Test: 1 fullscreen task and some desktop tasks, go to overview from home
screen, fullscreen tile focused
Test: fullscreen task open and no desktop tasks, go to overview,
fullscreen task focused and empty desktop tile on the right
Test: fullscreen task open and some desktop tasks in background, go to
overview, fullscreen tile focused, desktop tile on the right
Test: some desktop tasks focused, some fullscreen tasks in background,
go to overview, desktop tile focused, fullscreen tasks on the left
Change-Id: Ib28185b40f639d36b82b6d0e3c61026ec84e245c
This change adds in a new animation and layout to change the existing home tutorial as part of the effort to redesign gesture navigation education for users. This temporarily uses placeholder animations for the back and overview gestures.
Bug: 253521921
Bug: 241813570
Test: Manual
Change-Id: Ifd2de68d995172765d17578cebfd0d88ab7c2e5a
These are temporary UI updates until the redesigned gesture nav tutorial is ready.
Fixes: 265857697
Test: ran tutorial on large screen device
Change-Id: I3e50de1b0f5cd9e84dccea17c7ac07d3668e1168
These new assets are better at looping than the previous ones.
Followed go/sysui-illustration-eng to map from dark to light colors
programmatically. Handling the mapping in code is preferred over having
separate lottie assets for light and dark theme.
Test: Manual
Bug: 263157739
Change-Id: Ia3cd2a1e7d349188d182d796ba927f1c513d4716
Since this tooltip looks and behaves differently than the existing EDU
sheet, it has its own view and controller implementations (I also may
have wanted to write some Kotlin).
To keep transient taskbar open while on the second EDU step, another
autohide suspend flag is defined. Additionally, special casing is added
to avoid hiding transient taskbar if autohiding is currently suspended.
Tooltips use the same assets as the bottom sheet for now, and are scaled
down to fit the tooltip dimensions.
Reset `Taskbar Education` in Developer Options to try EDU again.
[Demos]
- First: https://screenshot.googleplex.com/ASBeGvrb2EA5wEF.png
- Second: https://screenshot.googleplex.com/7fnfcTh9bMYezDc.png
Test: Manual
Test: Open app, see swipe-up tooltip.
Test: Swipe up to show transient taskbar, see features tooltip.
Bug: 263157739
Fix: 258460203
Change-Id: I473f5fccbae279db0614763b640da0a120b6b7f7
Brian Isganitis
Sunny Goyal
Saumya Prakash
TreeHugger Robot
Schneider Victor-tulias
Jagrut Desai
Jon Miranda
randypfohl
Marcelo Arteiro
Ats Jenk
