This could not be reproduced until I removed a line that wouldn't call
onAssistantVisiblityChanged if the argument was the same value as the
argument as the previous call.
After that, the bug became readily reproducible. I traced through
Launcher till I found that FallbackActivityControllerHelper
.onAssistantVisibilityChanged was being called while the screen was
locked, proving that onAssistantVisiblityChanged was _not_ reaching
launcher.
Test: Verify bug no longer reproduces.
Bug: 134981174
Bug: 135247753
Bug: 135572849
Bug: 135733393
Bug: 136386749
Bug: 136776987
Bug: 137534772
Bug: 137764419
Change-Id: Ib5e8df3b5030a77c5df351a1fcd993db6bd602fc
hardcoding it to 16ms
> Creating a utility class for caching display property changes
Bug: 128940249
Change-Id: I6f9a214548de65bd1c8530508d665ee88312da4a
mMidProgress is intended to be the point at which we reach Overview when
swiping up and thus start scrimming it as All Apps shows above it. For
that reason, mMidProgress needs to match OverviewState's progress. In
contrast, the drag handle (accessibility arrow) can move up sooner to
avoid overlapping with the QSB; for this, we added mDragHandleProgress.
Bug: 136800511
Change-Id: I2825ff798707530420855257350e492b4b9b77dc
- Skip the assistant as the running task when handling swipe up
- Also ensure that we fall into the overview input consumer if we are
swiping it from the assistant over home
- Skip accounting for the scroll offset when there is no running task
Bug: 136282913
Change-Id: I28e45e407702d6d6aebaa0232cd96ccb10047644
Made ctor accept more arguments so we can
pass in mock objects for unit testing.
Test: Created RecentsTasksListTest.java, passes
adb shell am instrument -w -r -e debug false -e \
class 'com.android.quickstep.RecentTasksListTest' \
com.google.android.apps.nexuslauncher.tests/androidx.test.runner.AndroidJUnitRunner
Fixes: 135687618
Change-Id: Iffda661e9d5329a2a403060bde674ab81e4e720e
The original bug that was solving seems to be fixed by other changes,
and this allows users to scroll, dismiss, etc on recent tasks before
fully reaching overview from an app.
Bug: 137487381
Change-Id: I28a708811bba3ce739ce261f19eb29558d8f0e7d
This regressed in ag/8542000, where we cancel the animation instead of
ending it. We should only cancel when going to home; in other cases, we
should still call end().
Bug: 137487381
Change-Id: I093954908c3ac747ec3132aa700c8be2f927631a
This allows other components to get it directly from the view, rather
than retaining their own copy.
Bug: 137129923
Tested: Manual
Change-Id: Ibab307517c31cd3cb59b4d77ff390fd97546e86d
Instead of referencing Launcher directly (which may not be
present when there's a 3P launcher), reference the lowest
common ancestor of Launcher and RecentActivity to avoid
ClassCastExceptions.
Test: Visually inspected that Pixel Launcher crash dialog
no longer pops up.
* Install 3P launcher
* In developer options enable "enable freeform windows"
* Restart phone for settings to take effect
* Try to use it on any app you have in recent tasks
Fixes: 135419782
Change-Id: Ie1f54880ab46956b23e253850ca7f79b161da9bd
Currently only StatusBarTouchController overrides this to always return
false, so that you can swipe down for notifications during transition to
home screen from an app (in gesture nav).
Bug: 137161198
Change-Id: I803c37937d5294810cbe0c1bbffcd5dddcc5ca3b
Otherwise the preload may cause launcher to restore too early, resulting
in data loss.
Bug: 131315856
Change-Id: I4412c8f691286ba142e9c748a908a3ed42713a82
Instead of individually removing tasks,
ask for all tasks to get accurate list.
This method is invoked whenever user presses
back on a root activity, which causes the task to
be killed from perspective of the activity.
Test: Visually inspected, recent task no longer
disappears.
Open any app, hit back, and then go to overview quickly.
App should remain in recents list.
Fixes: 135687618
Change-Id: I1c135673ae987016db5df0b83f5ea8e345d3c7c1
(cherry picked from commit 8651219f7e)
Instead of individually removing tasks,
ask for all tasks to get accurate list.
This method is invoked whenever user presses
back on a root activity, which causes the task to
be killed from perspective of the activity.
Test: Visually inspected, recent task no longer
disappears.
Fixes: 135687618
Change-Id: I1c135673ae987016db5df0b83f5ea8e345d3c7c1
James O'Leary
Vadim Tryshev
Tony Wickham
Sunny Goyal
TreeHugger Robot
Winson Chung
Zak Cohen
Vinit Nayak
Jon Miranda