Commit Graph

1979 Commits

Author SHA1 Message Date
Sebastian Franco b1c47097d8 Move fixed landscape in RotationHelper from a request to a variable
Bug: 364711735
Test: NA
Flag: com.android.launcher3.one_grid_specs
Change-Id: I38ed82b2906308754d5157f6319e5d19fcfbc385
2024-11-08 12:09:08 -08:00
Sebastian Franco 9e4c99befd Adding Launcher Mode settings to Launcher settings
Bug: 364711735
Test: NA
Flag: com.android.launcher3.one_grid_specs
Change-Id: Iab688ebdb8449f9258b61f59a0afe97875f82a81
2024-11-07 21:17:10 -08:00
Shamali P ea078cb647 Add a resource override for providing default widgets filter.
The implementation in this CL is no-op i.e. all widgets will be shown

Bug: 356127021
Flag: com.android.launcher3.enable_tiered_widgets_by_default_in_picker
Test: Verified with other child cls
Change-Id: I0a6f8973dc8ec58fd87d29b3f291b5e290ea988d
2024-11-04 22:17:23 +00:00
Treehugger Robot f6c4a7acb1 Merge "[PostBoot] Fix bug where post boot shader has a flicker" into main 2024-10-26 07:17:58 +00:00
Fengjiang Li dd7d854c3a [PostBoot] Fix bug where post boot shader has a flicker
Pass correct default value -1 when getting RUNTIME_STATE_PENDING_REQUEST_CODE when it is not set.

This will avoid accidentally starting ProxyActivityStarter from Launcher#onCreate(), which will cause a flicker for post boot animation

Fix: 375308654
Flag: NONE - xml flag not supported
Test: manual
Change-Id: Ic3888508657b5b7aab37f6022768d53007bf9c00
2024-10-25 03:59:47 +00:00
Schneider Victor-Tulias 8463dc47eb Generalize ActivityTracker to support RecentsWindowManager
Continued quick switch couldn't work using existing infrastructure until RecentsWindowManager could be properly tracked by ActivityTracker. Refactored ActivityTracker into ContextTracker to support this.

Also refactored ActivityInitListener into ContextInitListener to fit the updated pattern.

Flag: com.android.launcher3.enable_fallback_overview_in_window
Fixes: 366023051
Test: RecentsWindowSwipeHandlerTestCase; Attempted continued quick switch from home and launched app
Change-Id: Ic38ebf3611ef22fbfd1ddeb79d72d8a3621940a0
2024-10-22 15:29:59 -04:00
Brandon Dayauon 093cf62e69 Merge "Force config update when twoline is toggled." into main 2024-10-12 05:33:47 +00:00
Brandon Dayauon 05105162d7 Force config update when twoline is toggled.
Based on the bug, it seems that onHandleConfigChange was not called via the perfetto trace. Here is the call order:
1) Loader Task is created
2) Loader task runs
3) Preinflation happens from setApps() in bindAllApplications() via ModelCallbacks.kt
4) When show long app names toggle happens: it eventually triggers an onHandleConfigurationChanged() which is traceable in perfetto.
5) After configChange, preinflation happens again.

In step 4) there is an early return that happens and makes it so it doesn't call the reinflation of views that happens in the mModel.rebindCallbacks().
When the force configUpdate happens upon toggle, reset the variable after it is done.

bug: 370121944
Test: presubmit/manually/perfetto in bug
Flag: NONE trying to fix edge case
Change-Id: Id0ba591bfe583b300cc241fcfc37db6dd5a85363
2024-10-11 15:43:02 -07:00
Shamali P dfcec9c71c Fix issue that widget drag and drop failed when are off
Remove extra screen & go to normal state only if widget
addition was complete. If a config activity was started, then
don't change to remove screen yet or go to normal state. Else,
QuickStepLauncher clears the existing activity open requests when
going to normal state. When animations are off, this led to config activity to never launch and hence, such widgets not being added.

Bug: 369422714
Test: Manual
Flag: EXEMPT BUGFIX
Change-Id: I4e7e29fd998a0cc5ca18a7a48b91a5b788a60a52
2024-10-09 20:28:39 +00:00
Sunny Goyal 621918feda Changing min-sdk version of Launcher to 31
Bug: 368071216
Flag: EXEMPT refactor -> dead code removal
Test: Presubmit
Change-Id: I1f0113c56de56f12f3a174eb31c3f8e8a09407e6
2024-09-20 06:00:10 +00:00
Mykola Podolian bff3b73c8f Merge "Hide hotseat when bubble bar is expanded." into main 2024-09-17 17:38:33 +00:00
Liran Binyamin 69f4974e24 Hide hotseat when bubble bar is expanded.
Added logic to stash the hotseat when on launcher home screen.

Bug: 280494203
Test: Manual:
http://recall/-/gx8ASgewUeUS3QYohfrd1J/fjfjUw296LRXUm9uYqXU4K
all tests in com.android.launcher3.taskbar
Flag: com.android.wm.shell.enable_bubble_bar

Change-Id: I67b298831eaed9c549a2fae7dc5a0d9fae51f7c4
2024-09-16 15:50:28 -07:00
Sunny Goyal 4f9ba255a4 Cleaning up some enabled features
Bug: 270394468
Bug: 270393900
Bug: 270390907
Bug: 270390930
Bug: 270390937
Bug: 270391693
Bug: 270391638
Bug: 270395177
Bug: 270395269
Flag: EXEMPT legacy flags cleanup
        ENABLE_SHOW_KEYBOARD_OPTION_IN_ALL_APPS
        ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
        ENABLE_DEVICE_SEARCH
        ENABLE_HIDE_HEADER
        ENABLE_TWOLINE_ALLAPPS
        IME_STICKY_SNACKBAR_EDU
        FOLDER_NAME_MAJORITY_RANKING
        SCROLL_TOP_TO_RESET
        ENABLE_SEARCH_UNINSTALLED_APPS
        ENABLE_HOME_TRANSITION_LISTENER

Test: Presubmit
Change-Id: Ia392c10fc65616405cc4d4a2b8ed566e3bb7d386
2024-09-13 14:24:27 -07:00
Fengjiang Li 97db09dbd8 Merge "[-1] Show toast when user trys to swipe to -1 on extreme battery saver mode" into main 2024-09-10 16:41:21 +00:00
Fengjiang Li a7e357e339 [-1] Show toast when user trys to swipe to -1 on extreme battery saver mode
Fix: 355485335
Flag: com.android.launcher3.use_activity_overlay
Test: manual - record a video
Change-Id: I79a3ece2fb2c0d1eddac0e4f91274ffe222e317f
2024-09-09 19:06:17 -07:00
Sunny Goyal f158286c34 Adding more properties in LaunchCookie, instead of just itemId
This allows better matching of items who do not have a fixed id

Bug: 364363493
Flag: EXEMPT bug fix
Test: Manual- Verified app launch and back animation
Change-Id: I4f9deba89399b89974686b64226b99f91a3d46be
2024-09-09 12:11:36 -07:00
Mark Fasheh 4baa30d151 Update launcher cold startup trace
Bug: 341061764
Flag: EXEMPT bugfix
Test: Boot phone, take trace
Change-Id: I29b5be5525206ac83bc36596395a1f71b43715c6
2024-08-29 00:03:00 +00:00
Sunny Goyal 42becd041b Cleanup unused workspacePageIndicator
Fix: 270395278
Flag: NONE removing dead code
Test: verify everything still works the same
Change-Id: Id0eda5c5994c3323a8d16900678fbd7b39911b62
2024-08-27 12:23:21 -07:00
Treehugger Robot 85b03a9f78 Merge "Add logs to check if onLayout is ever not called." into main 2024-08-20 21:09:38 +00:00
Brandon Dayauon 71fff87e2d Add logs for when sectionInfo is computed or added for bugreport.
bug: 336947811
Test: manually/presubmit: https://screenshot.googleplex.com/A2st8q57pajFBcG
dump: https://screenshot.googleplex.com/8JGoqz2ixodHH94
Flag: NONE adding logs

Change-Id: I3edc953fa8ec58a3677cc65f858b50d95184592c
2024-08-15 11:40:31 -07:00
Stefan Andonian fb34891ba6 Add logs to check if onLayout is ever not called.
Bug: 349929393
Test: Verified locally that the logs are shown in a bugreport.
Flag: EXEMPT logs
Change-Id: Ie5b759a2616456db9e232efcb0cfd21fdd4cc291
2024-08-15 18:22:25 +00:00
Shamali P 74d9fbd635 Define widget picker data provider separate from popup provider
Separate provider in ActivityContext and relevant implementations that
open widget picker

Bug: 353347512
Flag: EXEMPT BUGFIX
Test: Unit test
Change-Id: I55df3d9ce6ae9b7d0a310a8686b188618d229065
2024-07-22 23:58:04 +00:00
Sebastian Franco c794aca69f Refactoring FolderPagedView to make it more testable
Bug: 353588686
Test: Compiles
Flag: NONE refactor
Change-Id: I612523282a57beac90b14a890a333a1670ab0d48
2024-07-17 23:32:17 +00:00
Sebastián Franco 6e43c6aadf Merge "Moving ReorderWidgetsTest to an integration test instead of E2E" into main 2024-07-10 18:28:08 +00:00
Sebastian Franco 224f67a046 Moving ReorderWidgetsTest to an integration test instead of E2E
Flag: TEST_ONLY
Test: IntegrationReorderWidgetsTest
Bug: 324261526
Fix: 343761044

Change-Id: I9bfe8b587e1024260ddeeb48157c3d204f2d58f2
2024-07-10 04:20:41 +00:00
Sebastian Franco 00ed8ccde7 Update back gesture zone any time the screen size changes.
Fix: 336697780
Test: Manual testing, open widget picker on folded front screen and then unfold, the widget picker should be showing and the backgesture should work.
Flag: EXEMPT bugfix
Change-Id: Ie4a7bffbd9b24ba26826f825a7c66216f565952f
2024-07-03 13:54:39 -07:00
Ivan Tkachenko f58d227f61 Fix back gesture navigation in Launcher with DW
The windows back functionality with the
`enable_desktop_windowing_wallpaper_activity` flag enabled works as
expected and doesn't require changes in `#updateDisallowBack`.

- Added the `enable_desktop_windowing_wallpaper_activity` flag check in
  `Launcher#updateDisallowBack`
- The early return statement will get removed after flag is fully rolled
  out (b/333533253)

Bug: 330183377
Test: manual
Flag: com.android.window.flags.enable_desktop_windowing_wallpaper_activity
Change-Id: I2eaaa44da82da6cbdfe534793830d0f44c4668ba
2024-06-19 11:57:06 +00:00
randypfohl 176ce85d27 Abstracting StatefulActivity from StateManager
Flag: NONE - abstraction with no logic changes.

Test: Built and ran locally, for launcher3 and third party launchers

Bug: 224595066

Change-Id: I9da15bdd649d3a20e98c6552bb9e9abaec72f97f
2024-06-13 10:26:12 -07:00
Himanshu Gupta cf3a0ef2f0 Merge "Prompting the user to set Pixel/Quickstep as default Home app." into main 2024-06-12 21:13:19 +00:00
Himanshu Gupta 261a62219b Prompting the user to set Pixel/Quickstep as default Home app.
requestQuietMode API throws SecurityException in case its called
from a non-default Launcher app.
To mitigate this, we catch the exception and prompt the user
to set their default launcher to the current app.

Video(Pixel): https://photos.app.goo.gl/ni5X1c6vBbYW2JMJ9
Video(Pixel-aosp): https://photos.app.goo.gl/cYLJpTYW76Jnbonc9

Bug: 320446272
Test: Manual
Flag: NONE Bug fix tweak.
Change-Id: I6afb2ae85cabc038e1503e9c34eebd974c4f7a50
2024-06-11 19:11:21 +01:00
Pragya Bajoria d8522b7828 Update the flag check for back gesture to include tablet filtering to reduce the scope of desktop windowing logic.
Change-Id: I15edeceebfdc14569c1b98caf62c741b40049200
Bug: 346249587
Flag: EXEMPT (windowing is currently only limited to Tablet)
2024-06-10 19:29:30 +00:00
Schneider Victor-tulias 38b9e1438e Merge "Clean up unused debug logs for b/319168409" into main 2024-06-03 20:31:42 +00:00
Anton Vayvod ee38224910 Guard Flags references with a check for running on Android V.
Otherwise, Launcher3 next build crashes on non-V devices.

Bug: NONE Trivial cleanup.
Test: manual
Flag: NONE The change deals with flags

Change-Id: I9d9335ea1cb0f299aa5af8095ff1ea2f98c23542
2024-06-03 19:04:41 +00:00
Schneider Victor-tulias 43592a83c8 Clean up unused debug logs for b/319168409
Flag: NONE removing debug logs
Fixes: 319168409
Test: TaplDragTest#testDragAppIcon
Change-Id: I73208b042248df04281d52eaf3ed6832abbfc144
2024-06-03 12:05:40 -04:00
Jordan Silva 8181dfdf92 Fix Talkback wrong label announced going from App to Overview
To fix the incorrect title information being spoken after a transition state ends, a new function named getTitle is introduced in the LauncherState. This function provides the correct title for the transition state. The default accessibility label is set to R.string.home_screen. All Apps and Overview states override the getTitle function to ensure the correct accessibility label for their respective states.

Fix: 265892510
Flag: EXEMPT bugfix
Test: Manual with Talkback. With Talkback enabled, navigate from App to Overview.
Change-Id: I96b820f310f8b778a149709bca687a5912386246
2024-05-30 14:01:32 +00:00
Schneider Victor-tulias 8288819aa6 Add debug logs for b/319168409
Flag: N/A
Bug: 319168409
Test: TaplDragTest#testDragAppIcon

Change-Id: I96d26cc78af0a3f4145fc3486c4b6adfbd110c9e
2024-05-06 16:22:03 +00:00
Holly Jiuyu Sun 477d70f92e Merge "[reset] Call SearchUiManager#resetSearch instead of reset." into main 2024-04-30 21:20:22 +00:00
Federico Baron c113ce9f9f Merge "Migrate smartspace as a widget and smartspace removal toggle flags to aconfig" into main 2024-04-29 21:46:03 +00:00
Holly Sun 7bb9247bf6 [reset] Call SearchUiManager#resetSearch instead of reset.
This is a follow-up of ag/26362927.
When it's in searching state, we only need to reset search instead of resetting everything.

Test: search something and scroll in AA+. Trigger AA+ by filing an intent (adb shell am start -n com.google.android.apps.nexuslauncher/.NexusLauncherActivity -a android.intent.action.ALL_APPS). Notice the search RV is reset and scroll to top.
Bug: 328505782
Flag: aconfig com.android.launcher3.enable_private_space nextfood
Change-Id: I9d1d4386077433a676c1f3b8e3614fb848284a88
2024-04-26 14:25:16 -07:00
Holly Sun 47b9cb8436 [a11y] Change all apps screen name to All Apps instead of reusing Home.
Now even when we enter the All Apps page, talkback still reads the page name as Home (https://source.corp.google.com/h/googleplex-android/platform/superproject/main/+/main:packages/apps/Launcher3/src/com/android/launcher3/Launcher.java;l=586;drc=120838b04dcaf072704c6fb382ea9115672cfcaa).

Bug: 330470894
Bug: 333833220
Test: manual
Flag: NA
Change-Id: I32a1ce8844cd111c7d1c492ee0a39fec47858a47
2024-04-25 15:13:41 -07:00
fbaron 9d08e0fe70 Migrate smartspace as a widget and smartspace removal toggle flags to aconfig
Bug: 336823684, 336823681
Test: none
Flag: ACONFIG enable_smartspace_as_a_widget DISABLED
Flag: ACONFIG enable_smartspace_removal_toggle DISABLED
Change-Id: I4cba42e09f58365f761ab866b15a494817e6bb0f
2024-04-25 14:26:30 -07:00
Brandon Dayauon 120838b04d Make settings cog animate back to original button
Provide the appropriate itemInfo so that launcherBackAnimation would play correctly.

bug:324569690
Test manual video: https://drive.google.com/file/d/1GfjL4PhdGOxs2KfDpieTNiFiKQ61aCgh/view?usp=sharing
Flag: ACONFIG com.android.launcher3.Flags.enable_private_space trunkfood

Change-Id: I1a9458643e932b279bf4ba4ea33e3dc0a2c121c2
2024-04-18 14:32:33 -07:00
Sunny Goyal 4a22ed81ea Using resource overrides for PluginManager instead of code-swap
Bug: 330920490
Test: Presubmit
Flag: None
Change-Id: Ib1cd50f95873928b9ce104e8e95d21f1dca9c6e3
2024-04-12 11:38:32 -07:00
Alina Zaidi 0580379e30 Rename freeform tasks to desktop tasks
Bug: b/332878426
Test: refactoring CL. Existing unit tests still pass.
Flag: NONE

Change-Id: I24ad9699223dd383ff794ef3b028bf32beca96d7
2024-04-10 12:30:50 +00:00
Brian Isganitis 3f4e5812ce Merge "Prevent meta shortcut from cancelling split select state." into main 2024-04-10 07:34:47 +00:00
Brian Isganitis 84fbec0b16 Prevent meta shortcut from cancelling split select state.
There are two things that need to be changed for this to work:

1. Make the isInOverview condition check for any Overview UI (including
   the split select state, modal, etc.)
2. Toggle Home All Apps directly, because firing the intent will cause
   Launcher to pause and resume before the intent is handled. We
misinterpret the pause as a request to cancel split screen. Since
TaskbarManager has a reference to Launcher, we might as well call the
method directly.

Test: Manual
Fix: 319076403
Flag: N/A
Change-Id: Ib8899188f593a168a054a16717df4a95be098557
2024-04-09 16:10:56 -07:00
Fengjiang Li 59091e4612 [2/2] Fix widget resize frame show up at skewed location.
Wait until launcher is not animating to show resize frame

Fix: 331433240
Test: manual - took a photo
Flag: NONE
Change-Id: I3aec7f8bf2b6081134004b30de3d389e5b1ab253
2024-04-09 13:43:36 -07:00
Fengjiang Li 01cc273537 Add LAUNCHER_ALL_APPS_SEARCH_BACK jank instrumentation
Bug: 330405993
Test: prefetto trace TBD
Flag: aconfig com.android.launcher3.enable_predictive_back_gesture TEAMFOOD
Change-Id: I1fb2876fb29bc360cbb8dc8c1605215f28383c3c
2024-04-01 11:12:50 -07:00
Jeremy Sim da4ba9336e Merge "Reparent folders and app pairs" into main 2024-03-30 03:06:44 +00:00
Jeremy Sim 742630c2f8 Reparent folders and app pairs
Previously, app pairs and folders shared a common data model, FolderInfo. Now we need to separate them, so a new type, CollectionInfo, will serve as the parent of both types.

Bug: 315731527
Fixes: 326664798
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual, unit tests to follow
Change-Id: Ia8c429cf6e6a376f2554ae1866549ef0bcab2a22
2024-03-29 15:39:28 -07:00