Commit Graph

13731 Commits

Author SHA1 Message Date
Sunny Goyal b0416cc478 Merge changes from topic "revert-17983445-hotseat_span-WQWWPUHOTD" into tm-dev
* changes:
  Revert "Fix hotseat width to span a number of columns"
  Revert "Update workspace, cell layout, shortcut and widget, and cell size calculations."
2022-05-09 23:14:38 +00:00
Sunny Goyal 7869000544 Merge "Adding feature to automatically show keyboard in all-apps" into tm-dev 2022-05-09 21:50:48 +00:00
Sunny Goyal 89a89d63a4 Revert "Fix hotseat width to span a number of columns"
Revert submission 17983445-hotseat_span

Reason for revert: b/231283023
Reverted Changes:
Ice4e37929:Fix hotseat width to span a number of columns
I9ed508490:Fix hotseat width to span a number of columns

Change-Id: Iabf67c5efd8155131a0c8a88192ddd671a43747b
2022-05-09 19:32:07 +00:00
Sunny Goyal 3e8a04b341 Revert "Update workspace, cell layout, shortcut and widget, and cell size calculations."
This reverts commit b45d6c421d.

Reason for revert: b/231283023

Change-Id: Ic4941ea9ecd382348aae8e099e5a7ebf4ed0bba3
2022-05-09 19:31:45 +00:00
Becky Qiu 9c21bc071d Merge "[Toast] Fix the NPE in isPersonalTab()." into tm-dev 2022-05-09 18:24:49 +00:00
Becky Qiu f0fd3d8e2e [Toast] Fix the NPE in isPersonalTab().
Don't set mUsingTab until replaceRVContainer is done.

Bug: 224882720
Test: manual
Change-Id: I9ebec067d06df5e890ffe3c90d49f1de51b3b981
2022-05-09 09:57:29 -07:00
Kholoud Mohamed 0e2b622014 Merge "update enterprise strings on ACTION_DEVICE_POLICY_RESOURCE_UPDATED" into tm-dev 2022-05-09 14:57:40 +00:00
Alex Chau d9b6543a04 Merge "Sort hotseat items in migration to preserve position" into tm-dev 2022-05-09 10:35:49 +00:00
kholoud mohamed d5a4d60483 update enterprise strings on ACTION_DEVICE_POLICY_RESOURCE_UPDATED
Also updated work folder name provider to retrieve it from dpm

Bug: 218322904
Test: manual
Change-Id: Id80a9e90806f3a07f132b5cc1e9871bb35df42b0
2022-05-09 10:01:10 +01:00
Sunny Goyal 2a84e378b7 Adding feature to automatically show keyboard in all-apps
Bug: 227659010
Test: Manual
Change-Id: Id0a295d343aa895a2f672319ae1ccb3a975d41ce
2022-05-06 15:16:08 -07:00
Sunny Goyal f27d6c0dc7 Merge "Preventing widget preview from getting accessibility focus on internal content" into tm-dev 2022-05-06 22:15:04 +00:00
Abhilasha Chahal 43d68e9f6b Merge "Check if launcher has touch interaction service when registering touch events" into tm-dev 2022-05-06 21:58:36 +00:00
TreeHugger Robot c1ea2da7f3 Merge "Add DisplayController in PreviewContext's allowed objects" into tm-dev 2022-05-06 21:27:45 +00:00
Brandon Dayauon 5a726787db Merge "changed name and dimensions of work_mode_toggle button, changed outline to surface for the (x) icon.." into tm-dev 2022-05-06 21:00:08 +00:00
Alex Chau 1145722685 Add DisplayController in PreviewContext's allowed objects
Fix: 231526132
Test: switch grids
Change-Id: Ie43c54c5fbbea51ee3b795be6baa9c2eaf5e15e4
2022-05-06 20:17:57 +01:00
Alex Chau 950437ce26 Merge "Fix overview and quickswitch gesture logging" into tm-dev 2022-05-06 19:05:43 +00:00
Schneider Victor-tulias a78e070a2e Merge changes from topic "presubmit-am-1224af9ca3f341a895e4bc19976e2bb8" into tm-dev
* changes:
  Fix recents animation flicker
  Fix janky overview animation.
2022-05-06 18:48:29 +00:00
Sunny Goyal d4cb76ebf0 Preventing widget preview from getting accessibility focus on internal content
Bug: 209579561
Bug: 209579521
Bug: 209579162
Test: Manual
Change-Id: If65a74acf021b19438cdc37b07ac508985f8909a
2022-05-06 11:10:41 -07:00
Josh Tsuji 8217fce33e Merge "Actually interpolate the time value." into tm-dev 2022-05-06 17:51:09 +00:00
Brandon Dayauon e5142c5c53 changed name and dimensions of work_mode_toggle button, changed outline to surface for the (x) icon..
Fixed padding issue (tightness) between Personal/WorkTabs/EduDialog
Aligned Work Toggle button to be the same with the workTabs/eduCard
raised button up 20dp to align with specs

Fixed issue where allApps apps invade the tabs. Fixed RTL issues where it wasn't going RTL.
Fixed RTL issue for the workfab button where there was no margin on the left side of the button
Added DeviceProfile to constructor

Bug: 200810328
Bug: 224731300
Test:
	Before: https://screenshot.googleplex.com/6sRgNZQz4wKYn5n
	After: https://screenshot.googleplex.com/8hBLyDiMbMH9tn2
	After(showingLayoutBounds): https://screenshot.googleplex.com/MuVUXCegukAMzSr

Change-Id: Ibac3f5b8fe7d877c2f54a2c87f4393c1a91dc806
2022-05-06 09:52:05 -07:00
Abhilasha Chahal 997a757661 Check if launcher has touch interaction service when registering touch events
Bug: 228014625
Test: Refactoring change

Change-Id: I3b94f4f7fabf7cb2964eefd5cf1e099d2bb80ca6
2022-05-06 16:21:48 +00:00
Josh Tsuji d2ae944a43 Actually interpolate the time value.
This was broken and always linear.

Bug: 229890190
Test: atest SystemUITests
Change-Id: I7db6f5025c0fc70c9899c97ee23e486ede61a085
2022-05-06 15:15:27 +00:00
Alex Chau 664c1c18e7 Sort hotseat items in migration to preserve position
Fix: 231601760
Test: manual with local backup/restore
Change-Id: Ie89f0134485296c3cd252cf6b86bb3f88a0f90de
2022-05-06 15:47:11 +01:00
Alex Chau a717d1621d Allow BaseState.getTransitionDuration to read DeviceProfile
- Changed handheld duration to AllApps to 600

Bug: 227745955
Test: manual
Change-Id: I6f6642440dda3e39947231c2d38e8b60d152e08f
2022-05-05 14:44:00 +01:00
Alex Chau a70e23384f Fix overview and quickswitch gesture logging
- Log Home -> Overview gesture
- Log Home -> quickswitch as LAUNCHER_QUICKSWITCH_RIGHT

Bug: 219686410
Test: Local log in StatsLogCompatManager
Change-Id: Ic88fefd5af58dc03779f77b12611843c40706b1c
2022-05-05 14:33:27 +01:00
Sunny Goyal d3a841d91a Merge "Removing fading edges from recyclerView as we already have full background behing search box, and additional laying is not requred" into tm-dev 2022-05-05 05:21:11 +00:00
TreeHugger Robot 4bd36a37a7 Merge "Implementing support for item diffing instead of creating out the complete UI on every update" into tm-dev 2022-05-04 23:11:04 +00:00
Schneider Victor-tulias 9f922d3598 Fix recents animation flicker
The recents animation can sometimes start before launcher has started when started with 3-button mode. This causes the animation to start before the recents UI has been initialized by Launcher. Added a callback to properly synchronize launcher start and the recents animation.

Fixes: 229360539
Test: started the recents animation and checked logs (order of operations), when the recents animation or launcher started first
Change-Id: I5938bbba778a2886b4a1e4ee4844eaf28c6fac0e
2022-05-04 22:27:50 +00:00
Pat Manning f4bd9b6304 Merge "Update workspace, cell layout, shortcut and widget, and cell size calculations." into tm-dev 2022-05-04 18:19:02 +00:00
Pat Manning b45d6c421d Update workspace, cell layout, shortcut and widget, and cell size calculations.
Test: DeviceProfileGridDimensionsTest.kt
Fix: 230862148
Change-Id: Ib1d577bf21beb45b2f8b3d4bd57e72c188e0f71b
2022-05-04 15:39:03 +01:00
Alex Chau 92ad55a549 Merge "Add logs for InvariantDeviceProfile.getDeviceProfile" into tm-dev 2022-05-04 09:51:38 +00:00
Sunny Goyal 3c5a08ada1 Implementing support for item diffing instead of creating out the
complete UI on every update

Bug: 229860311
Test: Verified locally
Change-Id: I5712b5d76878a0ed72cc1392ede59b3778b7a1dc
2022-05-03 16:24:46 -07:00
Sunny Goyal f76524151d Merge "Replacing ItemInfoMatcher with predicate" into tm-dev 2022-05-03 20:04:55 +00:00
Sunny Goyal afaefbca33 Removing fading edges from recyclerView as we already have full
background behing search box, and additional laying is not requred

Bug: 221095750
Test: Manual
Change-Id: I2251ebae6f09467fb354d9240e3781a7ca076aa9
2022-05-03 11:00:32 -07:00
Schneider Victor-tulias bb44c03b1c Fix janky overview animation.
Switching to overview shortly after switching to 3-button mode caused a janky animation if the PagedView wasn't properly initialized yet. Moved the animation to a callback.

Fixes: 203632659
Fixes: 223719200
Test: manual
Change-Id: I8a345036c6b7322ae3fa50a23bcb7522f57c8a90
2022-05-03 10:38:23 -07:00
Sunny Goyal 32084d49d3 Replacing ItemInfoMatcher with predicate
This removed unnecessary componentName lookups when it
is not required. Many checks just rely on IDs and
userHandle

Bug: 231153610
Test: Presubmit
Change-Id: Ief93954abc5861062a9f55dc2ef181d3de106c62
2022-05-03 10:07:22 -07:00
Alex Chau d3e8cc40b4 Add logs for InvariantDeviceProfile.getDeviceProfile
Logged Configuration, DisplayMetrics, rotation and DisplayController.Info

Bug: 231312158
Test: manual
Change-Id: I03ffa80c150b1cb1a31e09ed67026a40cfe97fd2
2022-05-03 18:03:29 +01:00
TreeHugger Robot 53c0b2c00f Merge "Fixing wrong window insets estimation" into tm-dev 2022-05-03 16:57:09 +00:00
TreeHugger Robot f1a4296cd0 Merge "Tune AllApps dismiss animation" into tm-dev 2022-05-03 11:23:46 +00:00
Sunny Goyal 7bf8730634 Fixing wrong window insets estimation
Launcher was estimating the landscape insets incorrectly
causing the UI to get reloaded if device is rotated. This also
caused widgets to be refetched as a result of grid size change

Bug: 218067434
Test: Verified locally that the window bounds do not change
Change-Id: Ia7228296c78ea3056f4859e43696d4bfd9522d3c
2022-05-02 13:18:45 -07:00
Schneider Victor-tulias 9b6babf839 Translate the 3 navigation buttons to/from their in-app position when animating to/from the -1 screen, all apps and widgets.
Bug: 221455508
Test: opened all apps, widgets, -1 screen, notifications shade and keyboard in various combinations and orders; locked screen, launched app, returned home with the back/home buttons, opened overview
Change-Id: Ia0b406aacf72b34bd6b7ff1c01278ab6895a7da4
Merged-In: Ia0b406aacf72b34bd6b7ff1c01278ab6895a7da4
(cherry picked from commit 9c1a452a1d)
2022-05-02 18:45:01 +00:00
TreeHugger Robot 002e1fcde5 Merge "Do not add HOTSEAT_ICONS to visible elements for device type "phone" in ALL_APPS State" into tm-dev 2022-04-30 17:12:35 +00:00
Anushree Ganjam f6254c5947 Do not add HOTSEAT_ICONS to visible elements for device type "phone" in
ALL_APPS State

HOTSEAT_ICONS got added to visible elements for ALL_APPS State in ag/16992837.

============================================================
Phone
Before:
HotSeat present in view hierarchy - https://hsv.googleplex.com/4906040983289856?node=41
Video: https://b.corp.google.com/issues/228803923#comment9

After:
HotSeat not present in view hierarchy - https://hsv.googleplex.com/5379653922455552?node=42
Video: https://b.corp.google.com/issues/228803923#comment11
============================================================

Tablets

I couldn't test this implementation on tablet. But I have verified on a phone
locally by adding HOTSEAT_ICONS to visible elements and then verifying
"IMPORTANT_FOR_ACCESSIBILITY_NO_HIDE_DESCENDANTS" get set and hotseat icons are not focusable in all apps.
Video : https://b.corp.google.com/issues/228803923#comment14

============================================================

Bug: 228803923
Bug: 227565451

Test: Manual. See the video attached in bug.
Change-Id: I055e3bb61c8cfd240e0fe1000fe3a391a150f6d1
2022-04-29 23:33:48 +00:00
TreeHugger Robot 4adce848da Merge "Removing ununsed append logic in search" into tm-dev 2022-04-29 22:55:13 +00:00
Alex Chau f39cc126bf Tune AllApps dismiss animation
- Avoid overriding interpolator in AllAppsTransitionController.setStateWithAnimation as it's no longer needed and it'll wrongly override interpolator for ANIM_ALL_APPS_FADE
- Override ANIM_ALL_APPS_FADE to FINAL_FRAME in QuickstepAtomicAnimationFactory for tap deadzone to dismiss animation, also added EMPHASIZED_ACCELERATE for the dismiss animation
- Tuned dismiss animation across form factors to 300ms

Fix: 220336617
Test: manual
Change-Id: I4b3e827b503dcb1dd39f0bd99d4c1dd5ffdba0f3
2022-04-29 20:31:26 +01:00
Sunny Goyal 3091f0a4fe Removing ununsed append logic in search
Bug: 229860311
Test: Manual
Change-Id: Id6a72784b186fc5f0aaeac52f2a66fa35711fe4c
2022-04-29 09:49:50 -07:00
Thales Lima 828875cd12 Fix hotseat width to span a number of columns
Bug: 227344807
Test: manual
Change-Id: Ice4e37929bcbb8c9cf3af340e67b6bec002578bd
2022-04-29 14:56:30 +00:00
Raj Garg 0191a02a02 Merge "Making the parseAndAddDeepShortcut api private." into tm-dev 2022-04-28 09:58:37 +00:00
My Name 9a6dbac68c Making the parseAndAddDeepShortcut api private.
There is no need to expose this api. Missed the comment https://googleplex-android-review.git.corp.google.com/c/platform/packages/apps/Launcher3/+/17956680/comments/1c9b7443_cc54296d

Test: Tested manually on device.
Change-Id: If71e203f32a59fa59c406303411a37cba7b6c62e
2022-04-28 05:17:40 +00:00
Anushree Ganjam fa693be19f Merge "Revert "Refactors Search results into separate RV for Toast."" into tm-dev 2022-04-28 04:52:01 +00:00