Commit Graph

33301 Commits

Author SHA1 Message Date
TreeHugger Robot ac802c2bdc Merge "Improving diagnostics when Launcher dies during a gesture" into ub-launcher3-master 2020-06-25 22:32:28 +00:00
TreeHugger Robot e997bd682e Merge "Improving diagnostics when can't find a widget" into ub-launcher3-master 2020-06-25 22:24:05 +00:00
Tracy Zhou 73f1937b6c Do preview grid migration in a worker thread am: f957ff9123
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12002727

Change-Id: I56067831e0e5c3b43eb60d4f62459e251228e88c
2020-06-25 22:22:03 +00:00
Tony Wickham 3d6bfc2905 Merge "Fix tracking window being slightly off when swiping from an app" into ub-launcher3-master 2020-06-25 22:18:32 +00:00
Tracy Zhou 6b79a3767d Do preview grid migration in a worker thread
Also remove USE_SURFACE_VIEW_FOR_PREVIEW flag

Fixes: 159755324
Test: manual
Change-Id: I6517c34911e217a69063226b01e4583194902f9c
(cherry picked from commit 633a4bdf57)
2020-06-25 21:05:04 +00:00
Tracy Zhou f957ff9123 Do preview grid migration in a worker thread
Also remove USE_SURFACE_VIEW_FOR_PREVIEW flag

Fixes: 159755324
Test: manual
Change-Id: I6517c34911e217a69063226b01e4583194902f9c
(cherry picked from commit 633a4bdf57)
2020-06-25 21:04:25 +00:00
Tracy Zhou 6d24c69e48 Merge "Do preview grid migration in a worker thread" into ub-launcher3-master 2020-06-25 21:04:04 +00:00
vadimt 56fe9150fa Improving diagnostics when Launcher dies during a gesture
Instead of crashing upon getting uninitialized event sequence, we show a
meaningful message.

Bug: 159921830
Change-Id: Ie42039b39a453c60bd5df3e54058d582137bba06
2020-06-25 13:32:20 -07:00
Tracy Zhou 633a4bdf57 Do preview grid migration in a worker thread
Also remove USE_SURFACE_VIEW_FOR_PREVIEW flag

Fixes: 159755324
Test: manual
Change-Id: I6517c34911e217a69063226b01e4583194902f9c
2020-06-25 13:12:52 -07:00
Samuel Fufa 0036b2b67a Add NPE check for prediction controller
Bug: 159835714
Test: Manual
Change-Id: I9cc03f6491f4e14462be6c01edf3ed4ca1d82136
2020-06-25 20:10:01 +00:00
Samuel Fufa 514df92bcf Add NPE check for prediction controller
Bug: 159835714
Test: Manual
Change-Id: I9cc03f6491f4e14462be6c01edf3ed4ca1d82136
2020-06-25 13:08:55 -07:00
Tony Wickham f0a1b2ccd8 Fix tracking window being slightly off when swiping from an app
Test: swipe up from an app in landscape, seascape, and portrait,
and verify the window tracks with the finger 1:1 until pullback

Bug: 149934536
Change-Id: Ia469877e7152c8135e0b9153f69c191ba86cbd14
2020-06-25 11:51:28 -07:00
TreeHugger Robot 66a0594903 Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into rvc-dev am: ccf588d36b am: a2c80c2a1e am: 2d062629af am: 048730d37b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11994586

Change-Id: I66e94485af4645cc855dfb716a6a822e2c6103ba
2020-06-25 18:09:34 +00:00
TreeHugger Robot 0ba4e72af9 Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into rvc-dev am: ccf588d36b am: 6be2c6cb83 am: a04df0eeff am: 1f076e9dff
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11994586

Change-Id: I4a25b04d6c8eb783b9455a8bdcaef039b9c22fe1
2020-06-25 18:08:42 +00:00
TreeHugger Robot d9dd5cec0f Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into rvc-dev am: ccf588d36b am: 6be2c6cb83 am: 40483a5399 am: 4073796ff7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11994586

Change-Id: Ic1582747cd4d16c5df22ce4e6d0e5716d17aebfd
2020-06-25 18:07:35 +00:00
TreeHugger Robot 048730d37b Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into rvc-dev am: ccf588d36b am: a2c80c2a1e am: 2d062629af
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11994586

Change-Id: Ic0a39f519fc6d90044a21b658eeedfd5f7214195
2020-06-25 18:01:24 +00:00
TreeHugger Robot 1f076e9dff Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into rvc-dev am: ccf588d36b am: 6be2c6cb83 am: a04df0eeff
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11994586

Change-Id: I3e01b753efbbcb097ced25620e0a79ac9d6de10c
2020-06-25 18:00:39 +00:00
TreeHugger Robot 4073796ff7 Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into rvc-dev am: ccf588d36b am: 6be2c6cb83 am: 40483a5399
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11994586

Change-Id: I5027efb83c40b59c9a8e66ed8cc693cc8b79918b
2020-06-25 17:55:10 +00:00
TreeHugger Robot 2d062629af Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into rvc-dev am: ccf588d36b am: a2c80c2a1e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11994586

Change-Id: I68707d6786ccb793f7ed89e649bea55a5a3f1005
2020-06-25 17:13:03 +00:00
TreeHugger Robot a04df0eeff Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into rvc-dev am: ccf588d36b am: 6be2c6cb83
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11994586

Change-Id: I0f76e1d3261b8bace3f9ccdf4862b62f6918f3d7
2020-06-25 17:12:16 +00:00
TreeHugger Robot 40483a5399 Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into rvc-dev am: ccf588d36b am: 6be2c6cb83
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11994586

Change-Id: I233f4b8d386421dde48dd61094ece14121bb6a07
2020-06-25 17:09:22 +00:00
TreeHugger Robot 670c17c48f Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into rvc-dev am: ccf588d36b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11994586

Change-Id: Ic189d580a0b86481eb002eb0c1d2c8f8668f87ba
2020-06-25 16:49:42 +00:00
TreeHugger Robot a2c80c2a1e Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into rvc-dev am: ccf588d36b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11994586

Change-Id: I26e24cc4d0a5d4ad075a8e3ee358071b6c3dcec6
2020-06-25 16:49:23 +00:00
TreeHugger Robot 6be2c6cb83 Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into rvc-dev am: ccf588d36b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11994586

Change-Id: If5bd4173783df2ffa89062dece3b0a6b1aa1ffe7
2020-06-25 16:49:17 +00:00
TreeHugger Robot ccf588d36b Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into rvc-dev 2020-06-25 16:38:47 +00:00
Andy Wickham 0358dfd435 Updates Assistant gesture regions when no longer tracking multiple. am: d2731957ea am: 9befc26ea2 am: 88a3101efe am: 5a25790ded
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11992046

Change-Id: Iec2e7cb1259a210cd644f02db281c06c5aa2ffe1
2020-06-25 03:21:49 +00:00
Andy Wickham 0ed1db591a Updates Assistant gesture regions when no longer tracking multiple. am: d2731957ea am: 3fef2dd92d am: 221d9b90c9 am: cda55605ce
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11992046

Change-Id: Ic01b981d002515a1c6deeff75fc6e9ce188c34a6
2020-06-25 03:21:28 +00:00
Andy Wickham 3b98451394 Updates Assistant gesture regions when no longer tracking multiple. am: d2731957ea am: 3fef2dd92d am: 98f26d1a15 am: 5cf822dff3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11992046

Change-Id: I2769af25a543a8860d7533f8e677e958d2b4b0ef
2020-06-25 03:21:00 +00:00
android-build-team Robot 4ff8176505 Snap for 6626737 from 975d792bf7 to mainline-release
Change-Id: Ic3c68d95375d180f2928eedb69f6f2e301adf05e
2020-06-25 03:10:50 +00:00
Andy Wickham 5a25790ded Updates Assistant gesture regions when no longer tracking multiple. am: d2731957ea am: 9befc26ea2 am: 88a3101efe
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11992046

Change-Id: I99b27e74513afd627f77d28d203adbdd1094de59
2020-06-25 03:10:48 +00:00
Andy Wickham cda55605ce Updates Assistant gesture regions when no longer tracking multiple. am: d2731957ea am: 3fef2dd92d am: 221d9b90c9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11992046

Change-Id: I60e4c2ead8f9011306263622a140e93a2f06036f
2020-06-25 03:10:41 +00:00
Andy Wickham 5cf822dff3 Updates Assistant gesture regions when no longer tracking multiple. am: d2731957ea am: 3fef2dd92d am: 98f26d1a15
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11992046

Change-Id: Icd0730419ab07fc1379a4686dce2691d7999a55f
2020-06-25 03:10:35 +00:00
Andy Wickham 88a3101efe Updates Assistant gesture regions when no longer tracking multiple. am: d2731957ea am: 9befc26ea2
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11992046

Change-Id: I9c15d2c268879ee5201389cd48e3e9c62bcabd21
2020-06-25 02:56:36 +00:00
Andy Wickham 221d9b90c9 Updates Assistant gesture regions when no longer tracking multiple. am: d2731957ea am: 3fef2dd92d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11992046

Change-Id: I56eb67aa43786f970a39e65b25a9c4245c10fa77
2020-06-25 02:56:15 +00:00
Andy Wickham 98f26d1a15 Updates Assistant gesture regions when no longer tracking multiple. am: d2731957ea am: 3fef2dd92d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11992046

Change-Id: I5d090cbf082d62fd783ed27faa6fed602c1b8d20
2020-06-25 02:56:05 +00:00
Andy Wickham fafff26524 Updates Assistant gesture regions when no longer tracking multiple. am: d2731957ea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11992046

Change-Id: Idbc9f144081d65d62665a91194252efb046d98c2
2020-06-25 02:39:46 +00:00
Andy Wickham 9befc26ea2 Updates Assistant gesture regions when no longer tracking multiple. am: d2731957ea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11992046

Change-Id: I63e52519cf6a1ab15d5efce76f8ef120ba142b01
2020-06-25 02:39:27 +00:00
Andy Wickham 3fef2dd92d Updates Assistant gesture regions when no longer tracking multiple. am: d2731957ea
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11992046

Change-Id: Iacfc6d6f8d8eb7eda45137d7aef8941c9620cb39
2020-06-25 02:39:14 +00:00
Tony Wickham 072e4c276d Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into ub-launcher3-rvc-dev am: 9d69370095
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11990144

Change-Id: I0b8a7052caf6352f4505a4327385332f2a6ef934
2020-06-25 02:28:27 +00:00
Tony Wickham 9e84745e4b Pass isLikelyToStartNewTask to onGestureStarted()
This ensures we immediately setRecentsAttachedToAppWindow(). As
mentioned in the bug, there was an edge case where we would animate
the attached state if the first move event passed the touch slop,
causing the adjacent task view to lag behind during the gesture.

Fixes: 159742520
Change-Id: Ie47bb84fdd3dbd69e3b74ca504d487fb9aedb551
(cherry picked from commit c6a56ef7a2)
2020-06-25 02:11:04 +00:00
Tony Wickham 9d69370095 Merge "Pass isLikelyToStartNewTask to onGestureStarted()" into ub-launcher3-rvc-dev 2020-06-25 02:10:54 +00:00
Tracy Zhou dfa3de7d3f Get rid of a weird shadow background when rendering smartspace in preview
I think it has something to do ripple background, clipChildren, focusable, clickable, etc. My previous projects ran into related issues before, which is why I tried to set focusable here to false. Let me know if you have a better idea of what exactly is going on

FYI, I also did go back to my previous CL and confirmed that it's necessary.

Fixes: 152278370
Test: Factory reset the phone (with latest build and launcher built from this CL). Make sure no background is shown
Change-Id: I401ffcccd1e07a3c0beb5ed460a707d25bddf41e
2020-06-24 18:43:37 -07:00
android-build-team Robot 571ddfc6c5 Snap for 6626121 from ca493d1426 to rvc-release
Change-Id: Iaa5aeff0b0e28ce14eae34ec403c256e78af9a7d
2020-06-25 01:02:27 +00:00
Andy Wickham 646f2ab0d9 Merge "Updates Assistant gesture regions when no longer tracking multiple." into ub-launcher3-rvc-dev am: fce6be550b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11989960

Change-Id: Iac670fc5f6cfdb0bb38a571c96136858f1b14f1a
2020-06-24 22:43:38 +00:00
Andy Wickham d2731957ea Updates Assistant gesture regions when no longer tracking multiple.
This should prevent states where Assistant triggers from
the vertical-center of the screen in portrait (see bug).

Also fleshes out OrientationTouchTransformerTests and
adds some new ones that fail without this change:
 - enableMultipleRegions_assistantTriggersInMostRecent
 - enableMultipleRegions_assistantTriggersInCurrentOrientationAfterDisable

Fixes: 158686674
Change-Id: I6d045a485f62e4010e9e3d00805a50fdd953a2fc
(cherry picked from commit 4b531b972d)
2020-06-24 22:32:14 +00:00
Andy Wickham fce6be550b Merge "Updates Assistant gesture regions when no longer tracking multiple." into ub-launcher3-rvc-dev 2020-06-24 22:29:45 +00:00
vadimt fb099c7fe1 Improving diagnostics when can't find a widget
Instead of "exceeded number of attempts" now printing that can't scroll
to widget.

Change-Id: Ia6f582e038d68fc35f152d94e592f60ef0bc2cf4
2020-06-24 21:54:16 +00:00
Andy Wickham 4b531b972d Updates Assistant gesture regions when no longer tracking multiple.
This should prevent states where Assistant triggers from
the vertical-center of the screen in portrait (see bug).

Also fleshes out OrientationTouchTransformerTests and
adds some new ones that fail without this change:
 - enableMultipleRegions_assistantTriggersInMostRecent
 - enableMultipleRegions_assistantTriggersInCurrentOrientationAfterDisable

Fixes: 158686674
Change-Id: I6d045a485f62e4010e9e3d00805a50fdd953a2fc
2020-06-24 21:23:35 +00:00
Tony Wickham c6a56ef7a2 Pass isLikelyToStartNewTask to onGestureStarted()
This ensures we immediately setRecentsAttachedToAppWindow(). As
mentioned in the bug, there was an edge case where we would animate
the attached state if the first move event passed the touch slop,
causing the adjacent task view to lag behind during the gesture.

Fixes: 159742520
Change-Id: Ie47bb84fdd3dbd69e3b74ca504d487fb9aedb551
2020-06-24 11:59:10 -07:00
TreeHugger Robot 34a73f1611 Merge "Fixing NPE befre ActionsView first initialized." into rvc-dev am: ca493d1426 am: c3adb0a088 am: 0fe041c328 am: efc1b9c1b7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11978215

Change-Id: Ic723803d4e089de7d8a9dc663eecf6dd5bb60d0f
2020-06-24 07:51:19 +00:00