Commit Graph

33301 Commits

Author SHA1 Message Date
TreeHugger Robot f8d7e3428c Merge "Fixing jank in launching app from recents" 2020-11-21 03:38:39 +00:00
Pinyao Ting 7aaaa35501 fix the issue widget id wasn't being migrated in backup
After SuW the favorite table is copied into backup table, but the widget
id in the backup table hasn't been migrated. This introduces general
unstabality and can sometimes leads to the disappearance of widgets
after a restore.

Bug: 171774227
Test: run Backup Restore flows and verified database status with arbitrary
logging

Change-Id: If275a6b5395504d6de90e26c3998f759e797f6e1
2020-11-20 18:18:52 -08:00
Tracy Zhou 5b468d252f Log grid size change
Test: manually make sure that the correct path is fired
Fixes: 173481818
Change-Id: I7dc2143eb9c0527287398590d46fc2408bc47e44
2020-11-20 17:15:30 -08:00
vadimt 6c1fa64a1d Fixing jank in launching app from recents
Moving expensive actions from the last
frame's rendering.

This reduces the max frame time from > 16 ms
to <= 8 ms, which is good for now.

Test: Trace, metrics
Bug: 173640772
Bug: 173072373
Change-Id: I6d06a129f68d9b26f52c773b817558c77604ae5e
2020-11-21 00:09:42 +00:00
TreeHugger Robot b4f5e6f016 Merge "Removing obsolete shadows" 2020-11-20 20:35:43 +00:00
Samuel Fufa cb6ac3df97 Merge "hide app results if app info can't be found" 2020-11-20 16:29:57 +00:00
Samuel Fufa e5d2ad8e34 Even more logs for flaky work test
Bug: 159671700
Change-Id: I009f243b5e3076d15bc89a4755d5ddb9a5b3119e
2020-11-19 22:54:02 +00:00
vadimt daa731f1fe Removing binder call from the gesture injection
This causes jank under lock contention stress.

Test: local
Bug: 173072373
Change-Id: I3a44e510254f6d651cedb91f72e1789ae97d9b67
2020-11-19 22:12:09 +00:00
Samuel Fufa d41dfd3288 hide app results if app info can't be found
Bug: 173673806
Change-Id: I337912a354ba4374240c4be1c3f2595c4228ec74
2020-11-19 12:55:06 -06:00
John Li b43d8fa9a5 Merge "Haptic effect on alphabetical scroll in Pixel Launcher" 2020-11-19 08:15:06 +00:00
Sunny Goyal 3751be0f1c Removing obsolete shadows
Change-Id: I9dcaa69e4e86130642be15e3585f5898dd866839
2020-11-18 21:45:14 +00:00
Tiger Huang 2f4654ee04 Merge "Replace the system UI visibility with appearance (Launcher)" 2020-11-18 13:30:06 +00:00
John Li ce7f9f2ae1 Haptic effect on alphabetical scroll in Pixel Launcher
Bug: 169397156
Test: manual
Change-Id: Id0c51ac9e9ca7d0f3aaf9b490874de6ee0e97a28
2020-11-18 08:13:25 +00:00
Sunny Goyal 8bc273056f Merge "Resolve auto close on widget swipe" 2020-11-18 06:18:14 +00:00
Sreyas 0da8d424e8 Make modal based UI changes in TaskView only if modalness changes.
Fixes issue with jittery displaying of suggestion chip, when entering overview.
Merging into master manually as automerger failed.
Tested:Manual

Change-Id: I8228c51b22d550cb8f0aa559f997060b571763f1
(cherry picked from commit ed5e43bd25)
2020-11-17 18:46:48 +00:00
Samuel Fufa 2c86122fa4 Resolve auto close on widget swipe
Bug: 172891360
Test: Manual
Change-Id: Icb384b6dc5ec9a29b6a9a7811b862a2d83ca11a7
(cherry picked from commit 5fa6f3ce503cde51687985ebc9dee6f163b9b1ea)
2020-11-17 18:34:46 +00:00
Sunny Goyal 54834b0909 Merge commit '2cd8dd628268a177357afcccfeb7da8639e3a061' into merge_ub-launcher3-master_6976145
Test: manual, presubmit on the source branch
    x20/teams/android-launcher/merge/ub-launcher3-master_master_6976145.html

Change-Id: Ic13b1a20cc3d555e8e86717ca0da97103ff09c85
2020-11-16 14:40:43 -08:00
TreeHugger Robot 2cd8dd6282 Merge "Removing blocking call during cuj_LAUNCHER_APP_LAUNCH_FROM_ICON" into ub-launcher3-master 2020-11-13 19:24:40 +00:00
vadimt 4dd0fb173b Removing blocking call during cuj_LAUNCHER_APP_LAUNCH_FROM_ICON
This is a part of Blue Chip de-janking effort and is
a P0 item in our CUJ list.

In the last frame of the app-open animation, we have
a
android.view.IRemoteAnimationFinishedCallback$Stub$Proxy.onAnimationFinished call
which is blocking and prone to lock contention in WindowManager.

Moving the call to after the animation.

Bug: 173072373
Change-Id: If5eb6469900d1892b861eda6d6b4807d90630b6b
2020-11-12 18:42:20 -08:00
Schneider Victor-tulias 64154ead74 Fix hotseat predicted app update regression.
Hotseat predicted app updates were only being allowed then the hotseat was invisible or when the workspace was loading. This was too strict. Changed the logic to ignore hotseat visibility when the workspace is loading, when there are empty spots in the hotseat and when the predicted items are unchanged. This ensures the hotseat always has the intended number of icons and that icons can be updated in-place.

Fixes: 172597819

Demo: https://drive.google.com/file/d/100svnqX048Da7vues2p-vvQNN6sIF8v4/view?usp=sharing
Change-Id: I2f93ff44618c0282a6411918c34d70f75ec73b73
2020-11-12 11:22:53 -05:00
Schneider Victor-tulias 7bbec50031 Fix AllAppsSearchPlugin icon redrawing without special-casing.
Preventing icon animations in deep shortcuts fixed the icon redrawing issue in the all apps search page, however other icons could still be redrawn, yet could not be special-cased without removing icon update animations altogether. Added logic to only animate icon updates outside of the all apps search page.

Demo: https://drive.google.com/file/d/1ReT2O_1tV20terY0Jr1NJGxIxPblHCK4/view?usp=sharing

Change-Id: Ibe0b43801ec5340c3551125aef13170d569d2c55
2020-11-12 10:31:20 -05:00
Sunny Goyal 6f1bc72fda Merge "Fixing animation cancelled not called if gesture was not initiated" into ub-launcher3-master 2020-11-12 04:33:07 +00:00
Sunny Goyal 986ea0da60 Fixing Robolectic model tests
Some tests were broken because of refactoring in LauncherModel.

Change-Id: I55aa32d75a4d16338796a1b1765717fd72ba4b33
2020-11-12 01:01:55 +00:00
android-build-team Robot db2bd24c8b Snap for 6966897 from a18b9f3e42 to rvc-qpr2-release
Change-Id: Ie846f5555e90cb09245c3f11f05eed7aebb8c237
2020-11-12 00:08:14 +00:00
TreeHugger Robot c32e39f1db Merge "Fix OutOfBounds issue on getFocusedChild" into ub-launcher3-master 2020-11-11 21:56:54 +00:00
Sunny Goyal 0112a3d434 Fixing animation cancelled not called if gesture was not initiated
Previously, in case of a tap in the gesture region, swipeHandler was not
explicitly cancelling the launcher state animation. It was getting reset
bucause launcher gets onStop immediately after that.
But in some cases, it may not get onStop (if the top activity finishes),
which leaves the Launcher UI in a broken state

Bug: 172842997
Change-Id: Iff7b1e5b8f67b2f4dd8096b88c4cd97115ec912a
2020-11-11 12:23:47 -08:00
Pinyao Ting af0391f9b2 Include more error logging for widget restore
Bug: 171774227
Test: manually tested complete backup & restore flow
Change-Id: Ieb4b39d80a24b4dff377ee74d24d9010acd0daca
(cherry picked from commit ae1997b9d5)
2020-11-11 19:36:09 +00:00
Samuel Fufa 437513d5ef Federate SliveLiveData for Search results
Instead of every slice result creating its own live data, we should manage a single SliceLiveData per url that SliceViews can observe.

Bug: 173022319
Test: Manual
Change-Id: Ieaf599aadfac40450be4f39657d3cefb70644e0c
2020-11-11 12:48:40 -06:00
Samuel Fufa c25bc0335b Fix OutOfBounds issue on getFocusedChild
In cases where search only shows items that don't require focus highlighting,getFocusedChildIndex returns -1.

Bug: 13023194
Change-Id: I6145ae26e3953c5fc4fd1ed1696eb931017cac0f
2020-11-11 11:31:54 -06:00
Samuel Fufa 9ee4e86cf8 Merge "Search support for widgets with config activity" into ub-launcher3-master 2020-11-11 16:21:01 +00:00
TreeHugger Robot 8edcfc0f65 Merge "Include more error logging for widget restore" into ub-launcher3-master 2020-11-11 04:03:09 +00:00
TreeHugger Robot 1a7e371214 Merge "Refactoring DigitalWellbeing Banner to not use footers." into ub-launcher3-master 2020-11-11 01:42:19 +00:00
Pinyao Ting ae1997b9d5 Include more error logging for widget restore
Bug: 171774227
Test: manually tested complete backup & restore flow
Change-Id: Ieb4b39d80a24b4dff377ee74d24d9010acd0daca
2020-11-10 16:53:25 -08:00
Winson Chung ff6bcae03a Merge changes from topic "revert_ui_mode_changes" into rvc-qpr-dev am: a18b9f3e42 am: 42e3618151
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12932788

Change-Id: I331c8b67d6ffe66670cd37f6670ad473e65feac6
2020-11-10 23:07:20 +00:00
Winson Chung 29944ad5ca [automerger skipped] DO NOT MERGE Revert "Handle uiMode changes" am: 4b4341d3a7 am: 4bfad584c5 -s ours
am skip reason: subject contains skip directive

Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12932788

Change-Id: I459d2cdc41535706fa19be6e3773d3483749e7b6
2020-11-10 23:07:18 +00:00
Winson Chung 42e3618151 Merge changes from topic "revert_ui_mode_changes" into rvc-qpr-dev am: a18b9f3e42
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12932788

Change-Id: I6a3c606e2d5d7882909ff179d41e507c117f6df8
2020-11-10 22:35:54 +00:00
Winson Chung 4bfad584c5 DO NOT MERGE Revert "Handle uiMode changes" am: 4b4341d3a7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12932788

Change-Id: I090572abd8046a30ed8353cac0e5730f90c74b2e
2020-11-10 22:35:52 +00:00
Winson Chung a18b9f3e42 Merge changes from topic "revert_ui_mode_changes" into rvc-qpr-dev
* changes:
  DO NOT MERGE Revert "Handle uiMode changes"
  DO NOT MERGE Revert "Defer recreation until resumed"
2020-11-10 22:17:52 +00:00
Hyunyoung Song 967551b0fd Merge "People row text size fix" into ub-launcher3-master 2020-11-10 18:47:37 +00:00
Hyunyoung Song f62b8a93c0 Merge "IME stability" into ub-launcher3-master 2020-11-10 18:45:00 +00:00
Hyunyoung Song 5278e85c4c People row text size fix
Change-Id: I912f8d41bf49215988f37a2405086bf4d737af99
2020-11-10 10:39:54 -08:00
Samuel Fufa ffd2b6d25e Search support for widgets with config activity
Shows widget preview in search if widget requires config.

preview: https://drive.google.com/file/d/1q1ROu7-OUGfskDMRxXPNQMdr3T-WMMkv/view?usp=sharing
Bug: 168321831
Test: Manual
Change-Id: I6c1c168ebac4ce33a4234e8a417eba789f664f43
2020-11-10 10:16:02 -06:00
Hyunyoung Song 90a43a5f00 IME stability
Bug: 170739594

Change-Id: Ib667c6dfb321411d59e728a1f34d4803f7293f05
2020-11-10 00:54:46 -08:00
TreeHugger Robot bbaf9ff6f8 Merge "Fix NPE inside getFocusdChild" into ub-launcher3-master 2020-11-10 07:05:41 +00:00
Hyunyoung Song 3a4caed1f3 Fix NPE inside getFocusdChild
Bug: 172883035
Change-Id: Iea3e07165cdaa45031ee5bbc11add5c115cab366
2020-11-09 22:19:37 -08:00
Samuel Fufa 104463a1e2 Merge "Polish search result icons" into ub-launcher3-master 2020-11-10 03:10:56 +00:00
Samuel Fufa 81de07e405 Polish search result icons
SearchResultIconRow consumes a loaded ItemInfoWithIcon from its child SearchResult and updates other siblings with itemInfo.

preview: https://drive.google.com/file/d/1ijZsR5Q6M0DeZdlRJWpRb4AKmmTLBElY/view?usp=sharing
Change-Id: Ibb3fb697494749fd2e886dcdaa93241767a65944
2020-11-09 19:33:58 -06:00
TreeHugger Robot 91ead92b8a Merge "Fixing app-to-overview animation in 3 button mode" into ub-launcher3-master 2020-11-10 00:27:08 +00:00
Sunny Goyal 1cd6a5f30e Fixing app-to-overview animation in 3 button mode
Instead of copying orientation state information from RecentsView
to taskViewSimulator, using the same state object, so that new
properties (like RecentsRotation and flags) are automatically covered

Bug: 162881482
Change-Id: I02d0a710a6ecc4a3cebd0fcc4c49032127df1ce3
2020-11-09 15:52:29 -08:00
TreeHugger Robot d7f0ead7e5 Merge "Dismissing popup if the underlying icon no longer supports it" into ub-launcher3-master 2020-11-09 23:41:12 +00:00