Commit Graph

33301 Commits

Author SHA1 Message Date
Alex Chau 3a06568d8b Use PersistedTaskSnapshotData to calculate TaskView size
- Disabled variable width for running task, as PersistedTaskSnapshotData is not always up to date for current task after rotating the device

Bug: 174464656
Test: Test tablet overview with different comination of portrait/landscape wide/narrow thumbnails in portrait/landscape
Change-Id: Ifa01e72020ccaf422e3975b092462de85fa19efd
2021-02-17 11:41:24 +00:00
Vinit Nayak a34af18b0e Update System settings content observer to cache values.
Existing ContentObserver will cache values and overwrite
them when the value itself is modified or caller force
updates.

Bug: 149571513
Test: Wrote unit tests, mostly for caching logic.
Not meant to test ContentObserver contract for registering an
observer.

Change-Id: I12835f6c2be27ce17f65a55c51c4ef85c63b4487
2021-02-16 20:58:53 -08:00
thiruram e1a8440d78 Add @Nullable annotation to AllAppsStore.getApp.
Test: Manual
Bug: 180120291
Change-Id: I3f29d478e39b46e307f33f2f354720bc2915b550
2021-02-17 03:53:40 +00:00
Vadim Tryshev b6d28e885d Merge "Switching overlays more correctly" into sc-dev 2021-02-17 03:20:55 +00:00
Lucas Dupin 2cdc6bae39 Conform to new naming
Resources were renamed from main/accent to primary/secondary.

Test: make
Bug: 171916625
Change-Id: Ic71cf716eba9f57d27869dffa501219c41c999ec
2021-02-16 17:47:33 -08:00
vadimt a9740ecc8f Switching overlays more correctly
Test: presubmit
Bug: 180114721
Change-Id: I0d8d0c70ef34ec941e28704d06f9df5f17782155
2021-02-16 23:22:36 +00:00
Tony Wickham bb4de85c25 Draw folder leave-behind when opening folder in taskbar
Previously there was only support for CellLayout to draw the
leave-behind. Added FolderIconParent interface so any parent can
draw the leave-behind, and implement that by TaskbarView.

Test: Open folder in Taskber, ensure leave-behind draws

Bug: 171917176
Change-Id: I08d1d939a34f971f893994fe05cac972d165ef53
2021-02-16 15:10:05 -08:00
Tony Wickham 7ba547cd2d Folder support in Taskbar
- Add TaskbarActivityContext which allows shared Launcher elements to
  "just work" using existing generic ActivityContext.
- TaskbarContainerView extends BaseDragLayer<TaskbarActivityContext>.
- Inflate FolderIcon and Folder using TaskbarActivityContext to be
  shown in TaskbarContainerView.
- Use TaskbarActivityContext's DeviceProfile to determine icon size
  instead of overriding in styles. This also ensures that normal
  BubbleTextView icons have the same size as FolderIcons.

Test: Place a folder in home screen hotseat, ensure it shows up in
taskbar and can be opened, and that apps inside it can be launched
or dragged.
Bug: 171917176

Change-Id: Ic25d2f84bcd7e3399c88989305ea565497c030d9
2021-02-16 15:07:01 -08:00
Tony Wickham 1906cc33f9 Refactor Folder to use ActivityContext and BaseDragLayer
These are the more generic versions of Launcher and DragLayer, so
that Folders can be used in other surfaces.

Test: Open and close Folders on home screen, ensure works properly
Bug: 171917176
Change-Id: I39b9aedbd8319ca61ea0e776bc95eab585e023d5
2021-02-16 15:06:50 -08:00
Sunny Goyal e9110af0e0 Merge "Fixing dragView not getting removed on returning home" into sc-dev 2021-02-16 22:13:33 +00:00
Sreyas 960ddb07fc ShareTargets animations and styling.
Test: Manual
Bug: 169772466
Change-Id: I5a5118e23f90c4c585ad78f054e2c3e6b5d32001
2021-02-16 13:23:02 -08:00
Steven Ng 0be3a615d9 Render preview layout in full widgets sheet and bottom widgets sheet
Video: https://drive.google.com/file/d/1gRE0axaq6tm3R_gjSon0RR5lC8HCmwee/view?usp=sharing

Test: Install a sample app which provides a preview layout.
      Go to full widgets sheet to observe widget previews are correctly
      displayed for bitmap previews, layout previews and placeholder
      previews. Repeat the same for bottom widgets picker.
      Pin a widget from a sample app which provide a custom RemoteViews
      preview, observe the custom RemoteViews is correctly rendered.

Bug: 179797520
Change-Id: I2ccd1f77b54a2430d842ee25349fa6e54b9159dc
2021-02-16 19:34:03 +00:00
Sunny Goyal 384b578ab2 Removing menu and dialog for custom actions hanlding.
These do not work well with gesture-nav and can potentially
block the Launcher UI.

Instead exposing on custom actions with keyboard accelerator and
using thee internal arrowPopup for resize options
Fixing SecondoryDropTarget not sending appropriate stats log

Bug: 179854703
Test: Verified on device
Change-Id: I268690f8a937896e4350496128a38959003f8939
2021-02-16 10:45:06 -08:00
Jonathan Miranda 8dd4ddc7ae Merge "Add border spacing and fixed cell height to grid." into sc-dev 2021-02-16 18:38:38 +00:00
Andy Wickham 9199fd1831 Merge "Adds CONTAINER_QSB to be used for QSB data." into sc-dev 2021-02-16 05:35:56 +00:00
thiruram c96873caad [AA+] Log LAUNCHER_ONSTOP & LAUNCHER_ONRESUME events with AllApps session InstanceId.
* Transitions between AllApps and App screen logs LAUNCHER_ONSTOP & LAUNCHER_ONRESUME events. This change add InstanceId specific to the current AllApps session to these logs; this will help to regenerate AllApps session from logs on the server side. This should only affect logs from AllApps screen, but not others.

* Removes LiveSearchManager.allAppsLogger method as it may create confusion with 2 methods for logging into Statsd

* Moved AllApps entry and exit logs to Launcher.

Bug: 178562918
Test: Manual
Change-Id: I5fab941777a3dfd2e9b19c0efd5b06d3884222ef
2021-02-15 23:56:52 +00:00
Hyunyoung Song c860448bca Merge "Fix WidgetsListContentEntryTest static initialization error" into sc-dev 2021-02-15 22:54:12 +00:00
Steven Ng d2526d6a9a Merge "Make all widgets collapsed in the full widget picker by default" into sc-dev 2021-02-15 22:18:24 +00:00
Steven Ng e92bc55d12 Make all widgets collapsed in the full widget picker by default
Changes:
1. Add a WidgetListHeader view for showing icon, app name and a subtitle.
2. Only WidgetListHeaders are always visible to users in the full widget
   picker.
3. Only one widgets list from an app is visible in the full widget picker
   at any one time.

Test: Auto: run add robolectric tests under widget/picker
      Manual: Open full widgets picker. Then, expand and collapse apps.
      Video: https://drive.google.com/file/d/1gzfeEm5IOAu0qHsO77OTS2eMfU7CHJiL/view?usp=sharing

Bug: 179797520
Change-Id: Idac58be23dfeafcb79b3c61b4972d3addb462de1
2021-02-15 17:46:38 +00:00
Hyunyoung Song 9dbb9fe868 Merge "Revert "Update Robolectric SDK to 30"" into sc-dev 2021-02-14 04:44:21 +00:00
Steven Ng 53d3427b4e Fix WidgetsListContentEntryTest static initialization error
Test: m RunLauncherRoboTests

Bug: 180158637
Change-Id: I26316dddd41b1519e8deb0e049355cdce71aac4f
2021-02-13 20:46:07 +00:00
Hyunyoung Song 5fb8aae805 Revert "Update Robolectric SDK to 30"
This reverts commit 5ed0907cd3.

Reason for revert: b/180139562

Change-Id: I9520993ee925935ab621239686377a39e2e25590
2021-02-13 07:34:54 +00:00
Hyunyoung Song 106aa0d6f1 Merge "Apply Silk/ colorBackground(Floating) to AllApps" into sc-dev 2021-02-13 04:14:49 +00:00
Zak Cohen 0d1fa0ee8d Merge "Adjust task padding overview to match new specs." into sc-dev 2021-02-13 01:23:38 +00:00
Zak Cohen fe7fb09b90 Merge "Remove elevation from Task in Overview." into sc-dev 2021-02-13 01:23:02 +00:00
Zak Cohen e38dc9b5f8 Merge "Remove scaling and dimming for adjacent tasks in Overview." into sc-dev 2021-02-13 01:22:51 +00:00
Sreyas Rangaraju 4e6a7e340d Merge "Updated TaskMenuView." into sc-dev 2021-02-12 23:11:39 +00:00
Sunny Goyal 9cc6ecfa11 Fixing dragView not getting removed on returning home
Bug: 179330150
Test: Verified on device
Change-Id: Id0baadac36b700bd1c57382b0024c248063f9127
2021-02-12 13:08:04 -08:00
thiruram 6600860f0f [AA+] Log app launches with AllApps session InstanceId when current state is ALL_APPS.
Bug: 178562918
Test: Manual
Change-Id: I65b264cc37079280b59179d5b2f29b67e7a12cc5
2021-02-12 20:02:41 +00:00
Rajeev Kumar 1216e5999e Merge "Add NIU Actions buttons to the Go Overview" into sc-dev 2021-02-12 18:23:17 +00:00
Sunny Goyal 4c23ca768f Fixing shortcut intent getting cleared during backup/restore
Bug: 174570283
Bug: 156871815
Test: Verified on device
Change-Id: Ie286ee783bfe96c5b2be28f0db5298caf3801e6d
2021-02-12 18:04:23 +00:00
Lucas Dupin 2268d7a937 Merge "Revert "Ignore broken launcher tests"" into sc-dev 2021-02-12 17:24:59 +00:00
Andy Wickham 19ab177d1b Adds CONTAINER_QSB to be used for QSB data.
Also updates some related generics definitions for
better/simpler compile-time checks.

Bug: 178536734
Test: Manual
Change-Id: If439b64ad968f62674f856fd3ff465bf21cc9204
2021-02-11 22:16:24 -08:00
Lucas Dupin db3f34f956 Revert "Ignore broken launcher tests"
This reverts commit 03c5a46235.

Reason for revert: Fixed tests
Bug: 180016597

Change-Id: I45390f157c6c3a379d686e8802648aa948071b72
2021-02-12 02:57:58 +00:00
Sunny Goyal f8bb6c02a1 Merge "Registering input monitor in Launcher process" into sc-dev 2021-02-12 01:04:46 +00:00
Sreyas e87b4c4979 Updated TaskMenuView.
Added padding on top of task name and removed unused code.
Bug: 179490926
Test: Manual

Change-Id: Id28547f30872f449f4f51238854155358b2dbcbe
2021-02-11 15:36:30 -08:00
Lucas Dupin 5fc546d09c Merge "Ignore broken launcher tests" into sc-dev 2021-02-11 23:15:39 +00:00
Zak Cohen b849aaf63d Remove scaling and dimming for adjacent tasks in Overview.
New designs flatten out the overview list and don't have scaled and dimmed
tasks adjacent to the main one.

Bug: 179922117
Test: Local run
Change-Id: I2dde04ed60b9d8459810a10d0c27dd6e131855a6
2021-02-11 19:21:27 +00:00
Zak Cohen b56611d962 Adjust task padding overview to match new specs.
New mocks have increased padding between the tasks.
I think we might need to fold some of these size calculations together
eventually, but this should be ok for the moment.


Bug: 179922117
Test: Local build and run
Change-Id: I4b5186d36012e80d55fae791e0c151c3112eecd1
2021-02-11 19:08:44 +00:00
Zak Cohen 34f4b7ebb8 Remove elevation from Task in Overview.
New designs don't have elevation for task views.


Bug: 179922117
Test: Local run
Change-Id: I0b3cb698574b49a279c7265e7f523819d20e2827
2021-02-11 19:08:02 +00:00
Hyunyoung Song b3d739dfa9 Apply Silk/ colorBackground(Floating) to AllApps
Bug: 180020638
Test: adb shell setprop persist.sysui.monet 1 && adb shell am crash com.android.systemui
Change-Id: Ied508f3452a3e640495fff4d1567c3b094f54432
2021-02-11 10:52:06 -08:00
Ryan Mitchell 03c5a46235 Ignore broken launcher tests
Fabricated overlay changes seem to have made these tests flaky. Ignore
them for now while we figure out why the tests are flaky.

Bug: 180016597
Test: atest NexusLauncherOutOfProcTests
Change-Id: I639dabb2d6d57243882e0bc7100cc4947b32e37f
2021-02-11 18:20:43 +00:00
Steven Ng fa58bfa0b7 Merge "Refactoring before adding a new view type in the WidgetsListAdapter" into sc-dev 2021-02-11 01:06:11 +00:00
Adam Cohen 12e547f2a8 Merge "Draw the workspace scrim in the LauncherRootView instead of DragLayer" into sc-dev 2021-02-10 23:33:06 +00:00
thiruram 91d4f9f007 Fix to avoid NPE with LiveSearchManager.
Bug: 179911188
Test: manual
Change-Id: Ic7f8ae7f7e2795eb18569670e166310102b7ea02
2021-02-10 23:24:32 +00:00
vadimt 2b6d18230b Instrumenting swiping up to all apps for jank
Bug: 178656784
Test: manual
Change-Id: I2332f0f358dc7312dc7ad0b88bc51db5bfa8be6c
2021-02-10 15:24:02 -08:00
Jon Miranda 228877d37c Add border spacing and fixed cell height to grid.
- Border spacing is the spacing between the cells.
- Workspace cell height is now fixed, and we allocate
  all the "extra" space to three different variable height
  areas.

* Built behind ENABLE_FOUR_COLUMNS flag because it hinders the
default grid.

Bug: 175329686
Test: - set border spacing to 0 and confirm matches prior layout
      - test drag and drop still worked
      - test reordering
      - test widgets
      - test folders
      - test multiwindow

Change-Id: Ic6f3dff577d28ff214bda4b0a787ec7fd08c108b
2021-02-10 17:22:37 -05:00
TreeHugger Robot 99f23c9714 Merge "Update TaskIcon UI." into sc-dev 2021-02-10 22:03:30 +00:00
Steven Ng 2f5648a911 Refactoring before adding a new view type in the WidgetsListAdapter
Changes made:
1. Model: added an abstract class for storing common information for
   entries shown in the full page widgets picker.
2. Introduced a ViewHolderBinder interface to split the logic of binding
   data to ViewHolder into separate classes.
3. Move the view holder binding of WidgetsListRow from WidgetListAdapter
   to its new class.
4. Move some widgets picker classes into a new picker package.

Test: Auto: Run WidgetsListAdapterTest, WidgetsListRowEntryTest and
      WidgetsListRowViewHolderBinderTest.
      Manual: open the all apps widgets tray and navigate the list.

Bug: 179797520
Change-Id: Iab29557842bb79156cad84d00a4c5d0db0c5aa06
2021-02-10 21:23:40 +00:00
TreeHugger Robot 16126eedcd Merge changes I0e4cedbf,Idfa1b82c into sc-dev
* changes:
  Add instanceId to LAUNCHER_FOLDER_CONVERTED_TO_ICON log event.
  Fixes wrong container for LAUNCHER_ITEM_DROP_COMPLETED log event.
2021-02-10 20:42:50 +00:00