Commit Graph

33301 Commits

Author SHA1 Message Date
Winson Chung e6ef8dac28 Removing screen pinning flag check
- The flag may be inaccurate, revert to the activity manager check
  for now

Bug: 131552865
Test: Manual
Change-Id: If7c00ba7a1cbb726dcd65993451e82d76778fd4b
2019-04-30 18:19:24 +00:00
Kevin 7184228332 Merge "Overlap insets with item margins" into ub-launcher3-qt-dev
am: d9c0fe130b

Change-Id: I1718e8778a09dcf9442330c0d40eac77b0e1dc8e
2019-04-30 11:09:47 -07:00
TreeHugger Robot d9c0fe130b Merge "Overlap insets with item margins" into ub-launcher3-qt-dev 2019-04-30 18:00:12 +00:00
Kevin d8144a6304 Overlap insets with item margins
The system insets already create visual space for us, so there is no
need to add additional margin if we already have the insets acting as a
buffer. So we can just overlap them, preventing scenarios where we have
too much scrollable white space.

As a bonus, we get a more robust way of determining the clear all
button's bottom margins as we now base it directly off whether the
insets cover the space as opposed to using the orientation (which is
an indirect way of knowing the insets).

Bug: 131636735
Test: Test on 320x569 mdpi. Matches UX spec.
Change-Id: I6a3a3a5475ed303ed21bca3ed3cc363276c6e745
2019-04-30 10:33:55 -07:00
Winson Chung d95d598e23 Merge "Fix some MW visual issues" into ub-launcher3-qt-dev
am: 287f5d5aef

Change-Id: I5e1bb9797ed101c547c319be520e80ef056ec39c
2019-04-30 10:00:58 -07:00
TreeHugger Robot 287f5d5aef Merge "Fix some MW visual issues" into ub-launcher3-qt-dev 2019-04-30 16:48:43 +00:00
Winson Chung 8d86cf0bcc Fix some MW visual issues
- Ensure that we don't apply apply crop from device coordinates (reset to
  surface coordinates)
- Disable rounded window corners in MW

Bug: 128364741

Change-Id: Ia91500ca97b44537829983945cd3d3cc82747aeb
2019-04-30 09:35:22 -07:00
Kevin 8f6d41ee53 Fade task items when swiping out
As we have a fixed width for the task list now, we have to ensure that
we do not clip the task items when we swipe them out. In addition, we
should fade them out by the end of the swipe as the swipe end location
may still be on a visible part of the screen.

Bug: 131686863
Test: Go to landscape mode, swipe out tasks
Change-Id: If86136a9f9d47098a6dd5d355d3a99d540165c77
2019-04-30 09:13:51 -07:00
android-build-team Robot 02da7618e4 Snap for 5515275 from d50b5572c7 to rvc-release
Change-Id: Id2cbccc106662493e34cb83c1429dcd84527384c
2019-04-30 03:13:07 +00:00
Tony Wickham 90261839dc Merge "Add null check before removing live tile overlay" into ub-launcher3-qt-dev
am: 32d475bca4

Change-Id: I1f3807a1ce735d0334a9b73dcdbf99a9aced5ad9
2019-04-29 18:30:27 -07:00
Vadim Tryshev 14f33b7ee0 Merge "Disabling fallback overview tests until the bug is fixed" into ub-launcher3-qt-dev
am: 9736474072

Change-Id: I5b0a698c6c01d7a87b3932eb9736a40b312535e4
2019-04-29 18:24:25 -07:00
TreeHugger Robot 32d475bca4 Merge "Add null check before removing live tile overlay" into ub-launcher3-qt-dev 2019-04-30 01:22:32 +00:00
Vadim Tryshev 9736474072 Merge "Disabling fallback overview tests until the bug is fixed" into ub-launcher3-qt-dev 2019-04-30 01:10:51 +00:00
Vadim Tryshev 781d444e75 Merge "Slowing down gestures for virtual device" into ub-launcher3-qt-dev
am: b93786dca3

Change-Id: I815ba5c12d80ed8d87ccaa855a40e197310d8f25
2019-04-29 18:06:22 -07:00
Kevin 5e3cf315ec Merge "Fix thumbnail views not rotating w/ orientation" into ub-launcher3-qt-dev
am: 40689ca9ab

Change-Id: I1ecf235dc3a78d51972d2ca822fbf91fa6399b1c
2019-04-29 18:00:21 -07:00
Vadim Tryshev b93786dca3 Merge "Slowing down gestures for virtual device" into ub-launcher3-qt-dev 2019-04-30 00:59:45 +00:00
TreeHugger Robot 40689ca9ab Merge "Fix thumbnail views not rotating w/ orientation" into ub-launcher3-qt-dev 2019-04-30 00:45:37 +00:00
Tony Wickham de68f8097c Add null check before removing live tile overlay
Bug: 131630813
Change-Id: I6d2c39c61aa918b11dd3d15703fe6ca52c19778d
2019-04-30 00:31:38 +00:00
Winson Chung d50b5572c7 Merging ub-launcher3-qt-dev, build 5505393 am: d4e8bdbc62
am: 1d79362f5c

Change-Id: I1cfcd20fa01fabc762216fbc9ce7da1b978b9847
2019-04-29 17:31:22 -07:00
vadimt dc5b2fbdbe Slowing down gestures for virtual device
Change-Id: I636bd3c053295041d0ae4e5c97f2790f5a1e40dd
2019-04-29 17:18:30 -07:00
Winson Chung 1d79362f5c Merging ub-launcher3-qt-dev, build 5505393
am: d4e8bdbc62

Change-Id: I91f1c3d4bf134226ac40111e2a0eda3ad8e1fd35
2019-04-29 17:18:27 -07:00
Kevin 27831e1b01 Fix thumbnail views not rotating w/ orientation
View has an optimization where it will not measure again if it
is exact and the measurement has not changed. This means that when an
onMeasure pass starts off for each task view on orientation change,
it does not get passed down to the view holding the thumbnail and
icon as its measure specs have not changed. This causes an issue as
we use this measure call to react to orientation changes and
re-measure the thumbnail view to match the orientation of the device.

To fix this, we call forceLayout on the child explicitly on orientation
change to ensure that we get the measure call. This sets the flag to
force a re-measure in the next layout.

Bug: 131427332
Test: Do repro in bug, view rotates correctly
Change-Id: I0ef84dfcd0b3883582c8903d99d5e8a757ae8e74
2019-04-29 17:15:20 -07:00
Kevin cf4255336b Merge "Add 1.5x dimens for screens that are large enough" into ub-launcher3-qt-dev
am: 67b6541d7e

Change-Id: Ieb470638587ce4c060de7adcb689fe9e06b3e295
2019-04-29 17:07:41 -07:00
Kevin 798353cd2b Merge "Don't clip recents items with system bars" into ub-launcher3-qt-dev
am: ee8caf680a

Change-Id: I56befc5a089db2b9e5663b9907507f3a84923bfc
2019-04-29 17:07:16 -07:00
TreeHugger Robot 67b6541d7e Merge "Add 1.5x dimens for screens that are large enough" into ub-launcher3-qt-dev 2019-04-29 23:55:29 +00:00
TreeHugger Robot ee8caf680a Merge "Don't clip recents items with system bars" into ub-launcher3-qt-dev 2019-04-29 23:44:44 +00:00
Kevin 3dae6383f4 Add 1.5x dimens for screens that are large enough
For phones with smallest width at least 480 dp, we can scale
everything by 1.5x to fill in the space better. For phones with less
width than this, we maintain the current 320 dp specification.

Bug: 131610834
Test: Emulate on 240x320 ldpi, 480x800 hdpi, 480x800 mdpi, 800x1280 mdpi
on both portrait and landscape and layouts work as intended
Change-Id: I3f7d28dc22aa3a2de96b3de51b1aa5b5c2cb19fc
2019-04-29 16:43:12 -07:00
Vadim Tryshev 7fd3c6fc66 Merge "Not switching nav mode on a virtual device for now" into ub-launcher3-qt-dev
am: ac8494bfd9

Change-Id: I8d2fe47624b8c4959187f9092fe4207806de854b
2019-04-29 16:36:47 -07:00
Vadim Tryshev 51f364a184 Merge "Disabling AppPredictionsUITests" into ub-launcher3-qt-dev
am: 203dde3999

Change-Id: If6a73efb41042957d674d75fcc303e87b8a41495
2019-04-29 16:36:19 -07:00
Kevin 5cfd599f49 Align layout to dp grid for landscape
am: dd165d2d7c

Change-Id: I224627063dbab99807a80a97c7de6605fa9e0784
2019-04-29 16:35:47 -07:00
vadimt de84db9890 Disabling fallback overview tests until the bug is fixed
Please reenable once fixed.

Bug: 131630813
Change-Id: Idb6f59c5e785180c96fce10365a2b070558abcdd
2019-04-29 16:28:29 -07:00
Vadim Tryshev ac8494bfd9 Merge "Not switching nav mode on a virtual device for now" into ub-launcher3-qt-dev 2019-04-29 23:22:10 +00:00
Kevin 0448ab6d7d Don't clip recents items with system bars
In order for items to go under the system bars, we have the recents view
consume the insets by setting padding to the recyclerview instead of
setting the margins with it. Then, we ensure the recycler view does not
clip to padding so that items are still visible even when scrolled past.

Bug: 131626311
Test: Manual test; items go under system bars
Change-Id: Iecbab537b8f9e2993ad5f74f87ba2e0c56fb0f63
2019-04-29 16:06:32 -07:00
Vadim Tryshev 203dde3999 Merge "Disabling AppPredictionsUITests" into ub-launcher3-qt-dev 2019-04-29 23:03:17 +00:00
vadimt 8dca8a7328 Not switching nav mode on a virtual device for now
Change-Id: Ie089638b6252073e5e495e87c7bc0d252a58e95f
2019-04-29 16:01:47 -07:00
Kevin 694e0fccad Merge changes Id401f273,I0b21c8ea,Ieb7936bd into ub-launcher3-qt-dev
am: 384a0aade0

Change-Id: Id250130cd3f1b2b563556cbd76603f6cf8d2015a
2019-04-29 15:22:51 -07:00
Kevin dd165d2d7c Align layout to dp grid for landscape
Set a fixed width for the recyclerview and center it for landscape mode.
In addition, put a margin below the clear all button as we no longer
have the nav bar padding the area below.

Bug: 131610834
Test: Manual; See recents UI in landscape mode
Change-Id: I8c74d2d7cc363a76c4c978befdc975693d700f86
2019-04-29 15:21:08 -07:00
Sunny Goyal da8105cc9f Merge "Adding support for accessibiliy gesture" into ub-launcher3-qt-dev
am: c6e7a38fb6

Change-Id: I6cb983919cd85e21b937b3e55ff98ecb2f2058d3
2019-04-29 15:17:38 -07:00
TreeHugger Robot 384a0aade0 Merge changes Id401f273,I0b21c8ea,Ieb7936bd into ub-launcher3-qt-dev
* changes:
  Layout aligned to dp grid for portrait (3/3)
  Layout aligned to dp grid for portrait (2/3)
  Layout aligned to dp grid for portrait (1/3)
2019-04-29 22:08:29 +00:00
TreeHugger Robot c6e7a38fb6 Merge "Adding support for accessibiliy gesture" into ub-launcher3-qt-dev 2019-04-29 21:54:41 +00:00
Kevin fc3a79e45e Layout aligned to dp grid for portrait (3/3)
Remove old custom view functionality to size based off device height
since we now specify dimensions exactly.

Bug: 131610834
Test: Builds, layout meets spec in portrait mode
Change-Id: Id401f27360f6bb2450d3ffb77888a1f709dc62f8
2019-04-29 14:52:56 -07:00
Kevin ad8ca82e61 Layout aligned to dp grid for portrait (2/3)
Add vertical margins to all recycler items. In the future, we will
change these dynamically to ensure a task item is semi-visible on screen

Bug: 131610834
Test: Builds
Change-Id: I0b21c8ea7249e7fac640705e8128e309b954815b
2019-04-29 14:48:48 -07:00
Sunny Goyal 4580149897 Adding support for accessibiliy gesture
Bug: 130905838
Change-Id: If796b6e6036c2f216abf87386d8eebcaa6368d02
2019-04-29 14:40:41 -07:00
Sunny Goyal 2acea9f872 Enabling quick-switch gesture in landscape mode (2 button UI)
Bug: 130689544
Change-Id: I6b424be4d80b3bf8263f456a024a81c63100030e
2019-04-29 14:33:56 -07:00
Tim Joines de7ef8c619 Merge "Launcher3GoIconRecents should override Launcher3Go" into ub-launcher3-qt-dev
am: 03225dba44

Change-Id: I2b529a21ae9573a4d21a585cd5585d4a81d39999
2019-04-29 13:37:24 -07:00
Kevin eb815415da Layout aligned to dp grid for portrait (1/3)
This CL sets fixed dp values for the recents item views based off the UX
spec.  Vertical margins will be handled by an item decorator in the next
CL to handle special cases.

Bug: 131610834
Test: Builds
Change-Id: Ieb7936bd24933552844a6bd1bdb9e3101b8cdca4
2019-04-29 13:12:54 -07:00
Tim Joines 03225dba44 Merge "Launcher3GoIconRecents should override Launcher3Go" into ub-launcher3-qt-dev 2019-04-29 20:05:21 +00:00
Sunny Goyal b4a03febfc Releasing SurfaceControl when they are no longer needed
am: 0382dd76e8

Change-Id: I5038e4ecd892a7e23658c9aa7c59a2e3beef7363
2019-04-29 12:33:25 -07:00
Ryan Mitchell 369725db43 Rename launcher:iconSize attribute to prevent overriding material am: 09328442d6
am: 7a86547199

Change-Id: I36017d544f9c6581d44e85722dcfbe47ca0412f4
2019-04-29 12:10:00 -07:00
Sunny Goyal 0382dd76e8 Releasing SurfaceControl when they are no longer needed
Bug: 123874711
Change-Id: I9c06723a3e5d4a23b8a6c60352806bb12daba598
2019-04-29 12:04:11 -07:00