Commit Graph

33301 Commits

Author SHA1 Message Date
vadimt 3ca5280186 Fixing All Apps's getting stuck in a non-updating state
Normally, if all apps is open, and an app installs/uninstalls/updates,
All Apps will immediately reflect this.

However, depending on something subtle in the intensity of the swipe
gesture that brought All Apps, all apps will freeze, and won't update.

This frozen state will go away after scrolling in all apps, iteration
with an icon and, generally, any tap interaction with All Apps.
Otherwise, it will stay until it's closed and opened again via a gesture
with a different pattern.

The reason is in the code that freezes All Apps updates during user
interactions with all apps.

For example, during scrolls. Or while the user holds an icon, expecting
to see a context menu; in this case an update would cause the menu to
not appear, which is somewhat annoying.

The motivation to add this code was to solve a category of lab-only
flakes when a context menu couldn't open because the lab device was busy
with post-flash activities.

The code incorrectly assumed that after ACTION_DOWN, we are guaranteed
to get either UP or CANCEL, which is wrong.

It's after *consumed* ACTION_DOWN that we'll get these events.

The fix still solves the user's and tests' problems that the code was
supposed to solve.

Bug: 134442147
Change-Id: I9db74a33ecf93b1dc6bc69df301f7f542dea2a40
2019-06-03 18:35:52 -07:00
Sunny Goyal 7486f1c93f Merge "Removing user locked change in LauncherAppState" into ub-launcher3-qt-dev am: ce0c093133
am: 7241d7cfe5

Change-Id: I673d348e511fca5c1798d2c2a26800f6eb5f2a19
2019-06-03 17:06:41 -07:00
Sunny Goyal 7241d7cfe5 Merge "Removing user locked change in LauncherAppState" into ub-launcher3-qt-dev
am: ce0c093133

Change-Id: Ib85ff9f162f4511726d270e9d1ab94734c04e054
2019-06-03 16:55:12 -07:00
TreeHugger Robot ce0c093133 Merge "Removing user locked change in LauncherAppState" into ub-launcher3-qt-dev 2019-06-03 23:44:58 +00:00
Sunny Goyal d17a951df8 Removing user locked change in LauncherAppState
The process will crash anyway when loading sharedPreference. So
we do not need any extra check to cause the same crash.

Bug: 134094839
Change-Id: Icfd4406ff601d6b9a75bd95ddcecb9869f7e7fa2
2019-06-03 23:19:02 +00:00
Zak Cohen 70ec2a4213 Merge "Remove unused hints code." into ub-launcher3-qt-r1-dev
am: 0f405d78d7

Change-Id: I88b0186a60948e6bed8c4db4a9b186a1e71bdf2f
2019-06-03 16:17:00 -07:00
TreeHugger Robot 0f405d78d7 Merge "Remove unused hints code." into ub-launcher3-qt-r1-dev 2019-06-03 23:02:01 +00:00
Sunny Goyal 9d8b1376e8 Adding some state for fallback recents View
Maintaining a boolean corresponding to overview or QuickSwitch which
updates the visuals for RecentsView accordingly

Bug: 134166337
Change-Id: If1aec99257de4db1796335f2cf39d2d35789915b
2019-06-03 16:00:06 -07:00
Hyunyoung Song becaf37421 Merge "Add shape detection logic only for circle icons" into ub-launcher3-qt-dev am: ed45267bf9
am: 355a04ed39

Change-Id: I6989dcacffcc58e4d50a8fd8f210c0ea51e921af
2019-06-03 15:53:48 -07:00
Hyunyoung Song 355a04ed39 Merge "Add shape detection logic only for circle icons" into ub-launcher3-qt-dev
am: ed45267bf9

Change-Id: I73fb9cfb2ed66bf88baa62f53714c028ea47b648
2019-06-03 15:46:47 -07:00
Hyunyoung Song ed45267bf9 Merge "Add shape detection logic only for circle icons" into ub-launcher3-qt-dev 2019-06-03 22:34:02 +00:00
Zak Cohen f3231f417d Remove unused hints code.
This layout is handled by the provider of the hints now.

Test: manual
Change-Id: Ifc0db2395a7503b1b03dcb796961ef6647c0413b
2019-06-03 14:58:18 -07:00
Hyunyoung Song f69426c484 Add shape detection logic only for circle icons
b/119330044

Change-Id: I93042effa8417167d844f073275e8b941e861e60
2019-06-03 14:05:20 -07:00
Adam Cohen 79c905d18a Fix issue where Workspace scrolling doesn't work am: acdde3d750
am: 80ed6012dd

Change-Id: I8816a17d486ba69ed372310a6e1fac0ecddddaf4
2019-06-03 12:39:34 -07:00
Adam Cohen 80ed6012dd Fix issue where Workspace scrolling doesn't work
am: acdde3d750

Change-Id: If949e3368d383b8a7ba1c6c7608af46011f36f73
2019-06-03 12:34:31 -07:00
Perumaal S 2461d61e14 Re-enable chips in qt-r1-dev
Fixes: 134164918
Change-Id: Ib5441a40ad8043afbe32d6c4c40808676cdcdb20
2019-06-03 10:21:47 -07:00
android-build-team Robot cf28741fa5 Snap for 5626839 from 077965d075 to qt-qpr1-release
Change-Id: Ibf7ecd4db17248e811da0f440bfbc8a82f6f17a4
2019-06-01 23:20:44 +00:00
Adam Cohen acdde3d750 Fix issue where Workspace scrolling doesn't work
=> The WorkspaceTouchListener was relying on receiving TOUCH_DOWN in order to
   clear its state. This is not guaranteed; ie. when touches begin above
   children of the workspace (icons or widgets)

=> Any invocation of the Workspace long press menu would trigger this issue
   and it would persist until a touch went directly onto the Workspace in a
   location without any children.

Bug 132298752

Change-Id: Id8617baaa1ce59dc84758a7c82049329323b04cc
2019-06-01 17:16:59 -06:00
android-build-team Robot ee747317dd Snap for 5626731 from 0ef6fe00b0 to qt-release
Change-Id: Ib6392982767c5546f7f70bd80406ac8cbc3de67f
2019-06-01 23:07:00 +00:00
android-build-team Robot b8ea3af73c Snap for 5626642 from 077965d075 to qt-c2f2-release
Change-Id: I114e8e05005b3a0eaaf1e7c85509c7e6e6ca6372
2019-06-01 23:02:49 +00:00
android-build-team Robot ccf02c1607 Snap for 5624916 from f70c0a09e9 to rvc-release
Change-Id: I89348c96435ced01bb855ee09ff69eede1b4c173
2019-06-01 03:17:21 +00:00
Tony Wickham 1d2acc1a67 Merge "Fix getting stuck in BackgroundAppState for 2-button mode" into ub-launcher3-qt-dev am: 72c6e7b736
am: dcff2f1875

Change-Id: Ifd59f5e3a82aa956993d1546118f047b75c595bf
2019-05-31 16:51:37 -07:00
Sunny Goyal 6865fb9723 Merge "Fixing overview scrim not initialized properly when launcher starts" into ub-launcher3-qt-dev am: 061c43eb4f
am: 3695646987

Change-Id: I83a1c1b95e48d1e2b919be4ead7e28d14e0bc3b1
2019-05-31 16:51:11 -07:00
Tony Wickham dcff2f1875 Merge "Fix getting stuck in BackgroundAppState for 2-button mode" into ub-launcher3-qt-dev
am: 72c6e7b736

Change-Id: I6ab2194d50a6d7dfb7bd7c13bab776331c426c23
2019-05-31 16:26:39 -07:00
Sunny Goyal 3695646987 Merge "Fixing overview scrim not initialized properly when launcher starts" into ub-launcher3-qt-dev
am: 061c43eb4f

Change-Id: I58aa5801e698c8e8b2e0133f6995d77b341cc76f
2019-05-31 16:26:05 -07:00
TreeHugger Robot 72c6e7b736 Merge "Fix getting stuck in BackgroundAppState for 2-button mode" into ub-launcher3-qt-dev 2019-05-31 23:22:30 +00:00
Tony Wickham a04e746e84 Fix getting stuck in BackgroundAppState for 2-button mode
When ending in recents, we reapply the state - therefore, it's important
to make sure we are in OverviewState before onSwipeUpComplete(). This is
done by mLauncherTransitionController, which sets OverviewState on end.
We already force mLauncherTransitionController to end before calling
onSwipeUpComplete(), but in this case we were calling cancel() and
setting mLauncherTransitionController = null, which meant we could never
call end() on it. Instead, we should always call end() if we set it to
null.

Also ensure mLauncherTransitionController is created even if the gesture
is completed, if an existing controller isn't already running. This can
happen if you swipe up quickly enough that we get onGestureEnd before
launcher is drawn, and in that case we still want the launcher component
to animate once its ready. This is even more important for 2-button
mode, because again, we rely on mLauncherTransitionController to set the
state to OverviewState before we reapply it.

Finally, clarified some methods by renaming "swipeUp" to
"swipeUpToRecents".

Bug: 132757019
Change-Id: Ieb24a4f36a39780e5d64d7bc312791608db474d1
2019-05-31 16:11:40 -07:00
TreeHugger Robot 061c43eb4f Merge "Fixing overview scrim not initialized properly when launcher starts" into ub-launcher3-qt-dev 2019-05-31 23:01:36 +00:00
Perumaal S 9f8dac1dbd Merge "Disable chips in qt_dev" into ub-launcher3-qt-dev am: 045dc86d9f
am: 165a28fd26

Change-Id: I0e43659dd5f3eecaeda063ae1dbc459596791668
2019-05-31 15:28:36 -07:00
Perumaal S 165a28fd26 Merge "Disable chips in qt_dev" into ub-launcher3-qt-dev
am: 045dc86d9f

Change-Id: I3ab54017ec08ff868001ddde2dda58d7d6119961
2019-05-31 15:23:35 -07:00
TreeHugger Robot 045dc86d9f Merge "Disable chips in qt_dev" into ub-launcher3-qt-dev 2019-05-31 22:12:40 +00:00
Vadim Tryshev 36a97714ec Merge "More debug tracing for switching to all apps not sending the final event" into ub-launcher3-qt-dev am: 719908c84b
am: 55ebd4e653

Change-Id: If580bc5b9a5abd39e90907324dfa1565a127f36e
2019-05-31 14:53:24 -07:00
Vadim Tryshev 55ebd4e653 Merge "More debug tracing for switching to all apps not sending the final event" into ub-launcher3-qt-dev
am: 719908c84b

Change-Id: Ife320795c1034d0b332a652b44d4f2c6e1a66418
2019-05-31 14:46:22 -07:00
Perumaal S 464dda250b Disable chips in qt_dev
- Not for use in qt_r1_dev

Bug: 134164918
Change-Id: Ib49289060a39a1a5615e762a4e72b105ed166135
2019-05-31 21:28:46 +00:00
Vadim Tryshev 719908c84b Merge "More debug tracing for switching to all apps not sending the final event" into ub-launcher3-qt-dev 2019-05-31 21:20:21 +00:00
android-build-team Robot dd88306293 Merge cherrypicks of [7848027, 7846805, 7847697, 7847517] into qt-c2f2-release
Change-Id: Ic0223aded1eea98f0b868ec4b2c011a8d40e67fa
2019-05-31 20:37:59 +00:00
Winson Chung f26d98e870 Merging ub-launcher3-qt-dev, build 5619253
Test: Manual
Bug:112282235 P3 Starting an app from Launcher very rarely takes > 10 sec
Bug:121279417 P2 Why LauncherInstrumentation.WAIT_TIME_MS == 60000?
Bug:123892607 P1 Test broken: WellbeingTests.testPauseAppFromAllApps
Bug:123900446 P1 App to home animation should zoom into the app icon
Bug:125844074 P2 Final UX and animations for Launcher DWB integration
Bug:131360075 P1 [Gesture Nav] Polish/finish landscape
Bug:131698989 P2 Add task callback for locked state change
Bug:131741395 P2 Allow windows to scale/move past overview positioning
Bug:131768436 P1 Bad placement of search bar
Bug:131854153 P1 Lots of Cuttlefish (and not only) tests are broken
Bug:131867841 P1 Changing display size does not update the grid
Bug:132460627 P1 Unable to swipe to all apps screen on devices
Bug:132687470 P1 Swiping home from forced landscape app creates cutoff task thumbnail
Bug:132756514 P1 Sometimes (when quick switching?) user gets stuck in full-screen recents view
Bug:132900132 P1 Apparently, tests start running while provisioning is still in progress
Bug:132917885 P1 Reduce swipe-up gesture region height in landscape
Bug:132975416 P1 Flake in NexusPredictionAppTracker.getAppPredictionContextExtras
Bug:132993129 P1 If predictions disabled, app predictions loading bar appears briefly on device restart
Bug:133113732 P1 [B1/C1][QT][CTS_Verifier_9.0_r1]Device Owner Tests-LockTask UI-Enable Overview button failure
Bug:133167096 P1 It is way too easy to dismiss apps from the lock screen
Bug:133651528 P1 [QT]"Pixel Launcher isn't responding" dialog pop up ,after DUT restored.
Bug:133765434 P1 [Flaky test] Launching task didn't open a new window
Bug:133765491 P1 App docked in split screen flickers with emptiness observed while rotating the device
Bug:133783088 P1 Footer showing up on all overview task snapshots even with no items showing.
Bug:133867119 P2 Lab-only flake: want to switch from workspace to all apps; Swipe failed to receive an event for the swipe end
Bug:64712476 P3 Import translations for dev branches

Change-Id: Ib4bcefdbb4027992e75e2742d72f199e13467875
(cherry picked from commit 0ef6fe00b0)
2019-05-31 20:37:38 +00:00
vadimt a8f77a6afd More debug tracing for switching to all apps not sending the final event
(to the test)

Bug: 134172603
Bug: 133867119
Change-Id: I00cf3a35daefa23d2e72a89d21e6ce37c8a9a46d
2019-05-31 13:34:24 -07:00
Vadim Tryshev 76fbff84e2 Merge "Annotating hierarchy dump for the error description" into ub-launcher3-qt-dev am: 43522d25f2
am: c201fe6b0b

Change-Id: Ie56ffbcb0d89fb5bc15c32d2438185420b082a4c
2019-05-31 12:18:25 -07:00
Vadim Tryshev c201fe6b0b Merge "Annotating hierarchy dump for the error description" into ub-launcher3-qt-dev
am: 43522d25f2

Change-Id: If5870760faa0150f94487ed9acfd7db724f10a4a
2019-05-31 12:10:25 -07:00
Vadim Tryshev 43522d25f2 Merge "Annotating hierarchy dump for the error description" into ub-launcher3-qt-dev 2019-05-31 18:54:02 +00:00
Govinda Wasserman f85febdaff Merge "Adds trigger for new gesture entrypoint to Assistant bundle" into ub-launcher3-qt-dev am: 164ebb2e8c
am: c985c6e563

Change-Id: Icd0c602956e643c9dd1c87352481760b121ca863
2019-05-31 11:44:15 -07:00
Govinda Wasserman c985c6e563 Merge "Adds trigger for new gesture entrypoint to Assistant bundle" into ub-launcher3-qt-dev
am: 164ebb2e8c

Change-Id: I43d6d72765b6d7aa69dce40a3350001a18c6ac63
2019-05-31 11:33:11 -07:00
vadimt 8fcf7059ed Annotating hierarchy dump for the error description
Change-Id: I10285d451f4816b4988ce0645669b9ec9cceac81
2019-05-31 11:32:09 -07:00
Govinda Wasserman 164ebb2e8c Merge "Adds trigger for new gesture entrypoint to Assistant bundle" into ub-launcher3-qt-dev 2019-05-31 18:09:53 +00:00
Tony Wickham 82e8b32f99 Merge "Don't recreate the launcher animation controller if gesture ended" into ub-launcher3-qt-dev am: 8765e262c2
am: ab384404b1

Change-Id: I8abe9febf5734e16c0506fc37ea6f9890d7aa454
2019-05-31 11:00:56 -07:00
Sunny Goyal 03d32ddb23 Fixing overview scrim not initialized properly when launcher starts
State UI depends on visible content, which can change due to predicitons.
Reapplying the state whenever then happens ensures that we are in correct
start UI

Change-Id: I9f195a92b747fda8a5b217dc960f230d7a695255
2019-05-31 11:00:35 -07:00
Tony Wickham ab384404b1 Merge "Don't recreate the launcher animation controller if gesture ended" into ub-launcher3-qt-dev
am: 8765e262c2

Change-Id: Ieb53126643d9f41a5ba5b85ca0d8b02ef2f6eb47
2019-05-31 10:55:54 -07:00
Tony Wickham 8765e262c2 Merge "Don't recreate the launcher animation controller if gesture ended" into ub-launcher3-qt-dev 2019-05-31 17:46:03 +00:00
Tony Wickham 436d5971b1 Don't recreate the launcher animation controller if gesture ended
This can happen if we get onApplyWindowInsets() after onGestureEnded().
In that case, we can get into some bad states because the running
animation is overwritten and thus can't be canceled.

Bug: 134096917
Bug: 133806285
Change-Id: Ic517d68a46a4446ca382445df1ba62c26e8243ad
2019-05-31 10:21:28 -07:00