Commit Graph

33301 Commits

Author SHA1 Message Date
Tony dd3198b78b Don't end launcher components anim early even if it does nothing
am: c5555c459b

Change-Id: I0ae148eaed1e78833f54449281c37f11acf889a4
2019-08-07 18:05:35 -07:00
Sunny Goyal e529a86fbd Adding support for storing keywords in iconCache
Change-Id: I1183e63a6556ebfb3eee5df23d149e09728193a9
2019-08-07 15:51:25 -07:00
Sunny Goyal f63fc3cc63 Merge "Merging ub-launcher3-qt-r1-dev, build 5782058 am: c128131a10 am: 530b284a90" into qt-qpr1-dev-plus-aosp
am: cfb3bc4834

Change-Id: I5cf5abd22b303140c7f37f5a68bfdc72848c21ad
2019-08-07 11:22:22 -07:00
Sunny Goyal 64f3d4ab72 Merging ub-launcher3-qt-r1-dev, build 5782058 am: c128131a10 am: 103974c88f
am: a938be7c06

Change-Id: I1b0967a7cbf3000d55f09744b51b7e8009cf1323
2019-08-07 11:18:47 -07:00
Tony c5555c459b Don't end launcher components anim early even if it does nothing
The janky animation that ends on the home screen with an invisible
task on top is caused by the following scenario (for example):
- Quick switch from task A to task B
- After landing on B, but before we get the callback that it was
  successfully launched, switch back to A (or you could go to C)

Now we are animating back to A, but we are still waiting to hear
whether B was successfully launched. If we hear that the launch
was indeed successful, we dutifully clean up after ourselves  by
returning launcher to its default state. Unfortunately, that
clobbers the current animation that is scrolling back to A, and
we end up in the bad state where we are showing the default
launcher state even though we just launched task B and were
about to launch task A.

Normally we avoid cleaning up the state animation if the user
is still controlling it. The reason we weren't doing that here
is because we ended the launcher animation early even though
the window animation was still running. Instead, we should keep
the launcher animation running for the full duration, so that
it prevents a cleanup from occurring in the middle.

Bug: 138620399
Change-Id: I959e62a52638a5b974ef9b406555078c928b91f1
(cherry picked from commit 03c548901f)
2019-08-07 17:56:34 +00:00
Android Build Merger (Role) cfb3bc4834 Merge "Merging ub-launcher3-qt-r1-dev, build 5782058 am: c128131a10 am: 530b284a90" into qt-qpr1-dev-plus-aosp 2019-08-07 17:53:58 +00:00
Sunny Goyal 3344ead807 Merging ub-launcher3-qt-r1-dev, build 5782058 am: c128131a10
am: 530b284a90

Change-Id: I9fc9b85891806b7cf401fcc258162531c54b1e12
2019-08-07 10:53:26 -07:00
Sunny Goyal a938be7c06 Merging ub-launcher3-qt-r1-dev, build 5782058 am: c128131a10
am: 103974c88f

Change-Id: I83a62783f021122d04ca676b94b1b7c86ab4f101
2019-08-07 10:52:58 -07:00
Sunny Goyal 103974c88f Merging ub-launcher3-qt-r1-dev, build 5782058
am: c128131a10

Change-Id: I0ffb8dfc13fa2c7a23015c1324abf1f15f981bc8
2019-08-07 10:40:16 -07:00
Sunny Goyal 530b284a90 Merging ub-launcher3-qt-r1-dev, build 5782058
am: c128131a10

Change-Id: I0f91de66acc9f6f0425d3f5da6d2c8a0b8863cca
2019-08-07 10:40:16 -07:00
Sunny Goyal 64a6fb063e Merge "Revert "Use new onTaskListUpdated() callback"" into ub-launcher3-master 2019-08-07 14:49:52 +00:00
Sunny Goyal 54bbbdfa61 Revert "Use new onTaskListUpdated() callback"
This reverts commit a04997b081.

Reason for revert: Platform master has API changes, and launcher-master should still map to qpr branch

Change-Id: Ib201c71b5557715d585d322ec2a1a528e352e61c
2019-08-07 13:49:41 +00:00
Vinit Nayak 0664d9ad09 Merge "Use new onTaskListUpdated() callback" into ub-launcher3-master 2019-08-06 22:40:23 +00:00
Sunny Goyal 0af5134bc5 Moving section names to model, to avoid an unnecessary hashmap
Change-Id: I9620367e0c2203b2290a4a188411ccb9174ae130
2019-08-06 15:21:36 -07:00
Sunny Goyal c128131a10 Merging ub-launcher3-qt-r1-dev, build 5782058
Test: Manual

Bug:132455160 P1 [Gesture Nav] Home to Overview Transition Improvement
Bug:133472746 P1 "Now playing History" widget can't be added to desired area.
Bug:135558924 P4 Pixel Launcher app crash after applying custom Style
Bug:136282913 P1 Swipe up from Assistant Fulfillment Card Jank
Bug:136591785 P2 Tune swipe up to home animation
Bug:138117089 P1 Random misses in GL comp on Pixel 3a/XL
Bug:138609751 P2 Trying to start an app before it was downloaded caused pixel launcher crash
Bug:138620399 P1 Quick switch flicker / artifacts
Bug:138646754 P4 Switching from 3-button to gesture nav - all apps disappeared
Bug:138793362 P4 With animation disabled, Launcher crashing on docking apps in split screen from overview screen.
Change-Id: I4f3b286ae79566fd53072df621be98646d0457d7
2019-08-06 12:09:08 -07:00
Pinyao Ting 5191e98a3f [automerger skipped] show dot in deep shortcuts when notification contains exactly identical set of person
am: e4061fc931 -s ours
am skip reason: change_id I975524e28168c10a186cdc24b188c161faf433cf with SHA1 49a3e699f9 is in history

Change-Id: I0703a66ae9d6e8c0cad20016082d3aee374cf7bd
2019-08-06 09:45:59 -07:00
Pinyao Ting e4061fc931 show dot in deep shortcuts when notification contains exactly identical
set of person

Bug: 132336512
Change-Id: I975524e28168c10a186cdc24b188c161faf433cf
Merged-In: I975524e28168c10a186cdc24b188c161faf433cf
2019-08-05 23:31:35 -07:00
Pinyao Ting eafd0c7a77 Merge "show dot in deep shortcuts when notification contains exactly identical set of person" into ub-launcher3-master 2019-08-06 05:56:06 +00:00
Pinyao Ting 49a3e699f9 show dot in deep shortcuts when notification contains exactly identical
set of person

Bug: 132336512
Change-Id: I975524e28168c10a186cdc24b188c161faf433cf
2019-08-05 20:41:58 -07:00
Vadim Tryshev 1c7b8267d9 Merge "Adding system health permissions to Launcher3 tests" into ub-launcher3-qt-qpr1-dev
am: aea3d051c4

Change-Id: Id5695b29f108646cf846fe74d5c2abaef055c9b7
2019-08-05 19:06:37 -07:00
Vadim Tryshev aea3d051c4 Merge "Adding system health permissions to Launcher3 tests" into ub-launcher3-qt-qpr1-dev 2019-08-06 01:41:01 +00:00
Vinit Nayak 1a4b815cd8 Merge "Add PREUPLOAD.cfg file to enable repo checkstyle hooks" into ub-launcher3-master 2019-08-06 01:34:02 +00:00
Vinit Nayak 0be5adfac9 Add PREUPLOAD.cfg file to enable repo checkstyle hooks
fixes: 65162750
Change-Id: I42dd2699d1966cf509f475a34e623ce449e87213
2019-08-06 01:31:17 +00:00
Sunny Goyal 9275c820e0 Merge "Fix DEFER_UPDATES_NEXT_DRAW flag is not unset when binging happens twice" into ub-launcher3-qt-r1-dev am: 0a9e91b6e4
am: 2c848d029c

Change-Id: I827430185fbab9433f74f402f382cb004ab744c3
2019-08-05 17:45:45 -07:00
Sunny Goyal 1217919981 Merge "Use task display id when starting split screen" into ub-launcher3-qt-r1-dev am: 6cf32a2e95
am: bafd62971a

Change-Id: I1b981e07329a0a6fc0667af58188c9ba047f068d
2019-08-05 17:39:42 -07:00
Sunny Goyal 2c848d029c Merge "Fix DEFER_UPDATES_NEXT_DRAW flag is not unset when binging happens twice" into ub-launcher3-qt-r1-dev
am: 0a9e91b6e4

Change-Id: Iad5027f7925981de0720ca960e5a8ffdd2a1463c
2019-08-05 17:39:41 -07:00
Sunny Goyal bafd62971a Merge "Use task display id when starting split screen" into ub-launcher3-qt-r1-dev
am: 6cf32a2e95

Change-Id: I7313eb81291d3fbe353882446d7da39bba355ec9
2019-08-05 17:33:42 -07:00
TreeHugger Robot 0a9e91b6e4 Merge "Fix DEFER_UPDATES_NEXT_DRAW flag is not unset when binging happens twice" into ub-launcher3-qt-r1-dev 2019-08-06 00:33:31 +00:00
vadimt 9473421755 Adding system health permissions to Launcher3 tests
Change-Id: Id4ae4731274bef243801e3a15bc87e9c3fa9e0c4
2019-08-05 17:31:53 -07:00
TreeHugger Robot 6cf32a2e95 Merge "Use task display id when starting split screen" into ub-launcher3-qt-r1-dev 2019-08-06 00:21:01 +00:00
Sunny Goyal 6b6d0a3972 Fix DEFER_UPDATES_NEXT_DRAW flag is not unset when binging happens twice
Bug: 138646754
Change-Id: I76eccdb812013299e18f197ba17ff858a01a6338
2019-08-05 17:20:10 -07:00
Vadim Tryshev 347ce4529b Merge "Adding debug tracing to catch non-dragging to workspace" into ub-launcher3-qt-qpr1-dev
am: f4a1814c3f

Change-Id: I2bb035bf176cb0fb3e16456f52153de065855740
2019-08-05 17:06:36 -07:00
Vadim Tryshev f4a1814c3f Merge "Adding debug tracing to catch non-dragging to workspace" into ub-launcher3-qt-qpr1-dev 2019-08-05 23:30:13 +00:00
James O'Leary d103d64f09 Merge "Fix inability to dismiss Assistant answer when launcher frontmost" into ub-launcher3-qt-r1-dev am: 290a9a814a
am: c714f1657b

Change-Id: I7c227379a4f429c8f73828782f64bfd89fb90eec
2019-08-05 15:26:45 -07:00
James O'Leary c714f1657b Merge "Fix inability to dismiss Assistant answer when launcher frontmost" into ub-launcher3-qt-r1-dev
am: 290a9a814a

Change-Id: I128fb662ea38a00f3a14734aae9c5c1bbb849b09
2019-08-05 15:20:46 -07:00
James O'Leary 290a9a814a Merge "Fix inability to dismiss Assistant answer when launcher frontmost" into ub-launcher3-qt-r1-dev 2019-08-05 22:06:14 +00:00
Jon Miranda 3edba34cb2 Fix launcher crash when trying to open work profile promise icon. am: 0121d466ec
am: ccf108c5f3

Change-Id: I95441f44090f04f391ad436f9177f8cceb496d15
2019-08-05 15:02:12 -07:00
Jon Miranda ccf108c5f3 Fix launcher crash when trying to open work profile promise icon.
am: 0121d466ec

Change-Id: I40272f5061cea59b846d6633cd60217a263eb454
2019-08-05 14:55:12 -07:00
Jon Miranda 0121d466ec Fix launcher crash when trying to open work profile promise icon.
Bug: 138609751
Change-Id: Ifb1c4628ce6307a19a2bb696e4771d5cd5810a90
2019-08-05 14:36:04 -07:00
vadimt f1726290d4 Adding debug tracing to catch non-dragging to workspace
Bug: 138729456
Change-Id: I28f1eaeb17a75cbc6f52b259d0226deaff42e0bb
2019-08-05 13:52:36 -07:00
Sunny Goyal 1eade2f947 Use task display id when starting split screen
Before starting split screen animation, we dismiss the task view, which
can detach the clicked view immediately, if animations are dissabled.
That will cause NPE as view.getDisplay will be null

Bug: 138793362
Change-Id: I611f6a824f756eceeed57aac5afdf38f421ff8d2
2019-08-05 11:24:43 -07:00
TreeHugger Robot 71b6d24964 Fix inability to dismiss Assistant answer when launcher frontmost
Bug: 136282913
Test: Verify Assistant answer card be dismissed from Home
Change-Id: I84d0a9bda333bc2f99161096299acfaa387ecf1e
2019-08-05 14:01:08 -04:00
android-build-team Robot c14ad6f430 Snap for 5778794 from 528647df2d to qt-qpr1-release
Change-Id: If007b3104efb2eab391752bcad62c8a7eab0ee1c
2019-08-03 23:19:34 +00:00
android-build-team Robot d4334fa71a Snap for 5778831 from fc3678b2a7 to rvc-release
Change-Id: I7fb44885232f494eef610bb1805684185129c0cf
2019-08-03 23:19:20 +00:00
android-build-team Robot 6ea2e3870b Snap for 5778854 from 8822dc0018 to qt-c2f2-release
Change-Id: Ib5a55686268aab2e6c38482349ea1a68863a00ad
2019-08-03 23:05:52 +00:00
Tracy Zhou 91e7a72217 Change RecentsAnimationListenerSet interface (Launcher)
am: bd7acf7665

Change-Id: I52b654212200962d3c2f1fe4376f2001736fcb0e
2019-08-01 21:54:14 -07:00
Tracy Zhou bd7acf7665 Change RecentsAnimationListenerSet interface (Launcher)
Bug: 138683199
Test: N/A
Change-Id: Ic53ef92fe4d5b55ff1d105a250accdf6f6c0916b
(cherry picked from commit 8e8a36f673)
2019-08-02 03:44:37 +00:00
Tracy Zhou fc3678b2a7 Merge "Change RecentsAnimationListenerSet interface (Launcher)" into qt-qpr1-dev am: 528647df2d
am: 1ea84b7974

Change-Id: I591a3b2d679b0abefb0ea788036aa603ff980741
2019-08-01 19:41:59 -07:00
Tracy Zhou 1ea84b7974 Merge "Change RecentsAnimationListenerSet interface (Launcher)" into qt-qpr1-dev
am: 528647df2d

Change-Id: I0a4818462a9ddc75a440e3a35ed13081bf83ed7d
2019-08-01 19:14:06 -07:00
Tracy Zhou 528647df2d Merge "Change RecentsAnimationListenerSet interface (Launcher)" into qt-qpr1-dev 2019-08-02 01:44:53 +00:00