Commit Graph

33301 Commits

Author SHA1 Message Date
Amos Bianchi 20cc7a3b5b Update proguard flags.
Fully R8 optimized variants may crash with:
java.lang.AbstractMethodError exception.

Test: build, manual test on device.
Change-Id: I18a7b011ddd3536e3d33b991954a52e5fc5c7d56
2020-02-24 15:35:49 -08:00
Hongwei Wang a1a91b0c50 Indicate PiP animation type from Launcher to SysUI
Also, need callback from SysUI to Launcher once the pip animation is
started to keep back compatibility.

Bug: 146594635
Test: manually
Merged-In: I617a17fd5f6049d9f1d49f9f834623a2bb49f6ca
Change-Id: I617a17fd5f6049d9f1d49f9f834623a2bb49f6ca
2020-02-24 21:16:40 +00:00
Peter Kalauskas 7cd0e178af Toggle loading state based on config_lowResTaskSnapshotScale
Change high res loading state implementation to toggle on/off based on
config_lowResTaskSnapshotScale!=0 instead of ro.config.low_ram=true

Test: TaskSnapshotCacheTest
Test: TaskSnapshotControllerTest
Test: TaskSnapshotPersisterLoaderTest
Test: TaskSnapshotSurfaceTest
Bug: 148099851
Change-Id: I316e553a8a13fe38f1224c38f7aa717a0f628f57
2020-02-24 21:03:45 +00:00
Peter Kalauskas ae11790d31 Add config to enable snapshot preloading
Enable preloading if config_enableTaskSnapshotPreloading instead of
assuming it should be off for all low ram devices. This allows it to be
configured via an overlay.

Test: TaskSnapshotCacheTest
Test: TaskSnapshotControllerTest
Test: TaskSnapshotPersisterLoaderTest
Test: TaskSnapshotSurfaceTest
Bug: 148099851
Change-Id: I9e3320dcff5b710e110cc7199c41c5a004991592
2020-02-24 21:03:26 +00:00
Tracy Zhou 4365734017 Merge "Render user's actual workspace in ThemePicker preview (Part 3)" into ub-launcher3-master 2020-02-24 20:01:58 +00:00
Andy Wickham 6b7fbd22dd Merge "Makes all ArrowPopups AccessibilityTargets." into ub-launcher3-master 2020-02-24 18:49:12 +00:00
Sunny Goyal d2c56525bb Merge "Using LeastSquaresVelocityTrackerStrategy for calculating velocity when detecting motion pause events. This is the same logic used by the platform implementation VelocityTracker" into ub-launcher3-master 2020-02-24 18:30:13 +00:00
TreeHugger Robot 7fa947cb31 Merge "Fix NPE on app launch log" into ub-launcher3-master 2020-02-24 18:24:22 +00:00
Samuel Fufa 5a93eb3baf Fix NPE on app launch log
Bug: 149969889
Change-Id: I60fd283ac082fab1ebf6ea90568e054525c414cc
2020-02-21 18:52:30 -08:00
Sreyas Rangaraju bc50563915 Merge "OverviewActions: Creating parent view to house RecentsView and Overview Actions." into ub-launcher3-master 2020-02-22 01:11:47 +00:00
TreeHugger Robot 218f5276a3 Merge "Fixes incorrect FromFolderLabelState in clearcut log when updating folder label." into ub-launcher3-master 2020-02-22 00:55:55 +00:00
Tony Wickham 3310b76a27 Merge "Remove mSourceWindowClipInsetsForLiveTile" into ub-launcher3-master 2020-02-22 00:34:09 +00:00
thiruram 15d79a9b85 Fixes incorrect FromFolderLabelState in clearcut log when updating folder label.
Bug description: When folder label is updated from a suggested label to a custom label,
EditFolderLabelEvent log expected to have FromFolderLabelState = FROM_SUGGESTED.
Currently FromFolderLabelState is logged as FROM_CUSTOM in such scenarios.

Root cause: Folder label state is decided based on whether IME has entered into compose mode while editing.
This works fine for initial folder creation and also updated to non-empty label(to both custom or suggested).
But when folder is edited from suggested to empty label, its internal state changes from SUGGESTED to CUSTOM as expected.
Later when empty label is updated to suggested again, its internal state remains custom forever.

Fix: Instead of setting folder's internal state based on IME's compose mode, comparing actual folder label with suggestions
and set it to SUGGESTED if any suggestion matches else CUSTOM.

Change-Id: Ieea572ee93fd5567e3128c9bbcea3b670f0f01d9
2020-02-21 16:24:21 -08:00
Sreyas a241df66df OverviewActions: Creating parent view to house RecentsView and Overview Actions.
Creating RecentsViewHolder to be contain LauncherRecentsView in OverviewPanel so Overview Actions View can be created only once.

Change-Id: I111f88903d2ff80275cc2e07b761577260073c17
2020-02-21 16:14:51 -08:00
Tracy Zhou be13d109b7 Render user's actual workspace in ThemePicker preview (Part 3)
go/grid-migration-preview

With this change, we can see actual grid migration in wallpaper preview.

The approach here: we use a tmp table (favorites_preview) here specifically for this preview (to write off the migration results), and load from this tmp table workspace items if migration is necessary and successful. Otherwise, we load from the current workspace.

UPDATED: this change should be completely compatible with the new multi-db grid migration algorithm. Here is why
1. In LauncherPreviewRender#renderScreenShot, I added a check to decide which grid migration preview method we should call. Once v2 preview method is implemented, it should be integrated with other parts of this change perfectly (the reason will be mentioned below).
2. While we have multiple DBs, mOpenHelper in LauncherProvider always points to the current db we are using. Queries using CONTENT_URI is routed to whatever DB mOpenHelper points to, so it works perfectly to directly operate on CONTENT_URI even when we use multi-db underneath the hood.
3. With 1 and 2 mentioned, I believe in order for this preview change to support multi-db, we only need to implement the V2 grid migration algorithm. Because most of what we are doing in this change is wrapped in GridSizeMigrationTask, it's perfectly safeguarded.

Bug: 144052839
Change-Id: Ie6d6048d77326f96546c8a180a7cd8f15b47e4c4
2020-02-21 15:49:00 -08:00
Peter Kalauskas 5bb63c916e Toggle loading state based on config_lowResTaskSnapshotScale
Change high res loading state implementation to toggle on/off based on
config_lowResTaskSnapshotScale!=0 instead of ro.config.low_ram=true

Test: TaskSnapshotCacheTest
Test: TaskSnapshotControllerTest
Test: TaskSnapshotPersisterLoaderTest
Test: TaskSnapshotSurfaceTest
Bug: 148099851
Change-Id: I316e553a8a13fe38f1224c38f7aa717a0f628f57
2020-02-21 23:36:58 +00:00
Hyunyoung Song 6b029c30b1 Merge "Convert LauncherPluginLib to soong" into ub-launcher3-master 2020-02-21 23:36:29 +00:00
Peter Kalauskas 03c8f296cd Add config to enable snapshot preloading
Enable preloading if config_enableTaskSnapshotPreloading instead of
assuming it should be off for all low ram devices. This allows it to be
configured via an overlay.

Test: TaskSnapshotCacheTest
Test: TaskSnapshotControllerTest
Test: TaskSnapshotPersisterLoaderTest
Test: TaskSnapshotSurfaceTest
Bug: 148099851
Change-Id: I9e3320dcff5b710e110cc7199c41c5a004991592
2020-02-21 23:35:37 +00:00
Sunny Goyal a173193afa Using LeastSquaresVelocityTrackerStrategy for calculating velocity
when detecting motion pause events. This is the same logic used by
the platform implementation VelocityTracker

Bug: 139750033
Change-Id: I87aabd46e58a5caa1395be3a63fd38d0ee75e355
2020-02-21 15:28:06 -08:00
Hyunyoung Song 8605be3162 Convert LauncherPluginLib to soong
Bug: 148896221
Change-Id: I0c09ba2994cf2a8e230aebc51eb52a8acadf8686
2020-02-21 14:56:40 -08:00
Hongwei Wang a93c2dcd56 Indicate PiP animation type from Launcher to SysUI
Also, need callback from SysUI to Launcher once the pip animation is
started to keep back compatibility.

Bug: 146594635
Test: manually
Change-Id: I617a17fd5f6049d9f1d49f9f834623a2bb49f6ca
2020-02-21 14:04:16 -08:00
TreeHugger Robot 9779405023 Merge "[Overview Actions] Add ControlType for overview action buttons." into ub-launcher3-master 2020-02-21 20:36:35 +00:00
Hyunyoung Song 621c1a8be7 Merge "Update the suggestFolderName when items are added and deleted from folders" into ub-launcher3-master 2020-02-21 20:08:20 +00:00
TreeHugger Robot b47a08ad1e Merge "Fixes NPE when creating folder with null suggestedFolderNames." into ub-launcher3-master 2020-02-21 20:05:38 +00:00
thiruram 888b516a22 Fixes NPE when creating folder with null suggestedFolderNames.
Bug: 149993849

Change-Id: Ia2758b76aef1812dab225c8a95e7141fcdeefab4
2020-02-21 11:05:37 -08:00
Hyunyoung Song 6d3e5465e2 Update the suggestFolderName when items are added and deleted from folders
Bug: 149935239
Bug: 149967272
Bug: 148900990

Change-Id: I0ed27236ad22579a1f3dcfd35a32252c5b1f6691
2020-02-21 11:00:48 -08:00
TreeHugger Robot fb5d542f51 Merge "Increase FileLog days" into ub-launcher3-master 2020-02-21 17:33:27 +00:00
android-build-team Robot d7d79f0048 Snap for 6224475 from 98e484548c to rvc-release
Change-Id: I9a0f573059b3a664c2d90b1cad26343959f68998
2020-02-21 03:11:27 +00:00
Samuel Fufa 46b4f58161 Increase FileLog days
Bug: 142753423
Change-Id: I43ccfe540cb0899a4a4ab6722b6670e830457f60
2020-02-20 16:45:57 -08:00
Vadim Tryshev 1562d104b8 Merge "Updating logcat reading logic" into ub-launcher3-master 2020-02-21 00:27:46 +00:00
Tony Wickham f1030cf564 Merge changes Ie48f4b66,Ia48f4453 into ub-launcher3-master
* changes:
  Always update clip rect before applying surface params
  Clean up AppWindowAnimationHelper and TransformParams
2020-02-20 22:53:10 +00:00
Tony Wickham a754374c30 Remove mSourceWindowClipInsetsForLiveTile
It seems that the only time it is used, it is the same as
mSourceWindowClipInsets anyway.

Bug: 149870691
Change-Id: I3b1a5a47a0d49cdd6eb8a3271ca24da6c17109cb
2020-02-20 14:08:07 -08:00
Tony Wickham d1d342b1c7 Always update clip rect before applying surface params
Previously, we were only updating the clip rect when params.currentRect
== null, meaning the clip would be stale once the caller started
providing its own rect (e.g. when swiping to home).

Also fix some visual jumps when swiping home, all caused by running the
transform progress from 0 to 1 instead of starting at whatever the
progress was before ending the gesture, e.g.:
- When swiping to home without animating into an icon, the corner radius
  was set back to the window corner radius.
- Before this change, the clip didn't update throughout the animation,
  making the window slightly bigger than the floating icon view; after
  this change, the clip jumped to show the insets again before clipping
  back down during the home animation.

Bug: 149870691
Change-Id: Ie48f4b665a5bf3cbef76bdf7f043febe99fb84a0
2020-02-20 14:07:09 -08:00
Tony Wickham badab61ace Clean up AppWindowAnimationHelper and TransformParams
AppWindowAnimationHelper and TransformParams were being very tightly
intertwined, to the point that you really had to understand subtle
nuances of both in order to get a desired behavior. This makes making
changes really difficult, because there are lots of "traps" to know
about and navigate. To help alleviate this burden, cleaned up some of
these traps and give AWAH and TP distinct roles:
- A caller who needs to animate an app window needs both AWAH and TP.
  TP defines specific parameters of how the app window should be
  controlled, and AWAH simply reads from TP in order to provide the
  desired behavior.
- Only the caller should write to TP; AWAH should no longer change
  anything in a TP that is passed to it. For instance, instead of
  repurposing TP.currentRect, AWAH now has its own mCurrentRect to
  update based on passed parameters.
- TP is a very basic class that just holds various values that callers
  can set one at a time. The order should not matter (setting one value
  will never set another one), and defaults make sense.
- Commented the setter methods in TP so developers shouldn't have to
  follow the code to see how they are used.

Bug: 149870691
Change-Id: Ia48f4453c29549271a3fc6538128a1a77439e015
2020-02-20 14:06:58 -08:00
vadimt 2f41808e9b Updating logcat reading logic
Start a thread to read logcat synchronusly instead
of back-tracking at the end of the test

Also:
* Reusing the same logcat process for all checks. This eliminates
reading the log from its start for every gesture. We don’t kill that
process at the end, and don’t stop the thread. I’ve verified that
“am instrument” doesn’t hang, and the logcat process gets automatically
killed after the test process exits.
* Not using mStarted latch, as there is no need to wait until the reader
reaches the start mark.

Bug: 149422395
Change-Id: Ide4ed19ad8d099c41918f38c2b073b8b2e143b69
2020-02-20 22:02:52 +00:00
Andy Wickham 27d3c595cf Makes all ArrowPopups AccessibilityTargets.
This currently includes the menu that pops up when
long pressing an app icon in Launcher or Search, or
long pressing Smartspace. Previously, only the menu
for Launcher apps grabbed accessibility focus after
the open animation completed, and now all three do.

Fixes: 145253300
Change-Id: I147b45d38a04ab9a55eee9b5bd5551b4c7185fcf
2020-02-20 20:36:16 +00:00
Samuel Fufa aeaad97eb7 Increase timeout for WorkTabTest.toggleWorks test
Bug: 149927292
Change-Id: I6dcd0bfa2fe584be9e46f653992f9c748e795614
2020-02-20 11:22:49 -08:00
Winson Chung d446f98457 Merge "Adding new tracing call from SysUI" into ub-launcher3-master 2020-02-20 06:37:46 +00:00
Tracy Zhou 7be160170d Merge "Render user's actual workspace in ThemePicker preview (Part 5)" into ub-launcher3-master 2020-02-20 05:53:45 +00:00
Winson Chung f3b7246bf2 Adding new tracing call from SysUI
Bug: 144854916
Test: This change is only to ensure the changes build
Change-Id: I62b247b45454861328b6062ed571c854a374aa34
2020-02-20 04:52:07 +00:00
android-build-team Robot 69c7ae5d61 Snap for 6220271 from 94c1178e47 to rvc-release
Change-Id: I09f6c142a932968afd1ea1af3bacad6a69542e3e
2020-02-20 03:22:02 +00:00
TreeHugger Robot 91f97cb2d1 Merge "Increase timeout for flaky work test" into ub-launcher3-master 2020-02-20 01:49:30 +00:00
Becky Qiu 4e3eaa5a71 [Overview Actions] Add ControlType for overview action buttons.
Design: go/logging_for_overview_actions

Test:local, logging result: https://paste.googleplex.com/6489148393259008

Bug:139828243

Change-Id: I61fa66f8ec6edae43f6242599f8d4ea8e28d735d
2020-02-19 17:45:06 -08:00
TreeHugger Robot 6e82910a45 Merge "Give current TaskView accessibility focus" into ub-launcher3-master 2020-02-20 01:16:42 +00:00
Samuel Fufa d1c0779726 Increase timeout for flaky work test
Bug:149867607
Change-Id: Ic746a4857a47fc29372d19419ddfa6eaebd06f87
2020-02-19 17:08:26 -08:00
Tracy Zhou 10a285dc24 Render user's actual workspace in ThemePicker preview (Part 5)
This change takes care of rendering widgets using widget provider's layout info.

Test: manual
Bug: 144052839

Change-Id: I7002d8bf653513cdd317736d550a47f61f0ee474
2020-02-19 16:46:25 -08:00
Andy Wickham 9fb7d28b63 Removes exported="true" for RecentsActivity.
Change-Id: Iea9ad04886c3221cefa709c14b6501b2af83af06
2020-02-20 00:07:06 +00:00
Andy Wickham 2eac20e378 Merge "Renames BackGestureTutorialActivity to GestureSandboxActivity." into ub-launcher3-master 2020-02-19 23:51:20 +00:00
TreeHugger Robot b3c991f7d3 Merge "null check in showLableSuggestion()." into ub-launcher3-master 2020-02-19 21:45:38 +00:00
Andy Wickham 63b7f36338 Renames BackGestureTutorialActivity to GestureSandboxActivity.
Bug: 148542211
Change-Id: Iaac537380b02f1c52f967748c30fe49ac36bb91e
2020-02-19 21:12:11 +00:00