Commit Graph

6193 Commits

Author SHA1 Message Date
Sunny Goyal 01e33cf03f Merge "Making some fields accessible to subclasses" into ub-launcher3-qt-dev am: 3831fc99dc
am: bc0b145ef5

Change-Id: I18ebe0d63b0c07bf9938dbc13c1fec9f494f9401
2019-05-24 15:51:31 -07:00
Sunny Goyal de533a182b Merge "Removing prediciton loading state" into ub-launcher3-qt-dev am: c62699fd63
am: 101544f646

Change-Id: I4095c6d99e16dc646a7e83d23b7a800fe1d47231
2019-05-24 15:30:19 -07:00
TreeHugger Robot 3831fc99dc Merge "Making some fields accessible to subclasses" into ub-launcher3-qt-dev 2019-05-24 22:28:34 +00:00
Sunny Goyal c62699fd63 Merge "Removing prediciton loading state" into ub-launcher3-qt-dev 2019-05-24 22:01:09 +00:00
vadimt 292d20caae Merge "Adding myself as an owner of test directories" into ub-launcher3-qt-dev am: 1625bf74dd
am: 1bbb70da60

Change-Id: I7cf6ae38e7ab0378687e8fa3c4ff280f915a2aa5
2019-05-24 12:01:48 -07:00
TreeHugger Robot 1625bf74dd Merge "Adding myself as an owner of test directories" into ub-launcher3-qt-dev 2019-05-24 18:06:28 +00:00
vadimt addaab60fa Adding myself as an owner of test directories
Change-Id: I3d6649a2b804715cebb80b8cac881ef227738088
2019-05-24 10:54:12 -07:00
Sunny Goyal 823652477e Merge "Remove unnecessary dispatchInsets routing" into ub-launcher3-qt-dev am: f54839bf35
am: 1508a5684b

Change-Id: Ie0075e4b34146449c3d64cd2fa6919cbe286a574
2019-05-23 22:07:16 -07:00
Sunny Goyal a5e3a70ed8 Merge "Moving TestInformationProvider to Launcher3 so that it can be used for testing Launcher3 without quickstep" into ub-launcher3-qt-dev am: 4c96dd2cd0
am: 7cb09bb7d1

Change-Id: I7a70c07e7da994dd9bfaad699001a98914bcc10e
2019-05-23 22:06:42 -07:00
Tony Wickham 2817f50f52 Merge "Set scroller to new max duration if snapping too slowly" into ub-launcher3-qt-dev am: a80180bfcb
am: 163100cc27

Change-Id: I8b6f0b5c9c0f8eea560f427ad217fdd1601ad396
2019-05-23 22:05:44 -07:00
vadimt 48940a6355 Merge "Quick patch for PredictionUiStateManager.applyState interrupting allapps" into ub-launcher3-qt-dev am: 571e51161c
am: 167b7da7f5

Change-Id: If170cf6bb7cb19621b04597ad91c82b89f08d599
2019-05-23 22:04:12 -07:00
TreeHugger Robot f54839bf35 Merge "Remove unnecessary dispatchInsets routing" into ub-launcher3-qt-dev 2019-05-24 00:31:18 +00:00
Sunny Goyal 4c96dd2cd0 Merge "Moving TestInformationProvider to Launcher3 so that it can be used for testing Launcher3 without quickstep" into ub-launcher3-qt-dev 2019-05-24 00:12:14 +00:00
Sunny Goyal 9820c05f2b Removing prediciton loading state
Also fixing test flakyness due to delayed prediction loading

Bug: 132993129
Bug: 131854153
Change-Id: I85f7afff0e3ee0ca9e40e92e91681f797a0bc2de
2019-05-23 17:01:19 -07:00
TreeHugger Robot a80180bfcb Merge "Set scroller to new max duration if snapping too slowly" into ub-launcher3-qt-dev 2019-05-23 21:53:06 +00:00
Tony Wickham 9b832295c3 Set scroller to new max duration if snapping too slowly
Change-Id: I87bfc8f767f7ae9cbe838c2a9ba229bec179f526
2019-05-23 14:42:24 -07:00
Winson Chung dd71ca0437 Support individual lock task features
- If screen pinning is enabled, disable gestures and wrap with input
  consumer to break out of screen pinning (existing logic)
- If Home & Overview are both disabled, disable gestures completely
- If only Home is disabled, then always launch the user into fallback
  recents (to simplify logic around breaking out of overview into Home)
- If only Overview is disabled, then prevent swiping from going into
  overview or from triggering overview from home
- Switch to using screen pinning flag check instead of binder call

Bug: 133113732
Bug: 131698989

Change-Id: Ie6f447520d4cc3fa1eaaf8427ee014851688bf37
2019-05-23 14:33:05 -07:00
Sunny Goyal 68ff2d91cf Making some fields accessible to subclasses
Bug: 132975416
Change-Id: Icc7043d8299c88fcf505068f8cabd4705d19010d
2019-05-23 14:16:06 -07:00
Sunny Goyal ab3963ddcf Moving TestInformationProvider to Launcher3 so that it can be used for
testing Launcher3 without quickstep

Also keeping the provider as disabled until needed

Change-Id: Ib5f459e02ae551724b390f3b74f43d601568d749
2019-05-23 14:02:33 -07:00
TreeHugger Robot 571e51161c Merge "Quick patch for PredictionUiStateManager.applyState interrupting allapps" into ub-launcher3-qt-dev 2019-05-23 20:53:27 +00:00
Sunny Goyal 30b3848a79 Merge "Reading navigation_bar_gesture_height for bottom swipe region" into ub-launcher3-qt-dev am: 1b9afd4f73
am: 475e342637

Change-Id: I3e45f81dd91da370f153a4c5eeb02a604de4edec
2019-05-23 13:07:50 -07:00
Vadim Tryshev 27587a1d26 Merge "Reducing test wait time from 60 sec to 10 sec" into ub-launcher3-qt-dev am: 789fe60dc4
am: a46e847945

Change-Id: I4ea2798cee12cb5e6250b01a135e1327ef3d1acc
2019-05-23 13:06:57 -07:00
vadimt 0c1ed7cb4c Quick patch for PredictionUiStateManager.applyState interrupting allapps
Constructor of PredictionUiStateManager posts an action in 5 sec, which
may interfere with the process of opening all apps.

Waiting until the posted action happens.

Hopefully this will fix massive flakes.

Bug: 131854153
Change-Id: I6544eae1a3b063c03e78185826c05a76add1f71b
2019-05-23 12:36:32 -07:00
TreeHugger Robot 1b9afd4f73 Merge "Reading navigation_bar_gesture_height for bottom swipe region" into ub-launcher3-qt-dev 2019-05-23 17:53:24 +00:00
Sunny Goyal f5d02b069a Reading navigation_bar_gesture_height for bottom swipe region
Bug: 132917885
Change-Id: I39d266fc34a69c3ba50246b5a66350942a85becb
2019-05-23 10:42:24 -07:00
Vadim Tryshev 789fe60dc4 Merge "Reducing test wait time from 60 sec to 10 sec" into ub-launcher3-qt-dev 2019-05-23 17:33:53 +00:00
vadimt 40bbfbed0f Reducing test wait time from 60 sec to 10 sec
Bug: 112282235
Bug: 121279417
Change-Id: Id88e782145b5fdae42354f6fce830aa05b78857a
2019-05-23 10:23:41 -07:00
Tony Wickham 2fd9346e5f Merge "Capture screenshot when animating to home" into ub-launcher3-qt-dev am: eb64fd3946
am: d949b9fd04

Change-Id: I74975e9216abb0a497b4ac466756337ca3747cc0
2019-05-22 21:11:39 -07:00
Jonathan Miranda f562177d66 Merge "Use spring to update window/icon scale for swipe up animation." into ub-launcher3-qt-dev am: 16dfcb9588
am: e9adb8ab46

Change-Id: I9c6e08b617a06fe6b6001afcec8c528cf6223b7d
2019-05-22 21:10:45 -07:00
Tony Wickham eb64fd3946 Merge "Capture screenshot when animating to home" into ub-launcher3-qt-dev 2019-05-23 01:56:08 +00:00
Jonathan Miranda 16dfcb9588 Merge "Use spring to update window/icon scale for swipe up animation." into ub-launcher3-qt-dev 2019-05-23 01:49:23 +00:00
Sunny Goyal cf7e6c4a32 Merging ub-launcher3-qt-dev, build 5595491
Test: Manual

Bug:122345781 P1 Inflation happens and a binder call during swipe up gesture, that may cause jank
Bug:123900446 P1 App to home animation should zoom into the app icon
Bug:124510042 P1 [Gesture Nav] Home animation polish
Bug:126744445 P1 Add chips support for Overview UI library
Bug:127783075 P1 When swiping up to recents, sometimes velocity is really wrong
Bug:129036789 P2 [a11y] Talkback doesn't indicate App paused in Home/Apps list.
Bug:131839392 P2 Ensure Go Launcher follows theming standards
Bug:132283018 P1 Shelf Jump
Bug:132356358 P1 Fix invocation animation for fling
Bug:132588097 P1 Launcher folder shadow and image flickers on going home
Bug:132716177 P4 Swiping right at home shows alphabet index
Bug:132900132 P1 Apparently, tests start running while provisioning is still in progress
Bug:132917885 P1 Reduce swipe-up gesture region height in landscape
Bug:133009122 P2 Rare flake: dragged launchable to workspace, but the current state is not WORKSPACE; Can't find a launcher object; selector: BySelector [RES='\Qcom.google.android.apps.nexuslauncher:id/apps_view\E']
Bug:133010447 P2 Blueline: flake: test manages to click search box instead of starting an app
Bug:133010773 P2 qt-dev / crosshatch: flake: java.lang.AssertionError: http://go/tapl : want to switch from background to overview; Swipe failed to receive an event for the swipe end: 720, 2959, 720, 2050
Bug:133011252 P2 flake: Launching an app didn't open a new window: Calendar
Bug:133265591 P1 Blocked touches in thin region over home
Change-Id: Iac4013556a2a49418d1634762698ea59bbf95a75
2019-05-22 17:24:58 -07:00
Sunny Goyal 1c817f563c Merge "Adding a utility class to cache views at an activity level" into ub-launcher3-qt-dev am: a338daa261
am: ec140680dd

Change-Id: Ia2ad9d28dd49c9814031dcaf6dbaf6b814c7b810
2019-05-22 16:46:48 -07:00
TreeHugger Robot a338daa261 Merge "Adding a utility class to cache views at an activity level" into ub-launcher3-qt-dev 2019-05-22 23:35:03 +00:00
vadimt 4289b819ae Enable debug tracing for a lab-only non-starting app from all apps am: 3ab80bb734
am: c3b0cf2868

Change-Id: I6f305f2aee3cee6b2b4ea7895d471b7b07b64451
2019-05-22 16:13:32 -07:00
Tony Wickham aa8b2d86fc Capture screenshot when animating to home
This is to ensure the task thumbnail is captured in the correct
orientation, rather than waiting until after the task pauses
which might be after the device rotates to portrait.

Also update the state to wait until screenshot is captured
before finishing the transition to home.

Test: testStressPressHome
Test: Swipe up from a forced landscape app, enter overview;
      ensure task view thumbnail is shown correctly

Bug: 132687470
Change-Id: I5cd5f4b2a413628a8bdcb456e2d132c1c2da5258
2019-05-22 15:44:04 -07:00
Tony Wickham f46873b52c Merge "Fix some issues with shelf jumping/duration" into ub-launcher3-qt-dev am: 9e26fccacc
am: 136cbc54bb

Change-Id: I002029f2d31bf0c921ddbcc807e294f44d982c9d
2019-05-22 15:07:15 -07:00
Sunny Goyal 5686333117 Adding a utility class to cache views at an activity level
Bug: 122345781
Change-Id: I9a939e0b19c06c1089c1ceb515f8b97fb5dbb49e
2019-05-22 14:23:12 -07:00
vadimt 3ab80bb734 Enable debug tracing for a lab-only non-starting app from all apps
Bug: 132900132
Change-Id: I9c5bb51e49f865ea1e1d3d2209a8dfb149f66e87
2019-05-22 12:58:35 -07:00
Tony Wickham 9e26fccacc Merge "Fix some issues with shelf jumping/duration" into ub-launcher3-qt-dev 2019-05-22 19:21:37 +00:00
Adam Cohen b486c131fe Merge "Fix issue where Assistant could be invoked at the same time as all apps" into ub-launcher3-qt-dev am: 47f21e8a08
am: c598c4dfe9

Change-Id: I6448665bd6dd75a7dd0132d491b3a0445dcdc6d5
2019-05-21 23:22:26 -07:00
vadimt 845a7f4683 Merge "Adding tracing for a lab-only flake" into ub-launcher3-qt-dev am: 0ef504aa71
am: 13c6c96234

Change-Id: I647695bb7c815509f58482aa8596217d30e22082
2019-05-21 23:21:56 -07:00
Adam Cohen 47f21e8a08 Merge "Fix issue where Assistant could be invoked at the same time as all apps" into ub-launcher3-qt-dev 2019-05-22 03:48:36 +00:00
Tony e246dff69f Fix some issues with shelf jumping/duration
Don't use OvershootParams for 0 button mode, since that interpolator
assumes the shelf is moving in conjunction with recents/app window.
Instead, use OVERSHOOT_1_2 like we do when not flinging.

Also bound the duration when entering recents, since scroller
duration could be 750ms if we are snapping to the current page.
Now we cap at MAX_SWIPE_DURATION (350ms). This case is most likely
to be hit when ending a slow swipe near the final recents scale,
since in that case duration is close to 0 and the scroller duration
is taken instead.

Test:
- Artificially always detect a pause, fling up in 0 button mode;
  ensure shelf doesn't jump
- Either with the above artifical change in 0 button, or 2 button
  mode, end a swipe to recents near its final scale with a slight
  scroll to the right; ensure duration is 350 instead of 750

Bug: 132283018
Bug: 127783075
Change-Id: I8d5fbd0b30af21b9587fba47d141ba90b3b6e778
2019-05-21 20:27:55 -07:00
TreeHugger Robot 0ef504aa71 Merge "Adding tracing for a lab-only flake" into ub-launcher3-qt-dev 2019-05-22 03:12:56 +00:00
vadimt e17d1feb79 Adding tracing for a lab-only flake
We had a resolved case in the past where an app's context menu didn't
open on a long click (thanks to app updates), now the menu opens, but
the drag gesture doesn't drag the icon.

Bug: 133009122
Change-Id: I45d104a92fab6556ecd937aef76f0a8147e67f56
2019-05-21 17:19:23 -07:00
Miranda Kephart 8d70fab0c1 Merge "Pass in fling velocity for gesture progress" into ub-launcher3-qt-dev am: 49e5d8227b
am: 40b95f105b

Change-Id: I74d4ca609b7e42ec1982a2642eae006dd950c684
2019-05-21 16:36:57 -07:00
Sunny Goyal 55958e0331 Merge "Using squared hypot to optimize some comparisions" into ub-launcher3-qt-dev am: 32ba3c1125
am: 4c801fdc2b

Change-Id: I23aab3bee6469692d7c056cf6465fdf429dc2ead
2019-05-21 16:36:26 -07:00
Sunny Goyal 2524b82369 Remove unnecessary dispatchInsets routing
Insets are dispatched to all views. We never consume the insets and
let each view decide what to do with it.
Also fixing scrim in all-apps when in full-gesture navigation

Change-Id: Ib1c6bef5b32aac0c6ea03078b5138d2d0408c6d8
2019-05-21 15:58:44 -07:00
Adam Cohen 8f7d2b0dfd Fix issue where Assistant could be invoked at the same time as all apps
issue 132366412

-> First, we shouldn't accept flings when the delegate has intercepted. This prevents any situation
   where both are triggered.

-> Modified the slop to be the standard 8dp. This acts as a standalone fix because
   it means that there are no situations where we cross all apps slop before assistant slop.
   ie. in a purely vertical gesture from the corner, without this change, it's possible to trigger
   all apps instead of Assistant.

Change-Id: I39e3d8a525e165024399d9802d4cc1d7ae329ee6
2019-05-21 15:52:34 -07:00