Commit Graph

6193 Commits

Author SHA1 Message Date
Andy Wickham d2731957ea Updates Assistant gesture regions when no longer tracking multiple.
This should prevent states where Assistant triggers from
the vertical-center of the screen in portrait (see bug).

Also fleshes out OrientationTouchTransformerTests and
adds some new ones that fail without this change:
 - enableMultipleRegions_assistantTriggersInMostRecent
 - enableMultipleRegions_assistantTriggersInCurrentOrientationAfterDisable

Fixes: 158686674
Change-Id: I6d045a485f62e4010e9e3d00805a50fdd953a2fc
(cherry picked from commit 4b531b972d)
2020-06-24 22:32:14 +00:00
Andy Wickham fce6be550b Merge "Updates Assistant gesture regions when no longer tracking multiple." into ub-launcher3-rvc-dev 2020-06-24 22:29:45 +00:00
Andy Wickham 4b531b972d Updates Assistant gesture regions when no longer tracking multiple.
This should prevent states where Assistant triggers from
the vertical-center of the screen in portrait (see bug).

Also fleshes out OrientationTouchTransformerTests and
adds some new ones that fail without this change:
 - enableMultipleRegions_assistantTriggersInMostRecent
 - enableMultipleRegions_assistantTriggersInCurrentOrientationAfterDisable

Fixes: 158686674
Change-Id: I6d045a485f62e4010e9e3d00805a50fdd953a2fc
2020-06-24 21:23:35 +00:00
Tony Wickham c6a56ef7a2 Pass isLikelyToStartNewTask to onGestureStarted()
This ensures we immediately setRecentsAttachedToAppWindow(). As
mentioned in the bug, there was an edge case where we would animate
the attached state if the first move event passed the touch slop,
causing the adjacent task view to lag behind during the gesture.

Fixes: 159742520
Change-Id: Ie47bb84fdd3dbd69e3b74ca504d487fb9aedb551
2020-06-24 11:59:10 -07:00
TreeHugger Robot bd053698af Merge "Fixing NPE befre ActionsView first initialized." into rvc-dev am: ca493d1426 am: 3af603f240 am: 39d753dfff am: ebce67c523
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11978215

Change-Id: Ieeca4b86744eedcfc400b31884839c271a77fd8e
2020-06-24 07:50:35 +00:00
TreeHugger Robot ca493d1426 Merge "Fixing NPE befre ActionsView first initialized." into rvc-dev 2020-06-24 06:52:16 +00:00
TreeHugger Robot cb0bd36e79 Merge "Remove hotseat edu flag" into rvc-dev am: d6cd14d179 am: e65a33134d am: 373d9f4d88 am: fc8bfcf97f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11979630

Change-Id: Iac5479c15d9f5562c0af9c1f73bdfb2244bec308
2020-06-24 05:27:12 +00:00
Zak Cohen b9c83bb854 Merge "Fixing TaskMenu positioning." into rvc-dev am: b2b0d4d478 am: c588af043c am: c943b2ed54 am: 202319be61
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11978354

Change-Id: Iec16e12df3fd8ac0f32b96f353cc419adaa03222
2020-06-24 04:53:12 +00:00
TreeHugger Robot d6cd14d179 Merge "Remove hotseat edu flag" into rvc-dev 2020-06-24 04:43:52 +00:00
TreeHugger Robot 44035d9d17 Merge "Merging from ub-launcher3-rvc-dev @ build 6621659" into rvc-dev am: 738b1af342 am: f7897465e3 am: 808a7c1920 am: dde7797ec5
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11975976

Change-Id: Ifdd13981f0e61d248e89a1f10eec3b51369840f4
2020-06-24 04:26:33 +00:00
Sreyas 20024f4447 Fixing NPE befre ActionsView first initialized.
Bug: 159728260
Change-Id: I00e6f8fccf8057495f77873f2f0a1ab01e63ed23
(cherry picked from commit 88f1f2046c)
2020-06-24 04:11:05 +00:00
Sreyas 2bbce930cb Fixing NPE befre ActionsView first initialized.
Bug: 159728260
Change-Id: I00e6f8fccf8057495f77873f2f0a1ab01e63ed23
(cherry picked from commit 88f1f2046c)
2020-06-24 04:10:29 +00:00
Zak Cohen 950c93ad64 Merge "Fixing NPE befre ActionsView first initialized." into ub-launcher3-master 2020-06-24 04:09:53 +00:00
Zak Cohen b2b0d4d478 Merge "Fixing TaskMenu positioning." into rvc-dev 2020-06-24 03:58:19 +00:00
TreeHugger Robot 18575b5c77 Merge "Prevent premature resetting of quickswitch mode" into rvc-dev am: 1c90b51de6 am: 995cab35af am: 3d040cfadd am: 34f04fe1df
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11977176

Change-Id: Ic81575a194a8c86ea57b40752d1f3d3ba2ee0705
2020-06-24 03:45:24 +00:00
TreeHugger Robot fa8137da41 Merge "Remove hotseat edu flag" into ub-launcher3-rvc-dev am: 9f3ae7b573
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11975459

Change-Id: I9380cc36aea7e9876e09d80db57d7d62829c7314
2020-06-24 03:36:49 +00:00
TreeHugger Robot 9f3ae7b573 Merge "Remove hotseat edu flag" into ub-launcher3-rvc-dev 2020-06-24 03:23:54 +00:00
Samuel Fufa 6293af5575 Remove hotseat edu flag
Launcher should not restrict user migration to a one time event if we want users to migrate their hotseat by enabling hotseat prediction from suggestion settings.

Test: Manual
Bug: 159731272
Change-Id: I0e42dd6b6cf6374928e5b399d121d17fe8024ae1
2020-06-24 02:01:07 +00:00
TreeHugger Robot 615a9b8c3d Merge "Fixing TaskMenu positioning." into ub-launcher3-rvc-dev am: f95cf17a13
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11975970

Change-Id: I457b19e1bbc25d9716106d0df9e3bb6a6eacf455
2020-06-24 00:17:53 +00:00
Sreyas 98ef53458d Fixing TaskMenu positioning.
Bug: 159728554
Change-Id: I4a666363f092b5416edecd0731a0f448916c8def
2020-06-24 00:14:21 +00:00
TreeHugger Robot f95cf17a13 Merge "Fixing TaskMenu positioning." into ub-launcher3-rvc-dev 2020-06-24 00:03:27 +00:00
TreeHugger Robot b27413d147 Merge "Add explicit android:exported="true" declarations" into ub-launcher3-master 2020-06-23 23:41:29 +00:00
Sreyas 88f1f2046c Fixing NPE befre ActionsView first initialized.
Bug: 159728260
Change-Id: I00e6f8fccf8057495f77873f2f0a1ab01e63ed23
2020-06-23 16:31:34 -07:00
Sunny Goyal 315eb02012 Merging from ub-launcher3-rvc-dev @ build 6621659
Bug:150504032
Test: manual, presubmit on the source branch
x20/teams/android-launcher/merge/ub-launcher3-rvc-dev_rvc-dev_6621659.html

Change-Id: Id9689e3dfa641c0e004c9dc975e281358bed7ad7
2020-06-23 16:28:38 -07:00
Sreyas 7776d30609 Fixing TaskMenu positioning.
Bug: 159728554
Change-Id: I4a666363f092b5416edecd0731a0f448916c8def
2020-06-23 16:17:11 -07:00
Rajeev Kumar b6354114ba Add explicit android:exported="true" declarations
We add this for GestureSandboxActivity and
com.android.launcher3.uioverrides.QuickstepLauncher to
reinstate the behavior of go/ag/11746107 which was
incorrectly reverted in go/ag/11963698.

We also add this for HotseatEduActivity which was
newly added in go/ag/11963698.

(Cherry pick from master cadb94983b)

Bug: 159709775
Fixes: 159709775
Test: wembley-userdebug boots and has functioning Launcher
Change-Id: I17904f9ad88abc66364675426545eae423cb3175
Merged-In: I17904f9ad88abc66364675426545eae423cb3175
2020-06-23 23:04:38 +00:00
TreeHugger Robot da25b230ed Merge "Prevent premature resetting of quickswitch mode" into ub-launcher3-rvc-dev am: 359a28e934
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11931812

Change-Id: I0c139e6381b85d723997d6cf6135e12b7d64ff9f
2020-06-23 22:55:18 +00:00
Vinit Nayak d92946356e Prevent premature resetting of quickswitch mode
Previously, whenever a user returned to the same
rotation that they had started quickswitch in,
we were sending sysui the reset flag(-1) indicating
that quickstep was complete instead of sending
the rotation of the device the user was in.

This was intentional and it worked, however we now
always send the active rotation while the user
is in a quickswitch session because sysui needs
to show the fake home handle for immersive apps,
which can occur in any rotation. This state is
distinct from not being in quickswitch at all, in
which no fake handles are shown.

Fixes: 158677967

Change-Id: I910324abf781b4b30fe981139712bcb5b653c318
(cherry picked from commit f2daafcdf8)
2020-06-23 22:45:44 +00:00
TreeHugger Robot 359a28e934 Merge "Prevent premature resetting of quickswitch mode" into ub-launcher3-rvc-dev 2020-06-23 22:42:48 +00:00
TreeHugger Robot 7e47e05f40 Merge "Fix hotseat button alignment" into ub-launcher3-rvc-dev am: d0fcfe2bb7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11972637

Change-Id: I95d09bbf30ca40ecc57b334eb41203a01efd59aa
2020-06-23 22:24:53 +00:00
Vinit Nayak f2daafcdf8 Prevent premature resetting of quickswitch mode
Previously, whenever a user returned to the same
rotation that they had started quickswitch in,
we were sending sysui the reset flag(-1) indicating
that quickstep was complete instead of sending
the rotation of the device the user was in.

This was intentional and it worked, however we now
always send the active rotation while the user
is in a quickswitch session because sysui needs
to show the fake home handle for immersive apps,
which can occur in any rotation. This state is
distinct from not being in quickswitch at all, in
which no fake handles are shown.

Fixes: 158677967

Change-Id: I910324abf781b4b30fe981139712bcb5b653c318
2020-06-23 15:07:22 -07:00
Tony Wickham 333e41932b Store newGestureState before onConsumerAboutToBeSwitched clears it am: b47a99e3cc am: fa5559ff64 am: b2676f22d9 am: bf68d13368
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11972618

Change-Id: Id271c5227db2067c4db596f219d56dc37c06b305
2020-06-23 21:47:30 +00:00
TreeHugger Robot 2f987f6466 Merge "Add an exported flag in manifest" into ub-launcher3-master 2020-06-23 21:31:32 +00:00
Ashwini Oruganti aa902e859b Add an exported flag in manifest
With b/150232615, we will need an explicit value set for the exported
flag when intent filters are present, as the default behavior is
changing for future versions. This change adds the value reflecting the
previous default to the manifest.

These changes were made using an automated tool, the xml file may be
reformatted slightly creating a larger diff. The only "real" change is
the addition of "android:exported" to activities, services, and
receivers that have one or more intent-filters.

Bug: 150232615
Bug: 158198882
Test: TH
Exempt-From-Owner-Approval: mechanical refactoring
Change-Id: I083a7bcab968c881f7cdff7152a249691ffac316
2020-06-23 13:58:18 -07:00
Samuel Fufa 3c2a17b6f6 Remove hotseat edu flag
Launcher should not restrict user migration to a one time event if we want users to migrate their hotseat by enabling hotseat prediction from suggestion settings.

Test: Manual
Bug: 159731272
Change-Id: I0e42dd6b6cf6374928e5b399d121d17fe8024ae1
2020-06-23 12:53:37 -07:00
Samuel Fufa a44c09d6c9 Fix hotseat button alignment
Screenshot: https://screenshot.googleplex.com/Vr9FXe3oN2t
Bug: 159731214
Change-Id: I9e413f5d9bf0144edd413cc5995e7f1fda152f28
2020-06-23 12:46:30 -07:00
Rajeev Kumar cadb94983b Add explicit android:exported="true" declarations
We add this for GestureSandboxActivity and
com.android.launcher3.uioverrides.QuickstepLauncher to
reinstate the behavior of go/ag/11746107 which was
incorrectly reverted in go/ag/11963698.

We also add this for HotseatEduActivity which was
newly added in go/ag/11963698.

Bug: 159709775
Test: wembley-userdebug boots and has functioning Launcher
Change-Id: I17904f9ad88abc66364675426545eae423cb3175
2020-06-23 19:06:15 +00:00
Tony Wickham b47a99e3cc Store newGestureState before onConsumerAboutToBeSwitched clears it
Bug: 159659393
Change-Id: If98d54b7ca397ef56a5c6d50c0fd92f25a9494b4
(cherry picked from commit efb7e60edc)
2020-06-23 16:45:51 +00:00
Hyunyoung Song 85d90a16bc Merging from ub-launcher3-rvc-dev @ build 6617269
Bug: 150504032
Test: manual, presubmit on the source branch
https://android-launcher.teams.x20web.corp.google.com/merge/ub-launcher3-rvc-dev_rvc-dev_6617269.html

Change-Id: I7a13230553f9c42d5f67164234c33cf77efa9cf2
Merged-In: I2a168bfa8e3979ade26ab1d3cddbbae84cf79590
2020-06-23 05:11:31 +00:00
TreeHugger Robot 9c2fda3cac Merge "Log query_length & parent_container for actions on search results." into ub-launcher3-rvc-dev am: ea3edf1247
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11959991

Change-Id: I78c8c6feaf284d8e8b492f9d477e11ef731bc559
2020-06-23 02:33:12 +00:00
TreeHugger Robot ea3edf1247 Merge "Log query_length & parent_container for actions on search results." into ub-launcher3-rvc-dev 2020-06-23 02:16:44 +00:00
Hyunyoung Song 0b51b916b0 Merging from ub-launcher3-rvc-dev @ build 6617269
Bug: 150504032
Test: manual, presubmit on the source branch
https: //android-launcher.teams.x20web.corp.google.com/merge/ub-launcher3-rvc-dev_master_6617269.html
Change-Id: I2a168bfa8e3979ade26ab1d3cddbbae84cf79590
2020-06-22 18:53:39 -07:00
TreeHugger Robot 5f057a99d6 Merge "Store newGestureState before onConsumerAboutToBeSwitched clears it" into ub-launcher3-rvc-dev am: 7551b6191f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11963700

Change-Id: If316db050aa0794fb43b892b424598c1ff4e7bbc
2020-06-23 01:50:05 +00:00
TreeHugger Robot 7551b6191f Merge "Store newGestureState before onConsumerAboutToBeSwitched clears it" into ub-launcher3-rvc-dev 2020-06-23 01:33:55 +00:00
thiruram dbd61d4026 Log query_length & parent_container for actions on search results.
Bug: 154717227
Change-Id: I8e7d725014f60a2fd9a7fe13fce705acbc7623ad
2020-06-22 18:14:12 -07:00
Tony Wickham efb7e60edc Store newGestureState before onConsumerAboutToBeSwitched clears it
Bug: 159659393
Change-Id: If98d54b7ca397ef56a5c6d50c0fd92f25a9494b4
2020-06-22 17:37:07 -07:00
Thiru Ramasamy 7273d3c346 Merge "Adds additional folder label states (UNLABELED & EMPTY_LABEL)" into ub-launcher3-rvc-dev am: 51ece1847c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11931814

Change-Id: I2054b8bf93c12ba6bb14b49fd668050bba213068
2020-06-22 21:12:33 +00:00
TreeHugger Robot 71c030a864 Merge "Fixing rotation watcher not enabled in landscape" into ub-launcher3-rvc-dev am: ceaad08f06
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/11959138

Change-Id: Ida6defb23bd6d816332441266ecfc78e715f740f
2020-06-22 21:12:25 +00:00
Thiru Ramasamy 51ece1847c Merge "Adds additional folder label states (UNLABELED & EMPTY_LABEL)" into ub-launcher3-rvc-dev 2020-06-22 21:04:12 +00:00
TreeHugger Robot ceaad08f06 Merge "Fixing rotation watcher not enabled in landscape" into ub-launcher3-rvc-dev 2020-06-22 21:00:07 +00:00