Commit Graph

6193 Commits

Author SHA1 Message Date
TreeHugger Robot e1358149fc Merge "Removing unused tracing" 2020-12-14 18:21:37 +00:00
Ice Chang feb22118bf Merge "Add swipes left method in Background.java" 2020-12-12 16:33:16 +00:00
vadimt c610f26404 Removing unused tracing
Test: presubmit
Bug: 139891609
Change-Id: I30b432d329d6606b3d955409c167bddbacce8a37
2020-12-11 19:43:49 -08:00
Tony Wickham e3386502cf Fix TaskViewTouchController crash in seascape
Previously, we were using scroll direction POSITIVE as a catch all
to mean "up" but in seascape, we actually want NEGATIVE. Added
getUpDirection() to capture that. Tried to clarify the code a bit
by putting all the methods used solely by TaskViewTouchController
together with documentation. It's still pretty confusing and feels
redundant, but couldn't think of an obvious way to simplify.

Test: Swipe up and down on a task in all permutations of:
- 3 button mode
- Gesture navigation
- Portrait
- Landscape
- Seascape
- LTR
- RTL
- Home rotation allowed
- Home rotation disallowed

Fixes: 174009771
Fixes: 173567204
Change-Id: Id0f8d6f4365d888eb46182d8544d18206795dfb8
2020-12-11 17:30:41 -08:00
TreeHugger Robot 3b83609977 Merge "Not using blocking call to populate task title for logging" 2020-12-11 23:38:44 +00:00
TreeHugger Robot 04ed82860e Merge "Jank: taking screenshot in helper thread for quick switch" 2020-12-11 22:44:42 +00:00
TreeHugger Robot ef9f1e0af5 Merge "Adding tracing for app-to-overview" 2020-12-11 19:25:06 +00:00
Sunny Goyal e98f980a98 Ignoring crash if the 3p icon surface is no longer valid
Test: Verified on device locally
Change-Id: I5684731c3a66d5690f83878f3c4726d859349bd4
2020-12-10 16:59:28 -08:00
Sunny Goyal cfcefb0c47 Synchronizing model data access
Test: Presubmit
Bug: 173328873
Change-Id: Ifc1724e17ebfa2ee5f21bb3f272986b8a14fdbc1
2020-12-10 16:24:19 -08:00
vadimt 4b77e83a42 Not using blocking call to populate task title for logging
For now, passing null title

Bug: 175048504, 173072373
Test: presubmit
Change-Id: Ia2ed5433be9490d71786c98b8244f1c76e4e3088
2020-12-10 23:47:12 +00:00
vadimt 5794fa1aba Jank: taking screenshot in helper thread for quick switch
This operation is prone to lock contention.

Test: Manual
Bug: 173640772, 173072373
Change-Id: I86088255fa0cd8b369d9efec53fdac81210e71db
2020-12-10 12:48:05 -08:00
TreeHugger Robot cbf8fe08da Merge "Moving removing task after QS to a background thread." 2020-12-10 20:34:15 +00:00
Sunny Goyal 189fa681b1 Merge "DO NOT MERGE Revert "Handle uiMode changes"" 2020-12-09 22:37:05 +00:00
vadimt 3b55aab715 Adding tracing for app-to-overview
It will help finding jank in the quick switch
scenario.

Also removing tracing for cases when it's done
by the jank monitor.

Test: manual
Bug: 174892351
Change-Id: I16fc784ddb52203dba54eab2700b5a04a10088ff
2020-12-09 12:32:23 -08:00
Tracy Zhou 2268a7cb27 Merge "Render animation for launching settings in live tile mode" 2020-12-09 18:16:35 +00:00
Tracy Zhou f985f13ec1 Render animation for launching settings in live tile mode
Right now the animation is pretty basic. Will need to fine tune it.

Fixes: 172626326
Test: manual
Change-Id: Ibc64f6a988e1c7ad3f32732e1db2f0f29489e3f9
2020-12-09 00:18:00 -08:00
Winson Chung ff6d94dd92 DO NOT MERGE Revert "Handle uiMode changes"
Bug: 171707437
Test: Repro steps on bug

This reverts commit 0ad7b172e6.

Change-Id: If30cbb6c155e879dc8307a0a4a06dfb548b389a1
(cherry picked from commit 4b4341d3a7)
2020-12-09 07:33:40 +00:00
Schneider Victor-tulias e5764199de Merge "Add the ability to control the mock app thumbnail and app icon to TutorialControllers." 2020-12-07 17:43:04 +00:00
Schneider Victor-tulias 7f66dde4de Add the ability to control the mock app thumbnail and app icon to TutorialControllers.
Giving the gesture nav tutorial sandbox environment a more accurate look and feel requires the ability to inject mock drawables. The choice of drawables should go to TutorialControllers.

Bug: 175019879

Change-Id: Ie5b03b3fa07b017c0596a58dedf65d3e866a0727
2020-12-07 16:27:37 +00:00
vadimt 1e71ba5b98 Moving removing task after QS to a background thread.
Blocking binder call was creating jank.

Test: manual, presubmit
Bug: 173467481, 173072373
Change-Id: Ib19d2a97ed8cf3e9763008b042ef48d89532cb58
2020-12-04 14:18:52 -08:00
Vadim Tryshev 2fe8e76bd1 Merge "Jank: not blocking UI thread when starting a task" 2020-12-03 23:40:23 +00:00
Jon Spivack 446daa2678 Merge "Add the Share App system shortcut to the Go Launcher" 2020-12-02 23:29:33 +00:00
Tracy Zhou 620c249929 Merge "Log grid size change" 2020-12-01 16:50:43 +00:00
icechang 212cff1dec Add swipes left method in Background.java
Bug: 153276032
Test: TF_GLOBAL_CONFIG=/google/src/cloud/<ldap>/<workspace>/google3/wireless/android/test_tools/forrest/configs/local-host-config.xml \
pts-tradefed run commandAndExit cuj/<testname> \
--primary-abi-only \
--log-level verbose --log-level-display verbose \
--wifi-network GoogleGuest

Test:

Change-Id: Ib1cbc609f47a547f173e8170f00af9e8bdfa77bb
2020-12-01 21:34:26 +08:00
Jon Spivack a89a5084f2 Add the Share App system shortcut to the Go Launcher
This shortcut allows users to initiate peer-to-peer app sharing from an app's long-press menu on the home screen. It does so by passing an intent to the specified component. In this base implementation, that specification in config.xml is left blank, and the button will not appear. In GMS Launchers such as LauncherGoGoogle, the config should be set to point to Nearby Sharing.

This also establishes Launcher3QuickStepGo as a distinct subclass of QuickstepLauncher instead of merely a build configuration.

Bug: 157515296
Bug: 174286192
Test: Manual (tested on local wembley devices)
Test: m -j RunLauncherGoGoogleRoboTests
Change-Id: I826bd03721d2e7e963b15d5958e9a18a1cc16f1d
2020-11-30 18:53:56 -08:00
Jason Chang e08dd5861e Fix abnormal flicking when swiping up to exit OHM
Defer the action of onStopGestureDetected() from ACTION_MOVE
to ACTION_UP in OneHandedInputConsumer.

Bug: 171307756

Test: manual
Change-Id: Ie4a3cb0ba4477c131191a7ed1cf4daec2d364285
2020-11-27 18:03:33 +08:00
vadimt 6b193434ee Jank: not blocking UI thread when starting a task
This created jank at the end of quick switch.
Test: Manual
Bug: 173640772, 173072373
Change-Id: I86088255fa0cd8b369d9efec53fdac81210e71db

Change-Id: I96f821013d900ef57d61c462f897cba17f106bb8
2020-11-20 19:48:45 -08:00
Tracy Zhou 5b468d252f Log grid size change
Test: manually make sure that the correct path is fired
Fixes: 173481818
Change-Id: I7dc2143eb9c0527287398590d46fc2408bc47e44
2020-11-20 17:15:30 -08:00
vadimt 6c1fa64a1d Fixing jank in launching app from recents
Moving expensive actions from the last
frame's rendering.

This reduces the max frame time from > 16 ms
to <= 8 ms, which is good for now.

Test: Trace, metrics
Bug: 173640772
Bug: 173072373
Change-Id: I6d06a129f68d9b26f52c773b817558c77604ae5e
2020-11-21 00:09:42 +00:00
Tiger Huang 2f4654ee04 Merge "Replace the system UI visibility with appearance (Launcher)" 2020-11-18 13:30:06 +00:00
Sreyas 0da8d424e8 Make modal based UI changes in TaskView only if modalness changes.
Fixes issue with jittery displaying of suggestion chip, when entering overview.
Merging into master manually as automerger failed.
Tested:Manual

Change-Id: I8228c51b22d550cb8f0aa559f997060b571763f1
(cherry picked from commit ed5e43bd25)
2020-11-17 18:46:48 +00:00
Sunny Goyal 54834b0909 Merge commit '2cd8dd628268a177357afcccfeb7da8639e3a061' into merge_ub-launcher3-master_6976145
Test: manual, presubmit on the source branch
    x20/teams/android-launcher/merge/ub-launcher3-master_master_6976145.html

Change-Id: Ic13b1a20cc3d555e8e86717ca0da97103ff09c85
2020-11-16 14:40:43 -08:00
TreeHugger Robot 2cd8dd6282 Merge "Removing blocking call during cuj_LAUNCHER_APP_LAUNCH_FROM_ICON" into ub-launcher3-master 2020-11-13 19:24:40 +00:00
vadimt 4dd0fb173b Removing blocking call during cuj_LAUNCHER_APP_LAUNCH_FROM_ICON
This is a part of Blue Chip de-janking effort and is
a P0 item in our CUJ list.

In the last frame of the app-open animation, we have
a
android.view.IRemoteAnimationFinishedCallback$Stub$Proxy.onAnimationFinished call
which is blocking and prone to lock contention in WindowManager.

Moving the call to after the animation.

Bug: 173072373
Change-Id: If5eb6469900d1892b861eda6d6b4807d90630b6b
2020-11-12 18:42:20 -08:00
Schneider Victor-tulias 64154ead74 Fix hotseat predicted app update regression.
Hotseat predicted app updates were only being allowed then the hotseat was invisible or when the workspace was loading. This was too strict. Changed the logic to ignore hotseat visibility when the workspace is loading, when there are empty spots in the hotseat and when the predicted items are unchanged. This ensures the hotseat always has the intended number of icons and that icons can be updated in-place.

Fixes: 172597819

Demo: https://drive.google.com/file/d/100svnqX048Da7vues2p-vvQNN6sIF8v4/view?usp=sharing
Change-Id: I2f93ff44618c0282a6411918c34d70f75ec73b73
2020-11-12 11:22:53 -05:00
Sunny Goyal 6f1bc72fda Merge "Fixing animation cancelled not called if gesture was not initiated" into ub-launcher3-master 2020-11-12 04:33:07 +00:00
Sunny Goyal 986ea0da60 Fixing Robolectic model tests
Some tests were broken because of refactoring in LauncherModel.

Change-Id: I55aa32d75a4d16338796a1b1765717fd72ba4b33
2020-11-12 01:01:55 +00:00
Sunny Goyal 0112a3d434 Fixing animation cancelled not called if gesture was not initiated
Previously, in case of a tap in the gesture region, swipeHandler was not
explicitly cancelling the launcher state animation. It was getting reset
bucause launcher gets onStop immediately after that.
But in some cases, it may not get onStop (if the top activity finishes),
which leaves the Launcher UI in a broken state

Bug: 172842997
Change-Id: Iff7b1e5b8f67b2f4dd8096b88c4cd97115ec912a
2020-11-11 12:23:47 -08:00
TreeHugger Robot 1a7e371214 Merge "Refactoring DigitalWellbeing Banner to not use footers." into ub-launcher3-master 2020-11-11 01:42:19 +00:00
Winson Chung 4bfad584c5 DO NOT MERGE Revert "Handle uiMode changes" am: 4b4341d3a7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/12932788

Change-Id: I090572abd8046a30ed8353cac0e5730f90c74b2e
2020-11-10 22:35:52 +00:00
Winson Chung a18b9f3e42 Merge changes from topic "revert_ui_mode_changes" into rvc-qpr-dev
* changes:
  DO NOT MERGE Revert "Handle uiMode changes"
  DO NOT MERGE Revert "Defer recreation until resumed"
2020-11-10 22:17:52 +00:00
Sunny Goyal 1cd6a5f30e Fixing app-to-overview animation in 3 button mode
Instead of copying orientation state information from RecentsView
to taskViewSimulator, using the same state object, so that new
properties (like RecentsRotation and flags) are automatically covered

Bug: 162881482
Change-Id: I02d0a710a6ecc4a3cebd0fcc4c49032127df1ce3
2020-11-09 15:52:29 -08:00
Sunny Goyal cff31d8281 Merge "Removing separate Cancel and End callbacks and using AnimationListener instead" into ub-launcher3-master 2020-11-06 01:29:39 +00:00
Sunny Goyal ff9e7d6aa9 Removing separate Cancel and End callbacks and using AnimationListener instead
This removes the additional step of invoking these callbacks separately

Change-Id: I0b60047a44f179ba725f15b1e791e336884869c9
2020-11-05 16:35:11 -08:00
Tracy Zhou 3260bc51cb Merge "Handle the animation when restarting apps" into ub-launcher3-master 2020-11-06 00:05:49 +00:00
TreeHugger Robot e2c3a8f657 Merge "Using UI_HELPER_THREAD for various activity manager interactions" 2020-11-05 23:12:36 +00:00
Hyunyoung Song 64340cca97 [DO NOT MERGE] Add WW log for noti shade swipe down from home.
Bug: 171973663
Change-Id: I1e8ff20c62d4f91a05cb1cfc0337e351f2bc8885
(cherry picked from commit a87f99a35a)
2020-11-05 08:55:40 +00:00
Sunny Goyal ffa21961bf Using UI_HELPER_THREAD for various activity manager interactions
Bug: 170648272
Change-Id: Iec36389be5d747c5dc4d2bb2a8138758d48efa53
2020-11-04 22:36:21 +00:00
Sunny Goyal 8cadc1281f Using UI_HELPER_THREAD for various activity manager interactions
Bug: 170648272
Change-Id: Iec36389be5d747c5dc4d2bb2a8138758d48efa53
2020-11-04 14:29:59 -08:00
Tracy Zhou ae567f96f6 Merging from ub-launcher3-master @ build 6952418
Test: manual, presubmit on the source branch
x20/teams/android-launcher/merge/ub-launcher3-master_master_6952418.html

Change-Id: Id8ec665ff7be486b794807f6524e385728ea7717
2020-11-04 12:33:10 -08:00