Commit Graph

3952 Commits

Author SHA1 Message Date
TreeHugger Robot bc9dd92220 Merge "Delaying taskbar loading until user setup completed" into sc-v2-dev 2021-10-19 21:49:02 +00:00
Sunny Goyal 2a528a43c1 Delaying taskbar loading until user setup completed
> Also keeping it stashed while all-set activity is visible
> Creating a shared state (simiar to saved instance state) for taskbar
> Keeping taskbar stashed while all-set activity is visible

Bug: 194786060
Bug: 201782272
Test: Manual
Change-Id: Iab5e082243a206772266aece62d3028f5acb6400
2021-10-19 12:38:02 -07:00
Vinit Nayak 75465b2d7f Add log to RemoteTargetGluer to determine which array is empty.
Bug: 199658495
Change-Id: I069044d8ee0173fa3870f48d50374c634e0d58d7
2021-10-19 18:10:06 +00:00
Schneider Victor-tulias b4307ff8aa Merge "Update gesture navigation tutorial with new specs for foldable devices." into sc-v2-dev 2021-10-19 17:59:31 +00:00
Tracy Zhou fc0b21596f Merge "Track LauncherState for task bar stashing better" into sc-v2-dev 2021-10-19 07:06:14 +00:00
Vinit Nayak 6f6e97c653 Merge "Ensure RecentsView RemoteTargetHandle's are non-null" into sc-v2-dev 2021-10-18 23:19:21 +00:00
Mady Mellor 20c05fbd4c Merge "Add a scrim to taskbar for bubbles expanded state" into sc-v2-dev 2021-10-18 19:35:05 +00:00
Tracy Zhou ae88197e5f Track LauncherState for task bar stashing better
- Animate in onStateTransitionStart
- Commit in onStateTransitionComplete

Fixes: 193938970
Fixes: 200765631
Fixes: 201644899
Test: Go home from overview; Go to all apps from home; Go to overview from home
Change-Id: I393022c86f09806fea29fb5bc7191304b473f231
2021-10-18 10:51:51 -07:00
Tony Wickham e202a64e56 Merge "Fix taskbar layout issues in setup wizard" into sc-v2-dev 2021-10-18 16:01:38 +00:00
Vinit Nayak 30d46ef842 Merge "Handle race between creating and assigning RemoteTargetHandles" into sc-v2-dev 2021-10-16 05:39:24 +00:00
Vinit Nayak 15028e030b Handle race between creating and assigning RemoteTargetHandles
* Getting a callback from shell to inform when task is in split
and when it's been removed is asynchronous, and not
coordinated with launcher's swipe up gesture.
* There's a chance that user can quickswitch to single app
and start swipe up before shell could notify
LauncherSplitScreenListener, which would cause mismatched state.

Bug: 199658495
Change-Id: I722eeb26d83e99b2a2f77748984d0d7c390b5fec
2021-10-15 22:18:46 +00:00
Vinit Nayak 775fcb3fcf Ensure RecentsView RemoteTargetHandle's are non-null
Fixes: 201246959
Change-Id: Ifb8463e62765c92377db2a57ff7568e31da667aa
2021-10-15 15:16:20 -07:00
TreeHugger Robot 27e294a973 Merge "Removing overscroll pluging support" into sc-v2-dev 2021-10-15 19:27:25 +00:00
Vinit Nayak 2a7c0c4ed8 Merge "Align 3 button nav with hotseat" into sc-v2-dev 2021-10-15 15:25:16 +00:00
Tony Wickham bb6e278f14 Fix taskbar layout issues in setup wizard
- Align nav buttons (only back is enabled) to start instead of end
- Don't animate from init()
- Provide 0 contentInsets.bottom
  - Auto-stash the taskbar during setup
  - Hide the stashed handle by adding an alpha channel for home disabled
  - Report 0 contentInsets when stashed if the handle isn't visible
- Tint nav buttons according to theme

Test: adb shell am start -a android.intent.action.MAIN -n com.google.android.setupwizard/.SetupWizardTestActivity
Bug: 194786060
Change-Id: I4a40501e8aad2a38ec00398efe9ea3dbfa7428cd
2021-10-14 21:50:03 -07:00
Vinit Nayak 74b25ca266 Align 3 button nav with hotseat
* Animate translationY alongside icons
* When device rotates on home, update
translationY
* Add padding to contextual buttons to center
it

Bug: 189807374
Change-Id: I149ef25df570fb1fd385f1da960c827105ff975d
2021-10-14 18:32:35 -07:00
Schneider Victor-tulias 97b85ee6cb Update gesture navigation tutorial with new specs for foldable devices.
- Added new layout files for mock screens.
- Added new mock hotseat

Bug: 198434693
Test: launched and completed tutorial on regular phone and foldable device.
Change-Id: I1ad04f9e8e3a012528d6fd8fbaa0366687c65d06
2021-10-14 12:37:34 -07:00
Vinit Nayak 22762d91cd Merge "Suspend auto-hiding taskbar when folder is open" into sc-v2-dev 2021-10-14 19:11:53 +00:00
TreeHugger Robot 5ec8046f6a Merge "Transform touch events in landscape mode now that app is on top" into sc-v2-dev 2021-10-11 23:01:31 +00:00
TreeHugger Robot 60c64adeed Merge "Sending Launcher resume event to app predictor" into sc-v2-dev 2021-10-11 21:22:50 +00:00
Tracy Zhou a4a4002fa5 Transform touch events in landscape mode now that app is on top
Fixes: 193375232
Test: Swipe up from app in landscape mode, interact with Overview, and make sure it's interactive
Change-Id: Ib1838f02d537918b7a13d51a1fdcacbf3d02b99d
2021-10-11 14:04:51 -07:00
TreeHugger Robot 11579eea19 Merge "Fix split select scroll range when TaskView aren't shifting" into sc-v2-dev 2021-10-11 19:53:24 +00:00
TreeHugger Robot 1569754519 Merge "Add scroll logging to RecentsView behind DEBUG flag" into sc-v2-dev 2021-10-11 18:13:45 +00:00
Alex Chau 02150305f9 Fix split select scroll range when TaskView aren't shifting
- There is an edge case that when ClearAllButton is visible, no split translation is applied, the offset adjustment needs to be calculated differently in that case
- Also, apply the scrollOffset to the TaskViews / ClearAllButton instead of updating min/max scroll

Bug: 200537659
Test: Split right in grid, split left with clear all button, split left without clear all button
Change-Id: I869c448bbec6aec8fa070e47193a692be6f75e84
2021-10-11 19:02:28 +01:00
Sunny Goyal 1b6d43b13e Sending Launcher resume event to app predictor
Bug: 202535375
Test: Manual
Change-Id: I1618a5ed973b9d4f898442647e3e197ed4935aa4
2021-10-08 16:21:56 -07:00
Mady Mellor 5fdf2d08fc Add a scrim to taskbar for bubbles expanded state
When bubbles are expanded a scrim is shown on top of
everything. Taskbar is layered above bubbles but we still
need the scrim to show on top of it. This CL adds the
ability to show a scrim on taskbar.

The scrim is a view in the taskbar drag layer and is
placed between the taskbar and the nav buttons so that
it can block touches / scrim the taskbar but still allow
the nav buttons to be visible and touchable.

Add interpolators for alpha matching what bubbles is using.

Test: manual 1 - expand bubbles while taskbar is visible
                 => observe scrim
               - open manage menu
                 => observe darker scrim
             2 - check that taps on scrim collapse manage
                 menu or stack
             3 - check there isn't a scrim while taskbar is
                 stashed and bubbles / manage menu are open
             4 - check that three button nav works while
                 bubbles are expanded
Bug: 197139718
Change-Id: I94c4ecd07f81b2bad55c38525d60f493d3c1f9d8
2021-10-08 14:55:43 -07:00
Alex Chau e95de31304 Add scroll logging to RecentsView behind DEBUG flag
Bug: 202514687
Test: manual
Change-Id: Iec022f2583baa794904242a44a2c8dca8ea4b1be
2021-10-08 16:26:08 +01:00
Tony Wickham 1bd4bf7ff1 When taskbar would be stashed in 3 button mode, hide icons instead
In 0 button mode, stashing morphs the icons into the home handle. In 3 button mode, that doesn't make sense, but we should still hide the icons (and just keep the 3 nav buttons). You still can't manually stash via long press in 3 button mode, but this will address other states where we automatically stash the taskbar when we want to hide the icons from users (e.g. when pinning an app).

Test: Pin an app from overview in 3 button mode, ensure the taskbar icons disappear until unpinning
Bug: 190192993
Change-Id: I499c59bd9d7871ff64696b67065cf9d4863222a5
2021-10-07 23:29:41 -07:00
Tony Wickham db0c2f1b79 Add flags to stash taskbar for app pinning and empty hotseat
Test: pin an app from overview, watch taskbar stash automatically until unpinning
Test: turn off suggestions for hotseat, remove all items and watch taskbar stash automatically when opening an app
Fixes: 190192993
Fixes: 193937948
Change-Id: Ia7260c60a820af1a48c9e4a400a52753baf34d41
2021-10-07 23:29:41 -07:00
Tony Wickham 772732de9e Migrate mStashedInApp to FLAGS_STASHED_IN_APP
This is to prepare for different flags that could cause taskbar to be stashed in an app without the user explicitly long pressing to stash.

Test: run wwdebug and wwlogcat, ensure still get logs for long press stash events; other interactions like clipping tasks to above unstashed taskbar still work as before
Bug: 190192993
Bug: 193937948
Change-Id: I90846e650a438e03bdcfdf9c4bf919e19cc5abb3
2021-10-07 23:29:34 -07:00
Vinit Nayak 2a77ff74bd Suspend auto-hiding taskbar when folder is open
* Notify SystemUi to suspend autoHide behavior
until launcher notifies otherwise
* There's no exclusive lock for AutoHideController
behavior, so down the road another component can
choose to resume auto-hide behavior even if launcher
has requested otherwise (and vice versa),
something to keep in mind.

Fixes: 193938507
Test: Opened folder while in immersive video,
taskbar stayed open.

Change-Id: I12f4055911822893551683466cfd532c8108a3a0
2021-10-07 13:46:26 -07:00
Alex Chau fe69980f90 Merge "Only adjust min/max scroll for split screen in landscape" into sc-v2-dev 2021-10-07 14:52:05 +00:00
Vinit Nayak 7c2b52e5cf Merge "Show split options when overview actions hidden for grid" into sc-v2-dev 2021-10-07 14:51:44 +00:00
Vinit Nayak c5ae15b481 Merge "Move back to end of screen on keyguard" into sc-v2-dev 2021-10-07 14:49:47 +00:00
Vinit Nayak a08e806e25 Move back to end of screen on keyguard
* Animate it back into position after user unlocks
* Re-create taskbar on layout direction change so
PropertyHolders are recreated to take into account
new values

Fixes: 199852418
Test: Tested w/ password + pin for gesture + 3 button
Change-Id: Ie7f16f737a8fc12328c05d7628d0e3ae09fc08ca
2021-10-06 18:09:15 -07:00
Sunny Goyal 0ecfb69596 Removing overscroll pluging support
Bug: 201677812
Test: Presubmit
Change-Id: Id8136e99746946ba840754ef8e71a4574f49938e
2021-10-06 11:23:46 -07:00
Tony Wickham f9d2082cf3 Merge "Fix issues with starting new recents animation before previous onRecentsAnimationStart" into sc-v2-dev 2021-10-06 17:36:45 +00:00
Alex Chau aea42dc43e Only adjust min/max scroll for split screen in landscape
- Portrait's split placeholder is at top/bottom and does not affect scroll

Bug: 200537659
Test: Split left and split right in portrait / landscape, check if min/max scroll is correct
Change-Id: Ib7eb09d3cc44c8e0d962920ad094c73abc5f0dbd
2021-10-06 12:31:10 +01:00
Tony Wickham 66ed0ff23e Fix issues with starting new recents animation before previous onRecentsAnimationStart
- Fix logic for canceling animation for continued quick switch, so that this case (starting a new gesture before onRecentsAnimationStart() of the previous gesture) instead goes to the STATE_FINISH_WITH_NO_END flow.
- Update the end target so that we go to that state instead of always overview state if swipe was past the halfway threshold when we call endLauncherTransitionController(). This is specifically so we don't use OverviewInputConsumer on the second gesture, given the first one was canceled and didn't actually go to overview.
- GestureState#isRecentsAnimationRunning() now checks for STATE_RECENTS_ANIMATION_STARTED rather than _INITIALIZED, to be consistent with its javadoc and TaskAnimationManager#isRecentsAnimationRunning(). This also ensures we can correctly calculate continued quick switch (see above).
- Call cleanUpRecentsAnimation() before creating a new one in TaskAnimationManager. This ensures that the previous listener doesn't immediately cleanup the new gesture when it gets onRecentsAnimationCanceled() due to the new recents animation starting.

Test: swipe to home twice from the app, locally ignoring the onRecentsAnimationStart() from the first one, and ensure the second one responds normally
Bug: 193851085
Change-Id: I76e27c96b54293805546c0d6c82e77f975c69d7a
2021-10-05 18:14:51 -07:00
Vinit Nayak 6ab0d1e7be Merge "Reset state after split launch animation finishes" into sc-v2-dev 2021-10-06 00:56:48 +00:00
TreeHugger Robot 1bf753f7a6 Merge "Add TAPL test that dismissing focused task causes next task to become focused." into sc-v2-dev 2021-10-06 00:14:46 +00:00
Vinit Nayak 0516737146 Reset state after split launch animation finishes
Previously we were clearing SplitSelectStateController
state too soon for fake landscape case where
as soon as the tasks launch the device does a rotation
animation since the new split tasks are in landscape.
Move restting state after animation finishes.

Fixes: 201980666

Change-Id: I23efd59fad444c47ae6c2048888a8570f22610fd
2021-10-05 15:29:24 -07:00
Vinit Nayak 0ff2ad6ff4 Merge "Set SurfaceTransactionApplier on non-stale RemoteAnimationTargets" into sc-v2-dev 2021-10-05 21:44:34 +00:00
Vinit Nayak 95ee358269 Show split options when overview actions hidden for grid
* We hide split option in task menu for focused task
if the user hasn't scrolled at all in overview
* We show option when user has scrolled because then
the split option from overview actions will be hidden
* Mostly uses the same logic as
RecentsView#updateActionsViewFocusedScroll()

Bug: 201380373
Test: Manual
Change-Id: Ia8769a67cfbb2e4414cd4d8e816e62245fc4bd2c
2021-10-05 14:28:07 -07:00
Pat Manning a140a0b611 Add TAPL test that dismissing focused task causes next task to become
focused.

Test: TaplTestsQuickstep.java
Bug: 197630182
Change-Id: I6f29dc6e3954f1b22ce8ffdf0a83db97202caefe
2021-10-05 18:00:11 +00:00
Vinit Nayak 01e47343e6 Set SurfaceTransactionApplier on non-stale RemoteAnimationTargets
* When we create RemoteTargetHandles we create a new
RemoteAnimationTarget from the old ones, which weren't
getting their addReleaseCheck() methods called
* The old recentsAnimationTargets were having it be set on them,
however they go unused.

Bug: 199043513
Change-Id: I36317f213139435ec09997290853787e30d11e0f
2021-10-05 10:40:12 -07:00
Alex Chau 516584e648 Adjust min/max scroll according to mSplitPlaceholderSize
- RTL is not handled yet due to split select broken

Bug: 200537659
Test: Split left and split right, check if min/max scroll is correct
Change-Id: I734d890bb955601da52cd806074014ed2e7eba55
2021-10-05 17:22:05 +01:00
Jerry Chang b001ce602f Merge "Update side stage outline visibility with swipe gesture" into sc-v2-dev 2021-10-05 00:46:36 +00:00
Jerry Chang d41c032afd Update side stage outline visibility with swipe gesture
Bug: 200850654
Test: enabled side stage outline, observed the outline updates its
      visibility with swipe gesture properly.
Change-Id: I59fcb1fdbb07f5ad5327036972ebbe20ebeb11b7
2021-10-02 10:04:32 +08:00
Alex Chau d4864e5cbc Don't snap to task when tapping task icon in overview grid
- Open task menu directly instead of snapping to task, as there are spaces to do so unlike small screen

Fix: 201428316
Test: Tap task icon with clear all button shown in overview grid, no snapping
Test: Tap task icon with clear all button shown in non-grid overview, snapped to last task
Change-Id: Ief79f7c758c4109e5c7722b2f35647db98a9f05c
2021-10-01 18:23:25 +01:00