Vinit Nayak
b03ec55872
Merge "Null out mSplitHiddenTaskView when resetting split selection state" into tm-qpr-dev am: 66160e9dd8
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20029582
Change-Id: I2f2ce0e026d6dbecaacdd7f026e208d658249eae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-03 23:14:57 +00:00
Vinit Nayak
66160e9dd8
Merge "Null out mSplitHiddenTaskView when resetting split selection state" into tm-qpr-dev
2022-10-03 22:45:42 +00:00
Stefan Andonian
371ba32e44
Fix ViewCapture NPE. am: b759de4769
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20075879
Change-Id: I1c44ad208cc7d36d070971ef507c735ca385cdfc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-03 18:40:33 +00:00
Stefan Andonian
b759de4769
Fix ViewCapture NPE.
...
The ViewPropertyRefs, when copied from 1 frame to another, where also
transferring the same "next" reference. Sometimes, the recycled
ViewPropertyRef would be the same ViewPropertyRef instance as one of the copied
ViewPropertyRefs, which would caused an NPE, since the recycled VPR
would have it's next value set to null.
Bug: 249125402
Test: Repro steps are dragging and dropping around an item on the
workspace to different locations. This consistently repro's the crash in
about 10 seconds of doing this. Afte the fix, the crash stopped.
Change-Id: Ia43d8f788eb4889c0890fea0bb839cb9fed78ada
2022-10-03 15:25:04 +00:00
Jeremy Sim
635815666c
Fix 2 bugs involving split staging task translation am: 978b0021a9
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20087546
Change-Id: Iffca62d17d40b168ff53c5624dc09dda2fbe4fec
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-10-01 01:23:06 +00:00
Jeremy Sim
978b0021a9
Fix 2 bugs involving split staging task translation
...
This patch fixes two bugs related to the way tiles slide in when a split is staged. Previously, translations were not being completely reset, so on repeated splits, the thumbnails would retain their old translation setting and cause awkward movements to occur during the slide-in animation.
Fixed by adding setTaskViewsPrimarySplitTranslation() and setTaskViewsSecondarySplitTranslation() in resetFromSplitSelectionState().
Fixes: 249154347
Fixes: 249824716
Test: Manual on grid and non-grid Overview, in a variety of conditions
Change-Id: I2d9aa621a17f178ff8216740d76429d2ac484b39
2022-09-30 14:30:04 -07:00
Brian Isganitis
00f9389e4e
Merge "Avoid syncing voice interaction background window for skipAnim=true." into tm-qpr-dev am: f733a716fd
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20068647
Change-Id: Ie484ca3d0918573c7e706ddea23823ea82cc9f1a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-29 21:41:47 +00:00
Brian Isganitis
f733a716fd
Merge "Avoid syncing voice interaction background window for skipAnim=true." into tm-qpr-dev
2022-09-29 21:13:59 +00:00
Vinit Nayak
64e8d014a0
Merge "Update animations for phones: Overview > OverviewSplitSelect transition" into tm-qpr-dev am: 888f745490
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20056375
Change-Id: I897b8dde1e1691f4fc2c9ca632dcf7579f186b3e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-28 18:58:35 +00:00
Vinit Nayak
888f745490
Merge "Update animations for phones: Overview > OverviewSplitSelect transition" into tm-qpr-dev
2022-09-28 18:30:16 +00:00
Brian Isganitis
c7c2e8d7e6
Avoid syncing voice interaction background window for skipAnim=true.
...
Test: Manual
Fix: 236924161
Change-Id: Iaf95221678d36f9b5782fd8c4bda626b946565a9
2022-09-27 23:36:24 +00:00
Jeremy Sim
ba7324e2b8
Update animations for phones: Overview > OverviewSplitSelect transition
...
This change updates the animation for initiating a split from the Overview screen on phones. Includes new timings and interpolators, and extends timing data classes related to SplitAnimationTimings.
Fixes a noticeable issue where the split animation appeared slow on phones.
Outstanding issues (fixes in progress):
- Repeated invocations of split on phones cause an erroneous animation to play. (b/249154347)
- Thumbnail corners do not match placeholder corners; the transition between the two is slightly janky. (b/236761794)
- Placeholder icons should be 72dp. (b/236761794)
Bug: 236761794
Test: Manual
Change-Id: Ibb97ef54498b0aa9556df531d8084799259c06e2
2022-09-27 11:45:02 -04:00
Ats Jenk
98b79c3e11
Merge "Set up a place holder tile for desktop" into tm-qpr-dev am: aeea6768e6
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19914914
Change-Id: I97e4df052f43d0b6dfef5b3a04c0013c5133adca
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-27 00:10:20 +00:00
Ats Jenk
aeea6768e6
Merge "Set up a place holder tile for desktop" into tm-qpr-dev
2022-09-26 23:43:19 +00:00
Brian Isganitis
7fc8bf0c25
Merge "Properly color taskbar nav buttons when slide-in view is shown." into tm-qpr-dev am: 815018be9a
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20040590
Change-Id: I8a55315e04ee588298f13c3b053a906bffd5e9c5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-26 23:07:12 +00:00
Brian Isganitis
815018be9a
Merge "Properly color taskbar nav buttons when slide-in view is shown." into tm-qpr-dev
2022-09-26 22:56:06 +00:00
Brian Isganitis
731ef0c301
Properly color taskbar nav buttons when slide-in view is shown.
...
Supports overriding the current nav bar color with one that would be
visible over a slide-in view.
Demo:
https://drive.google.com/file/d/1MB26QM5qeeyVB6Bj14IGoPCWVT_P7K-3/view?usp=sharing&resourcekey=0-wnMgciNrUXC_l7gI3JFm8A
Test: Manually with light and dark themes, as well as All Apps and EDU
views.
Fix: 248359789
Change-Id: I134ae719b10f3de78ea18220a835de56a82ecb02
2022-09-26 11:41:38 -07:00
Tony Wickham
7092878a57
Merge "Don't moveToRestState from onTaskAppeared" into tm-qpr-dev am: 34461ba303
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20040404
Change-Id: Ifc7d9c45214c3f79a1c19a031741a3ab2a48ed86
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-24 07:09:33 +00:00
Tony Wickham
34461ba303
Merge "Don't moveToRestState from onTaskAppeared" into tm-qpr-dev
2022-09-24 06:44:17 +00:00
Ats Jenk
919ddf19f3
Set up a place holder tile for desktop
...
Create a placeholder tile in recents for desktop.
It is based on launcher task information. With extra flag indicating it
is for desktop.
When it is clicked, it will call sysui to show apps on desktop.
Test: manually verify that desktop tasks do not show up separately in
recents
Bug: 244348395
Change-Id: I8535a54e1545841cd988d4770e6fc5e857277cda
2022-09-23 16:28:48 -07:00
Tony Wickham
017bbc098a
Don't moveToRestState from onTaskAppeared
...
There's a possible race here where we call moveToRestState before
Launcher is actually stopped, so it starts to animate the state
change, causing a visual jump before it gets stopped. We already call
moveToRestState in StatefulActivity#onStop, so this one shouldn't be
necessary anyway.
Test: Enable Winscope tracing, quick switch from app A to app B; before
this change, 9/10 times it would repro the jump in the bug, 0/10 times
after this fix. (Also verified through debug logging.)
Fixes: 244583136
Change-Id: I656b028f26a64f872960cb3fe87c39b097431511
2022-09-23 14:14:52 -07:00
Mady Mellor
bfd21f48a9
Merge "Set package name on the floating intent" into tm-qpr-dev am: dea0a2466b
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20027851
Change-Id: I6800ea518cd6af0194eeda4f89908428f25fb29e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-23 18:20:56 +00:00
Mady Mellor
dea0a2466b
Merge "Set package name on the floating intent" into tm-qpr-dev
2022-09-23 17:50:53 +00:00
Sebastián Franco
f5ff31ab74
Merge "Check for null when calling getCreatedActivity which is marked as Nullable" into tm-qpr-dev am: 8c158770d7
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20025053
Change-Id: I0424bb93fff149dc5ac168caed4a1974b319970a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-23 15:51:31 +00:00
Sebastián Franco
8c158770d7
Merge "Check for null when calling getCreatedActivity which is marked as Nullable" into tm-qpr-dev
2022-09-23 15:19:43 +00:00
Winson Chung
47104adfd6
Merge "Revert "Fix case of gesture being stuck when the Launcher is stopped mid-gesture"" into tm-qpr-dev am: d859a20086
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20028589
Change-Id: Iede5e3cd5e207b0ca4ee688a8ae4660726d6b0c7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-23 05:01:06 +00:00
Winson Chung
d859a20086
Merge "Revert "Fix case of gesture being stuck when the Launcher is stopped mid-gesture"" into tm-qpr-dev
2022-09-23 04:33:22 +00:00
Vinit Nayak
26fee57f37
Null out mSplitHiddenTaskView when resetting split selection state
...
* May have accidentally been removed in ag/19984439
Fixes: 248153819
Test: Repro in bug doesn't occur
Change-Id: Icdc04de84c28963d36368f9672baf5993cd87d8a
2022-09-22 16:27:47 -07:00
Vinit Nayak
d563e886a1
Merge "Prevent taps on initial TaskView animated into split select" into tm-qpr-dev am: 061e6f5dd5
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20015839
Change-Id: Iaa19f2123c9b549152fc5237439301793badb273
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-22 22:36:09 +00:00
Winson Chung
8ae6b852d7
Revert "Fix case of gesture being stuck when the Launcher is stopped mid-gesture"
...
This reverts commit 240b064cdb .
Reason for revert: b/248344141
Change-Id: I559e583ddea4a68b4291ceb8ba119500d051ed36
2022-09-22 22:10:20 +00:00
Vinit Nayak
061e6f5dd5
Merge "Prevent taps on initial TaskView animated into split select" into tm-qpr-dev
2022-09-22 21:56:55 +00:00
Mady Mellor
ceff6537ee
Set package name on the floating intent
...
Test: treehugger
Bug: 237678727
Change-Id: I70923e62893cd6578fa3fa21e025cd5cf5e15edf
2022-09-22 12:08:41 -07:00
Sebastian Franco
e7c222cdb5
Check for null when calling getCreatedActivity which is marked as Nullable
...
Fix: 243508135
Test: compiles
Change-Id: Id1ff2cf68fa10690a1bbec60a0c17cceab9db8d1
2022-09-22 13:03:15 -05:00
Schneider Victor-tulias
d496c3d20d
Merge "Allow Taskbar stashing for external tests" into tm-qpr-dev am: 418b1f8e82
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19611434
Change-Id: If0c7eef8169237721cc4d62885d10f23d19d11e1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-22 17:51:38 +00:00
Schneider Victor-tulias
418b1f8e82
Merge "Allow Taskbar stashing for external tests" into tm-qpr-dev
2022-09-22 17:25:24 +00:00
Mady Mellor
6d37424c94
Merge "Add a button for floating tasks to taskbar (behind a flag)" into tm-qpr-dev am: 13b7e00fff
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19874561
Change-Id: Ic1c92bac2b98e3eac04acd567ab208f814f00408
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-22 15:37:38 +00:00
Mady Mellor
13b7e00fff
Merge "Add a button for floating tasks to taskbar (behind a flag)" into tm-qpr-dev
2022-09-22 14:58:13 +00:00
Nicolò Mazzucato
a2c42f1696
Merge "Fix taskbar instrumentation crash" into tm-qpr-dev am: 98e4e461fe
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19964665
Change-Id: I898becf047d68427c012df32dacd730949a27a97
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-22 09:16:44 +00:00
Nicolò Mazzucato
98e4e461fe
Merge "Fix taskbar instrumentation crash" into tm-qpr-dev
2022-09-22 08:28:41 +00:00
Stefan Andonian
886f34e9c2
Merge "Copying ViewCapture from last frame when possible." into tm-qpr-dev am: 94502428a9
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19803004
Change-Id: I747e93e408f1d4298978ec760c9491d8c5d90821
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-22 00:08:21 +00:00
Vinit Nayak
5144be3903
Prevent taps on initial TaskView animated into split select
...
Fixes: 247843657
Test: Tapping on animating taskView as soon as
split top is selected from app menu doesn't result
in starting split prematurely.
Change-Id: I94455d9bab381e5223f70cab981830d51a8fad6b
2022-09-21 16:57:53 -07:00
Andy Wickham
c6ed393aae
Merge "Reduces vertical padding of predicted apps in All Apps." into tm-qpr-dev am: a297508c15
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19937149
Change-Id: Iccb595edba64d451c43f211363e586525cdcc020
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-21 23:23:36 +00:00
Stefan Andonian
94502428a9
Merge "Copying ViewCapture from last frame when possible." into tm-qpr-dev
2022-09-21 22:44:53 +00:00
Schneider Victor-tulias
e87055e2dd
Merge "Update page index update logs" into tm-qpr-dev am: c4928df98b
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19993478
Change-Id: I2ed1dba48e195fcce4733a259f24f0f783ea6f62
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-21 21:41:43 +00:00
Winson Chung
0b07c8daba
Merge "Fix case of gesture being stuck when the Launcher is stopped mid-gesture" into tm-qpr-dev am: a4512046cf
...
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19939112
Change-Id: I59734e44784feda5d7920060a66b2db2cc681f15
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com >
2022-09-21 21:30:35 +00:00
Schneider Victor-tulias
e64a8cfb20
Allow Taskbar stashing for external tests
...
Moved Taskbar stashing enabling logic to QuickstepTestInformationHandler to allow external tests to use the Taskbar API
Test: TaplTestsTaskbar
Bug: 240129939
Change-Id: I0ede8e4767cbe068328997a3afd51f9d5df2799a
2022-09-21 10:44:23 -07:00
Andy Wickham
a297508c15
Merge "Reduces vertical padding of predicted apps in All Apps." into tm-qpr-dev
2022-09-21 17:25:39 +00:00
Stefan Andonian
7308c39049
Copying ViewCapture from last frame when possible.
...
Bug: 242867462
Test: Used system.nanotime to time the performance improvements
before and after. Verified correct behavior by coloring dirty
views differently in the go/web-hv tool and ensuring that the
hierarchies were emitted correctly for dirty and clean views.
Change-Id: I624572170bc914ed2c9d329e37e64a88203f87f4
2022-09-21 16:38:01 +00:00
Schneider Victor-tulias
c4928df98b
Merge "Update page index update logs" into tm-qpr-dev
2022-09-20 21:50:36 +00:00
Winson Chung
a4512046cf
Merge "Fix case of gesture being stuck when the Launcher is stopped mid-gesture" into tm-qpr-dev
2022-09-20 19:51:08 +00:00