Commit Graph

6017 Commits

Author SHA1 Message Date
Alex Chau b00a9fca79 Use taskbarSize to calculate clippedInsets
- Instead of calculating clippedInsets from thumbnail dimension, always use taskbarSize
- Clean up clippedInsets code as only bottom inset is ever present

Fix: 235328056
Test: With taskbar hidden, out of orientation thumbnail has proper size in quickswitch and overview
Change-Id: I3d7fc7899f04862c3401935b10f475e9ab74685a
2022-07-04 18:49:11 +01:00
Jeremy Sim e19aab9010 Merge "Allows Launcher to recover gracefully into OverviewSplitSelect state" into tm-qpr-dev 2022-07-01 21:40:34 +00:00
Jeremy Sim c94f4b779b Allows Launcher to recover gracefully into OverviewSplitSelect state
When Launcher restarts (as the result of a UiModeChange or something else), it attempts to recover its previous state. However, the OverviewSplitSelect state is unique because it requires some additional information to recover properly (the taskId of the staged task and so on). This change makes it so that the relevant information is passed forward in the recovery bundle. Launcher will now restart in the base Overview state, and then immediately apply the saved data to recover the OverviewSplitSelect state.

Fixes: 233019928
Test: Manual
Change-Id: Ie6123ef9c374be000268f82857b696c49213c541
Merged-In: Ie6123ef9c374be000268f82857b696c49213c541
2022-07-01 00:07:54 +00:00
Tracy Zhou 1092ccacbf Merge "Show IME switcher only when physical keyboard is connected in 3 button nav (instead of also when virtual keyboard is visible)" into tm-qpr-dev 2022-06-29 21:27:17 +00:00
TreeHugger Robot 3cbbacebc8 Merge "Let launcher clean-up shell transition leashes" into tm-qpr-dev 2022-06-29 02:41:30 +00:00
Wei Sheng Shih 0dd24fc7c3 Merge "[Shell Transition]Fix live tile be hidden by wallpaper leash." into tm-qpr-dev 2022-06-29 02:10:19 +00:00
Anushree Ganjam a65cc60f9d Merge "Move bitmapSupplier.get() call to a worker thread." into tm-qpr-dev 2022-06-28 23:13:35 +00:00
Hongwei Wang 6c4b75c365 Merge "Scale the surface by progress when auto enter PiP" into tm-qpr-dev 2022-06-28 16:40:21 +00:00
Vinit Nayak 6b05c8ce1f Merge "Close all open views for 1P and 3P launchers" into tm-qpr-dev 2022-06-28 16:24:16 +00:00
Vinit Nayak c012c5385d Merge "Hide split option if task is not dockable" into tm-qpr-dev 2022-06-28 16:15:52 +00:00
Nicolò Mazzucato 5529b23fbb Merge "Add jank monitoring for taskbar appearing and disappearing" into tm-qpr-dev 2022-06-28 15:15:35 +00:00
Vaibhav Devmurari b1405a2fc1 Merge "Allow taskbar and taskbar all apps window to receive split touches" into tm-qpr-dev 2022-06-28 10:24:27 +00:00
Nicolo' Mazzucato 8256537fdb Add jank monitoring for taskbar appearing and disappearing
Bug: 228969045
Test: record a perfetto trace and make sure the interaction is there
Change-Id: Id220f8eef5b08fb69410e08c230f867ffe21d126
2022-06-28 08:28:35 +00:00
Vinit Nayak e8a805c3f6 Hide split option if task is not dockable
* Also hide if activity is currently in multi-window
to keep logic parity

Fixes: 236689017
Test: Unable to initiate split with Camera app
Change-Id: Ib7e3043cbc7d4e2ef5da51779de36969ae7e6fef
2022-06-27 22:26:11 -07:00
Tracy Zhou 5bd220a230 Merge "Stash task bar when ime switcher is showing" into tm-qpr-dev 2022-06-28 04:50:34 +00:00
Anushree Ganjam d1a3e7ff2c Move bitmapSupplier.get() call to a worker thread.
bitmapSupplier.get() is called twice which is unnecessary.
Call bitmapSupplier.get() in the constructor instead.

Bug: 232850298
Test: Manual.
OverView - shareImageToTarget https://b.corp.google.com/issues/232850298#comment8
Screenshot share from Toast - https://b.corp.google.com/issues/232850298#comment7

Change-Id: I920f89b90fafcc0d51b1b948fd76fdc9aaee4c52
2022-06-28 00:42:53 +00:00
Evan Rosky 6f4613749e Let launcher clean-up shell transition leashes
Originally disabled this when we were directly using
the transition's leashes for animation (since the transition
system owns those leashes). However, now that we create our
own leashes in RemoteAnimationAdapterCompat, we can use this
logic again.

Bug: 235616350
Test: launch and close app in quick succession
Change-Id: I27f70f26e114443aeb83671437f54747aae92c51
2022-06-27 16:07:33 -07:00
Tracy Zhou 6663ebba3e Merge "Perform haptic feedback on nav button key press" into tm-qpr-dev 2022-06-27 22:55:42 +00:00
Hongwei Wang 56911984e4 Scale the surface by progress when auto enter PiP
Video: http://recall/-/aaaaaabFQoRHlzixHdtY/coTRupQrNjoSwGDzMhA4X7
Video: http://recall/-/aaaaaabFQoRHlzixHdtY/fDqPTOPwyxHaZ4HLZDF7di
Bug: 235268241
Test: Verify the auto enter PiP animation for YouTube in \
      both folded and unfolded state. See also videos.
Change-Id: I6fc10d6a733b8bdd3587994e8e27c4d6ab7e4f39
2022-06-27 11:32:15 -07:00
Tony Wickham c4405218ca Merge "Log when MotionPauseDetector detects onMotionPauseChanged" into tm-qpr-dev 2022-06-27 17:28:17 +00:00
Vaibhav Devmurari 207e374413 Allow taskbar and taskbar all apps window to receive split touches
Adding feature to allow UI interaction during Drag and drop.
To allow user to interact with taskbar UI during D&D, the window
should support FLAG_SPLIT_TOUCH to receive touch events while user
using D&D.
DD: go/global_drag_and_drop

Test: manual
Bug: 220109830
Change-Id: Icd549aa272c140d865d89eeb9f5619b5ab13c015
(cherry picked from commit 0074baa82e)
2022-06-27 10:11:58 +00:00
Tracy Zhou 015adda83c Stash task bar when ime switcher is showing
Bug: 226489759
Test: connect to physical keyboard and select a typable field, and make sure the task bar is stashed
Change-Id: Ie1cf753f793dc9cb350e57e9448c2913260992ca
2022-06-25 16:26:13 -07:00
Tracy Zhou 849a0c4e81 Show IME switcher only when physical keyboard is connected in 3 button nav (instead of also when virtual keyboard is visible)
Bug: 226489759
Test: connect to a physical keyboard in 3 button nav and make sure the ime switcher shows; and doesn't show with virtual keyboard
Change-Id: Ib9a5880eb1bd6d5b877a9f3789ce858f399c4910
2022-06-24 23:40:41 -07:00
Tracy Zhou f9fafe7a92 Merge "Fix ime switcher not showing for 3-button nav" into tm-qpr-dev 2022-06-25 06:36:39 +00:00
TreeHugger Robot ce12869fad Merge "Treat all apps predictions as all app icons when animating icons to their original position" into tm-qpr-dev 2022-06-25 06:33:16 +00:00
Schneider Victor-tulias a36e5f13c0 Treat all apps predictions as all app icons when animating icons to their original position
Taskbar all apps predictions were being ignored when animating a cancelled drag to their original position. This was causing a null pointer since they no longer had a view parent that could be used. These icons will now animated to the taskbar all apps icon.

Fixes: 236669335
Test: cancelled drags of taskbar icons, predicted taskbar icons, taskbar all apps icons and taskbar all apps prediction icons
Change-Id: I2a9a1ed4120927a08b8c8341ad36dfdb95fef608
2022-06-24 12:22:04 -07:00
Tracy Zhou 804feb76e7 Fix ime switcher not showing for 3-button nav
Bug: 226489759
Test: connect to a physical keyboard in 3 button nav and make sure the ime switcher shows
Change-Id: Iabde149e8bcd1edacff8e039f956628c69341ecb
2022-06-24 11:17:40 -07:00
Luca Zuccarini 4a0129fa5f Merge "Unify the source of truth for NORMAL <> ALL_APPS transitions." into tm-qpr-dev 2022-06-24 10:25:49 +00:00
Alex Chau f7526085a9 Merge "Check null before getting DeviceProfile in AbsSwipeUpHandler" into tm-qpr-dev 2022-06-24 10:05:27 +00:00
Sunny Goyal c3a5c4b16e Merge "Fixing wrong flags used by AllAppsController in SystemUiController" into tm-qpr-dev 2022-06-23 22:52:11 +00:00
Tony Wickham c214335eba Log when MotionPauseDetector detects onMotionPauseChanged
Test: verified logging locally
Bug: 232548865
Change-Id: I587481a380148127f715c5b1b59436b2cbc1533e
2022-06-23 15:05:42 -07:00
Tracy Zhou 0a0fcb809c Perform haptic feedback on nav button key press
Fixes: 203614307
Test: manual
Change-Id: Icaea3f5e436522f23202c20fcc7f7c5dbe309372
2022-06-23 14:29:34 -07:00
Schneider Victor-tulias 2df19a2345 Merge "Fix a potential null-pointer onActivityDestroyed" into tm-qpr-dev 2022-06-23 18:29:09 +00:00
Alex Chau 7ba6cadf27 Check null before getting DeviceProfile in AbsSwipeUpHandler
Fix: 236677962
Test: manual
Change-Id: Ibf3dbc6db509a54c87dc4bd64a7c7ea213870708
2022-06-23 12:05:42 +01:00
Sunny Goyal 24b441051e Fixing wrong flags used by AllAppsController in SystemUiController
Bug: 236857339
Test: Verified the UI manually
Change-Id: I2773837932ed50a59ebc9d2810f9e7ee501b6f6b
2022-06-22 12:09:22 -07:00
Alex Chau 7356c13760 Merge "Revert "Finish recents animation on activity destroyed."" into tm-dev am: ed2e7719cb am: 90abf51d5b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19015866

Change-Id: I3d68a995880a27c953164e2d4767f63ab38b0bfc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-22 12:39:41 +00:00
Alex Chau ed2e7719cb Merge "Revert "Finish recents animation on activity destroyed."" into tm-dev 2022-06-22 11:59:31 +00:00
Sunny Goyal 506165689f Revert "Finish recents animation on activity destroyed."
This reverts commit 0fd3b13d01.

Reason for revert: b/236514960
Bug: 228137694
Bug: 230373809

Change-Id: Ifed5f2a13fda4409982d548e3212bd16c81b63bc
2022-06-22 11:59:13 +00:00
wilsonshih 9840bdaa13 [Shell Transition]Fix live tile be hidden by wallpaper leash.
A generic fix to specific layers for live tiles/wallpaper.
Because there cannot sure the absolutely z-order of recents surface, we
can always set wallpaper layer to bottom, and set the z-order of live
tiles to either MAX or MIN + 1, so live tile can always above wallpaper,
also the live tile can be show above/below recents surface based on
mDrawsBelowRecents.

Test: enable shell transition, open app then entering recents, verify
the live tile stay visible when entering recents. And the shared
indicators visible when state transition complete.
Test: also verify above test for legacy transition.
Bug: 236410500

Change-Id: I0f86d7617af1d96c28783320248af64f576bd570
2022-06-22 15:21:49 +08:00
Schneider Victor-tulias 6c71fe71bd Merge "Fix taskbar unstash animation delay when launching a split task." into tm-qpr-dev 2022-06-21 19:38:46 +00:00
Schneider Victor-tulias bfde6b2e5d Fix a potential null-pointer onActivityDestroyed
Fixes: 234082544
Test: started recents from a large screen and phone
Change-Id: I54ee93793ec146d1b0b0f00f23256aaca5975bc0
2022-06-21 12:34:02 -07:00
Schneider Victor-tulias dfadafe45b Fix All set activity not drawing on initial swipe. am: 4d18da78c0 am: 3a126d78a9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18930603

Change-Id: Ie74ad15bc52082615cabced4f86c33e69de9560c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-20 08:10:49 +00:00
Schneider Victor-tulias 4d18da78c0 Fix All set activity not drawing on initial swipe.
The launcher was not properly preloading upon launching the All Set Activity. The Launcher would only start loading once the user started swiping up. This would stop the all set activity from drawing.

Test: Factory reset with a restore and tested the all set page.
Fixes: 234536107
Change-Id: I6bcb805ea6c43fb993f2b57499444ea62bcc37e1
2022-06-16 20:38:24 +00:00
Luca Zuccarini c703f3a3e0 Unify the source of truth for NORMAL <> ALL_APPS transitions.
Bug: 231682175
Bug: 234812580
Test: manual
Change-Id: I5b66735474915d7a59bda337f67df37ff397908a
2022-06-16 16:40:26 +00:00
Tony Wickham d100f6825f Merge "Clear MotionPauseDetector onRecentsAnimationCanceled()" into tm-dev am: 9d5f64adf1 am: 1cba5f9d47
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18914942

Change-Id: Ib76e6458f71282ebb7753db8c4ea9b671fb0fa19
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-16 15:28:03 +00:00
Tony Wickham 9d5f64adf1 Merge "Clear MotionPauseDetector onRecentsAnimationCanceled()" into tm-dev 2022-06-16 14:55:48 +00:00
Alex Chau ccc55f1668 Merge "Detect force visible nav bar based on kids mode." into tm-qpr-dev 2022-06-16 13:55:14 +00:00
Schneider Victor-tulias e164995f9e Fix taskbar unstash animation delay when launching a split task.
Fixes: 232033354
Test: switched between split and unsplit tasks using 3 button nav and gesture nav
Change-Id: I9a4e2eb08e9970540093e3dc60b64a372be2052f
2022-06-15 14:55:37 -07:00
Alex Chau c1d26448c5 Animate inline QSB between home and apps
- Added a QSB to taskbar to be animated between inline QSB and taskbar
- Passed endValue of taskbar animator to TaskbarController to have aniamtion variation between home -> app and app -> home
- Tuned duartion of taskbar animation and also stagger animation when taskbar is present
- Disabled scaling down of taskbar and inline QSB for home -> app
- Disabled stagger animation of taskbar and inline QSB for app -> home

Bug: 220733187
Test: manual
Change-Id: I4aac0bbc343b992a0472298595770e2bf2a55990
2022-06-15 22:12:29 +01:00
Vinit Nayak d18304ca15 Close all open views for 1P and 3P launchers
* Previously TaskView was closing task menu view, but
that got removed since launcher was doing that on
state transition.
* Only 1P launcher was doing that and not 3P launcher,
moved call to remove open views to parent class

Test: Invoking split on 3P launcher doesn't result in a crash
Bug: 199342537
Change-Id: I6afbe7640ede362a677e15a33409a7cabdb8cca9
2022-06-15 14:09:49 -07:00