Commit Graph

28165 Commits

Author SHA1 Message Date
TreeHugger Robot a3e412ea2d Merge "Don't handle task appeared during second quick switch transition" into ub-launcher3-rvc-dev am: 75dcd82a67
Change-Id: Ie8e09210f9821fcc63c051ebf3789035bd4f5f4f
2020-05-13 04:09:22 +00:00
TreeHugger Robot 75dcd82a67 Merge "Don't handle task appeared during second quick switch transition" into ub-launcher3-rvc-dev 2020-05-13 03:35:23 +00:00
vadimt 0790cef41c Dumping view hierarchy before swiping to Overview
Bug: 156044202
Change-Id: I21a11a7a55103cffbc05ddeeb93ecc4f6f4063e7
2020-05-12 18:25:32 -07:00
Tracy Zhou 10ccc347a8 Merge "Fade in grid preview" into ub-launcher3-rvc-dev am: 9a1becebec
Change-Id: I8a849e11e5b5e4749756d606febbc64ee260ec53
2020-05-13 00:47:55 +00:00
Tracy Zhou 9a1becebec Merge "Fade in grid preview" into ub-launcher3-rvc-dev 2020-05-13 00:45:37 +00:00
TreeHugger Robot 6787f85f91 Merge "Adds westworld logging events for drag and drop on target bar buttons." into ub-launcher3-rvc-dev am: 0276b7e2a7
Change-Id: Icea3c424ed61a32251962a76f5e8c3b469dcbef8
2020-05-13 00:41:38 +00:00
TreeHugger Robot 0276b7e2a7 Merge "Adds westworld logging events for drag and drop on target bar buttons." into ub-launcher3-rvc-dev 2020-05-13 00:31:19 +00:00
TreeHugger Robot 6097c36aea Merge "[Overview Actions] Put the taskview in the middle of the screen." into ub-launcher3-rvc-dev am: 7c604edf92
Change-Id: Icfd6a7d2a74dcdd355ff4afdf68b385cd4675996
2020-05-12 23:19:19 +00:00
TreeHugger Robot 7c604edf92 Merge "[Overview Actions] Put the taskview in the middle of the screen." into ub-launcher3-rvc-dev 2020-05-12 23:01:25 +00:00
Tony Wickham f6be443eb4 Don't handle task appeared during second quick switch transition
Instead of using shared gesture state, use the swipe handler's
internal state. This ensures that only the handler that started
the new task can finish the controller for it (i.e. starting a
new gesture, which creates a new handler, will ignore the
onTaskAppeared() that the previous handler initiated).

Test: Quick switch to delayed task A, then quick switch to B right
before onTaskAppeared() such that we get onTaskAppeared() during
the transition (easier to repro if you increase animation durations
with springs off). Before this change, A appeared on top.

Bug: 156412706
Change-Id: Ic7d3cd43399005095b2e7c7382218edffefdc27b
2020-05-12 17:46:02 -05:00
TreeHugger Robot 1f38375426 Merge "Generating a long-press even only when it's expected" into ub-launcher3-rvc-dev am: 7839eaa9b7
Change-Id: I546f62ecf5337d342faace36b4689b0aa1de72bc
2020-05-12 22:28:46 +00:00
Sunny Goyal a0b81d3488 Adding state manager to fallback recents activity am: 3f948e3f42
Change-Id: I0d957c6966ff43edb7a74a867e436cfb58dbae07
2020-05-12 22:28:35 +00:00
TreeHugger Robot 7839eaa9b7 Merge "Generating a long-press even only when it's expected" into ub-launcher3-rvc-dev 2020-05-12 22:22:52 +00:00
thiruram ff48451ecd Adds westworld logging events for drag and drop on target bar buttons.
This would add below set of LauncherEvents:
* LAUNCHER_ITEM_DROPPED_ON_REMOVE
* LAUNCHER_ITEM_DROPPED_ON_CANCEL
* LAUNCHER_ITEM_DROPPED_ON_DONT_SUGGEST
* LAUNCHER_ITEM_DROPPED_ON_UNINSTALL
* LAUNCHER_ITEM_UNINSTALL_COMPLETED
* LAUNCHER_ITEM_UNINSTALL_CANCELLED

Sample Logs: https://docs.google.com/document/d/1CBP2yTcXdFhPdNG5ZmWFKSgd8mDbMevY-akVlUXPLDo/edit#bookmark=id.3ndtl1dalhdt

Bug: 152978018
Change-Id: I055a1b001524753eea71384b4765522f5946fbbc
2020-05-12 15:09:28 -07:00
Becky Qiu 073cbca370 [Overview Actions] Put the taskview in the middle of the screen.
Using horizontal padding 48dp to adjust the scale of the taskview and put it in the middle of the vertical space.

Test: local
Bug: 155444014
Change-Id: Iee6096baf18ae1106c24c83b4675abd4d3ff4d4f
2020-05-12 15:00:54 -07:00
Tracy Zhou 0d880c876b Fade in grid preview
Fixes: 156406762
Test: https://drive.google.com/open?id=1JshUMjd1ASjHcAhnAiG3PEC-6wCRY7EE
Change-Id: I6a99650796fe64a6c11ee9fad6904b14373c6363
2020-05-12 14:43:44 -07:00
Tony Wickham f0c7966a77 Only set spring end value if animation wasn't canceled
Animations should only be canceled (as opposed to ended) if the
caller is intending to update the state from there. In that case,
we shouldn't jump to the end value.

Bug: 155335494
Change-Id: I93a21f0e2e1923ccdfab890adcb58c49ceb98a28
2020-05-12 16:22:03 -05:00
Sunny Goyal b78ea4b4fc Changing RecentsView layout based on the split screen task size
Bug: 155816922
Change-Id: I33f69d72f8a27e3621d029c6ee4045c3664f3ac9
2020-05-12 14:04:19 -07:00
Sunny Goyal 3f948e3f42 Adding state manager to fallback recents activity
Bug: 156398988
Change-Id: Id0a106ef888ade5223940ac8243108c39b4d6b98
2020-05-12 13:31:48 -07:00
TreeHugger Robot 6043914ab3 Merge "Simplifying animation creating logic for app-to-overview" into ub-launcher3-rvc-dev am: 7dcd4d6ed6
Change-Id: Ic8e649d1bf85bf2c89052fbad8876a56f0c1fb70
2020-05-12 18:51:49 +00:00
TreeHugger Robot 7dcd4d6ed6 Merge "Simplifying animation creating logic for app-to-overview" into ub-launcher3-rvc-dev 2020-05-12 18:42:22 +00:00
TreeHugger Robot 50e5b48987 Merge "Even more additional logging for pause non-detection" into ub-launcher3-rvc-dev am: 2830c99bee
Change-Id: I79cb9f2505f63520d68e6171c78e679d2f7a393b
2020-05-12 18:23:53 +00:00
TreeHugger Robot 2830c99bee Merge "Even more additional logging for pause non-detection" into ub-launcher3-rvc-dev 2020-05-12 17:35:42 +00:00
vadimt 60bc43d0cc Even more additional logging for pause non-detection
Bug: 156044202
Change-Id: I7c1a8a9ef4149bd64597908c0b6797cfe33fd4b6
2020-05-12 09:51:24 -07:00
Sunny Goyal 4888790bde Simplifying animation creating logic for app-to-overview
Removing optional 'shouldAnimate' flag. This was false only in 3-button mode but
the code was also handling animation, leading to inconsistent expectations. Instead
always assuming animation and finishing the animation promptly.

Change-Id: Ic56476dc5ea64c9a7d7e9744f3e33cd61dfde9e8
2020-05-12 16:37:27 +00:00
TreeHugger Robot 0d509972b3 Merge "Fixing pullback factor not initialized after launcher process death" into ub-launcher3-rvc-dev am: b8759f9b26
Change-Id: I756285734bbd876b378f0577608bd169a87f1dcb
2020-05-12 03:18:35 +00:00
TreeHugger Robot b8759f9b26 Merge "Fixing pullback factor not initialized after launcher process death" into ub-launcher3-rvc-dev 2020-05-12 03:06:29 +00:00
TreeHugger Robot cce22e3aae Merge "Make educational half-sheet black in dark mode" into ub-launcher3-rvc-dev am: 3d3c41a3a6
Change-Id: I6475e7778377bccec0ab6ab3c6fd9f16c1710e7c
2020-05-12 01:21:38 +00:00
TreeHugger Robot 3d3c41a3a6 Merge "Make educational half-sheet black in dark mode" into ub-launcher3-rvc-dev 2020-05-12 01:07:21 +00:00
TreeHugger Robot 1095b4e4e8 Merge "Abstracting out state handler logic into base classes so that it can also be used in different activity" into ub-launcher3-rvc-dev am: eb0136b7c4
Change-Id: I951cd086091f97ab5b61635af74582287e3a449e
2020-05-12 00:32:10 +00:00
TreeHugger Robot eb0136b7c4 Merge "Abstracting out state handler logic into base classes so that it can also be used in different activity" into ub-launcher3-rvc-dev 2020-05-12 00:29:52 +00:00
TreeHugger Robot 40ce12ae48 Merge "Restart running task if another task was started but not appeared" into ub-launcher3-rvc-dev am: badfff4469
Change-Id: I6c4e7f72b4dce305c34f7d5fd0b257e6d6f18b3c
2020-05-12 00:27:26 +00:00
TreeHugger Robot badfff4469 Merge "Restart running task if another task was started but not appeared" into ub-launcher3-rvc-dev 2020-05-12 00:03:52 +00:00
TreeHugger Robot 64f394c317 Merge "Make darkmode allapps backgrounds solid black" into ub-launcher3-rvc-dev am: c8b81d72a4
Change-Id: Id81c556b695665992ae32d5d3b38c1a01880dda9
2020-05-11 23:53:48 +00:00
TreeHugger Robot 3b8d75ead7 Merge "String translation updates" into ub-launcher3-rvc-dev am: e123ac8fb5
Change-Id: Ib3ac2d22a6628746681b54daedfbad6bfd74dccb
2020-05-11 23:53:42 +00:00
TreeHugger Robot 9f7e56f6d7 Merge "Remove bold from work paused overlay text" into ub-launcher3-rvc-dev am: c03cfeec36
Change-Id: I9b098e6088ec8f4870277a8aec2c21f98b48a73a
2020-05-11 23:53:33 +00:00
TreeHugger Robot c69f309b53 Merge "Even more logging for pause non-detection" into ub-launcher3-rvc-dev am: 072a6e01bc
Change-Id: I96c55b22decc3bc7a5e724c70b69a76da3e511ea
2020-05-11 23:53:19 +00:00
TreeHugger Robot 735d6bf871 Merge "Resolve Test flakes" into ub-launcher3-rvc-dev am: 3d668090af
Change-Id: I36d5980cd1e8176c599c9c4c705028bba599b5b2
2020-05-11 23:53:11 +00:00
TreeHugger Robot c8b81d72a4 Merge "Make darkmode allapps backgrounds solid black" into ub-launcher3-rvc-dev 2020-05-11 23:44:30 +00:00
TreeHugger Robot e123ac8fb5 Merge "String translation updates" into ub-launcher3-rvc-dev 2020-05-11 23:44:00 +00:00
TreeHugger Robot c03cfeec36 Merge "Remove bold from work paused overlay text" into ub-launcher3-rvc-dev 2020-05-11 23:43:20 +00:00
TreeHugger Robot 072a6e01bc Merge "Even more logging for pause non-detection" into ub-launcher3-rvc-dev 2020-05-11 23:42:30 +00:00
TreeHugger Robot 3d668090af Merge "Resolve Test flakes" into ub-launcher3-rvc-dev 2020-05-11 23:40:43 +00:00
Sunny Goyal 35e7d38681 Abstracting out state handler logic into base classes so that it can
also be used in different activity

Change-Id: Ic5e60b21e1429c71f1cd4e7041e70bf4fc9761b7
2020-05-11 16:38:26 -07:00
Tony Wickham a57000c33d Restart running task if another task was started but not appeared
If we just finish the controller to resume the running task like
we normally would, the delayed task will appear on top when it's
ready. Instead, we need to start the original task in this case.

- Move mLastStartedTaskId to GestureState, shared between swipe
  handlers when continuing the gesture.
- Update logic to change LAST_TASK to NEW_TASK if a task was
  started (but not appeared) during the same gesture; likewise,
  only change NEW_TASK to LAST_TASK if no task was started.
- Finish the controller when successfully starting the task
  that already appeared, since we won't get onTaskAppeared().

Bug: 156132424
Change-Id: I1e9af297840745ab3d5e90214425f10a2616d90a
2020-05-11 18:26:06 -05:00
TreeHugger Robot 5ae89c4789 Merge "Fixing current task not overshooting on swipe-up in overview" into ub-launcher3-rvc-dev am: ed31f24dbf
Change-Id: I7005d712a77453d138fc3f9997213d63b307a394
2020-05-11 23:14:49 +00:00
vadimt d5cb9a7a18 Even more logging for pause non-detection
Bug: 156044202
Change-Id: I31fead73a6a64617aea67e66b01c365841229b92
2020-05-11 15:56:54 -07:00
TreeHugger Robot ed31f24dbf Merge "Fixing current task not overshooting on swipe-up in overview" into ub-launcher3-rvc-dev 2020-05-11 22:55:45 +00:00
Sunny Goyal 84376f305b Fixing current task not overshooting on swipe-up in overview
> also fixing flicker during swipe-up when scroll is applied before recents
has been initialized

Bug: 154761552
Change-Id: I45c2b6801b8b87097c2816e26a234bab41b72ed4
2020-05-11 14:39:32 -07:00
TreeHugger Robot 40c15fdba2 Merge "Temporarily removes Settings button from Back tutorial." into ub-launcher3-rvc-dev am: 6459397e3d
Change-Id: Ia46921c839292a828f42a6f6d4d6921b35b1bdf6
2020-05-11 21:22:08 +00:00