Commit Graph

10334 Commits

Author SHA1 Message Date
Sunny Goyal 3219c4f3c8 Removing dummy activity added for preview development
Bug: 121414492
Change-Id: I8ae4643f871af259dab04a5b37acfb49d59d6261
2018-12-27 08:16:10 -08:00
Tony f80e893163 When undoing a removal, always return to the page it came from
We were already returning to the current page, but this wasn't
always right, e.g. when removing the last item on the last page.
So now we mark the page the item was removed from, and bind that
page first when undo is clicked.

This also addresses an issue where we incorrectly returned to the
first page if currentPage = INVALID_RESTORE_PAGE, which happens if
there are no items on the first page.

Bug: 118846684
Change-Id: I4ec1f64b24ba1cc308ce08bfb3111b5981fae99b
2018-12-21 12:21:53 -08:00
Hyunyoung Song a7a9583bb8 Remove IconShapeOverride
Bug: 120736782
Change-Id: Iee44f10ff2b9ec447ae74d9ad6a0aa3668c401d6
2018-12-19 17:16:56 -08:00
Vadim Tryshev 57e98b8006 Merge "Adding tests that would reliably reproduce shifted search." into ub-launcher3-master 2018-12-17 23:21:55 +00:00
vadimt 00d4255272 Adding tests that would reliably reproduce shifted search.
This would guaranteed to repro b/118441555 before it was fixed.

The test doesn't use the most powerful feature of race condition
reproducer, which is enumerating all possible event sequences.

Instead, it uses explicit repro sequences, which makes the test much
faster.

Bug: 120628042
Test: The added test
Change-Id: I89a7a9964f160a8a20ba3d9dda2f248237713014
2018-12-17 14:41:20 -08:00
Tony Wickham bf560728c1 Merge "Remove notification dot if app is disabled" into ub-launcher3-master 2018-12-14 00:10:24 +00:00
vadimt d177aba4a2 Fixing ConcurrentModificationException
Bug: 120664974
Test: Manual
Change-Id: I67e88c6980fbabb9afb9f4946baf731852f19b19
2018-12-13 11:53:56 -08:00
Sunny Goyal c5939393a9 Bye bye workspace screens table
Removing a separate table for workspace screens. List of screens are
automatically parsed using the items in the favorites DB. Order of the
screen based on the screen id and rearranging screens is no longer
supported. In case the screens need to be rearranged, all the items
in the favorites db will need to be updated with new screen ids.

This makes backing up the DB (in the same database) easier as only
one table needs to be duplicates.

Change-Id: I8ba947a898f637d780e2f49925e78604263126e8
2018-12-10 11:43:35 -08:00
Sunny Goyal 415f173331 Changing the format for device profile definition
Device profiles are defined such that the grid size is fixed
and only the icon and text sizes change. For every grid size option
there are multiple display configurations.

Bug: 118758696
Change-Id: I54aac9106c576324b02530913c447e849b4ae1da
2018-12-07 00:06:25 -08:00
TreeHugger Robot dab230f63c Merge "Add framework for reliably reproducing race conditions." into ub-launcher3-master 2018-12-07 07:14:01 +00:00
Vadim Tryshev 0d4ac57128 Add framework for reliably reproducing race conditions.
Bug: 120628042
Test: RaceConditionReproducerTest
Change-Id: Id658e2b0da6af186b76501ff16edbd135dda3c9b
2018-12-06 16:11:18 -08:00
Sunny Goyal 25849b0a27 Fixing widget entering drag mode when clicked on an empty area
Bug: 119623336
Change-Id: I9e2281f57f07d98a414febb1e3052cb89ef5cb60
2018-12-06 04:02:07 -08:00
Tony Wickham e2c724204e Merge "Remove some obsolete notification badging code" into ub-launcher3-master 2018-12-05 21:20:14 +00:00
Tony Wickham 7120490595 Merge "Rename "badges" to "dots" where appropriate" into ub-launcher3-master 2018-12-05 21:19:57 +00:00
Sunny Goyal c6726f5c36 Merge "Adding support for launcher preview generation" into ub-launcher3-master 2018-12-05 09:10:17 +00:00
Sunny Goyal ef92b82778 Adding support for launcher preview generation
Creating a utility class which generates a launcher preview
for a provided InvariantDeviceProfile

Bug: 118758696
Change-Id: I0aebeb6eed37f72edd1cc305e58eece305aae3ff
2018-12-04 20:19:14 -08:00
Tony Wickham c70f2fd5f1 Remove some obsolete notification badging code
Now that we only show dots instead of badges, we can simplify some logic
and remove a couple unused methods.

Change-Id: I72056eeb12e8968ec67b4c5b3a450d2ed5d4ee84
2018-12-04 15:58:56 -08:00
Tony Wickham 1e58cd7270 Remove notification dot if app is disabled
For instance, when turning off work profile, all work profile apps are
disabled and notifications are removed. Previously, we weren't updating
the dots in this case because we ignore unsupported ItemInfos (e.g.
disabled items in this case).

Note that this was only user-visible for Folders, because regular
shortcuts were updated when the disabled state changes.

Bug: 111791593
Change-Id: I3c49e6e3bf18753a868eb993b29c77abbefd3466
2018-12-04 14:42:52 -08:00
Tony Wickham f34bee819c Rename "badges" to "dots" where appropriate
This will reduce confusion with the other "badging" concept we use for,
e.g. work profiles. It is also consistent with the external name
"notification dots".

Change-Id: I2a2c9d96dc0d6284eb0c48adc78a856271caad4d
2018-12-04 10:46:40 -08:00
Hyunyoung Song 4d64da3259 Merge "setVisibility should not propagate focus on children views" into ub-launcher3-master 2018-12-01 01:21:51 +00:00
TreeHugger Robot ddf3592803 Merge "Move BadgeRenderer to iconloader library" into ub-launcher3-master 2018-12-01 00:37:30 +00:00
Tony Wickham 8912b04c80 Move BadgeRenderer to iconloader library
- Rename BadgeRenderer to DotRenderer
- Move drawing parameters to new class DrawParams
- Add leftAlign param
Change-Id: I69de56c13280ba5e7e1ea3868c23edfac01012e9
2018-11-30 16:28:56 -08:00
Hyunyoung Song 63dd081b36 setVisibility should not propagate focus on children views
Bug: 120064903
Change-Id: I2d58d1ef89db7749f9e6551c716b3cc0567915b3
2018-11-30 13:31:37 -08:00
Tony Wickham 35903e1d9d Merge "Fix end state when animating launcher after swipe up from an app" into ub-launcher3-master 2018-11-30 17:21:59 +00:00
Sunny Goyal b891eebbb5 Fixing shortcut icons are not getting correct color extraction.
> Avoiding color extraction for icons which have already be evaluated
> Fixing color extraction from hardware bitmaps

Bug: 111343544
Change-Id: I624866e892465684871fbc130003e32945d86460
2018-11-30 01:41:56 -08:00
Tony 6cfb0edb41 Fix end state when animating launcher after swipe up from an app
Previously we were comparing the controller's progress at the time of
the end of the animation... which is always 1. Instead, we should be
comparing the effective final progress based on the interpolator.

Change-Id: I18110b5a3b914839860931187f39cfa11182b3e2
2018-11-29 11:35:16 -08:00
TreeHugger Robot 429395f043 Merge "Moving autority definition to a separate file, so that it can be easily customized using android studio" into ub-launcher3-master 2018-11-28 00:59:35 +00:00
Sunny Goyal 4276e7b649 Moving autority definition to a separate file, so
that it can be easily customized using android studio

Change-Id: I17f4f4511c2af5d382727769d1b74413f233d500
Bug: 120079798
2018-11-27 23:20:32 +00:00
TreeHugger Robot 33fd26f025 Merge "Moving Pause button to the left of the context menu header" into ub-launcher3-master 2018-11-26 23:36:21 +00:00
Vadim Tryshev fdfeb6dd3b Moving Pause button to the left of the context menu header
See this mock:
https://www.google.com/url?q=https://docs.google.com/presentation/d/1AepsnLeKcRhjMW35SkB5yMKO3u6waigug8Tyfe0LO5o/edit%23slide%3Did.g455d187f2a_0_45&sa=D&ust=1542320415002000&usg=AFQjCNH-jsy5THG1WqxjeYbj628QFMJKvQ

Bug: 117888000
Test: Manual
Change-Id: I1edbc569347f09f0806ad6749735c3dec198277a
2018-11-26 14:30:52 -08:00
TreeHugger Robot 4a5bc9f8b0 Merge "Making CellLayout inflatable without LauncherActivtiy" into ub-launcher3-master 2018-11-21 01:21:49 +00:00
TreeHugger Robot d2fe2010f9 Merge "Removing Launcher dependency in search box layout" into ub-launcher3-master 2018-11-21 01:14:42 +00:00
Sunny Goyal ab770a10b9 Making CellLayout inflatable without LauncherActivtiy
This will allow creating cellLayout with a different device profile
or a different activtiy which can be used when displaying multiple
activities in multi-display or generating a preview for changing
display properties.

Change-Id: I386731d95e33c48bdef270ce9c0d3e9feefb6262
2018-11-20 17:11:13 -08:00
Ryan Lothian 1ede836b9b Merge "Get Robolectric tests passing" into ub-launcher3-master 2018-11-20 22:54:15 +00:00
Sunny Goyal 33611be973 Removing Launcher dependency in search box layout
Bug: 118758696
Change-Id: Id918c44b8bd2a97ab577481b7584afbe56e8a591
2018-11-20 13:53:33 -08:00
TreeHugger Robot 1b5d7ea6f8 Merge "Moving some methods from various activities to the base interface" into ub-launcher3-master 2018-11-19 21:50:22 +00:00
Sunny Goyal fe8e4a90be Moving some methods from various activities to the base interface
This allows creating some custom views in the absence of
activity context

Bug: 118758696
Change-Id: I23999290e972a2a8cbd725a521a4e0c7c2e5023e
2018-11-19 13:04:35 -08:00
Ryan Lothian d813e79ecc Get Robolectric tests passing
+ Default SDK 28 -> 26, as >26 isn't available for
  unbundled make builds.

+ @Ignore 3 test methods that currently fail with
  resource-related errors.

Test: RunLauncherRoboTests succeeds locally
Bug: 119567714
Change-Id: Id6ea42cef050119d892b5af2b1ba1afc4c4f0b28
2018-11-15 20:17:33 +00:00
Jonathan Miranda a5c67901f8 Merge "Clean up span calculations in LauncherAppWidgetProviderInfo." into ub-launcher3-master 2018-11-15 00:35:55 +00:00
Winson Chung 3386fbf674 Ensure base StatsLogManager can be instantiated
Bug: 119500924
Change-Id: Ia1adfa75147508ff1ff2a119cfba62b034ae4604
2018-11-14 15:11:48 -08:00
TreeHugger Robot 9c9625a15f Merge "Moving come tests to Roboelectric" into ub-launcher3-master 2018-11-13 23:22:53 +00:00
Vadim Tryshev 9d9310ba72 Merge "Fix showing strange Launcher on pressing Home." into ub-launcher3-master 2018-11-13 01:28:24 +00:00
Vadim Tryshev e45e60140e Fix showing strange Launcher on pressing Home.
Bug: 118441555
Test: manual, race condition repro, TaplTests
Change-Id: I8b09895558f8baa72eb3a794724170417fadfda6
2018-11-12 16:11:55 -08:00
Sunny Goyal 06a07e9748 Moving come tests to Roboelectric
> Fixing resource loading in robo tests

Change-Id: Id5b8a0e4916a2a200da7a41b03f19846834beb1f
2018-11-12 10:49:59 -08:00
Tony Wickham 4cdf0bd49f Merge "Add ToggleableGlobalSettingsFlag for QUICK_SWITCH" into ub-launcher3-master 2018-11-10 00:48:54 +00:00
Sunny Goyal 202fabfe10 Adding reusable version of IconCache and IconFactory
> Adding resource based allowing projects to control cache behavior
> Fixing missing comments from ag/5470467
> Adding support for no-immemory cache

Bug: 115891474
Change-Id: I691206805430cd93d3be78119bc249cefd79790a
2018-11-09 15:44:07 -08:00
Tony 94c5b83a7e Add ToggleableGlobalSettingsFlag for QUICK_SWITCH
- ToggleableGlobalSettingsFlag saves/loads from Settings.Global rather than
  SharedPrefs, allowing other processes to update the setting as well.
- ToggleableGlobalSettingsFlag#get() reads from storage every time.
- Add the flags' descriptions to the feature flags settings UI.

Change-Id: I9cfc44ddaa5d9e223cf77a9b2475f8d25757d1fb
2018-11-09 15:27:24 -08:00
TreeHugger Robot 7b3c12f90e Merge "Allow overriding flags in Robolectric tests" into ub-launcher3-master 2018-11-09 16:08:29 +00:00
Sunny Goyal 1a9cbd3c88 Moving BaseIconCache to icon lib
Change-Id: I4fb56dcd6231a848d152e690edaf8885efbc995a
2018-11-08 15:18:25 -08:00
Ryan Lothian af0c0e8b0d Allow overriding flags in Robolectric tests
Bug: 117235618
Change-Id: Ibc01a4fe1de6a38d9fc620e4601fdb2282bf03e1
2018-11-08 17:25:23 -05:00