Commit Graph

10334 Commits

Author SHA1 Message Date
Tony ae087dc9b8 Fade out scrim when swiping to home
Bug: 134517106
Change-Id: Ica725e3a327c1c069e3859732ea6a878d361a3d8
2019-06-04 19:25:03 -07:00
vadimt 8474ab2b9d Merge "Fixing All Apps's getting stuck in a non-updating state" into ub-launcher3-qt-dev
am: 8789aa05a1

Change-Id: I583ea8c9e6920aa072fa29087c51ce817e6b9d63
2019-06-04 17:51:24 -07:00
TreeHugger Robot f17eb616a8 Merge "Some RecentsView layout fixes" into ub-launcher3-qt-dev 2019-06-04 21:34:19 +00:00
Sunny Goyal 1b52c7e5de Some RecentsView layout fixes
> Only creating task overlay for one view at a time
> Fixing setOverviewStateEnabled called twice when going
  between OVERVIEW and BACKGROUND state

Bug: 132815672
Bug: 122345781
Change-Id: I51ac5b0744af87194eca08e07fd2c75b8fa0d3e0
2019-06-04 14:17:30 -07:00
Perumaal Shanmugam 067bce7d8a Merge "Re-enable chips in qt-r1-dev" into ub-launcher3-qt-r1-dev 2019-06-04 17:29:10 +00:00
TreeHugger Robot 8789aa05a1 Merge "Fixing All Apps's getting stuck in a non-updating state" into ub-launcher3-qt-dev 2019-06-04 16:37:58 +00:00
vadimt 3ca5280186 Fixing All Apps's getting stuck in a non-updating state
Normally, if all apps is open, and an app installs/uninstalls/updates,
All Apps will immediately reflect this.

However, depending on something subtle in the intensity of the swipe
gesture that brought All Apps, all apps will freeze, and won't update.

This frozen state will go away after scrolling in all apps, iteration
with an icon and, generally, any tap interaction with All Apps.
Otherwise, it will stay until it's closed and opened again via a gesture
with a different pattern.

The reason is in the code that freezes All Apps updates during user
interactions with all apps.

For example, during scrolls. Or while the user holds an icon, expecting
to see a context menu; in this case an update would cause the menu to
not appear, which is somewhat annoying.

The motivation to add this code was to solve a category of lab-only
flakes when a context menu couldn't open because the lab device was busy
with post-flash activities.

The code incorrectly assumed that after ACTION_DOWN, we are guaranteed
to get either UP or CANCEL, which is wrong.

It's after *consumed* ACTION_DOWN that we'll get these events.

The fix still solves the user's and tests' problems that the code was
supposed to solve.

Bug: 134442147
Change-Id: I9db74a33ecf93b1dc6bc69df301f7f542dea2a40
2019-06-03 18:35:52 -07:00
Sunny Goyal 7241d7cfe5 Merge "Removing user locked change in LauncherAppState" into ub-launcher3-qt-dev
am: ce0c093133

Change-Id: Ib85ff9f162f4511726d270e9d1ab94734c04e054
2019-06-03 16:55:12 -07:00
TreeHugger Robot ce0c093133 Merge "Removing user locked change in LauncherAppState" into ub-launcher3-qt-dev 2019-06-03 23:44:58 +00:00
Sunny Goyal d17a951df8 Removing user locked change in LauncherAppState
The process will crash anyway when loading sharedPreference. So
we do not need any extra check to cause the same crash.

Bug: 134094839
Change-Id: Icfd4406ff601d6b9a75bd95ddcecb9869f7e7fa2
2019-06-03 23:19:02 +00:00
TreeHugger Robot 0f405d78d7 Merge "Remove unused hints code." into ub-launcher3-qt-r1-dev 2019-06-03 23:02:01 +00:00
Hyunyoung Song ed45267bf9 Merge "Add shape detection logic only for circle icons" into ub-launcher3-qt-dev 2019-06-03 22:34:02 +00:00
Zak Cohen f3231f417d Remove unused hints code.
This layout is handled by the provider of the hints now.

Test: manual
Change-Id: Ifc0db2395a7503b1b03dcb796961ef6647c0413b
2019-06-03 14:58:18 -07:00
Hyunyoung Song f69426c484 Add shape detection logic only for circle icons
b/119330044

Change-Id: I93042effa8417167d844f073275e8b941e861e60
2019-06-03 14:05:20 -07:00
Perumaal S 2461d61e14 Re-enable chips in qt-r1-dev
Fixes: 134164918
Change-Id: Ib5441a40ad8043afbe32d6c4c40808676cdcdb20
2019-06-03 10:21:47 -07:00
Adam Cohen acdde3d750 Fix issue where Workspace scrolling doesn't work
=> The WorkspaceTouchListener was relying on receiving TOUCH_DOWN in order to
   clear its state. This is not guaranteed; ie. when touches begin above
   children of the workspace (icons or widgets)

=> Any invocation of the Workspace long press menu would trigger this issue
   and it would persist until a touch went directly onto the Workspace in a
   location without any children.

Bug 132298752

Change-Id: Id8617baaa1ce59dc84758a7c82049329323b04cc
2019-06-01 17:16:59 -06:00
TreeHugger Robot 045dc86d9f Merge "Disable chips in qt_dev" into ub-launcher3-qt-dev 2019-05-31 22:12:40 +00:00
Perumaal S 464dda250b Disable chips in qt_dev
- Not for use in qt_r1_dev

Bug: 134164918
Change-Id: Ib49289060a39a1a5615e762a4e72b105ed166135
2019-05-31 21:28:46 +00:00
vadimt a8f77a6afd More debug tracing for switching to all apps not sending the final event
(to the test)

Bug: 134172603
Bug: 133867119
Change-Id: I00cf3a35daefa23d2e72a89d21e6ce37c8a9a46d
2019-05-31 13:34:24 -07:00
Sunny Goyal 33838e8a2f Letting touch pass even in disabled states
In disabled states, dragLayer should not receive touch anyway. Removing
the additional check to avoid user getting stuck.

Bug: 134062513
Change-Id: Id31a31254377e9a737ecd6e9905e66c54e4eb740
2019-05-31 08:56:13 -07:00
TreeHugger Robot f36e5e002a Merge "Fixing interactive state for background states and notifying LauncherCallback accordingly" into ub-launcher3-qt-dev 2019-05-31 06:01:25 +00:00
Jon Miranda b3c9077c76 Tuning app open/close animation.
* Mostly value changes.
* Added a way to round the corners during swipe up to home animation.

Bug: 123900446
Change-Id: Id61d241d919ba51ced0633585e36b7d93efe30b0
2019-05-30 18:43:22 -07:00
Sunny Goyal e9c6f4cc69 Fixing interactive state for background states and
notifying LauncherCallback accordingly

During quick switch Launcher can get resumed only to be paused again
when launching a new app. Updating the logic for deferred resume to
account for that and moving some additional calls to deferredResume

Bug: 134062513
Change-Id: Ia607f178bc17d45d53fb032a06cd70f9abc6b513
2019-05-30 11:59:29 -07:00
Jon Miranda a1898247ca Hide original icon immediately for app close.
Bug: 123900446

Change-Id: I12d906267dafe80a9dc5d5e39452bddd95b0f748
2019-05-30 11:24:29 -07:00
TreeHugger Robot efd5f86a0a Merge "Hide original icon immediately for app close." into ub-launcher3-qt-dev 2019-05-30 18:06:24 +00:00
Vadim Tryshev 5f642bf783 Merge "Adding debug tracing for a lab-only issue" into ub-launcher3-qt-dev 2019-05-30 17:58:04 +00:00
TreeHugger Robot cae0a80c83 Merge "Disabling seamless rotation in multiwindow mode" into ub-launcher3-qt-dev 2019-05-30 17:47:51 +00:00
Vadim Tryshev 1c9b6293c8 Merge "Add debug tracing for a lab-only flake" into ub-launcher3-qt-dev 2019-05-30 17:46:10 +00:00
Sunny Goyal da14cf8b9f Disabling seamless rotation in multiwindow mode
Bug: 133765491
Change-Id: If68c709fa5b8216d63fc516f16f03bf2aa83172a
2019-05-30 10:32:11 -07:00
vadimt 26185e1fed Adding debug tracing for a lab-only issue
Task doesn't get resumed upon clicking at it.

Bug: 133765434
Change-Id: I8c5c1308041949d94c6982c78b8337ea81ad400f
2019-05-30 10:30:32 -07:00
vadimt 6f871d423b More debug tracing for RemoteActionShortcut
Change-Id: If7bbc0817f4a833243f46ca15dde86ffc573ab58
2019-05-29 18:33:06 -07:00
TreeHugger Robot 1dbec0ef43 Merge "Fix bug where shape reveal progress gets started too early." into ub-launcher3-qt-dev 2019-05-29 21:57:41 +00:00
TreeHugger Robot ea068967ae Merge "Add staggered springs animation when swiping up to home." into ub-launcher3-qt-dev 2019-05-29 21:47:27 +00:00
Jon Miranda c69d1ffd92 Add staggered springs animation when swiping up to home.
Bug: 123900446
Change-Id: I275e34c6dca5b026f272ab216b18651c0df27bc4
2019-05-29 14:32:49 -07:00
Jon Miranda 928fc8d1e2 Fix bug where shape reveal progress gets started too early.
* This caused the shape to not match the window size on app close.

Bug: 123900446
Change-Id: Iaa2c06f19c535f72ae4c080b4bc847d336f1a77d
2019-05-29 14:19:16 -07:00
vadimt 17f9d57ac7 Add debug tracing for a lab-only flake
This time, Launcher doesn't send a completion event upon switching from
Home to all apps.

Bug: 133867119
Change-Id: I3738cf10a14ea288df2dfda387aafda022beb349
2019-05-29 14:10:28 -07:00
TreeHugger Robot ee20f0eeb7 Merge "More logging for lab-only flake when an app doesn't start" into ub-launcher3-qt-dev 2019-05-29 19:35:57 +00:00
TreeHugger Robot 1d43df01a4 Merge "Fix bug where changing the display size does not update the launcher grid." into ub-launcher3-qt-dev 2019-05-29 19:33:58 +00:00
Jon Miranda 7aa9000642 Hide original icon immediately for app close.
Bug: 123900446
Change-Id: I46e54da39e3bf4fe79e0583b52c568c702a9f16a
2019-05-29 11:41:46 -07:00
Sunny Goyal 51f220dac2 Fixing ANR when loader task could run while helding the lock object
During AppWidgetRestoredReceiver, we call forceReload from worker thread
which in turn starts the loader while holding mLock. This causes other
loader calls on UI thread to cause ANR

Bug: 133651528
Change-Id: Iabf983c4319bd6e6ef88e74fe6076289294454f9
2019-05-29 11:07:10 -07:00
Jon Miranda c0f1f4f3af Fix bug where changing the display size does not update the launcher grid.
The bug is caused by launcher saving the grid name and using that grid name
to look for matching display options. This makes sense when changing the grid
size, but doesn't work well when changing the display size.

Example: Initial Pixel display size is set to Default, so we save "normal" as
the KEY_IDP_GRID_NAME. When we change display size to Largest, the
KEY_IDP_GRID_NAME is still "normal" and so we only look at display options
under "normal". Before this, Pixel with display size set to Largest would be
set to "reasonable".

This should be safe change for Q, and we can have a proper fix when we
officially support changing grid size.

Bug: 131867841
Change-Id: If5f3b0a13b90069973e929024b26bd9b9c45a7d8
2019-05-28 16:05:09 -07:00
Jon Miranda ed7d714805 Fix bug where DiscoveryBounce is not cancelled after state change.
Bug: 131768436
Change-Id: I7d389671969a75ae7ec9f9f5cc1326f7105e2071
2019-05-28 14:44:52 -07:00
vadimt 5aef526e95 More logging for lab-only flake when an app doesn't start
I suspect that All Apps gets refreshed around the time of the click.

Bug: 132900132
Change-Id: I6d3053f7d8f998e08ca495c005e14ddece634164
2019-05-28 18:28:09 +00:00
vadimt 2d6cd80bc9 Launcher reports whe 0-button swipe-up gesture pause is detected.
This eliminates an unreliable timeout.

Also removing an unnecessary check for harness that is done by the
called method.

Change-Id: If954580060415cbb2952532c16ea0ae4dc7b9469
2019-05-24 19:28:40 -07:00
Sunny Goyal c62699fd63 Merge "Removing prediciton loading state" into ub-launcher3-qt-dev 2019-05-24 22:01:09 +00:00
TreeHugger Robot 1d847cf266 Merge "Lock launcher rotation during activity transition to allow proper seamless transition at the end" into ub-launcher3-qt-dev 2019-05-24 18:07:08 +00:00
TreeHugger Robot d3dcb497bd Merge "Fix crash when launching some apps which require icons to be loaded on the model thread" into ub-launcher3-qt-dev 2019-05-24 01:24:08 +00:00
Sunny Goyal 9fd2d0ee0a Fix crash when launching some apps which require icons to be loaded on
the model thread

Change-Id: I945a94c458d872b41e44b4b3a2d023f85d8a7c88
2019-05-23 18:13:43 -07:00
TreeHugger Robot f54839bf35 Merge "Remove unnecessary dispatchInsets routing" into ub-launcher3-qt-dev 2019-05-24 00:31:18 +00:00
Sunny Goyal 4c96dd2cd0 Merge "Moving TestInformationProvider to Launcher3 so that it can be used for testing Launcher3 without quickstep" into ub-launcher3-qt-dev 2019-05-24 00:12:14 +00:00