Commit Graph

10334 Commits

Author SHA1 Message Date
TreeHugger Robot 243dd30da3 Merge "Add tracing for non-dragging icon" into ub-launcher3-qt-qpr1-dev 2019-09-05 21:57:01 +00:00
Tony Wickham d785fc289c Merge "Properly prevent All Apps relayouts by avoiding scrollToPosition" into ub-launcher3-qt-qpr1-dev 2019-09-05 21:27:41 +00:00
vadimt 30618db33f Add tracing for non-dragging icon
Bug: 138729456
Change-Id: Ib18f1544f2520509bd982f032bf3ed0c72ca9529
2019-09-05 14:08:39 -07:00
Sunny Goyal ac6f69f78d Lazily binding folder pages and icons
Folders are bound before they are opened and unbound on close. This
allows us to recycle the views in folders

Bug: 139051851
Change-Id: Ic1ed3265c0f583af54d73dab6f2751bc95266ea9
2019-09-05 17:17:11 +00:00
TreeHugger Robot e1335c2359 Merge "Removing flinging via UI Automator" into ub-launcher3-qt-qpr1-dev 2019-09-05 00:13:30 +00:00
vadimt 758a1d983d Removing flinging via UI Automator
UI Automator loses events. Switching to the homemade scrolling.

Bug: 138729157
Change-Id: Ib09bd5714e83eadfc65b54202867bf375e6b47c5
2019-09-04 16:35:19 -07:00
TreeHugger Robot 1bd96b1e96 Merge "Update app open/close animations." into ub-launcher3-qt-qpr1-dev 2019-09-04 22:33:33 +00:00
Jon Miranda 9b78e190fa Update app open/close animations.
- For app open, the icon text remains where it is and only the icon moves.
- Similarly for app close, the icon text remains where it is and fades in
  with the rest of the other icons text.

- With this change, the original view is always "VISIBLE"
  (if BubbleTextView/FolderIcon) but we hide certain elements.

Added video to bug.

Bug: 137200188
Bug: 139885365
Change-Id: I3d20c5f05bc7c0b9d052d8074ac3bfc21531c83d
Merged-In: I3d20c5f05bc7c0b9d052d8074ac3bfc21531c83d
2019-09-04 21:45:05 +00:00
TreeHugger Robot 18c691404f Merge "Update app open/close animations." into ub-launcher3-master 2019-09-04 21:37:26 +00:00
Samuel Fufa c04780c13f Merge "Don't persist invalid previews to cache" into ub-launcher3-master 2019-09-04 20:53:29 +00:00
Jon Miranda dff0de4730 Update app open/close animations.
- For app open, the icon text remains where it is and only the icon moves.
- Similarly for app close, the icon text remains where it is and fades in
  with the rest of the other icons text.

- With this change, the original view is always "VISIBLE"
  (if BubbleTextView/FolderIcon) but we hide certain elements.

Added video to bug.

Bug: 137200188
Bug: 139885365
Change-Id: I3d20c5f05bc7c0b9d052d8074ac3bfc21531c83d
2019-09-04 13:03:18 -07:00
Samuel Fufa 15357968db Don't persist invalid previews to cache
Test: Manual
Bug:137404499
Change-Id: I04a3a0e081fcb8de45601f028398670e7542ed22
2019-09-04 10:01:52 -07:00
Tony Wickham bfdeda96e6 Properly prevent All Apps relayouts by avoiding scrollToPosition
Calling scrollToPosition on RecyclerView internally calls
requestLayout() (to cacluate where to scroll and then go there).
Therefore, we should avoid calling that whenever possible, especially
during transitions. In particular, we can optimize scrollToTop() to not
scrollToPosition() if we are already at the top.

This makes some other workarounds unnecessary, namely setting All Apps
to GONE during system gestures.

Test: Open an app, swipe up, ensure AllAppsRecyclerView doesn't get
onLayout().  If we had scrolled to an app first, we get one layout
in prepareRecentsUi(), but not during the transition.

Bug: 140308849
Change-Id: I62ee341bf5893c121cfc013cc6542559f79d2a42
2019-09-03 16:16:54 -07:00
Andy Wickham 1f3b82ba6e Marks ScrimView unimportant for accessibility when Widgets screen is opened. am: c40872b913
am: 42cbb23d0d

Change-Id: I3f52c9905e73547fa885de33159f75d5fa4e5cb7
2019-09-03 15:35:26 -07:00
Andy Wickham 42cbb23d0d Marks ScrimView unimportant for accessibility when Widgets screen is opened.
am: c40872b913

Change-Id: Ic078f5dd44e57883041433ad001ed4fa684dcba2
2019-09-03 15:29:25 -07:00
Andy Wickham c40872b913 Marks ScrimView unimportant for accessibility when Widgets screen is opened.
This prevents it from holding focus while the Widgets screen is visible
(after using Widgets action from the All Apps caret thingy).

Test: Manually followed steps provided in bug, and issue not seen after this change.
Fixes: 139918680
Change-Id: I280ac97fb7ff9fa67f1c6a1ce9cdfa9e451231eb
2019-09-03 21:20:22 +00:00
Jon Miranda 0b439b446d Merge "Only add promise icon if icon is provided in the SessionInfo." into ub-launcher3-qt-qpr1-dev am: 505a88140e
am: 3105f80e64

Change-Id: Ic8d685a5f9a9f2b2ede483402d6c80e40ec9cdc4
2019-09-03 11:24:46 -07:00
Sunny Goyal f6d5c67402 Merge "Fix bug where we incorrectly change the default profile id of the database." into ub-launcher3-qt-qpr1-dev am: a42681f6d2
am: 71834aa186

Change-Id: Id5169fab20896a5e24e8856b714edc1b5cc738ad
2019-09-03 11:24:14 -07:00
Jon Miranda 3105f80e64 Merge "Only add promise icon if icon is provided in the SessionInfo." into ub-launcher3-qt-qpr1-dev
am: 505a88140e

Change-Id: I1bb3883810bde87ffc3b69b154f2f886c09e6e85
2019-09-03 11:17:48 -07:00
Sunny Goyal 71834aa186 Merge "Fix bug where we incorrectly change the default profile id of the database." into ub-launcher3-qt-qpr1-dev
am: a42681f6d2

Change-Id: I05ca0e24324272e06087221fbbb50a6dbef7ed4f
2019-09-03 11:17:14 -07:00
TreeHugger Robot 505a88140e Merge "Only add promise icon if icon is provided in the SessionInfo." into ub-launcher3-qt-qpr1-dev 2019-09-03 16:27:11 +00:00
Pinyao Ting c2c4d8358c Merge "migrate custom widgets in comply with plugin framework" into ub-launcher3-master 2019-09-03 16:23:37 +00:00
Sunny Goyal a42681f6d2 Merge "Fix bug where we incorrectly change the default profile id of the database." into ub-launcher3-qt-qpr1-dev 2019-09-03 16:23:18 +00:00
Jon Miranda a8c7c0b713 Only add promise icon if icon is provided in the SessionInfo.
- In some cases, SessionInfo is created without an icon until later on
  in the install process. This prevents promise icons with default Android
  logo from appearing.
- This will also prevent apps without a launching activity from appearing
  as a promise icon and then disappearing when the app is installed.

Bug: 135633159
Change-Id: I30adde8bf2cf583bffca8ed878f9cc20d6d41a13
2019-09-03 08:13:09 -07:00
vadimt 7e6ba0e5bf Merge "Adding tracing for mismatch between current and stable states" into ub-launcher3-qt-qpr1-dev
am: 78ebf57e9f

Change-Id: Ifac50ddd7ad0a689722e4911a735cf2d503d177a
2019-08-30 18:10:34 -07:00
TreeHugger Robot 78ebf57e9f Merge "Adding tracing for mismatch between current and stable states" into ub-launcher3-qt-qpr1-dev 2019-08-31 00:55:55 +00:00
vadimt 7bfc820d0c Adding tracing for mismatch between current and stable states
Bug: 140311911
Change-Id: Ie6196015a3f1b35b1403a12540ff7e3290f8cb3d
2019-08-30 17:13:43 -07:00
Tony Wickham 4feff8ba95 Don't update all apps content visibility during home animation
am: 7310bb4b5c

Change-Id: I92382497e4444e2ca1d1951c44646bc5047a6f36
2019-08-30 16:22:51 -07:00
Tony Wickham 7310bb4b5c Don't update all apps content visibility during home animation
We already set the all apps content visibility = GONE at the start of
the gesture to prevent relayouts, but when animating home we were
inadvertently changing it to INVISIBLE, causing a relayout and jank.

Bug: 140308849
Change-Id: I285746f8ac8f3f857282e22ebec8eebd0b98647f
2019-08-30 22:10:55 +00:00
Pinyao Ting c7a6c2979c migrate custom widgets in comply with plugin framework
Bug: 139888225
Change-Id: I8a3d0fe2689ad5ba24b19309728bbad0b6287f71
2019-08-30 12:06:22 -07:00
Jon Miranda 768cb139cc Fix bug where we incorrectly change the default profile id of the database.
Change-Id: I0fafc06f5e28c1fdff77003c984e686719a60cd2
2019-08-30 16:11:00 +00:00
TreeHugger Robot 5fb858e252 Merge "Fix RequestPinItemTest, broken by my manual merge." into ub-launcher3-master 2019-08-29 19:17:44 +00:00
Jon Miranda d49fe3130e [DO NOT MERGE] Fix NumberFormatException for launcher.
Fix is already in ub-launcher3-master: I5094b22ddc77c45590cea1a5f5dead0dc7580abf

Bug: 140076379
Change-Id: I01948cf71ef2e058dc1ef8c506f174856ee09e0d
2019-08-29 19:10:28 +00:00
Samuel Fufa 9fd21056c7 App shortcut overlapping app icon when selecting the app using USB mouse
Test: Manual
Bug:113287687
Change-Id: Ib02c736a312937a9b71d5168d965446b6fc5b7b7
2019-08-28 17:58:14 -07:00
Vinit Nayak b57c577669 Merge "Add unique id to trace logs through recents animations" into ub-launcher3-master 2019-08-26 22:55:01 +00:00
Vinit Nayak 9b26e63f90 Add unique id to trace logs through recents animations
Generate a 3 digit number and append it to
log statements here as well as in platform.

fixes: 134619041
Test: Inspected log output with adb shell dumpsys activity service TouchInteractionService

Change-Id: I52a76dd2950565b246384d7766fdede9e28f5bb9
2019-08-26 15:10:21 -07:00
Samuel Fufa 68c97cf5ac Sorting people by key crashes launcher
Approch: approach: filter out people with null getKey before sorting.

Bug:139436782
Change-Id: I6510a12374ff4fec02c879ff76ba42b1fcdb8281
(cherry picked from commit 8628eb9353)
2019-08-26 18:05:59 +00:00
vadimt 7468bbd2d4 Adding debug tracing for All Apps appearing instead of Overview
am: 197ae725a0

Change-Id: Iab3642e2dcb4f766d490a88aa7a481a1117b98a3
2019-08-23 20:01:22 -07:00
Becky Qiu 71959e59d2 Merge "Move swipe actions on container logging to west world." into ub-launcher3-qt-qpr1-dev
am: 6d0d8969f6

Change-Id: I2229ea7c878ac84b00110235df65ced2f9baf171
2019-08-23 20:01:05 -07:00
TreeHugger Robot 84768d83bc Merge "Dragging an icon from prediction row to workspace crashes launcher" into ub-launcher3-master 2019-08-24 01:40:26 +00:00
Samuel Fufa 08457b0017 Dragging an icon from prediction row to workspace crashes launcher
Test:Manual
Bug:139942462
Change-Id: I5c4a2ca518b08f4ccf47072f8f355e76b7da9424
2019-08-23 14:40:11 -07:00
TreeHugger Robot 300d74fcae Merge "Close shortcut menu after launching from hotseat" into ub-launcher3-master 2019-08-23 21:33:56 +00:00
vadimt 197ae725a0 Adding debug tracing for All Apps appearing instead of Overview
Bug: 139941530
Change-Id: Ia9827c6edd48c559e9602e1e37de83293517ad5e
2019-08-23 12:11:00 -07:00
TreeHugger Robot 2345e6cdc6 Merge "Mouse wheel scroll apps with work profile enabled instead of switching tabs" into ub-launcher3-master 2019-08-23 18:40:40 +00:00
TreeHugger Robot 1b8d309782 Merge "Add support for searchwidget in layout files." into ub-launcher3-master 2019-08-23 18:22:10 +00:00
Samuel Fufa 59cba191c3 Mouse wheel scroll apps with work profile enabled instead of switching tabs
Test: Manual
Bug:79164903
Change-Id: I4b382034ea5b91b24dcc158bd9fa46d64f54cc7a
2019-08-23 11:20:29 -07:00
Becky Qiu 6d0d8969f6 Merge "Move swipe actions on container logging to west world." into ub-launcher3-qt-qpr1-dev 2019-08-23 18:03:02 +00:00
Samuel Fufa ca37b8afe5 Add support for searchwidget in layout files.
Test: Manual
Bug:139703885
Change-Id: I86b36187d95bb5db59dbf6ae2e20373d23e55aa1
2019-08-23 10:58:13 -07:00
Samuel Fufa 03302548ae Close shortcut menu after launching from hotseat
+ Fixed bug where popup menu does not close when animations are disabled.

Test: Manual
Bug:123298377
Change-Id: I863241158e09a618af6243d8afd70549421013d0
2019-08-23 10:54:57 -07:00
Vadim Tryshev 29a8f130fb Merge "Not freezing All Apps during user interactions" into ub-launcher3-qt-qpr1-dev
am: 94dcb3b5bf

Change-Id: I110730f8abb1d63c363aba9939799570bea69f07
2019-08-22 17:32:16 -07:00