Commit Graph

10334 Commits

Author SHA1 Message Date
TreeHugger Robot 6c12641bee Merge "Unifying various tracing calls" into ub-launcher3-master 2019-10-14 22:29:59 +00:00
Sunny Goyal 17c72fbb60 Unifying various tracing calls
Change-Id: Iedf6662ad1d7281b850bdc43b3a1e373ce535ac6
2019-10-14 14:23:19 -07:00
vadimt ce25a2bf68 Adding tracing for a lab-only flake
Bug: 142514365
Change-Id: I9c93ecabbcbad6d4683d595587831d8465e62ee8
2019-10-14 11:34:38 -07:00
TreeHugger Robot 4009493f3c Merge "Wait for the task to be in recents before validation" into ub-launcher3-master 2019-10-12 00:20:10 +00:00
Winson Chung c062580b5a Wait for the task to be in recents before validation
- There are two issues:
  1) Currently the system does not add the task to the task list until
     the activity starting the task has been resumed (to be fixed in a
     follow up platform CL). When the three activities are started in
     sequence, it's possible for one of the activities to not reach the
     resumed state leading to an unexpected number of recent tasks the
     next time it's fetched.
  2) When swiping up, it may take time for getTasks to return and call
     applyLoadPlan, so try and wait until the task views have had a
     chance to be applied before continuing.
  3) Use the launcher activity tracker instead of activity rule since it
     will return the same activity even after the activity is destroyed
- Move the margin handling to the caller instead of the scroll method

Bug: 141580748
Change-Id: I2b7634f5ac6869ba4b369b3bd60e0f63747c0f0b
2019-10-11 17:10:38 -07:00
Jon Miranda 4d6038e63a Merge "Wait until listeners/end runnable is created before checking icon result." into ub-launcher3-qt-future-dev
am: 3d97fdcfdf

Change-Id: I22b11d50b86da3e50726dada351797a5774f3b3f
2019-10-11 11:53:30 -07:00
Jon Miranda 1dd2e48190 Wait until listeners/end runnable is created before checking icon result.
This prevents the case where original icon is in hidden state, then the
view gets recycled and since there is no listener/end runnable the original
icon is left in the hidden state.

Bug: 142120338
Change-Id: I5f5bfa2a7c70d10869f51edf5c40bbaab1ef93bc
2019-10-11 11:03:26 -07:00
Winson Chung bfcee430fe 5/ Remove OverviewInteractionState
- We can move the background call to UiThreadHelper, the last sysui flags
  and back button alpha to SystemUiProxy (and dedupe values there as well)

Bug: 141886704

Change-Id: I22183608700c6d71355597c7a08eefa19f4381fd
2019-10-08 13:15:15 -07:00
Winson Chung 8ff53f7e65 4/ Move SystemUiProxy to its own singleton instead of routing through the model
Bug: 141886704
Change-Id: I415b9ef7b57b525407e3a341b946e3ca66125102
2019-10-08 13:15:13 -07:00
James O'Leary 8d46a3dc00 Merge "Add feature flag + leftward swipe for Compose access." into ub-launcher3-master 2019-10-08 19:03:04 +00:00
TreeHugger Robot f31dab5e02 Merge "Removing static instance of LauncherAppsCompat and unnecessary wrapper classes" into ub-launcher3-master 2019-10-08 18:49:36 +00:00
Jeff Pierce e4607587ed Add feature flag + leftward swipe for Compose access.
Stole ag/9453040 from jspierce@ and added a feature flag.

ag/9453040: Exploratory prototype to test leftward swipe access to
Compose across home screen, launcher, and lock screen. Requires Compose
APK (installed separately).

Change-Id: I15a045976b1eb41392795d3a4f0743f365dec1d2
2019-10-08 14:00:53 -04:00
vadimt 4b5c1ef71b Adding support for intentionally leaking views.
Bug: 139137636
Change-Id: I923d1781daee9ae47eb306ee8fa3c44790c6993f
2019-10-08 17:04:26 +00:00
TreeHugger Robot 86017c9611 Merge "Removing access to LauncherModel.getCallbacks" into ub-launcher3-master 2019-10-08 16:26:12 +00:00
TreeHugger Robot 8ae1151387 Merge "Reduce risk of flakes in memory leak detection tests." into ub-launcher3-master 2019-10-08 16:24:34 +00:00
Samuel Fufa 023188e424 Merge "Scale Icon badges for shortcut and widgets" into ub-launcher3-qt-future-dev
am: f2d486e5b0

Change-Id: I5c2c115b1ee42489d969ff30c48abf00d4a5a3f7
2019-10-07 18:56:02 -07:00
Samuel Fufa f2d486e5b0 Merge "Scale Icon badges for shortcut and widgets" into ub-launcher3-qt-future-dev 2019-10-08 01:41:53 +00:00
vadimt 1b92f6d964 Reduce risk of flakes in memory leak detection tests.
Now performing jreck@-style garbage collection prior to getting Launcher
PSS. The reduces PSS noise from ~700KB to ~250KB (std dev).

The tests (MemoryTests) run outside of Launcher process and
communicate with Launcher via RPC.

The change is in the RPC handler that lives in Launcher and returns
Launcher PSS to the test.

Bug: 139137636
Change-Id: I457e590b005dac53345f4223d972c7961754938c
2019-10-08 01:05:41 +00:00
Tony Wickham 1ab5de3fc8 Merge "Fix quickswitch flickers/ignored swipes" into ub-launcher3-qt-future-dev
am: 9788183962

Change-Id: I153fe569fd3f2c8ad065282eed56f9f13c5ab0d4
2019-10-07 14:27:22 -07:00
Tony Wickham 9788183962 Merge "Fix quickswitch flickers/ignored swipes" into ub-launcher3-qt-future-dev 2019-10-07 21:08:34 +00:00
Tony Wickham af33f2c9d4 Fix quickswitch flickers/ignored swipes
- Don't set current page to running task when applying load plan,
  if we are already settling on a new task to launch.
- When starting a new task, finish to the running app if that's
  the task being started (should not happen with above change)
- When disabling free scroll mode, don't snap to a page if we're
  already on it. This was setting mNextPage so the first check
  was falsing.

Bug: 142068081
Change-Id: I5b392d9726a81c51718d2f94eee6cd4f78b61f69
2019-10-07 21:08:04 +00:00
TreeHugger Robot fedd5f1fd7 Merge "Removing host deletion on startup and corresponding callbacks" into ub-launcher3-master 2019-10-07 18:28:44 +00:00
Samuel Fufa aa038af6b3 Scale Icon badges for shortcut and widgets
Test: Manual
Bug: 141262820
Change-Id: I03edc986e3fe1876b6b7ed179b96864d587cb137
2019-10-04 17:06:33 -07:00
Samuel Fufa 5e6741828f Merge "Decouple grid size and widget preview size in WidgetsRecyclerView" into ub-launcher3-qt-future-dev
am: e5865a03bb

Change-Id: I72ff45bd7080a7bb6ca4ab681423d6bd1da8a291
2019-10-04 16:45:48 -07:00
TreeHugger Robot e5865a03bb Merge "Decouple grid size and widget preview size in WidgetsRecyclerView" into ub-launcher3-qt-future-dev 2019-10-04 23:36:22 +00:00
Samuel Fufa f1424a3b38 Decouple grid size and widget preview size in WidgetsRecyclerView
Test: Manual
Bug:142148773
Change-Id: I59aa29e95ddb7d6002a88cf853bae5fcf9811154
2019-10-04 15:15:58 -07:00
vadimt 1ac98548a7 resolve merge conflicts of 08776ada1e to ub-launcher3-qt-future-dev
Bug: None
Test: I solemnly swear I tested this conflict resolution.
Change-Id: I9a3b0f67ee874b5ec4ad67f41a46ec7876d19082
Merged-in: I9a3b0f67ee874b5ec4ad67f41a46ec7876d19082
2019-10-03 20:58:15 +00:00
Pinyao Ting e72ba6b616 Merge "Fix the issue talkback feedback doesn't say anything when user long press on an app icon." into ub-launcher3-qt-future-dev
am: a61914194e

Change-Id: Ife1d71cdaf821705288a775c3ff6e3f8bbd8f454
2019-10-03 10:57:36 -07:00
Pinyao Ting 52d0252150 Fix the issue talkback feedback doesn't say anything when user long
press on an app icon.

When user long press on an app icon, the a11y focus event wasn't
properly triggered on the container of deep shortcut, which is why
there wasn't any talkback feedback after long press on an app icon.

Bug: 140786694
Change-Id: Ib38db147faa5a163985f1ed74beec04c588b022c
2019-10-03 07:47:33 -07:00
Tracy Zhou c8611b3afe Merge "Live tile should switch to screenshot before finishing recents animation" into ub-launcher3-master 2019-10-03 00:08:09 +00:00
Tracy Zhou 387279d938 Live tile should switch to screenshot before finishing recents animation
Fixes: 139439373
Test: Launch a new app from shortcuts in Overview mode. Make sure the
live tile stays put (no hole). Same with touching empty space in
Overview to go home.

Change-Id: I6cacf2842e21f9856d0021cea9fddf4f870f09f0
2019-10-02 16:53:02 -07:00
Sunny Goyal e7b00128c7 Removing static instance of LauncherAppsCompat and unnecessary wrapper classes
Bug: 141376165
Change-Id: I8c1f1ab7d83ec50fe9c7bf39960ef9c360025ec7
2019-10-02 16:20:22 -07:00
Sunny Goyal b0adac23e0 Removing access to LauncherModel.getCallbacks
Bug: 137568159
Change-Id: Ic074dec6a8981a4b9aabf028cf3b878b532abb11
2019-10-02 14:27:40 -07:00
Sunny Goyal 01615a69d2 Removing host deletion on startup and corresponding callbacks
> Launcher deletes the phantom widget ids in loader

Bug:141376165
Change-Id: Icf0542535f194f9abc67e7190f34cb60f69e9f66
2019-10-02 12:08:26 -07:00
Sunny Goyal 1456522cab Merge "Removing static listeners from PackageInstallerCompat" into ub-launcher3-master 2019-10-02 18:27:45 +00:00
Samuel Fufa 0063204dbf Add nullcheck for VelocityTracker
Bug:134712476
Change-Id:I7834507a4e9aadf4d89c0ed6f3eba812df7425cd
(cherry picked from commit 6ef5b8abf4)
2019-10-02 18:23:03 +00:00
Andy Wickham b9efb9ad71 Merge "Some cleanup for SwipeDetector." into ub-launcher3-qt-future-dev
am: d39f7b51c8

Change-Id: Ifadf65abe4239a703c3d15eddc6ebd51a405a5e9
2019-10-01 14:57:43 -07:00
TreeHugger Robot d39f7b51c8 Merge "Some cleanup for SwipeDetector." into ub-launcher3-qt-future-dev 2019-10-01 21:47:46 +00:00
Andy Wickham 769c795edf Some cleanup for SwipeDetector.
It is now organized as follows:
 - private constants
 - public constants
 - private final fields
 - private variable fields
 - constructors
 - public methods
 - private methods
 - public interface/abstract class

This is intended to be a functional no-op.

Bug: 141939911
Change-Id: Iad5a9b3b73b35641f8a4f1d52ada6adef3825c47
Tested: Built and sanity checked manually.
2019-10-01 14:38:56 -07:00
Sunny Goyal e84c5b82be Unifying activity tracker callback
> Using a common class for both Launcher and RecentsActivity
> Removing static refenrece to LauncherModel and using a common pattern for
  tracking activities

Bug: 141376165
Bug: 137568159
Change-Id: Ic1897abe6913ec78e25725118eedf5b468d5ec70
2019-10-01 13:54:26 -07:00
TreeHugger Robot 08776ada1e Merge "Waiting for Launcher model load in out-of-proc tests." into ub-launcher3-qt-qpr1-dev 2019-10-01 19:48:05 +00:00
vadimt 7371e4da68 Waiting for Launcher model load in out-of-proc tests.
Not doing this seems to have caused flakes.

Bug: 141770616
Change-Id: Ia9caf20e4a2d93298adf4249ca815ad79bced802
Merged-in: Ia9caf20e4a2d93298adf4249ca815ad79bced802
2019-10-01 19:18:14 +00:00
Vadim Tryshev f7a2971530 Merge "Waiting for Launcher model load in out-of-proc tests." into ub-launcher3-master 2019-10-01 18:43:24 +00:00
vadimt 542b7df7fd Waiting for Launcher model load in out-of-proc tests.
Not doing this seems to have caused flakes.

Bug: 141770616
Change-Id: Ia9caf20e4a2d93298adf4249ca815ad79bced802
2019-10-01 17:46:35 +00:00
Samuel Fufa 1f3a847011 App title in Widget list shouldn't be actionable by a11y methods
Bug:139913027
Test:Manual
Change-Id: I2a5d5551d09ee2bc96444164ed77225a3b4a829a
(cherry picked from commit d3720c210b)
2019-10-01 17:33:18 +00:00
Pinyao Ting 44151960bf Revert "Revert "Revert "cache shourtcut image"""
am: 52908c9adc

Change-Id: I597a9e3a314887b668f482e74a4d2f548cca1da9
2019-10-01 10:09:11 -07:00
Pinyao Ting 52908c9adc Revert "Revert "Revert "cache shourtcut image"""
This reverts commit d13f0c5c45.

Reason for revert: app crashes when adding widgets automatically b/141568904

Change-Id: I5b97f440716c93b1bd93c899e3e1d40e8bbd2885
2019-10-01 09:44:11 -07:00
Vinit Nayak a62de7aa88 Merge "Set exclusion rect for launcher before it gains focus" into ub-launcher3-master 2019-10-01 15:54:05 +00:00
Sunny Goyal 045b4fab76 Removing static listeners from PackageInstallerCompat
Bug: 141376165
Change-Id: I2b49d53a05a04c622ed5a7b723109a6cc230d230
2019-09-30 23:17:15 -07:00
Vinit Nayak 9a8462117d Set exclusion rect for launcher before it gains focus
Back gesture still shows if user attempts to swipe
back while we're animating to launcher state normal.
Focus is only granted after the animation has
completed, but the user can interact w/ the back
edge panels while it's ongoing.

fixes: 138622418
Test: Open app, swipe home and quickly swipe from
the edge of the screen. Should go to -1 screen and
not see back arrow.

Change-Id: I32228370c7ec1bdb75474fdff2d1c99cb677fa6a
2019-09-30 16:04:57 -07:00