Commit Graph

10334 Commits

Author SHA1 Message Date
Tony Wickham 0bb211a9d5 Actually call LauncherTransitionable.onLauncherTransitionStep().
Previously, it was only called at the start and end of the transition;
now it is called as the animation interpolates. Specifically, a dummy
ValueAnimator is played alongside the transition animation and calls
dispatchOnLauncherTransitionStep() as it goes.

One place where this is important is in Workspace, where
mTransitionProgress is used to determine things like whether the
workspace should accept a drop - hence the bug that caused apps dragged
from All Apps to vanish when dropped before the transition ended.

Bug: 24215358
Change-Id: I32cd633c53557305caf84e87c9a4d4f07eef2223
2015-10-05 16:57:09 -07:00
Sunny Goyal 77ccb8d03c Removing some unused resources
Change-Id: I6aa8a2d7eb4599ed2351c54fe0885839b5ba4521
2015-10-05 14:14:19 -07:00
Sunny Goyal 8220d8afaa Merge "Adding some information in bug reports" into ub-launcher3-master 2015-10-05 21:06:46 +00:00
Sunny Goyal ec88204389 Update the widget spans after the provider changes
Bug: 24003213
Change-Id: I51ad5919a808ef10385d62a48a94589eefcb06bc
2015-10-05 13:23:52 -07:00
Sunny Goyal fd4264b2b5 Merge "Jailing the saved instance state of all the dynamically generated views" into ub-launcher3-burnaby-polish 2015-10-05 18:26:19 +00:00
Sunny Goyal d1a0e8b5c8 Jailing the saved instance state of all the dynamically generated views
Using itemId instead of generating a new id for each item. This is because
if the process gets killed, View.generateId will get reset but we will still
receive the generated item id map in onRestoreInstance. This will cause
conflicts with newly generated item ids.

We wrap all the generated homescreen views inside a single sparse array. This
ensures that we do not cause any conflict with dynamically generated views in
other parts of the UI.

Bug: 16840760
Change-Id: I6fe69c2e1dd463402f51222715fae31b9d4dd240
2015-10-05 18:25:49 +00:00
Tony Wickham 9aae47f8a6 Added 'Cancel' drop target from all apps and widget picker.
- Reuse DeleteDropTarget since it's the same effect, but with "Cancel"
  instead of "Remove" if supportsDeleteDropTarget() returns false.
- Rename related strings (but not their values)

Bug: 24104015
Bug: 24099531
Change-Id: Ia9fbcaa17bb17f7aa31df1f830298da01544c178
2015-10-05 10:58:15 -07:00
Winson 6febe1f361 Fixing regression when removing last item from folder.
- The regression caused the folder and all its contents to be removed
  before the new item could be moved to the place of the folder.  In
  addition, in this case, the LauncherModel would get out of sync with 
  the db because we move the last item to the workspace, but don’t 
  remove it from the contents, so deleting the folder would remove the
  item’s mapping in sBgItemIdMap.

Bug: 24620815
Change-Id: I17137f28b0f1617a890488c7a9c5b8a9e8df0e91
2015-10-02 18:26:48 -07:00
Sunny Goyal 95bae9a43d am c84e6e19: Disabling widget debug
* commit 'c84e6e19363c590bbfbac17e9ab7cc61a04d552a':
  Disabling widget debug
2015-10-02 20:23:05 +00:00
Sunny Goyal c84e6e1936 Disabling widget debug
Change-Id: I876a904358ce455c97a7a25a34c66af5e9316469
2015-10-02 12:48:37 -07:00
Winson 44818e07af Fixing regression in removing widgets via accessibility.
- Regression was introduced in ag/765323, but not visible in normal 
  drag and drop because the view is already removed from the parent.
  However, when accessibility is enabled, it was only removing it from
  the db, but not from the parents.

Change-Id: I37483d0cd6306d270441b11e6f05247d58b88521
2015-10-02 18:44:18 +00:00
Sunny Goyal 935eedad97 Merge "Do not reinflate/rebind widgets if we are going the rebind the full workspace anyway." into ub-launcher3-burnaby-polish 2015-10-02 17:40:35 +00:00
Winson 34ef93ccd6 am 058c21db: Ensure accessibility delegate is set on all apps icons.
* commit '058c21db49f4f058b7d84c8de55d3c649918ab70':
  Ensure accessibility delegate is set on all apps icons.
2015-10-02 17:21:59 +00:00
Winson 058c21db49 Ensure accessibility delegate is set on all apps icons.
Bug: 24605237
Change-Id: I801e2aca1732c021b06d996d907f368f97277cf9
2015-10-02 17:16:15 +00:00
Sunny Goyal a682a5d8c7 Make sure that the dimensions are not negative when drawing pending widget
Bug: 24585203
Change-Id: I3d328d0e1fe81d2704bb5b9d4b340a367bfb9249
2015-10-01 19:36:59 -07:00
Sunny Goyal 6bec75fe70 Do not reinflate/rebind widgets if we are going the rebind the full
workspace anyway.

Bug: 23820213
Bug: 24582781
Change-Id: I2cb4927916fed64a69100beb41ee14653ea1d70a
2015-10-01 18:51:50 -07:00
Winson Chung 1845049c66 Merge "Replace Long.compare() with implementation." into ub-launcher3-burnaby-polish 2015-10-01 22:53:15 +00:00
Sunny Goyal a13654529c Adding some information in bug reports
> Dumping workspace items
  > Dumping loader logs for crashes and data deletion
  > Removing unnecessary log dumps

Change-Id: Ia320988c2e3665e4d605d6e88bca77738e749273
2015-10-01 15:48:35 -07:00
Winson 12fb9fc3c3 Replace Long.compare() with implementation.
- Long.compare() was added in API level 19.

Change-Id: Ic7020c941403c10daa6feacdc737c6a82676ada0
2015-10-01 15:34:08 -07:00
Winson Chung b99d74bb05 am 0e32c14a: Merge "Fixing regression in search bar animation." into ub-launcher3-burnaby-polish
* commit '0e32c14ada3fae610ece912dcfd426a4a397d9ca':
  Fixing regression in search bar animation.
2015-10-01 19:37:04 +00:00
Winson Chung 0e32c14ada Merge "Fixing regression in search bar animation." into ub-launcher3-burnaby-polish 2015-10-01 19:33:58 +00:00
Winson a2dc7c351d Fixing regression in search bar animation.
- The other case should fall through to the animation even 
  when there is no search bar overlay.

Change-Id: Id91bea78b56934cc1c3379777068adc100f11dba
2015-10-01 12:19:23 -07:00
Sunny Goyal 5a87313591 am eaaed098: Merge "Adding progress information for preload icons in content description" into ub-launcher3-burnaby-polish
* commit 'eaaed098a633eb5a5759778d5b015e11373a5e3d':
  Adding progress information for preload icons in content description
2015-10-01 18:39:10 +00:00
Sunny Goyal eaaed098a6 Merge "Adding progress information for preload icons in content description" into ub-launcher3-burnaby-polish 2015-10-01 18:36:29 +00:00
Sunny Goyal dab7da510f Merge "Scale down drag views in spring-loaded workspace." into ub-launcher3-master 2015-10-01 18:34:59 +00:00
Sunny Goyal 93809cc316 am 9ccacb54: Merge "Fixing \'Item removed\' announced twice when using accessible DnD" into ub-launcher3-burnaby-polish
* commit '9ccacb544bfcb6b444edf09b1b37f955ae57168c':
  Fixing 'Item removed' announced twice when using accessible DnD
2015-10-01 18:28:51 +00:00
Sunny Goyal 9ccacb544b Merge "Fixing 'Item removed' announced twice when using accessible DnD" into ub-launcher3-burnaby-polish 2015-10-01 18:25:28 +00:00
Sunny Goyal c469aadd92 Adding progress information for preload icons in content description
Bug: 24086091
Change-Id: Id8fb024973f4affd998627d30077e2764b07edc4
2015-10-01 11:24:59 -07:00
Tony Wickham 778c0b020d Scale down drag views in spring-loaded workspace.
Bug: 24190193
Change-Id: Ic490fc3f46702c3d5360e869c4172f31700085a1
2015-10-01 11:08:36 -07:00
Winson Chung 81d5a2227b am 2c4d2ccd: Merge "Don’t create dummy app info." into ub-launcher3-burnaby-polish
* commit '2c4d2ccd90e60541efffb980b70270d0bfe4e585':
  Don’t create dummy app info.
2015-09-30 23:04:10 +00:00
Winson Chung 2c4d2ccd90 Merge "Don’t create dummy app info." into ub-launcher3-burnaby-polish 2015-09-30 23:00:57 +00:00
Winson 5fbe0746dd Don’t create dummy app info.
Bug: 24539514
Change-Id: I5d14a4d9993e072451f8e7ed9a4cea219ae5d246
2015-09-30 15:44:05 -07:00
Tony Wickham 9b803b5d7b Merge "Create widget resize frame after spring loaded workspace has exited." into ub-launcher3-master 2015-09-30 01:24:43 +00:00
Tony Wickham e038562675 Create widget resize frame after spring loaded workspace has exited.
Before, the resize frame was created as soon as a widget was dropped,
but this caused it to be in the wrong spot after the spring loaded
mode exited. Instead, we should wait until the workspace is back to
normal before creating the resize frame.

Bug: 24192073

Change-Id: I8d87febcc4ec7e3c44d50135184c3a837d7cd960
2015-09-29 18:22:05 -07:00
Winson e993c4b275 resolved conflicts for 850de64c to ub-launcher3-master
Change-Id: Ica4893082f03afe76abd42dca44016eb9e436c35
2015-09-29 17:39:37 -07:00
Winson Chung 850de64c0d Merge "Fixing other missing cases of truncated sorts." into ub-launcher3-burnaby-polish 2015-09-30 00:06:55 +00:00
Tony Wickham a3b240d32b Merge "Drags originating in Folder exit spring loaded mode when completed." into ub-launcher3-master 2015-09-30 00:01:13 +00:00
Winson 46a06da01c Fixing other missing cases of truncated sorts.
Bug: 24505761
Change-Id: I9b9358e8b134f0c4aac32ac536d9c8a1f0629957
2015-09-29 16:58:02 -07:00
Tony Wickham e872a420b6 am 58ecbe40: Flipped widths of Nexus 4 and Nexus 5 in InvariantDeviceProfile.
* commit '58ecbe40f6e95d53b74adeeea3fd83a32cea4f38':
  Flipped widths of Nexus 4 and Nexus 5 in InvariantDeviceProfile.
2015-09-29 22:24:59 +00:00
Tony Wickham 58ecbe40f6 Flipped widths of Nexus 4 and Nexus 5 in InvariantDeviceProfile.
Without this change, Nexus 4 uses the Nexus 5 device profile and
vice versa. But because the profiles have exactly the same values,
it didn't matter that they were flopped.

Change-Id: I3fd788e040feb8de5bb5f5e336acbd4ac995dc0f
2015-09-29 15:19:32 -07:00
Winson 0b90814f86 am c0880491: Highlighting sectioned apps on fast-scroll.
* commit 'c088049113c261331b5685e64050d14a31cd72df':
  Highlighting sectioned apps on fast-scroll.
2015-09-29 17:09:03 +00:00
Winson c088049113 Highlighting sectioned apps on fast-scroll.
- This CL fixes an old assumption we had about the height
  of rows in AllApps, and ensures that we account for the
  difference in height between the predictive icons and the
  normal icons.
- In addition, we refactor FastBitmapDrawable to have multiple
  states, which it manages in drawing itself, including the
  press state and fast scroll focus states.  And we also refactor
  some of the fast scroll logic in the all apps recycler view
  out to its own class.

Change-Id: I1988159b2767df733bbbfc7dc601859cde6c9943
2015-09-28 17:32:19 -07:00
Sunny Goyal 9e3a4d8573 am 51894540: am e1899e44: Merge "Adding size check when generating holographic outline" into ub-launcher3-burnaby
* commit '5189454083640c81bf3a171422b3ef114f150a77':
  Adding size check when generating holographic outline
2015-09-28 19:25:00 +00:00
Sunny Goyal 5189454083 am e1899e44: Merge "Adding size check when generating holographic outline" into ub-launcher3-burnaby
* commit 'e1899e44368f7602afc5b87a75102e7ff551982c':
  Adding size check when generating holographic outline
2015-09-28 19:21:58 +00:00
Sunny Goyal e1899e4436 Merge "Adding size check when generating holographic outline" into ub-launcher3-burnaby 2015-09-28 19:17:25 +00:00
Sunny Goyal 6cdc6b9f05 am 81284287: am de9590be: Adding null check when creating icon bitmap
* commit '81284287a761a9ee512bd7d4857995fdd8d8dcbc':
  Adding null check when creating icon bitmap
2015-09-28 18:49:19 +00:00
Sunny Goyal 81284287a7 am de9590be: Adding null check when creating icon bitmap
* commit 'de9590be4ca2779ae0f7f64a48ac8b90472484f8':
  Adding null check when creating icon bitmap
2015-09-28 18:46:18 +00:00
Sunny Goyal bf1a98f596 Adding size check when generating holographic outline
Bug: 24426913
Change-Id: Ic7c9c767ea60ae4b25e064127105d94104233596
2015-09-28 11:34:23 -07:00
Sunny Goyal de9590be4c Adding null check when creating icon bitmap
Bug: 24299267
Change-Id: I596e4a8dbd4e45cffff75e6cf7bbbf7ec45c8ec9
2015-09-27 19:05:04 +00:00
Winson aab143fd65 am f768d934: Fixing regression in L3 with search bar transition.
* commit 'f768d934682ba80da89d454543928e629a44103d':
  Fixing regression in L3 with search bar transition.
2015-09-25 23:23:56 +00:00